From patchwork Thu Jul 4 01:55:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 810201 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02AF4C2FD; Thu, 4 Jul 2024 01:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058156; cv=none; b=aN8VkWkmrilBFvP1Sf+zipYIorhOygPDyA2hXEqAAFobO4SGn6SlG18rAu+g2AXiKv4+foZ3FNQLPCDfAE2baYKbfD5OxJo3nxddXY3y/GhBMPFIEvFiAWXXgWI+yatuoE9ry4ND95AqWXTBy5Ste4iw3LVobXCM2JHgy4OA2tI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058156; c=relaxed/simple; bh=KzZP+IP0/ujONvqdTd3ry8tBG8tlrNCjztBdGudh+ek=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KGpwtORu9/0o509vfPL9ILKtXYG4b0Sl4tY46Pa+myKHvcJ+th68gI/C/8VgbuoOh3foZPvEDi5UFQGrw6iI6xhzSqGOmHAm6hUA4zv/9AfwQ9Wd8oGBT7e3CPIGHmYIT/JIWjgqmg1s35Rx15KhLLR4MagEcd7wl7u3rQObh8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fo63H/SI; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fo63H/SI" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-36796d2e5a9so97010f8f.3; Wed, 03 Jul 2024 18:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720058153; x=1720662953; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=srTz3o625QfiqUPJlQXV/25isfnbH1i5B1z3kNATQww=; b=fo63H/SIZSqXCXSQ0I0Jq26B//FujwlPGVu1hREv7F5s1o8KGuzSZGl6NsSAjch5Yz Ow3ya618W4qT2nLzvcMihz4Ex58Iv+54T8B8eBINF9/fQKCSUtt7M/RXa4gGLtn7TdSO cy1pphBOQDhqdvc4MGIPEUrkufQsyqcUvb3AfEi53fOiH5Y+SyGsaIr3KKziXACIHOrs g0s3QqB9ul9ep2rTyUzjAGW9ysVs6x1+hvQ08GyaaO5Xp7Zpy13LVoXpXJkEHO9oufIq 62Nzocmvz2NArZ5xSKUM+PZtEXGysBstwm3QR7jQ2hXw5FXKctdK1LiLNqPS/gfCkhQQ 8t8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720058153; x=1720662953; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=srTz3o625QfiqUPJlQXV/25isfnbH1i5B1z3kNATQww=; b=W7lhKg6tHr003VOKs3tSak3YrN9hJA10tMB0Ffx2LG6Pgito82Q1vW8u7XSFxmD+VM Y3KDkSQmjtIhi7Mr5jnkaurzwTOT7gMvTaWXqjwZTjQ1gfroQHnOqQ5O0n0fGTs9Vgfl XtLQCbCzCJFbByx58ltcDR/xrJ4yGEdhgrB0SO4rpDmY2utT2FUfxOhLSkVU2BgqBVIY 1aieSgvrHp9IwiN0N0aHVdzi2qWjMqqR5gMZodQ19iJfbBCJ4rJm9+TwXX349oCDL081 W95JT7Pc0SV8Eak6Hkg4sW0LUbnd72uCXaVrskiFCYCCkpUJtwdPp4xpIaireS/a4rID m0bA== X-Forwarded-Encrypted: i=1; AJvYcCVrOtHjKBjgC86suWms2dee/EanW5vdkUTHHT0PbUzTVvKK0sfp5UiEOKc5+Fbwz5Es0IGSoP9cQ3lupRFYD2m1jWlGHF/vjMeR2fflbLzcHG2kMmNZYPRGqeC/qJXpjbqdP5tEgCmbvg== X-Gm-Message-State: AOJu0Ywtzf14KX81hIJ0eSdu4C67XQJiXPH2PhauWVK/mdugBWgEEMNk bL/5Lmv5bRdmxn0oFpD8RuwnqOAn0dFrKNDYTw5wZDrk154/7FMK X-Google-Smtp-Source: AGHT+IFT7P0G3uGzZ5VNuv4W36ovoyJ0MmwkxGS8IeA/SQVAQGxeDBhvabTbh/FxSsb0w9vhjQjO6w== X-Received: by 2002:a5d:5712:0:b0:367:94e7:958a with SMTP id ffacd0b85a97d-3679dd17ec1mr247432f8f.6.1720058153130; Wed, 03 Jul 2024 18:55:53 -0700 (PDT) Received: from localhost.localdomain (93-34-90-105.ip49.fastwebnet.it. [93.34.90.105]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3679744be1fsm1976329f8f.2.2024.07.03.18.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 18:55:52 -0700 (PDT) From: Christian Marangi To: Pavel Machek , Lee Jones , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christian Marangi Subject: [PATCH 1/3] leds: leds-lp5569: Fix typo in driver name Date: Thu, 4 Jul 2024 03:55:40 +0200 Message-ID: <20240704015543.14495-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove extra x from driver name as this was a typo from copy-paste error. Signed-off-by: Christian Marangi --- drivers/leds/leds-lp5569.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5569.c b/drivers/leds/leds-lp5569.c index 7ccd8dd6026a..b7a74d6c19ca 100644 --- a/drivers/leds/leds-lp5569.c +++ b/drivers/leds/leds-lp5569.c @@ -529,7 +529,7 @@ MODULE_DEVICE_TABLE(of, of_lp5569_leds_match); static struct i2c_driver lp5569_driver = { .driver = { - .name = "lp5569x", + .name = "lp5569", .of_match_table = of_lp5569_leds_match, }, .probe = lp55xx_probe, From patchwork Thu Jul 4 01:55:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 810554 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91702C8CE; Thu, 4 Jul 2024 01:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058157; cv=none; b=m1HxWjv5Xa561k7qzBjZr43MUMQ9o8g1wk9mNDAHM0QmjdomspRzQnaB5PyOJD5tJw+a7GF3x9uwcoDM1L95FxOhiBc4qZXGc57wv+yIRvTzFcwcAQyT7VCzFe675hs+MDuM88puLrW538SHcbXihWGVPjV0Rj9gbcKTS3I1G/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058157; c=relaxed/simple; bh=pGeC0tIcc6RdK4J8gqAtoBjZUtUHrr6aVWLf8iR1ScU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nmwo+ryUNbH0ULkRUyFUPkh4dFfNHp5tZALYs55Q0gXxl+oFuz51pDMopeh5LhT1o23Tnu29mCpY8qaAAO6VjHen3rw4wHaa4H9yGieXdIVvq11rcsxqyDdrcn1ZT2GZ6Y+Kk6UrJJqEVnwVhznPOFUHsu8WTRlhDPkkFdvo5qQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z18bLMNa; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z18bLMNa" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3679e9bfb08so21202f8f.1; Wed, 03 Jul 2024 18:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720058154; x=1720662954; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3GmyLG4BAl3sAj48hgtamCgyGJ/9e0NRXPkNH2cJM84=; b=Z18bLMNaxEpnGNzeCMKd0OdVda7K1Y2sGh+FX+T37Nrt9QrAw+TRtUXAEsekgyi0EI FYJc4iJAYMMDqW2Hskcyc5w+0Qx3qH676+i4fhPMpNFPaqieHWc329kcDAYtkitbTfuZ EiiqidHDCqRYd/tdre8O/MsrASyKhRgHtOKuJXx8BRHYmPndT94lwU3am0DxEx+2Pv6j dyw9Izlvig16e9PT7OitedMnFodfxZ8xgTDsDVzD28rJC/eZBdkNkp6hNlC1FDbAq49G ol4BTJ2MflAeIduLoKbBPEgP3WBqxUDCjVZcdF1b3yVKxRcKJ/OIbLM5jfvOzKGzr9QY M6Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720058154; x=1720662954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3GmyLG4BAl3sAj48hgtamCgyGJ/9e0NRXPkNH2cJM84=; b=Zpp+z2AWSh/LB5O1Wof2LUNoqSNLPLlLx4oH7pgdgimno6wYz6waxaeJk7MuGn1V1o vpwBYba0CIpd6DRAbe4f7em9XnCsQ2XZbGfmddyKaqrLNhXVVDWC88SvyiRtVqP2KLAy 4B3+J6s8GVrhQhHg2P9USbbwVsgUlL2QwZkVdcLKg9N6m6dlC804S+ks7Vq85JRlIix7 4oiVd3BofNfLJ0bvE1egfx7/MXDiVCTfw2eXIGBB8tavNahmXAr7qk4lqbZeVvAP8zxj 1HCwySCeVnaVxFaZ5Vh1S39M2HUXAmIaJOEDzlsrHZhPUJpn/KqkglRiDOvJJVUzdo3K sThg== X-Forwarded-Encrypted: i=1; AJvYcCWkHjtkfcbdV90/tLIByuGsChrG+VE7TyH5LK1TUT96gtcuZ/srLvuj4Ec5wgPlGCoMQF9QZmBb8bvQlm11dKEtgk63wbmdA9R5vwja9Wd8ZBSB1T+IOpDWTF7Ix/bC3MhXOAdWWCX0SA== X-Gm-Message-State: AOJu0Yx9ge9XvDEiQZ5zQDeA0QT/qLcmhU2YLvVG/y9RkqwEhN8ZGvxg 2BCYa9Y/Y4adOvWLyE5xVRLPDM13k3fAy8XeJkUylnN0TWGRQ+NQ X-Google-Smtp-Source: AGHT+IHtUHqcRVS4WjUjxhBhrPYoD+O48LnlY3W3X+fGDUTBWPmQ6e0z1CS6N1r2SFHj8/ZiBDOnoA== X-Received: by 2002:a05:6000:1146:b0:362:2af4:43cc with SMTP id ffacd0b85a97d-3679f705228mr22854f8f.19.1720058153993; Wed, 03 Jul 2024 18:55:53 -0700 (PDT) Received: from localhost.localdomain (93-34-90-105.ip49.fastwebnet.it. [93.34.90.105]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3679744be1fsm1976329f8f.2.2024.07.03.18.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 18:55:53 -0700 (PDT) From: Christian Marangi To: Pavel Machek , Lee Jones , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christian Marangi Subject: [PATCH 2/3] leds: leds-lp5569: Better handle enabling clock internal setting Date: Thu, 4 Jul 2024 03:55:41 +0200 Message-ID: <20240704015543.14495-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240704015543.14495-1-ansuelsmth@gmail.com> References: <20240704015543.14495-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Better handle enabling clock internal setting. In further testing it was notice that internal clock config MUST be set before clock output config or the LED CHIP might stop working. This wasn't documented and was actually found on devices that have 2 chip chained where one chip provide clock for the other. Signed-off-by: Christian Marangi --- drivers/leds/leds-lp5569.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-lp5569.c b/drivers/leds/leds-lp5569.c index b7a74d6c19ca..2b4f358bc63a 100644 --- a/drivers/leds/leds-lp5569.c +++ b/drivers/leds/leds-lp5569.c @@ -179,20 +179,25 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip) val = LP5569_DEFAULT_CONFIG; val |= FIELD_PREP(LP5569_CP_MODE_MASK, chip->pdata->charge_pump_mode); + ret = lp55xx_write(chip, LP5569_REG_MISC, val); + if (ret) + return ret; if (chip->pdata->clock_mode == LP55XX_CLOCK_INT) { + /* Internal clock MUST be configured before CLK output */ + ret = lp55xx_update_bits(chip, LP5569_REG_MISC, + LP5569_INTERNAL_CLK, + LP5569_INTERNAL_CLK); + if (ret) + return ret; + ret = lp55xx_update_bits(chip, LP5569_REG_IO_CONTROL, LP5569_CLK_OUTPUT, LP5569_CLK_OUTPUT); if (ret) return ret; - - val |= LP5569_INTERNAL_CLK; } - ret = lp55xx_write(chip, LP5569_REG_MISC, val); - if (ret) - return ret; return lp5569_init_program_engine(chip); } From patchwork Thu Jul 4 01:55:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 810200 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF01FDDC3; Thu, 4 Jul 2024 01:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058158; cv=none; b=JBAyZI+r++crjH5PHCjOOogTPxCF9caq7sSbc9bqMki8hyVf3iBPiX5FaEtb/1WEASBPGr3lnfI3+Crb2c6dJXXZuyhS09hvsNq5sK2XWdlrcQhzARXnLxyIXK2zoZlId0H2XHM8GUj/tK67bHwcVEziIt4+kJbP9l1w3HIbYBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058158; c=relaxed/simple; bh=PVIcFfRyp6Fo5QfIoi6j67kPrYrGKJv9M1gOZ26CZq0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s8oCdLWJEYdcbxQ4LRbDkxNGHnW7xErhufXgud+3yMWLKWtTFkhBYlrIS4E7MekHkJlYXnBZaLkSjMyrF5BIkWQY98JN65HGg1BlF69wLIDO/VHPlFVH2iWWMRTLQucXNlEGfMj+pNSyEgK4zLQsXWvY3qaxDOJAnBlyh4C1fEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XPTvgmjt; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XPTvgmjt" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-361785bfa71so87107f8f.2; Wed, 03 Jul 2024 18:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720058155; x=1720662955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WzSl+/8bcfevQM/tI1jY7SZHL5qkQp688IL5xX3oJ64=; b=XPTvgmjtr6R4NhvP2dRKFiEdA6cqEVtIR5fxNP8PagpJV18tmoNQSl+rjyQbizVPod ZgUK9LAXuyemfk3IBnm+WRL/fb/zmez+JComGkmFU8pOhcQq3Y58D0LoRgimKq2HwgnX GxEkbt8Qk4+Ur40leFYnH4WYSoXO8ehJLQ4exPta59r50P2EcAyp7Raz2kCFaLAaQjhY 18/l5nePyuDLxp5Ro7XLuA8AzjmWyyOYzSA52NOfVYiy0APRj4fMrThi3AXnDLjsL3Xm WPuNvTsC3FElXu/VWaODUZK8AG/ESar1/uj7HEz5lhHgoV8wHCMRy65ajINHqip+Kkd4 oL0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720058155; x=1720662955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WzSl+/8bcfevQM/tI1jY7SZHL5qkQp688IL5xX3oJ64=; b=U8tiDyJx5V5mQutDwwB5kLbkWrkXVYl+vW5PWzUIXgxqTbD+MKzAIx+rFIpUzTiw8H tM2UtdTyUKLE/UTOAU55ETOzt7+nXpv/EB7WUF48DVNUyG5pCv1nZXA85E/aAVvDm+2E bNvojEwNQOfWZTjzqo+OGgos5bGHy7bCNa6u0nYdL0D7lNhIwJ/FTGJN95y7crHk9AMe ULHczeb5tAfttZ8PWKPmVQypXk9/wLQVws/0fQmqLDQzhieDzDpusrUVJkL3D/BrsMbs kx5qvwoT22ugQ1mHgyfVqlZlPMi0GRpMpkCGrVMkJUH/PEokwELpr0E9lKmx4Kw7rX0w t92A== X-Forwarded-Encrypted: i=1; AJvYcCUIqUX82jLftB1DbaLY+kW3JQpzYqduBv78YcvpCJKDlEVJNvSl53XmH+X2v+fEH+dcelcvoAycCBprV85X82iQ3JeuF+ywx8PMQw0ApbhUYQe5eA8nnrLLS2bRALdUByvRgVH/nV1fIg== X-Gm-Message-State: AOJu0YxHgSQzN8bHD6HcGcV2/z+cqnslUfdj6duW3XRsrqiQiwsxhFnu yiN3WJTbZQvG8MjWmYLRq7XQ9PlVZ9w6gOwLi+qSbRfKNMVC1sKg X-Google-Smtp-Source: AGHT+IExz4O0d2+Hb3+0Nto2FFEgQVCxJcUBa9Pg27WAiQVYDApybURSUX4ZI/at5dqFFbdl2I6gRA== X-Received: by 2002:a05:6000:231:b0:367:8f98:c503 with SMTP id ffacd0b85a97d-3679dd1028fmr178452f8f.1.1720058154822; Wed, 03 Jul 2024 18:55:54 -0700 (PDT) Received: from localhost.localdomain (93-34-90-105.ip49.fastwebnet.it. [93.34.90.105]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3679744be1fsm1976329f8f.2.2024.07.03.18.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 18:55:54 -0700 (PDT) From: Christian Marangi To: Pavel Machek , Lee Jones , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christian Marangi Subject: [PATCH 3/3] leds: leds-lp5569: Enable chip after chip configuration Date: Thu, 4 Jul 2024 03:55:42 +0200 Message-ID: <20240704015543.14495-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240704015543.14495-1-ansuelsmth@gmail.com> References: <20240704015543.14495-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Documentation say that clock internal config needs to be set BEFORE chip is enabled. Align code to this and move the CHIP enable after the CHIP is configured. While at it also make use of STATUS reg and check when STARTUP is completed instead of sleep for 1-2 ms. Signed-off-by: Christian Marangi --- drivers/leds/leds-lp5569.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/leds/leds-lp5569.c b/drivers/leds/leds-lp5569.c index 2b4f358bc63a..cd1a189c542f 100644 --- a/drivers/leds/leds-lp5569.c +++ b/drivers/leds/leds-lp5569.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -91,6 +92,8 @@ #define LP5569_ENG2_MUX_ADDR 0xd0 #define LP5569_ENG3_MUX_ADDR 0xe0 +#define LP5569_STARTUP_SLEEP 500 + #define LEDn_STATUS_FAULT(n, status) ((status) >> (n) & BIT(0)) #define LP5569_DEFAULT_CONFIG \ @@ -170,13 +173,6 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip) int ret; int val; - ret = lp55xx_write(chip, LP5569_REG_ENABLE, LP5569_ENABLE); - if (ret) - return ret; - - /* Chip startup time is 500 us, 1 - 2 ms gives some margin */ - usleep_range(1000, 2000); - val = LP5569_DEFAULT_CONFIG; val |= FIELD_PREP(LP5569_CP_MODE_MASK, chip->pdata->charge_pump_mode); ret = lp55xx_write(chip, LP5569_REG_MISC, val); @@ -198,6 +194,13 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip) return ret; } + ret = lp55xx_write(chip, LP5569_REG_ENABLE, LP5569_ENABLE); + if (ret) + return ret; + + read_poll_timeout(lp55xx_read, ret, !(val & LP5569_STARTUP_BUSY), + LP5569_STARTUP_SLEEP, LP5569_STARTUP_SLEEP * 10, false, + chip, LP5569_REG_STATUS, &val); return lp5569_init_program_engine(chip); }