From patchwork Fri Jun 28 13:29:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 808600 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F77829B0 for ; Fri, 28 Jun 2024 13:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719581416; cv=none; b=hIC+F1azEHy1tpOAjWnj267fQ/j3lH8jVTsETEWcSuVsxGIchs1Us31u2NogHDC5zKp3QyJ8RJatcvk0pfmMqr+cY33cunUznmqzZt+uy7JJtUqBRay2jcZw76WlnfbF0gbFHm8KdNrT/PmrEqUV/l67ikP3eulbZpzUlF2a7xM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719581416; c=relaxed/simple; bh=2/TJGAbpZdXIuRAH8d1JX1KZPFgtsSB4eyGYOXRL2XU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y1huF8ZY25OFiRWXfPcXg7BcXKazbG83TOmB5wvAS7aLrvzVFRkX/uKuGTdYArnlUB7A4bgY3Xz5yHsc0upg2OhCyRal+aI7uYQkqDHcVlgils9He8dN74AdrG9zCuNyfDTM6zP+MceX7C8WX8DUERsYZQVZQP3pj+VACz78fbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=YMocfmVx; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YMocfmVx" Received: from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 08E9F16B0; Fri, 28 Jun 2024 15:29:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719581379; bh=2/TJGAbpZdXIuRAH8d1JX1KZPFgtsSB4eyGYOXRL2XU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YMocfmVxBliFkiIQ7e+wtymRWhZTipnlMogR88hkuUYl+6WoIvRlkNnLhHM2DtJ4K lEs8nC2WN4sX0ce6WBKNNzNhHh3fMUtsToICdOsoYC1yvmHxYYdammeq2DhtbzqR4I 4GgJmRjBOTGtYuJ6MztPbQw5ieV3BfGtQUyeXyi0= From: Jacopo Mondi To: Linux Media Mailing List , Hans Verkuil , Sakari Ailus , Naushir Patuck , David Plowman , Nick Hollinghurst Cc: Jacopo Mondi , Dave Stevenson , Tomi Valkeinen , Laurent Pinchart , Kieran Bingham , Mauro Carvalho Chehab Subject: [PATCH v2 2/5] media: uapi: pisp_common: Add 32 bpp format test Date: Fri, 28 Jun 2024 15:29:43 +0200 Message-ID: <20240628132948.871568-3-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240628132948.871568-1-jacopo.mondi@ideasonboard.com> References: <20240628132948.871568-1-jacopo.mondi@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add definition and test for 32-bits image formats to the pisp_common.h uAPI header. Fixes: c6c49bac8770 ("media: uapi: Add Raspberry Pi PiSP Back End uAPI") Signed-off-by: Jacopo Mondi Acked-by: David Plowman --- include/uapi/linux/media/raspberrypi/pisp_common.h | 3 +++ 1 file changed, 3 insertions(+) -- 2.45.2 diff --git a/include/uapi/linux/media/raspberrypi/pisp_common.h b/include/uapi/linux/media/raspberrypi/pisp_common.h index b2522e29c976..74d096188233 100644 --- a/include/uapi/linux/media/raspberrypi/pisp_common.h +++ b/include/uapi/linux/media/raspberrypi/pisp_common.h @@ -72,6 +72,8 @@ enum pisp_image_format { PISP_IMAGE_FORMAT_SHIFT_8 = 0x00080000, PISP_IMAGE_FORMAT_SHIFT_MASK = 0x000f0000, + PISP_IMAGE_FORMAT_BPP_32 = 0x00100000, + PISP_IMAGE_FORMAT_UNCOMPRESSED = 0x00000000, PISP_IMAGE_FORMAT_COMPRESSION_MODE_1 = 0x01000000, PISP_IMAGE_FORMAT_COMPRESSION_MODE_2 = 0x02000000, @@ -134,6 +136,7 @@ enum pisp_image_format { PISP_IMAGE_FORMAT_PLANARITY_PLANAR) #define PISP_IMAGE_FORMAT_wallpaper(fmt) \ ((fmt) & PISP_IMAGE_FORMAT_WALLPAPER_ROLL) +#define PISP_IMAGE_FORMAT_bpp_32(fmt) ((fmt) & PISP_IMAGE_FORMAT_BPP_32) #define PISP_IMAGE_FORMAT_HOG(fmt) \ ((fmt) & \ (PISP_IMAGE_FORMAT_HOG_SIGNED | PISP_IMAGE_FORMAT_HOG_UNSIGNED)) From patchwork Fri Jun 28 13:29:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 808599 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536551E89A for ; Fri, 28 Jun 2024 13:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719581419; cv=none; b=L49jfcsqwacKmq9y0LSsKg+R7XlrcVkd1mrKde1bXz1ITeIwO2EKRBA4x0dXj7CiAWn1K1d4gc5CtWjBOw+SF96QlbgCJn95x5Wm69GMuKNUBjhD02Fgb+kbbziVJZVRMliRP7hQZDMKVTXw0fGLdt9Wcxi5XWp9kF2ik4HY20s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719581419; c=relaxed/simple; bh=T3jlOrkkT2yn32h8hI7ffvgpnNYPtTcOtU5jiOj6FyQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q4tnyo6pLyShLBD9dBOY5Ze82ya5gfJR5z0zVXhkm0f2z0vi8kYj2Vabzz2QII1g+kfR56i2SbcMKLxNbL1KVPmVI1PdkeQjl5Me0kkrhNFJrJNV2V/5MFtUUJ+0c3zvGo5kSRmFfqCG/6K6MEk4RuXDSjtsH7tg5UnUtii5srk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=LhXOa8fC; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LhXOa8fC" Received: from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ABC0F1929; Fri, 28 Jun 2024 15:29:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719581381; bh=T3jlOrkkT2yn32h8hI7ffvgpnNYPtTcOtU5jiOj6FyQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LhXOa8fCPJ7kiF5FQ//0smtavPu3HZPbeD9RfPaEbOKlYES4s6d7jvapNFUW8XME/ zHBpqcvpg66QvvdBDvlYpMAJ+KCoWrwQAZd9u2DgN2pUxTe75Ql1jVBbsDqOgKRUbU ovK14WLy531Goe9MV51d/d93V0EO90MSLs+QtIco= From: Jacopo Mondi To: Linux Media Mailing List , Hans Verkuil , Sakari Ailus , Naushir Patuck , David Plowman , Nick Hollinghurst Cc: Jacopo Mondi , Dave Stevenson , Tomi Valkeinen , Laurent Pinchart , Kieran Bingham , Mauro Carvalho Chehab Subject: [PATCH v2 4/5] media: uapi: pisp_be_config: Re-sort pisp_be_tiles_config Date: Fri, 28 Jun 2024 15:29:45 +0200 Message-ID: <20240628132948.871568-5-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240628132948.871568-1-jacopo.mondi@ideasonboard.com> References: <20240628132948.871568-1-jacopo.mondi@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The order of the members of pisp_be_tiles_config is relevant as the driver logic assumes 'config' to be at offset 0. Re-sort the member to match the driver's expectations. Fixes: c6c49bac8770 ("media: uapi: Add Raspberry Pi PiSP Back End uAPI") Signed-off-by: Jacopo Mondi Acked-by: Naushir Patuck --- include/uapi/linux/media/raspberrypi/pisp_be_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.45.2 diff --git a/include/uapi/linux/media/raspberrypi/pisp_be_config.h b/include/uapi/linux/media/raspberrypi/pisp_be_config.h index 27d0cc417d6b..f8650ca92bf8 100644 --- a/include/uapi/linux/media/raspberrypi/pisp_be_config.h +++ b/include/uapi/linux/media/raspberrypi/pisp_be_config.h @@ -919,9 +919,9 @@ struct pisp_tile { * @config: PiSP Back End configuration */ struct pisp_be_tiles_config { + struct pisp_be_config config; struct pisp_tile tiles[PISP_BACK_END_NUM_TILES]; __u32 num_tiles; - struct pisp_be_config config; } __attribute__((packed)); #endif /* _UAPI_PISP_BE_CONFIG_H_ */