From patchwork Thu Jun 20 20:38:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferry Toth X-Patchwork-Id: 806653 Received: from mailfilter01-out30.webhostingserver.nl (mailfilter01-out30.webhostingserver.nl [195.211.72.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1561255882 for ; Thu, 20 Jun 2024 20:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=195.211.72.101 ARC-Seal: i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718916100; cv=pass; b=ip3BuImkg+1cFaggx9Dx0zHKhoI5e/l1hiEn2W1JcRrd0MjPhDVz5GgLAXEQrC9FnOsb2XPYVY6eaH60bKcbFn7y0XHgcO51bnjJpGoXrjdVB3lDO1u6iMA4kgLiuhIpCHrZ2GnXmpOVkTftRpqxzDOyXs9G9P+iudIMGTG49SQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718916100; c=relaxed/simple; bh=0LxJ/wU5deDOnAL0gaaMov0d5yoYltHA4deqIeDYEV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YfSPIvSuCnrxZHXpClsm69R+EIRdsNMiLE6ETZpVL3Eusa9TVKswqFaTjridGtfmwicwl+QOmZHni8b3i8S+bjlOPJJCEQlvJ9VWYWjVEgTEN3khOh1i435mAS3VHoetlMzAKQZqEkpDJP07nrUHGH2sTmAVT9KtIF1tv6HiSpI= ARC-Authentication-Results: i=3; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=exalondelft.nl; spf=pass smtp.mailfrom=exalondelft.nl; dkim=pass (2048-bit key) header.d=exalondelft.nl header.i=@exalondelft.nl header.b=IN01Xz3Z; arc=pass smtp.client-ip=195.211.72.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=exalondelft.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=exalondelft.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=exalondelft.nl header.i=@exalondelft.nl header.b="IN01Xz3Z" ARC-Seal: i=2; a=rsa-sha256; t=1718916027; cv=pass; d=webhostingserver.nl; s=whs1; b=CESL/oFkjGvCqHNXxH+zW2j6qryvpA+yqMKYLwfXhfNmUCHsBn7Zc0A8X3NRWlRt/WmhcIVscYdTD 7l9T8+v9xjdHoam/G8x0fPiZ/ktL2S5TjgzZQFauFnHW0lPfjun1uIr8vyGVQjAYtpAda+JFPJ0ud/ 440dYEGA8KCQM/7anCCI6tlfKsk0LOGwWXKdeEsgvLg+/omUYXRmzQ2XLVSZFtFHw2O2f7LJuFcZLZ KzPV6WCkdyrTWOLr9jxq4u4nlgqO6xVAaVQ+/suTbni7SRXWHYqLuR6Uh3uoLFQy9T83Ii5M+lT0oq wBs4slJv9MdzdnlhtRiMNEOKUvm42eg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=webhostingserver.nl; s=whs1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:dkim-signature:from; bh=EKI97Lvf28y1ymmuneD6FlzohhD+JdA8V3mE6I22kuo=; b=T2KNHMTfXTtiqBk4r9MoiNtwhztiMHjjH6sa7HIjp1CCOEjng3xIlAuENe0/tc1fLI/Qhr8+mw0vY xbjRfI1lwClGCmL043qNRm3l7gp3G7UN3SCvTDDRkrHt19W93PjBqVdXqxaoGshpXHvy1PpvdxVcwh OB37itMe8qiCVxfDWlTt8Ti/6Tm79Oy0h4vlanZw2h3jBiErin0cd0xe62rd9mveKirwjaFr5qKEhQ dWUT5xOYMz2CpOe2Xh/KqhYfaKk152qgoTwPHJHoN7eJFsdcqB4sTjkkRGtAM5le5OQj5cH5tf0uJ1 d3HZYa0r/0FwzFV0KWB1KkbemnpwM2Q== ARC-Authentication-Results: i=2; mailfilter01.webhostingserver.nl; spf=pass smtp.mailfrom=exalondelft.nl smtp.remote-ip=141.138.168.154; dmarc=pass header.from=exalondelft.nl; arc=pass header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=exalondelft.nl; s=whs1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:from; bh=EKI97Lvf28y1ymmuneD6FlzohhD+JdA8V3mE6I22kuo=; b=IN01Xz3Z+fde8v0b0TXXH8QlldNmerLqjfdloySAMH2xiNUVlFzAJkgHNiykkHabD4lkq6FYt6InQ cqX7PMXCz+0kv5A64Z1w8xfBu5tijzPWJvWcjwnY1tHaU6Ztm96um4WiQn6PrMsn5UCKGjvhZgWXqb /zeJqxLsx652aobWxIfyVBfmOXk0OS1E5/392rv5TiGRk5hltmc+Ork0zRwgKlPN9nAZKP64mCrJGe +QCDgfhSVWAganLeoQ4AdFhyjfXZuc+6CsortQOQtP24dME1Ifrz64B+aKO/TdmcENWxu57GEGSWG7 20H/yYHuVquDRP0yfaOtfFx25YoSr6A== X-Halon-ID: 52b7374d-2f45-11ef-8d21-001a4a4cb906 Received: from s198.webhostingserver.nl (s198.webhostingserver.nl [141.138.168.154]) by mailfilter01.webhostingserver.nl (Halon) with ESMTPSA id 52b7374d-2f45-11ef-8d21-001a4a4cb906; Thu, 20 Jun 2024 22:40:25 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=webhostingserver.nl; s=whs1; t=1718916025; b=JvTSQErQLLgb7IA8p3zkaKqn0gu70rBno/jSqSAp2Vz0GGbg+YxzjoQJAswx9MUobyivCJHdtP CK7RTaTxwBGG6oQb0FZwSZ+5XKJWpN62r91Q+oJ+Tf27qOlPI1Y0uaRqM5cjgGo2GC5ZyQZgdd hB2IHB7K4fCGr5k5GmeoHxPrEHDtxhWRtx2H5kjMUugxVDxVQi6VTdWoViy0k3a20sfqJBgweN sPCP6GDUbW6b4EVAGgzbRvrAirnsNhQn6mkLssATds935BhxzZfFgbdp/xKFBANBTsVZioptTb PwkElU9uJ/+MjsjWNVPcVLrur9okWlzQ22UOHfK/OHZGEQ==; ARC-Authentication-Results: i=1; webhostingserver.nl; smtp.remote-ip=2a02:a466:68ed:1:d31:9797:59c3:1c58; iprev=pass (2a02-a466-68ed-1-d31-9797-59c3-1c58.fixed6.kpn.net) smtp.remote-ip=2a02:a466:68ed:1:d31:9797:59c3:1c58; auth=pass (PLAIN) smtp.auth=ferry.toth@elsinga.info; spf=softfail smtp.mailfrom=exalondelft.nl; dmarc=skipped header.from=exalondelft.nl; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=webhostingserver.nl; s=whs1; t=1718916025; bh=0LxJ/wU5deDOnAL0gaaMov0d5yoYltHA4deqIeDYEV0=; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From; b=shS2ybvnw8pzX23x8sD59m9FcJuycyCZBo1yv8oTvgzbEzKZXUJSws5JrS581JyBS91t50vGkk aMN507HOxve7l9ltQ/pKPBFPa1iAe5ovRx2+h/CJDQEBkGaR3RTwHWXXJ964mDa06uZNf4f4bc UjFm8RCNLgCQbxzGjARy+yl5bjAhV8Q1BM/peQe1LAkE5XCdGXaDKRCxwrh3YK9B4iwnhX3RI8 X8HZ7XrE8kOJdUA3szX9p8Us82r77zfTCND8eIPonpVyr5wdVcZ3Qcbb9bf5vi5Ycu2VLaMG1P L+vE7Gv3xxsR2sn64gtZ8JidBms8kcnxzofYQBwQ1W9sTQ==; Authentication-Results: webhostingserver.nl; iprev=pass (2a02-a466-68ed-1-d31-9797-59c3-1c58.fixed6.kpn.net) smtp.remote-ip=2a02:a466:68ed:1:d31:9797:59c3:1c58; auth=pass (PLAIN) smtp.auth=ferry.toth@elsinga.info; spf=softfail smtp.mailfrom=exalondelft.nl; dmarc=skipped header.from=exalondelft.nl; arc=none Received: from 2a02-a466-68ed-1-d31-9797-59c3-1c58.fixed6.kpn.net ([2a02:a466:68ed:1:d31:9797:59c3:1c58] helo=submission) by s198.webhostingserver.nl with esmtpa (Exim 4.97.1) (envelope-from ) id 1sKOa1-0000000CPjK-2hJn; Thu, 20 Jun 2024 22:40:25 +0200 From: Ferry Toth To: Greg Kroah-Hartman , Ferry Toth , Hardik Gajjar , "Ricardo B. Marliere" , Kees Cook , Richard Acayan , Linyu Yuan , Justin Stitt , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , s.hauer@pengutronix.de, jonathanh@nvidia.com, paul@crapouillou.net, quic_eserrao@quicinc.com, erosca@de.adit-jv.com, regressions@leemhuis.info, Ferry Toth , stable@vger.kernel.org Subject: [PATCH v2 1/2] Revert "usb: gadget: u_ether: Re-attach netif device to mirror detachment" Date: Thu, 20 Jun 2024 22:38:30 +0200 Message-ID: <20240620203954.20254-2-ftoth@exalondelft.nl> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240620203954.20254-1-ftoth@exalondelft.nl> References: <20240620203954.20254-1-ftoth@exalondelft.nl> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ACL-Warn: Sender domain ( exalondelft.nl ) must match your domain name used in authenticated email user ( ferry.toth@elsinga.info ). X-ACL-Warn: From-header domain ( exalondelft.nl} ) must match your domain name used in authenticated email user ( ferry.toth@elsinga.info ) X-Antivirus-Scanner: Clean mail though you should still use an Antivirus This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4. Prerequisite revert for the reverting of the original commit f49449fbc21e. Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment") Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach") Reported-by: Ferry Toth Cc: stable@vger.kernel.org --- drivers/usb/gadget/function/u_ether.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index 11dd0b9e847f..aa0511c3a62c 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -1163,8 +1163,6 @@ struct net_device *gether_connect(struct gether *link) if (netif_running(dev->net)) eth_start(dev, GFP_ATOMIC); - netif_device_attach(dev->net); - /* on error, disable any endpoints */ } else { (void) usb_ep_disable(link->out_ep); From patchwork Thu Jun 20 20:38:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferry Toth X-Patchwork-Id: 806287 Received: from mailfilter06-out31.webhostingserver.nl (mailfilter06-out31.webhostingserver.nl [141.138.169.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F2465F47D for ; Thu, 20 Jun 2024 20:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=141.138.169.48 ARC-Seal: i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718916116; cv=pass; b=DCzFojPr3JY2x4XDCi9nCkndJCG0kjkC1+Lch2HvqZoV/Y0dUl25h2gfrd07gR7B9JjVLMV6zRN/ct46L3cMq4bDhEClwSggRG5s4VWrZ6gKAH1BqgBKkheASOD+uXloeWuQCcmah+khqRF/NJ9T0egQMp3qELIFenmTbyLfvAc= ARC-Message-Signature: i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718916116; c=relaxed/simple; bh=2LfGQsiTfKh7G/p03O+Vr+UYtMgWtbnVWvSWFL9ixwc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lklgyrz9Qd/Q1FW/uAKaTj/jXEwvCu6AMJANG3qmweqG0APcFW46lBhyd2aQ6Ij9GZHa9jO157injJBUQfNOywGF2J14kCTp16p3RkJg0Qdcdup6rHb317gJ8kUaiZ8fk8UJxL1dPMp75YJqQMdbRCJU0a+RSuLm1+AeS9RcryU= ARC-Authentication-Results: i=3; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=exalondelft.nl; spf=pass smtp.mailfrom=exalondelft.nl; dkim=pass (2048-bit key) header.d=exalondelft.nl header.i=@exalondelft.nl header.b=lKfjTQxM; arc=pass smtp.client-ip=141.138.169.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=exalondelft.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=exalondelft.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=exalondelft.nl header.i=@exalondelft.nl header.b="lKfjTQxM" ARC-Seal: i=2; a=rsa-sha256; t=1718916044; cv=pass; d=webhostingserver.nl; s=whs1; b=DIBJNlF/7sYFBVmECmPGxK3epF/JAZOFck9JZRkKTxoEGcPQWgPqFenyhDLsWHhQEk9T6HU/9LEHi AhGHAW0PfLpoi3GIbKLdfhYq0c3vT4s3Dm+hwkAoqr+AnNb+jPB+GuGWHByeQEg/RQXYz1/UZqgxCE abr0tNqR4G24mTJ2TW070oumeKI380r0swe3/kKoJnxoWDT8Ay2FMFQp1XP6g9n1Y792jvSUZ92Dcz WKklw+wQabjRnGirV30TUT/jZtABFDdZFGbgP+j8XPI0X5Ho+DuhprLDkPw9sxqIbAieV/GBrSmAyk GoIiTNxYP/F/GpGA3Li+wPuj4J5ZSsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=webhostingserver.nl; s=whs1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:dkim-signature:from; bh=FsLnuFLGe0haxXdGehDFQL/y8+K9ZmLXTG4uRUF1/zo=; b=Bn4/OKN3A7NA19dfI6ui8II6bCVsYhELe60i6kx2MY6Ib1EISe8EFJAJvKspmjSGL9ha8poPo25rj bkysbx3aXfhiflFoTQ9gkz6hLRQRBlnbTPoP7VGk/aXd4uDjQy97HLlYpkZqJNSxTEPsbIRRJGFG77 K3LTpmHLpftWTDRdilgs2dgUYMf8aIksMSm8TgzqPeDaWZIZHDwwtEHDj6omhX4cSuGb2TxZp1vP52 7foJ4WYcvVhOiJONf/UEIBS/QlD7PPa2xgR0N08PHeYvPuyyMJtrxVtaaifB0LYczbpGr448UbzXkG MMD+MjmB4pnUoyGkxz9qiFeV4goPGRQ== ARC-Authentication-Results: i=2; mailfilter06.webhostingserver.nl; spf=pass smtp.mailfrom=exalondelft.nl smtp.remote-ip=141.138.168.154; dmarc=pass header.from=exalondelft.nl; arc=pass header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=exalondelft.nl; s=whs1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:from; bh=FsLnuFLGe0haxXdGehDFQL/y8+K9ZmLXTG4uRUF1/zo=; b=lKfjTQxMd40s22s91x2niTfqbTmK2j5FC6LvRfmvj5fAUOL0lCXs0zEladHDsWAF78G42sCBuJgmy J/avCq5qeT5ZZfsL66Fs4uginmTrKo0KW1N1LdOQ4TCkmlfUT1pJcnE3Q8ThjO2FaONErexWa51kMb Fk9mWPI8H5AsHKH/axRGUAVUgbuEX56ZXq49Hwr/ioi+4/uFSUjRhSrU9lMCE1AnTPSdls+Crdari/ EqZZvr5BR5womKDM/kU9pp6XaouACgX76E5b4nd+LweGtjNnn+h9iHmCC9Hs3RAO2dQ8/oTx1V6/HH vPxhKaDmA5rIlR2u6yfMEXHe7xDpu7A== X-Halon-ID: 5c8f9e2b-2f45-11ef-a465-001a4a4cb958 Received: from s198.webhostingserver.nl (s198.webhostingserver.nl [141.138.168.154]) by mailfilter06.webhostingserver.nl (Halon) with ESMTPSA id 5c8f9e2b-2f45-11ef-a465-001a4a4cb958; Thu, 20 Jun 2024 22:40:42 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=webhostingserver.nl; s=whs1; t=1718916042; b=XKbj21OChAstn4hJjYm0/lFYJ9YUFrKTBmmZk/L5c0PVsEwPopJ1UvJpuXxssLFfzu6PZZ5jYs 2Ga1qBgyVntfnmzIvI3Gou+427IxImA5x5lHgtREUUR9LKg3w2aceO2vMnT06OXyadOcapm8zK d/wjMsR98fXKTtwyr1PQQSnVOJYgzTDnrLiPa6OKxvimtpPRlmjLuOEkmHHhVm9+GIQ70yYMBm z7qp8OqB9Q7wv/TbzCPwc77ayWmtkz7CW6ioBzuSvdNXzxt0p/yGph9kMK3QX6Qigi0888l1FC BDobtVPMWy20Ak2DYCjUmrERw4V03FaJsIoWhKaHEmYC1g==; ARC-Authentication-Results: i=1; webhostingserver.nl; smtp.remote-ip=2a02:a466:68ed:1:d31:9797:59c3:1c58; iprev=pass (2a02-a466-68ed-1-d31-9797-59c3-1c58.fixed6.kpn.net) smtp.remote-ip=2a02:a466:68ed:1:d31:9797:59c3:1c58; auth=pass (PLAIN) smtp.auth=ferry.toth@elsinga.info; spf=softfail smtp.mailfrom=exalondelft.nl; dmarc=skipped header.from=exalondelft.nl; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=webhostingserver.nl; s=whs1; t=1718916042; bh=2LfGQsiTfKh7G/p03O+Vr+UYtMgWtbnVWvSWFL9ixwc=; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From; b=kdOexz7d0KolgugU+OymvcIwmIXUOQ4VTE9btnGJde185fBspiwBwYe/ynRiveWTBN2g0xdvaz t0nZDal8JwR516/SbmtM3ZUPTGVB8Mz9tzjRSLOPj0ER+ArKEUtxvGUBf2wLvFyhQe0QL5BOR6 u1YF4vEZsDDwu8CVkCAQejPxR2PhrqLiu/DlN8tOhUVtl4Ah5sE3+Dm1NCzALB6RjnhN2cxZN9 XgXsqYQpq4lAG8grMeFVdm3SWgPZp8RCQCM6vv7DRLyOKVMwzauiP0HKYWmFE4riO8wfOph8rs X6BB3tS9RNtmY8BQVYRV5fpsUsLVNK2ZFozk4tTfuCNhCw==; Authentication-Results: webhostingserver.nl; iprev=pass (2a02-a466-68ed-1-d31-9797-59c3-1c58.fixed6.kpn.net) smtp.remote-ip=2a02:a466:68ed:1:d31:9797:59c3:1c58; auth=pass (PLAIN) smtp.auth=ferry.toth@elsinga.info; spf=softfail smtp.mailfrom=exalondelft.nl; dmarc=skipped header.from=exalondelft.nl; arc=none Received: from 2a02-a466-68ed-1-d31-9797-59c3-1c58.fixed6.kpn.net ([2a02:a466:68ed:1:d31:9797:59c3:1c58] helo=submission) by s198.webhostingserver.nl with esmtpa (Exim 4.97.1) (envelope-from ) id 1sKOaI-0000000CPjK-0j4N; Thu, 20 Jun 2024 22:40:42 +0200 From: Ferry Toth To: Greg Kroah-Hartman , Ferry Toth , Hardik Gajjar , "Ricardo B. Marliere" , Kees Cook , Richard Acayan , Linyu Yuan , Justin Stitt , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , s.hauer@pengutronix.de, jonathanh@nvidia.com, paul@crapouillou.net, quic_eserrao@quicinc.com, erosca@de.adit-jv.com, regressions@leemhuis.info, Ferry Toth , stable@vger.kernel.org Subject: [PATCH v2 2/2] Revert "usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach" Date: Thu, 20 Jun 2024 22:38:31 +0200 Message-ID: <20240620203954.20254-3-ftoth@exalondelft.nl> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240620203954.20254-1-ftoth@exalondelft.nl> References: <20240620203954.20254-1-ftoth@exalondelft.nl> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ACL-Warn: Sender domain ( exalondelft.nl ) must match your domain name used in authenticated email user ( ferry.toth@elsinga.info ). X-ACL-Warn: From-header domain ( exalondelft.nl} ) must match your domain name used in authenticated email user ( ferry.toth@elsinga.info ) X-Antivirus-Scanner: Clean mail though you should still use an Antivirus This reverts commit f49449fbc21e7e9550a5203902d69c8ae7dfd918. This commit breaks u_ether on some setups (at least Merrifield). The fix "usb: gadget: u_ether: Re-attach netif device to mirror detachment" party restores u-ether. However the netif usb: remains up even usb is switched from device to host mode. This creates problems for user space as the interface remains in the routing table while not realy present and network managers (connman) not detecting a network change. Various attempts to find the root cause were unsuccesful up to now. Therefore revert until a solution is found. Link: https://lore.kernel.org/linux-usb/20231006141231.7220-1-hgajjar@de.adit-jv.com/ Reported-by: Andy Shevchenko Reported-by: Ferry Toth Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach") Cc: stable@vger.kernel.org --- drivers/usb/gadget/function/u_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index aa0511c3a62c..95191083b455 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -1200,7 +1200,7 @@ void gether_disconnect(struct gether *link) DBG(dev, "%s\n", __func__); - netif_device_detach(dev->net); + netif_stop_queue(dev->net); netif_carrier_off(dev->net); /* disable endpoints, forcing (synchronous) completion