From patchwork Wed May 29 05:13:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 800072 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB41315B576; Wed, 29 May 2024 05:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959632; cv=none; b=GwJK/kROOsucA65huu9XNkaNoT2oddovBM28VLyGEyGzE4qQW+ojQeo7Z371DcqlbtAdNqbhOZ+hUq8RCSzj9gLh3UCVVadQ/hHHvdAq2thKq+/OzNlri8bPPz0fudMmmcSr0B4Kd9yuy/BLAydAAu24xvrcMckzubHJ+haw1Aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959632; c=relaxed/simple; bh=GM8LPBpwKXl+Vcdc3p4stBLCHkAcPevuDzjUI9Gsb8Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uXVISfrPTtBYlSgxEJNV4KYnOQ7sCqktcXoB6C5pKxiEDfJXldoPbJ4d77SY0KkpSrqNRiWEF4HF/K6OlkDhcCu+pxyiMLiCv6ngk2jH0rXmGd9w/gllnUOyypIPtERWjoV77vAj9xO4LsLQYD9bUr4FtsrQltlFCZ7BU343K0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=QYa0XjOA; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="QYa0XjOA" Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id D9B9720174; Wed, 29 May 2024 13:13:47 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959628; bh=/kCC/N3bNiMS05Tj8Fe/ikNvI4lWNncOVV0tIccEmmc=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=QYa0XjOALWVq7z6GhWeIteNJfE3k+PxHwl7GYBfn2DJ1mBhwZ+ulIvcY7QNOu3fHP t3unjjg5ZFdfppIdD+oTS8knouKCNlgCyu+VSH8WOaxMqw5Ea5EMTT4WiYXK/+u8cz 3IAXc/3WDOD5Wl59RK/KNbnLmLlj5tzkKdr9h29WFThQsoPfO4GAmkLC5Pyi296jTf hRIs7zNGKoIofzuFkSJi6ISt+gSjbcxH395uW+NM0rdNcoQUXk4+2y2kCJbSWAPS1v BIUubirGDBSFCV9e7Il+Cic5NRdHKARn7dgxpE9vrFoukJMQl7DsLvy+mjvWI/sVYr LqWMjLPWjqEgQ== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:20 +0930 Subject: [PATCH 1/4] dt-bindings: gpio: aspeed,sgpio: Order properties by DTS style Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-1-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 Tidy up the list of required properties and the example node by ordering the properties in terms of the DTS coding style. Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index 46bb121360dc..6b15a3a3fb66 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -51,12 +51,12 @@ properties: required: - compatible - reg - - gpio-controller - - '#gpio-cells' + - clocks - interrupts - interrupt-controller + - gpio-controller + - '#gpio-cells' - ngpios - - clocks - bus-frequency additionalProperties: false @@ -65,13 +65,13 @@ examples: - | #include sgpio: sgpio@1e780200 { - #gpio-cells = <2>; compatible = "aspeed,ast2500-sgpio"; - gpio-controller; - interrupts = <40>; reg = <0x1e780200 0x0100>; clocks = <&syscon ASPEED_CLK_APB>; + interrupts = <40>; interrupt-controller; + gpio-controller; + #gpio-cells = <2>; ngpios = <80>; bus-frequency = <12000000>; }; From patchwork Wed May 29 05:13:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 800358 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1DE15B577; Wed, 29 May 2024 05:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959632; cv=none; b=fGKbSEWLOmqom8ejl69l5cGVPS3via/0YrKIFtGVSTg4DWzzfKPUtIRrcCJTNlaOurL8YjvlG6LFZVxzLIjhbgEKz8iJmnP+R08atjTCrWIWKFE9Y86S42EtlaIE+Czt7HPGHB/mBMN3no8dG8mc3MyyofvajKo2NRpquf7RHkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959632; c=relaxed/simple; bh=q0ywzPv3N4UW0+g3oO484NorTjCE0X5hV9jtgBamYoM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M0y2wT2I7Mcd4OpoOv0KHXQ77iupa4WSG64yCitjeEvVNpN8/izyKJHLmJ/hwFnRrricShh+5bln/ARvNeBqYHEBCm60elRHqJ0v9tFMX6qDZPIwIbk3tOnsBbAR0ELBmhaL/0CybJ7jzRypZaWpebzEf14mYdGdUQT/7tqGWXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=N1gvTI6C; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="N1gvTI6C" Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 8CF14201FE; Wed, 29 May 2024 13:13:48 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959629; bh=mtqAhcAvlJCMsRl1w/jbIXT3+Kk1ZJpyaGl5JGCYoAo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=N1gvTI6CubZtn04shoegCi+x6OuiM4Basj1czUY0afacOBp2IlU7b2uazfXHbNGs0 VXy76WROR+zEEy+mcp6LSDZJ59sb2UJASKlyesXDs5jpQZNNW5e0asVfnVgltD/p7Z pUGcVdv1pK+xROxyuVlkNlcLNZosTnOHH/OaUwLhNKfn2FlPPMMQD28FjF9Y8UANPK QyeWS6EzueZLeogFKWi4CJpsQdu2/4eMF0CbyycF6KTxajs86wfu3OLbPaRABEHhdE icKiimKaMqu8U9TC03uGxIMBHMZ/iIRwjjSnXpAD82zk0gA0+6yWI8gm0spjzH+Adq A2sp6NsUAN3Gg== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:21 +0930 Subject: [PATCH 2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-2-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 Some devicetrees specify gpio-line-names in the sgpio node despite it not being defined by the binding. It's a reasonable thing to do, so define the property to squash warnings such as: ``` arch/arm/boot/dts/aspeed/aspeed-bmc-vegman-rx20.dtb: sgpio@1e780200: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' ``` Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index 6b15a3a3fb66..fe27b5d01e80 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -33,6 +33,11 @@ properties: gpio-controller: true + # Each SGPIO is represented as a pair of input and output GPIOs + gpio-line-names: + minItems: 160 + maxItems: 256 + '#gpio-cells': const: 2 From patchwork Wed May 29 05:13:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 800071 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E630015B579; Wed, 29 May 2024 05:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959633; cv=none; b=WdYFPBY0MnEIh0KG2AnWJsNAcTHGapB7iKmNDc4C7YIV6C/J41mvhVyyAVA89/Wl5mLWxcoHWCL+HlVnJqJFWBO4bJkivy/JUzU9q23EaTVg8D7Zy8TTP0XVuaqwOVhPGXp8wJQrOZx1vlUda9TPu8QPzoKMpzEcjcPcxSxbISQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959633; c=relaxed/simple; bh=pQT3j1oQNxF5pViaB6Eu0BnBEiWEkDrOna3mi9rt0oA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L91W+Ek5ztS5/EFrm3yd9ijRNiIVbDOqZZ6ymV2t38Kc0tNk6FY4n2ZbaNN2dRGERGvKOa6H3PrMgHZRqE+0DWHdFqT+bRDermze45LXOU0j+BDPmTtZDJH5lO7wI8+FRU4yxKNsxk8VrhlSoLtc5s7Yjlen0xh/Flo/BKI4a/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=T5l8q/Jk; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="T5l8q/Jk" Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 43F322024D; Wed, 29 May 2024 13:13:49 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959629; bh=RM0WLi2RJAK84kDk7oeF/Th0CqQkfxxrTkSFxmoFxho=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=T5l8q/JkQhlJqQvasahZe8N9NJFmSYLuQ0yU3G9i4C5vTUCBKyMD7XHhRpPFfaIpM Ts5bK7T26S0UExzICplw4oGdsJS6tlHY+dJnNPlMKpUlZdC6IrtQSaFBpyTZZvtkCR aDIFiQqPBcRsGLsJqmC27MMCw2XO/6jSyeOyldx84q4IipV53vuytBBgqwE1sjFPRG YVxszLFo6dYlDUmpXt+Lp0N3z90kQ3AhH+3/YqXhWBY8vVXdmguaX/KKhtDNDrHMHj Jt9p+1+z8nc5vytFxAwoqp1AYpXglN59qW28cBWwFusHhQY+PB1CN9hQU6Ju+8us31 IL2hqk104VfAg== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:22 +0930 Subject: [PATCH 3/4] dt-bindings: gpio: aspeed,sgpio: Specify #interrupt-cells Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-3-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 Squash warnings such as: ``` /home/andrew/src/kernel.org/linux/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-ast2500-evb.dtb: sgpio@1e780200: '#interrupt-cells' does not match any of the regexes: 'pinctrl-[0-9]+' ``` Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index fe27b5d01e80..02c02ef97565 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -46,6 +46,9 @@ properties: interrupt-controller: true + '#interrupt-cells': + const: 2 + clocks: maxItems: 1 @@ -75,6 +78,7 @@ examples: clocks = <&syscon ASPEED_CLK_APB>; interrupts = <40>; interrupt-controller; + #interrupt-cells = <2>; gpio-controller; #gpio-cells = <2>; ngpios = <80>; From patchwork Wed May 29 05:13:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 800357 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94AB115B96C; Wed, 29 May 2024 05:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959634; cv=none; b=kCmjqV46MQcErNu6VBHbi55jWJsiKq04nV35rkeXNU7stmynPTr2EqyzBrKyCX9ndQlo6dczGryQyjCrNIlVDuBK2DgwuCUcRLTr9N16ghxpVdiRhtWr+8XYg60etrZZGxwOtmDxqgHZYoRcLHUwsiRNeHR33HJW35othSYO+No= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716959634; c=relaxed/simple; bh=DNmFw/89eKVtL0FVlNQdhHMc+b/d21jA4hq+4viHbxg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QrL3/OD8ZkABPRVLF0ZF0QzKdfpBYANplvcb68pWODnUjWYV6e5irYIKyOv+SuYLtZO0D00MZKhbnu78hw7PjXlrgzbl/mMzmM7p/YP/cU+4grzNbn5DeMXa2Gyp6ddDuugpCrsAtoQryDrTBk2UyzNybzvb/en69Q5Nhc58B1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=Ogf7jb0r; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="Ogf7jb0r" Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 00E64202C8; Wed, 29 May 2024 13:13:49 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959630; bh=P8gBf6jRS53rX70PCjwXjULQnqD4pYqLyrNQvX02Huk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Ogf7jb0rwfeRUAkEBHkEOilwFfPZtc+QdoNrArChblbzGnE7CDo46q1yyT0DH/Ynf z5n9pmVMBzEXkzjtkjG0izFzI1kSxebGxNUXFvTbPHoicrexeNxg/g2BRg0reUlBvr TzUfLfF++c7HdZb/Um7ygIBpum0TyF4Gh7CMdLmoTEP3Y1kOs5WtG47/HNteyXEK5H ITUSb0lRKidY9pqHKZI/VT6P9Qdqpra5M+UyYMdvnRevOX/5pGpBuMnwizSsfbMjfm APUQrzWs2NCjULoUy++v+NaqFRZH51JSWxkfwvQcu4ML1TRmqoHKqmceMl9OI+XEcD CtDR8KeQQ1P6g== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:23 +0930 Subject: [PATCH 4/4] dt-bindings: gpio: aspeed,sgpio: Require #interrupt-cells Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-4-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 It shouldn't have been the case that it wasn't required. The kernel devicetrees already specified it where compatible nodes were defined, and u-boot pulls in the kernel devicetrees, so this should have minimal practical impact. Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index 02c02ef97565..433b50bd5484 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -62,6 +62,7 @@ required: - clocks - interrupts - interrupt-controller + - '#interrupt-cells' - gpio-controller - '#gpio-cells' - ngpios