From patchwork Fri May 24 07:10:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 799073 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F75986AFA; Fri, 24 May 2024 07:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716534655; cv=none; b=RldLPN6nLSGe+vMUSSan+z85ymJNAnCXFzACBmEMEsBMQbiuL+wSmCcg6hTMO+vMNyRkMM1sYFG4nM368qiLfAhOnRm4KOgKCxf95jAZwgdKLzeuJvGSX6NJmC/rg9M8pDqi126LwhLVP6Mvjv2uZhKZLR7aBk+Rgtapz0g52m8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716534655; c=relaxed/simple; bh=yoH7HDIzCvy2OCMXmqXpl6iSu4XuuIUTXd0xzeGfedg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ss7syKBhn6C1JEIxpM+q4uui2WHpdgQ1ckuZ7MNLnPNZ4Avw7XoxPvwtDHz6T6ui6u+fqHggKOG5WZCEQqJQURLjGFICTNADaQGyZ56IoH3ekLR9/9YpL/MS9HtyOV2uQGB+Bv4b2IAI9kiEiBNppIWKVUaa5mQkIr/izu5IOVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=0k1QsmKy; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="0k1QsmKy" Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 8400B1F9F4; Fri, 24 May 2024 09:10:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1716534649; bh=E+eiGEXpFDBtOnSags/hbRRzOuPfaC9yiDVYuMURIKE=; h=From:To:Subject; b=0k1QsmKyyyawhgK6mPG0YMcfmqol9ra56MShsur4YR1cISoGVrEsf6oy+G0BwS7tK MyWsOHKeZj0h0ZRkLNtP1ftuoD0kFCOlhaPOclrhrgWBvtlXSvvo80OAmDMNYjU+DZ wvggmPvsHno+DV8ZhB4WXn+Vtsy7atBBjqKIkmDA93Qh12CxIDzH8NqJGpG4GzwZHn aiks+KDfrGe9ykKumvzVErhMHLASDKMVjIHyCbQ1eJRgwFef5yN6/JeUc6W4qwjCcH 05iIonnmgCTem2goFQWf2nLRdUeMDROLJ+xEYxnG2Ubt8BK0oT4ci3hDhYolA0Z/hI uMA50jT5K+3Xg== From: Francesco Dolcini To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson Cc: Francesco Dolcini , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: [PATCH v1 1/2] dt-bindings: usb: gpio-sbu-mux: Make 'enable-gpios' optional Date: Fri, 24 May 2024 09:10:33 +0200 Message-Id: <20240524071034.4441-2-francesco@dolcini.it> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240524071034.4441-1-francesco@dolcini.it> References: <20240524071034.4441-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Francesco Dolcini The enable gpio is not required when the SBU mux is used only for orientation, make enable-gpios required only for alternate mode switch use case. Signed-off-by: Francesco Dolcini Acked-by: Conor Dooley --- Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml index 88e1607cf053..30edcce82f97 100644 --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml @@ -44,13 +44,18 @@ properties: required: - compatible - - enable-gpios - select-gpios - orientation-switch - port allOf: - $ref: usb-switch.yaml# + - if: + required: + - mode-switch + then: + required: + - enable-gpios additionalProperties: false From patchwork Fri May 24 07:10:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 799074 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B1C127B69; Fri, 24 May 2024 07:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716534655; cv=none; b=XEVDKQKimv1K/2QuaGfd42f/5as5O0YPT6xfsJyz5t0JIufrKaEQ54N2BUg3dGz1agtCPA0eF3M5lunAlsxukU+Hdln1vtJ1jEYCFNsm6aFa83Egehah+4CWRaK96R26721dBI2deNfD4hGf1K6jPZ7JbFAvNS9CoYsxY2SmoYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716534655; c=relaxed/simple; bh=HXpxaOrRDAPP2CP2iir/hke44+TLFRVRz0rqBRXLEtM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A0NBeMPtig+ViHRnvFHjOdSSp7SpTChLQllv0/j8wOP2jF37g8Bndo5Qful5tMLpeTJ3uaugfA5ZfZp6fEDsQb/2EFLF+CoaZAEc8dwi+YPCWhHiIiduSUzWiEsw1Ise6dHBfURmdgDIsGIx7f5L+vDOIlSps2iPAYSfyeoQdHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=dDYS3wFJ; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="dDYS3wFJ" Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 29EC91FA23; Fri, 24 May 2024 09:10:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1716534650; bh=c5sIWFFIE6HBCH8g2ES2lCEKcdDGNWDD+aCgSLy4Et0=; h=From:To:Subject; b=dDYS3wFJUM0+CjEvqBrgrvjSHuBjb5AWzJ004jLncA/Xzv/0GTj5ZTLGAYJInO50t gAeBj5q3eV9OU3/ndys0xKm0DVxag3bqqL2dufyI6+AmSP9je8bDnxmxs5uos096np +d25E0XLVK3vCj9B7+9gOZIH7FIZSohVrDU3ME32lVFw4XfFFan2I4gXwDEOdg+Ph9 Ehfk/ntkBrrKAmnjXoAXcyWvy4c7KwIp2R9OU9xNyLIlBn3VlqpYhFp8nr/13WmW6R Aj/RycMHBeVDhwqsf6ZGWutvnb4VaWcB61yNMKAxAwpP4sv2RzRN+rAII8kA6jUqgE GUN4NNQ5lmnJw== From: Francesco Dolcini To: Heikki Krogerus , Greg Kroah-Hartman Cc: Francesco Dolcini , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Bjorn Andersson Subject: [PATCH v1 2/2] usb: typec: mux: gpio-sbu: Make enable gpio optional Date: Fri, 24 May 2024 09:10:34 +0200 Message-Id: <20240524071034.4441-3-francesco@dolcini.it> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240524071034.4441-1-francesco@dolcini.it> References: <20240524071034.4441-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Francesco Dolcini The enable gpio is not required when the SBU mux is used only for orientation, make it optional. Signed-off-by: Francesco Dolcini --- drivers/usb/typec/mux/gpio-sbu-mux.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c index 374168482d36..cf44259980a1 100644 --- a/drivers/usb/typec/mux/gpio-sbu-mux.c +++ b/drivers/usb/typec/mux/gpio-sbu-mux.c @@ -47,7 +47,7 @@ static int gpio_sbu_switch_set(struct typec_switch_dev *sw, break; } - if (enabled != sbu_mux->enabled) + if (sbu_mux->enable_gpio && enabled != sbu_mux->enabled) gpiod_set_value_cansleep(sbu_mux->enable_gpio, enabled); if (swapped != sbu_mux->swapped) @@ -66,6 +66,9 @@ static int gpio_sbu_mux_set(struct typec_mux_dev *mux, { struct gpio_sbu_mux *sbu_mux = typec_mux_get_drvdata(mux); + if (!sbu_mux->enable_gpio) + return -EOPNOTSUPP; + mutex_lock(&sbu_mux->lock); switch (state->mode) { @@ -102,7 +105,8 @@ static int gpio_sbu_mux_probe(struct platform_device *pdev) mutex_init(&sbu_mux->lock); - sbu_mux->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); + sbu_mux->enable_gpio = devm_gpiod_get_optional(dev, "enable", + GPIOD_OUT_LOW); if (IS_ERR(sbu_mux->enable_gpio)) return dev_err_probe(dev, PTR_ERR(sbu_mux->enable_gpio), "unable to acquire enable gpio\n"); @@ -141,7 +145,8 @@ static void gpio_sbu_mux_remove(struct platform_device *pdev) { struct gpio_sbu_mux *sbu_mux = platform_get_drvdata(pdev); - gpiod_set_value_cansleep(sbu_mux->enable_gpio, 0); + if (sbu_mux->enable_gpio) + gpiod_set_value_cansleep(sbu_mux->enable_gpio, 0); typec_mux_unregister(sbu_mux->mux); typec_switch_unregister(sbu_mux->sw);