From patchwork Thu Apr 18 15:36:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parker Newman X-Patchwork-Id: 790112 Received: from mout.perfora.net (mout.perfora.net [74.208.4.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E3D16EBEA; Thu, 18 Apr 2024 15:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.208.4.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454647; cv=none; b=lO/+93vVh7P9Y2AxhpGARaM3Xqr+NYWFZUjRJIF0r7idtxXDkraNjJEXKM7KgI5d6ww4Q1sFSXb5AXx0TSWCnLgkXeB5KVmA349kUIKg17O3C62lclmiqSx5cCbp6I2fmSNZANCeLo1C9xfOkb7Esv+Lu+eS7EkiYHEusfCh2bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454647; c=relaxed/simple; bh=OAeYXdnsHo/DbZFmMhO4X2AF1kWlsKRdM1cAg1u4sQQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hpCYYJPazdhJvE6jW74MjPuh+JtdJFhjd4k8vRhkh7+ThiI+aODU/ueKoNSOiTSO8dprdZi+LMtkRU18tj+ukEot8QZrmypFS63HLRIEhNbY98G1Q9V6WZTAMjPv2Sl5a/Yzxt2mXatNboSMJ+l60yYDG6AATUtAtKytIWzVgwI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io; spf=pass smtp.mailfrom=finest.io; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b=KGZ6C84m; arc=none smtp.client-ip=74.208.4.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=finest.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b="KGZ6C84m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=finest.io; s=s1-ionos; t=1713454632; x=1714059432; i=parker@finest.io; bh=+oqF0TtEVeNFKa6CNbV30K8acenVtAv92jduxJuUnGU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=KGZ6C84mpRGmyLI24Vzuao4PZSuD2zS7lvjtVc/CVt1TMjVlhTMU0B8iTwdKbLLT e/67Ko+okbqsZImtBpynuk8W/n63ULHZV5vqX/kV7VIVdAdSQbBFCZ2ft++yQjgc0 mm2FcuvMMAAc+7DMzsyTRFUMmZ9f5nEVQZ+mDk1YpB0aBQ26R7+ev75Wft3p33Ba8 CUbUFd11LN8nIu6BfHQPxaH1JxAoADdzqsmHPEHZe5dNobuTVDbulqGRKjHoTjnKV APPewIWjXGLrTy+60v2F5/rj23QyzFbAquNJgn1zqgL/07c67hR70v7OboumGn65H UH2IYbzSNj0UjmFclQ== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from finest.io ([98.159.241.229]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0MH1eO-1rtZnu2Xuk-004pgx; Thu, 18 Apr 2024 17:37:12 +0200 From: Parker Newman To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Parker Newman , kernel test robot Subject: [PATCH v1 1/4] serial: exar: add missing kernel doc function parameters Date: Thu, 18 Apr 2024 11:36:28 -0400 Message-ID: X-Mailer: git-send-email 2.43.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:Peb4tWBB6FbIjS85voxb3JKatrdxNOnXiihCl6U2UyHeSbVugu8 gdH2glLJYS+dh5R3Sg/qu8lQkGm4Y6/ipwp9KOflfFIk6szoGss7v8IXhJtT61+IV5OGF2B aIXafB28nqUxsznV27dKZEjk8V/XDx+t0+3H8JGhs+Fy0efiOOFTsOClqVBoK8gLpxxoGlx wOxEDGh498tsbrraNBFlA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Q3pLf8qgAM4=;HwJgLiZqFwukb4dnVRLXoTN2R87 KLA0VPF7PN6g66gPeo45GCnj8XR29+ZsHskfogOpQ2kNDBPnNf+vTMDXRe+hkP4R6J26YiZx+ 13XyWr1px4fTnxiIUowKxs6r7RanfAE8PGB4uX21XJOOlqIhsu22ki69jBZbCuEc4KR+v65cw 0t2aDCizA7xpkL8CFOxp7koaMZoYuSTCigVHt/cUGL06qnsTg5S1WGl2Ie60s9W8BXERz775j aKyIC7rNgnTmpTcs/QLKFP03tOXnaAwH4E68f8Yb53WLP7XoxEsZJthydYGSzAHt7AYzsKLW2 +4Udui4ZhfAkO0yF7lJ107o3l1ruohl4pfeFTMhZy2X2PbErk3LW9lJ+lbfGDYS/cEeZGFXse R1wTaDis65rzmluBRhtBq2iqAz7oINQh3oebjaI8zGhVYyjoHyIOUVLfxabBKS4+dsMnEVhP4 4Jn/A3uWpLpAFFAh+s8+PWSh6qu/3JAcu4zIzGlClkaTwkiTuOUBVHLUTVmIz3dKPl36Y/toi Q82peq6wZLC2MdVk8lgyTTyme4BLgj9Gri2RiPxW42Mj7HnksLt8Jss/fvdDCeHuiMxBZZiWd ZZ8T2AcCiGCiFr7Xziwq9zM/tpw4KuX8JvtZ0UY2BspqgNBj+N3lnpl0e0YOVMNoVZd5p0OhN GorNL4kd3FbEXuxRj86ac3TvSjaxujRH1FKnYRq3vnULJcZPeNMe4Z7tAmBHYgOmn0qHTn88Z 0P0B+hgPfOssgGLXv4xJqiLoEL1lOFzXiItWzMAZ0bhdQh+9bku9Vo= From: Parker Newman Adds missing kernel doc function parameters to 3 functions. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404181353.1VIC4cz9-lkp@intel.com/ Signed-off-by: Parker Newman --- drivers/tty/serial/8250/8250_exar.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.43.2 diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 5e42558cbb01..a180741da634 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -715,6 +715,7 @@ static int cti_read_osc_freq(struct exar8250 *priv, u8 eeprom_offset) /** * cti_get_port_type_xr17c15x_xr17v25x() - Get port type of xr17c15x/xr17v25x * @priv: Device's private structure + * @pcidev: PCI device pointer * @port_num: Port to get type of * * CTI xr17c15x and xr17v25x based cards port types are based on PCI IDs. @@ -807,6 +808,7 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p /** * cti_get_port_type_fpga() - Get the port type of a CTI FPGA card * @priv: Device's private structure + * @pcidev: PCI device pointer * @port_num: Port to get type of * * FPGA based cards port types are based on PCI IDs. @@ -836,6 +838,7 @@ static enum cti_port_type cti_get_port_type_fpga(struct exar8250 *priv, /** * cti_get_port_type_xr17v35x() - Read port type from the EEPROM * @priv: Device's private structure + * @pcidev: PCI device pointer * @port_num: port offset * * CTI XR17V35X based cards have the port types stored in the EEPROM. From patchwork Thu Apr 18 15:36:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parker Newman X-Patchwork-Id: 790666 Received: from mout.perfora.net (mout.perfora.net [74.208.4.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA7FA16C453; Thu, 18 Apr 2024 15:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.208.4.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454645; cv=none; b=V4RmFJuHJWCBY7tdW0PjAc24ZmwCuMl6UQ9IGRZLm9fwGuis31V7twgxZSg3pkcdMMvkwgfWE5fTAQHILGnajrcqrrmA/GauUH1Ocs0vVRu9drSTm9GNdfcDMuQOfcZ4Hr7E/AE+fSyZRT/ybYhmvF1oQ0Bwn3VY5loMrNQqVnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454645; c=relaxed/simple; bh=6FcMwAVQ1oQ13VSGE3/gSNaKF921zwjZHklsSqpjmWk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tV4RpglWXOW/P0qQZ7mgWedKsxDy77TsoJj1PSIIw/JJuVTSckgK6aO38LC3a/7nzv2WDrK7tst9H8tquV885bTIsHJLT7HhTPgvlpoD1XXbxtINDbLN684Qjm2nPUwsiAYqMx7dMW/I9kbFY+0+7qPcIuwlYXUtzAyobUK5LTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io; spf=pass smtp.mailfrom=finest.io; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b=NnQEteed; arc=none smtp.client-ip=74.208.4.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=finest.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b="NnQEteed" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=finest.io; s=s1-ionos; t=1713454633; x=1714059433; i=parker@finest.io; bh=91znGsyHENCtexZoIjuZ12Bug2BwW+jFHp+nXCy9hyc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=NnQEteedl2hKmnSz3UYcDsE5k/E07G585K6/SqcIc8jbV2HjynREsfJNoze5byqL ObsiZWDnq3HJfb499Hi5HoIAcKTNLw8hxmCdSYt+n6BpfAklhz15NDBmSDzTlgKUD HVu9IsMjqqXtBxjGAejN89ox2+53Zhfak5W3yf8tb69vxpUwGehZyfsQSaSkI48Mm SN+VG7qsBccIfu+UpG2sF2UWjk5rDC3tOZ7oufhCuptdLXzPcwHKqLtddxdH+k1Gu ayk1n6vD20iUmd0HGR1HkItZXS1oYVI/uuDowWdnSKkEYZwou93/uErGt3r63/0mR YjX4uBL4RUxu9xrrrg== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from finest.io ([98.159.241.229]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0LoWNw-1sdwBO3kOg-00ow5j; Thu, 18 Apr 2024 17:37:12 +0200 From: Parker Newman To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Parker Newman Subject: [PATCH v1 2/4] serial: exar: use return dev_err_probe instead of returning error code Date: Thu, 18 Apr 2024 11:36:29 -0400 Message-ID: <69dce254723c80f69d4deef8512323a38aeeb7d1.1713452766.git.pnewman@connecttech.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:OoBam/oCzCOWDp5lY5iLVRbMrH/n35wBO3b0Jd7iTs6B+2WesgK xU1Z19cRezihSxiEIByqixoh5j199KAuBRQJcmt9JqV3vM6tjZcpePwevO3KMQfooiRaZmo Who3DLSRjsq0lp10ffCM+pAXI6yI2JnYfzBZ97pxC7PbVryL1LOILERMuJR7cp20a4M8J/0 FZqV14wfgyEc2CE3Pd8kw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AJoWJ7re4O0=;Ym4TddEyOePSxmlkoPMl3fc/KCL vvwZk7uSSM52cZp1Q+HK1xv3gh35/qA2y17pinMZ4V448Ljic10Idg0MzgKrrmuilAIHYZDmR 00Kuh7bsL+uXjebFN/nY1VUR0xZ18EkQM/EMvmR1RrBuu+pcdAU18OeF9A4/OKto8ElzIp1+o FfXUumtws1BpSkWZ4ZVVHvf9l2xfxuNWXOaydtjVuzZc0gFDljHuprchLTs2H59uqD9wGePyg A6701EMDd914ica0W1bGDIV+Ifsd2S6mrPzIyFuRGl8uTlZxInewfQbFuM/s7eRCFnXG7SN/i q5z8DFJsgLHN9e9m4t45agZgk5l51LgaZQBd2fCdNxGbYQb722JH5EqGWb1nWue2M/h1aqE/c V7JhY9phe4oEGPVV5/3xE3luEDTq7yY6DxZxfuLK7yvwjQ/tidqJJsLlMf+/rOWl3F8zwbg53 mhjNSUVboTUh3UeeI4Ya/L7mUJsm4Nmrq60gk6aRLInkpDqIfCIWNs2uPY8OIVpMsyAZMcuRp kmEBI6ZXCzZ71MBKoENPxKth448r86UNBqKoOgLTyOCrZHENa4K1NPQ6rahav+iCIMlScEmDC o3reyF6NIK3xBWKRaHWSNjIJrsBdomhDAT9QfA0snpMUzAyvFO+hA4u4zLaVW5VwL61CDes/o CO+7KIohshlnw/pJLd/B7OcshAYI9fvPrVAD5g6N/lVmh4hsSHnNt64zP+I13gstcbh9RRP80 46nryXfvP+IwNwELMz7l4RpWJNESt4Ig0FZH9Mozns+7+8cZIJcPeQ= From: Parker Newman Change to returning dev_err_probe() instead of returning the error code after calling dev_err_probe(). Signed-off-by: Parker Newman --- drivers/tty/serial/8250/8250_exar.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.43.2 diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index a180741da634..01748ddbf729 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -1551,9 +1551,8 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) nr_ports = exar_get_nr_ports(board, pcidev); if (nr_ports == 0) { - dev_err_probe(&pcidev->dev, -ENODEV, + return dev_err_probe(&pcidev->dev, -ENODEV, "failed to get number of ports\n"); - return -ENODEV; } priv = devm_kzalloc(&pcidev->dev, struct_size(priv, line, nr_ports), GFP_KERNEL); @@ -1587,9 +1586,8 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) if (board->board_init) { rc = board->board_init(priv, pcidev); if (rc) { - dev_err_probe(&pcidev->dev, rc, + return dev_err_probe(&pcidev->dev, rc, "failed to init serial board\n"); - return rc; } } From patchwork Thu Apr 18 15:36:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parker Newman X-Patchwork-Id: 790665 Received: from mout.perfora.net (mout.perfora.net [74.208.4.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E91216D4C8; Thu, 18 Apr 2024 15:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.208.4.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454646; cv=none; b=qVn8JhLrRIoOWDIeC3gOawUY6uN06MalM8B0GB218zooe4jboTF4xNZgDPL2YXXG9R0eZ/4f92ibp0C2bQd7bCMdC7asgRLk3i+6Z2Kw7Apxw2CTXUIdt/N7nQPDG7zCtBQAX5AToGHD95hiTlJnOiwwb7tVLf5tlrQMnmUNhFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454646; c=relaxed/simple; bh=1hWgt+DDvdbCIJN5SNmYKxsnzYxa5HptIF5iVF4grog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WbD6Lsu03mW9Yz20HlCzekNGMw+nT3Lc6AZUs6X1L6pRpY0+BL+aoweY1azssH6A9aDxe+QBbEctvCjaD07cksYIb+K2PQs6Qd5L1NBTviflw5SJt1DCqgEPHWSrFY4wLQ/X5BVcH/VYMvBHYPB+s95Pf4VERsUNc5QI8uDq/Dg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io; spf=pass smtp.mailfrom=finest.io; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b=jhPHWx7m; arc=none smtp.client-ip=74.208.4.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=finest.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b="jhPHWx7m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=finest.io; s=s1-ionos; t=1713454633; x=1714059433; i=parker@finest.io; bh=VlwHH/iE5BKx32sm64UdmIJpAec9xlGVHnH28Qxf16I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=jhPHWx7moDfvuucdBuRCTPfL+zexxKhgFg+vXQgcjiOAUQVwihGERqLWaaXsGs3X h735TdjEMYTygcpt7szMVGtFREqirKM9O2cL0dBIcGDNgm5j6ifXZUwSLWlaIdL0t IhSJ9XPKZZhmXpUkqVrcyvdlCfMYPp2wE1aERAklURc9+KqjB3WR0yyxyttkKKvlS HJ0e/vxC2zH/hqoMPDiU4G3Z1Fled1wH5Z3nE8YICwhh+rk1hsXgXp0P9qV0cFNAU p4wOOTD0pK+qVcG1t3SSXek8Df9oitw8mQe3T0Q53p+P8SKCWOyNmlG1tSWnLiths hx4vPyV2rqqAMF0dfQ== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from finest.io ([98.159.241.229]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0M1DzC-1sqfuD0sf2-012jsX; Thu, 18 Apr 2024 17:37:13 +0200 From: Parker Newman To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Parker Newman Subject: [PATCH v1 3/4] serial: exar: remove unneeded parenthesis Date: Thu, 18 Apr 2024 11:36:30 -0400 Message-ID: <1dbe1847d92dd34d223c6dc6b5cd0731b78e98e5.1713452766.git.pnewman@connecttech.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:bQEu5KI4PU9uazHVFAhyTCDEJ1cPLFKE43t9UspK+M1wWQnWe2B LzfV4GxATnu372R0rlrJw02M3X9EhYb58v1nKwnePnuBENb3W7TayDDpI0k4prAEuiCemJ3 If0Y5TsB5iojbiQuT9e3MP50HdhQ4DJV8/UUcNiH1iHuh6tdzsPtCHluBsGq2KREmJ98A4+ t5H8Kei4tYnCFmPFVxSpw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:vtyhNxCu1RU=;Dfn7KD6YNLoSkqEspF9rKAzceAJ rDC23iZIjdJlTLU7qndrM6zfTMRUvhzWhHXUXzjC8viMrtcSUjLlEVMwy0FbUVDUB+wrrq8xN WaIWq+kqbdtC35FnAR5d0nzArrMkA9pjQjXy66Lfrp2me6rWiW5wJ/rdm4pqeSZSbxhmMxS6n UTZ63MVn78aoV+8COqFNEFClbcrxDcppbO1q6nUc/O0GZCqdJX+Z7OvUAKpiaRmyyg+VxiGcE /P/B2tswXQgETYGsM56QmyVwFUVLYQYSKWQTyn5b7UMuKuRD5eUkD4H4SRS0Zc+tE0WMyNRT1 JX0ACxSdSiEmm4xiIvW9ESiT7r46RXjDljvyAKjtjPARneQS/03IEazVdrhHeWBcpu4jZ/oRo YeQOiQpJBfAT7m4Zlbj4FUoXBT/LqLmwpfk1965aLpcYmzVruXrJNcUMyFQzgP5uXkPZNXQ7u 9RTGXHFNHlj16JNOyQz1BzGd6ENiPk5R6NXnhkn8H6y6oqKUpJqM6qVLBIZdMzUGFGaqj2LQn t77445dvWsbL7i60n1VqvZ6hkeEQuP0YfCxkhVncaBGcI2c28SuSYxAEDnjvKMkd7fscQegeq E3wv0qbA6/3LzZpJaG9apPRY2pD9/u2KX1MorhStVFYN2ubmIkbeSc6mXx37dacV3Wny4y4V4 D48ikG5I4+X65/P0rj4tHcpMwqhfLSghIa0A+bMKDAGJkzaz+JfFhmMuc0U3uiDHJYSKmgoGt H0kGS7GoArdsobYRyc6T9HXw+q6PVkIIZPSoNjddA2JvWaof6/RsjQ= From: Parker Newman Remove unneeded parenthesis from several locations. Based on feedback from: Link: https://lore.kernel.org/linux-serial/f2353b8c-2079-b895-2707-f6be83161288@linux.intel.com Signed-off-by: Parker Newman --- drivers/tty/serial/8250/8250_exar.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) -- 2.43.2 diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 01748ddbf729..10725ad0f3ef 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -317,7 +317,7 @@ static inline u8 exar_ee_read_bit(struct exar8250 *priv) regb = exar_read_reg(priv, UART_EXAR_REGB); - return (regb & UART_EXAR_REGB_EEDO ? 1 : 0); + return regb & UART_EXAR_REGB_EEDO ? 1 : 0; } /** @@ -741,18 +741,18 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p break; // 1x RS232, 1x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_1_1: - port_type = (port_num == 0) ? + port_type = port_num == 0 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; break; // 2x RS232, 2x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2_2: - port_type = (port_num < 2) ? + port_type = port_num < 2 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; break; // 4x RS232, 4x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_4_4: case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_4_4_SP: - port_type = (port_num < 4) ? + port_type = port_num < 4 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; break; // RS232/RS422/RS485 HW (jumper) selectable @@ -789,12 +789,12 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p break; // 6x RS232, 2x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_6_2_SP: - port_type = (port_num < 6) ? + port_type = port_num < 6 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; break; // 2x RS232, 6x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2_6_SP: - port_type = (port_num < 2) ? + port_type = port_num < 2 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; break; default: @@ -981,10 +981,10 @@ static int cti_port_setup_xr17v35x(struct exar8250 *priv, if (ret) return ret; - exar_write_reg(priv, (offset + UART_EXAR_8XMODE), 0x00); - exar_write_reg(priv, (offset + UART_EXAR_FCTR), UART_FCTR_EXAR_TRGD); - exar_write_reg(priv, (offset + UART_EXAR_TXTRG), 128); - exar_write_reg(priv, (offset + UART_EXAR_RXTRG), 128); + exar_write_reg(priv, offset + UART_EXAR_8XMODE, 0x00); + exar_write_reg(priv, offset + UART_EXAR_FCTR, UART_FCTR_EXAR_TRGD); + exar_write_reg(priv, offset + UART_EXAR_TXTRG, 128); + exar_write_reg(priv, offset + UART_EXAR_RXTRG, 128); return 0; } @@ -1037,10 +1037,10 @@ static int cti_port_setup_xr17v25x(struct exar8250 *priv, if (ret) return ret; - exar_write_reg(priv, (offset + UART_EXAR_8XMODE), 0x00); - exar_write_reg(priv, (offset + UART_EXAR_FCTR), UART_FCTR_EXAR_TRGD); - exar_write_reg(priv, (offset + UART_EXAR_TXTRG), 32); - exar_write_reg(priv, (offset + UART_EXAR_RXTRG), 32); + exar_write_reg(priv, offset + UART_EXAR_8XMODE, 0x00); + exar_write_reg(priv, offset + UART_EXAR_FCTR, UART_FCTR_EXAR_TRGD); + exar_write_reg(priv, offset + UART_EXAR_TXTRG, 32); + exar_write_reg(priv, offset + UART_EXAR_RXTRG, 32); return 0; } From patchwork Thu Apr 18 15:36:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parker Newman X-Patchwork-Id: 790664 Received: from mout.perfora.net (mout.perfora.net [74.208.4.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25D7216D4C7; Thu, 18 Apr 2024 15:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.208.4.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454654; cv=none; b=PnnptcrI9KZl6/wpdkPEWffs21wgHwHzhotHw8AfPr5qBJXMf4yi1aXG37ilD40Jv4BN9/RZnDLgci1fbMLSV62rnE0n4fj9ZUIQwLClv8I6bExJHXHN9Zsqhldq8kwlL47e7ZNVzIVpkU01xtZehJaOEDTjCK9yY4QQSkro31I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713454654; c=relaxed/simple; bh=xrOseHxGhJJjbzBk9CbfMrD6MMhOfu9NvA7fUAzlpU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nJ8YjsNlk9/kLPdwUDq02azhPTKPe4V3e/4YLhnKgfYRtCEdUoqJjuRqP0ydMInVPRxfVk1iVktFTg61zrC+N6z3VsRT6G//xbbVqJLzPaKHKxfOW1X39AfgE1oJMFatEgEWQSsUc/fNZyG3wL+T2chmCuNo5KgOyH6y5KA2bME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io; spf=pass smtp.mailfrom=finest.io; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b=r5fbv7oE; arc=none smtp.client-ip=74.208.4.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=finest.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=finest.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=finest.io header.i=parker@finest.io header.b="r5fbv7oE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=finest.io; s=s1-ionos; t=1713454633; x=1714059433; i=parker@finest.io; bh=Ph05WVH8sofutm+g3QQ5ry41ZKtih+7xDUpbKSmjN4I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=r5fbv7oEwfLqrnoh+j/ksY4L5IwuHNOKOQeg0k/XemuRryPSYclJ2FLiJ4ctSoUX 7hnv6uks6oawn5/EjnLQHd1lS1rcv9dYz2wNzdaJVGB1KD4OHIZdMSD3oa0SxEM6o 7O1NkCAhUWjoY01I+LJiBNpYWBNw0tTfrbQqopTr59lGbN3d3p/GRSxaadDhd4Z1v TZOcXu/PyVty3JmJUH5qjfBC4HaZDtS3V1eI5VphuNN01mxzH8jgzs3yBuSJlj5Hw viUxMSWZWgf5aEdqYVeaLG5hkYY3miIQdTGWyFUEJMcd44n/KJ90DwsvHD90O61Ng OkUKA3CuNBwF3Oy+Hw== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from finest.io ([98.159.241.229]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0LbL7E-1sQil122iA-00bgXD; Thu, 18 Apr 2024 17:37:13 +0200 From: Parker Newman To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Parker Newman Subject: [PATCH v1 4/4] serial: exar: change port_type ternary line wrapping Date: Thu, 18 Apr 2024 11:36:31 -0400 Message-ID: <0081b6a7bbe1ad6ce114132f9ee86677a761de6d.1713452766.git.pnewman@connecttech.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:fEdVUzoim6yTgaflYo7WrYliLGG0Wd9ACHr3RzLIhaHdwvKaju9 HWlFhCpk0hiZYrfoc0FF7pIRylyoh1sT4OKHwi7t6+nVgn2YVeeaUEm9zo2SPsNe4y2KRX/ wFdQJCqCT6oKVg5sgieP74HMhPeIHtFDMd6aYgYNc/GGM0/VZ+Kz9JI15Ahjr7K/iycRQfo iNhp/q8p9PiQdWqdESFLg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Pq4BudVsxuU=;/kKc52QHcdEgk6SZ40r+13oNiO9 y0Hdf6jbiYkC817XjeW3l99+fHoN98GGqpHGbLX7/kRj1AU8S9SNkzuaeGzHb0tnDhQSCldco oSXEqc0q59StSVzfkkLGB2EztL41q5RoCtNBnqzDJWLbhAQgtN+7HFxT98Ugcj0s/QGgHnlsQ MvPJwBpvlFsxjfrJnFR8gUSofhX5FrrcjLym9Ros+zljucxYs3BBPw92aOEkaraZmKHwoHG7v cVjW3+3u8XZI0Gc+9jpTY1aXNKcDP8wwAKCOAcQvcui0exB8jn//hbLXpcxlUY+z0qZF+j9f7 WbGq1yHPaZriXjnbnam0bIif2XYyJGsltl1XYvreb/jNnou7Aak/qVaYGcL9LSM/gvXmMzUHW xcmscw7G9kHPYhDWgX1lUi/R+LNOJe7L6fggQ9I3Ks3flJux3mZlg2qbu73ittHpVsF7I6COU yePrv1WUpljSCBYgeyaz9nERZU5xQOcUdUA4QpklNcwDYgaaGasaiG/w7Z63n3uW9KFTjgt9/ PARSvKDF8YFcQUO/eFU4kRxf88CkF6PFp+UgjHveZs2h4a1tI2+ze/MQf50goBItoGoR1Ya0z CoaqZtsJuBgz2mrBosFUb7CZ3DExmxVQ4oCEI/SoQ5ZCRiCCDE2eRHe/tb2f0syBGGf6c5gYe JNl5ZvgpaKEQxz0QatBkO6k4ulHawUNIgA8SWwnPAPVZFpJl9z189I9P6HwWhUasDAHuyEHrP 1wQ34J7Pf2v6An3zwxMwbJb7SKcSXodYTHZ7KA/iQjmqbnWZBFiGd0= From: Parker Newman Change line wrapping of ternary operators in cti_get_port_type_xr17c15x_xr17v25x() for better readability. Old example: port_type = port_num == 0 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; New: port_type = port_num == 0 ? CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; Based on feedback from: Link: https://lore.kernel.org/linux-serial/f2353b8c-2079-b895-2707-f6be83161288@linux.intel.com Signed-off-by: Parker Newman --- drivers/tty/serial/8250/8250_exar.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.43.2 diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 10725ad0f3ef..a76b4e5bab4e 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -741,19 +741,19 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p break; // 1x RS232, 1x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_1_1: - port_type = port_num == 0 ? - CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; + port_type = port_num == 0 ? CTI_PORT_TYPE_RS232 : + CTI_PORT_TYPE_RS422_485; break; // 2x RS232, 2x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2_2: - port_type = port_num < 2 ? - CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; + port_type = port_num < 2 ? CTI_PORT_TYPE_RS232 : + CTI_PORT_TYPE_RS422_485; break; // 4x RS232, 4x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_4_4: case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_4_4_SP: - port_type = port_num < 4 ? - CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; + port_type = port_num < 4 ? CTI_PORT_TYPE_RS232 : + CTI_PORT_TYPE_RS422_485; break; // RS232/RS422/RS485 HW (jumper) selectable case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2: @@ -789,13 +789,13 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p break; // 6x RS232, 2x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_6_2_SP: - port_type = port_num < 6 ? - CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; + port_type = port_num < 6 ? CTI_PORT_TYPE_RS232 : + CTI_PORT_TYPE_RS422_485; break; // 2x RS232, 6x RS422/RS485 case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2_6_SP: - port_type = port_num < 2 ? - CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485; + port_type = port_num < 2 ? CTI_PORT_TYPE_RS232 : + CTI_PORT_TYPE_RS422_485; break; default: dev_err(&pcidev->dev, "unknown/unsupported device\n");