From patchwork Thu Oct 10 08:36:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 175731 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp1988815ill; Thu, 10 Oct 2019 01:54:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfFIguZg43VRgeVzSo7aEWZCJNyN39sgaGDSUhf6C8CEPPX301Fjkpg46mTdlmuzm32GN/ X-Received: by 2002:a17:906:6a4f:: with SMTP id n15mr7013245ejs.19.1570697682878; Thu, 10 Oct 2019 01:54:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570697682; cv=none; d=google.com; s=arc-20160816; b=G41ajMU2ywE4z0lPUp9nklT91AtuXS2vO95rteN95EBNXusQ5UgvGZXxF+0Alu8CzF v8yqswjctfwvRYMv1mDLICu7QpJUAy6MJ9LqjkyTRDht9BE/puyZ57OqYGU/v6g8OFto qKaOVsPckYlr5uGMB7ezHTr0aC7yt8pfTm/4rCO4b5GPYEybZzn3iYlcNMhFALN6eOL0 mWYuuVHIPNvSQ/uOta6QsMePDaT3sr9fbkiFg2Xc8+LrohEFL+v1zWRjS9b6Yzxl/QvY /3US2e+JKb4AXHistcp8Z4dY/Iv03p7TmB4I3j3NLKf75PCRoMVBeyFPwQUv2aiCg3ZY sWJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/8KlaFE7/zVeM1zqDtHBmpJBx54ZrKKPurxd8fnPIHo=; b=PFIeO2K5OAYs2AvVVHh2+FgqfjQHt92SdBqSUVkkQ/SEA6D7ywGowEk5tM1D7wkCW+ 4uJ4YCBWZv6p9zdR9llScWyWTs1MOhQd1qJ0yGZLet6VnR1ApNrOp5/WpE3UGbduPsnF T8hps+ITkuo+RoW+qoZbYFZQ4fQW59jo4+QGXSlOB4ev46CMSOzekmsMnWlSjs9iVoOJ 1yiwIuQxIAd+gbNG1U+fHgZkrBnLjSInMQYYu1EswyAw+ucDyAe52D4tCdd5dN0j/Uox mIZerGVrHnBC8z6mapIMvcd/yyZE8/qPAzM7e3qd5XIJKh+It2YPebyJEQFTn1rs7UvG hXnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Zv+oOrRv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1si2828917ejf.28.2019.10.10.01.54.42; Thu, 10 Oct 2019 01:54:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Zv+oOrRv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390056AbfJJIyl (ORCPT + 26 others); Thu, 10 Oct 2019 04:54:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:57346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389949AbfJJIuW (ORCPT ); Thu, 10 Oct 2019 04:50:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A23D32064A; Thu, 10 Oct 2019 08:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570697422; bh=roGeXEdnfRUvdAwGwtu+67kpTXlwRCPubY037q2Cz5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zv+oOrRvt4sI7Gf0xplUxI5ahxPOEgSSmpp0ISb2BSmDeNb61mBHKOwIb0196YGF7 /z3pNxiPnVCfQFQXhsxEjCbMAJapr+8ywcU/hwkzgzCnQD5aVmmCjSMcTmkqE+exKP 8GPtPkpk3j0MIrF/Ah31+g9z2H+94qmQ28CURSrA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Adam Ford , Jyri Sarha Subject: [PATCH 4.14 21/61] drm/omap: fix max fclk divider for omap36xx Date: Thu, 10 Oct 2019 10:36:46 +0200 Message-Id: <20191010083502.316843432@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083449.500442342@linuxfoundation.org> References: <20191010083449.500442342@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomi Valkeinen commit e2c4ed148cf3ec8669a1d90dc66966028e5fad70 upstream. The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not correct, and using divider of 32 breaks DSS with a flood or underflows and sync losts. Dividers up to 31 seem to work fine. There is another patch to the DT files to limit the divider correctly, but as the DSS driver also needs to know the maximum divider to be able to iteratively find good rates, we also need to do the fix in the DSS driver. Signed-off-by: Tomi Valkeinen Cc: Adam Ford Cc: stable@vger.kernel.org Link: https://patchwork.freedesktop.org/patch/msgid/20191002122542.8449-1-tomi.valkeinen@ti.com Tested-by: Adam Ford Reviewed-by: Jyri Sarha Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -1100,7 +1100,7 @@ static const struct dss_features omap34x static const struct dss_features omap3630_dss_feats = { .model = DSS_MODEL_OMAP3, - .fck_div_max = 32, + .fck_div_max = 31, .fck_freq_max = 173000000, .dss_fck_multiplier = 1, .parent_clk_name = "dpll4_ck",