From patchwork Sun Apr 14 14:07:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 789136 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFAA65D46C; Sun, 14 Apr 2024 14:07:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103680; cv=none; b=ceglLNBCDG9RXCEMsJjR+3fJzyNMsxBe1yPWFTr76OGRU4CdjHJpfjtLay6xsxSh/4M6qrhKJOiAusf6iLu005i/hHtmrG5z3heTuNN5o5H+6jeYqwyEbZzeXC5RJ7QLf/PcDmbMHs1TBev6BTTRVjG0UnUkf0TqWdMBTR+xtbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103680; c=relaxed/simple; bh=FSDsyMrRocq18g4fLSqC6+AUZYzqe2fK9hdMDuAh6QE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aHyF6WVm3Znz1wCyN1JDJYVwU2fChMkT3mg8vWsPQk/GR/yonF+JC/WmdQfnyzRnNSKURzqMZzVbj5/BGEL3MkzrPddjXitH0EMoi6O1ry+nr4zHE6sHwZBsnTmf/P6I06xJZjZPdyMZED/FV5c4rLB9+RFe+FYHbmIksEg/L6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EnfIEbd+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EnfIEbd+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9F3EC072AA; Sun, 14 Apr 2024 14:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713103679; bh=FSDsyMrRocq18g4fLSqC6+AUZYzqe2fK9hdMDuAh6QE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EnfIEbd+5MCYFKh2VhTHFTH6NXU76DOmSoWpb+qRuHWZG6Ex+SR4JIoN5/r/IcNf4 NA0+w73+s4g4iYwuThsaXDL5sRNgcbWINCfFftQ9k5pQD/nxKviGRsipla9b7yNl3n VIPW0GE6sYv6RSyCkym3OzbKxsL9qFL+SF1KsYiUrhPQ+6Tlyad9jrvJcoPOcmh+7a b97n37FvZFbsmXo1arCj9NYGiFJpzdfR1CahEDX9b99XcMBrizoEDW9nNsSkR95+o1 s967r+DuNom7bcDWR7GdvWW8EooMhyk61zdJOlzrUXBAiC5oA74RTjFZmVKY4YmJPG /fn8x1VW8fdxA== From: Krzysztof Kozlowski Date: Sun, 14 Apr 2024 16:07:31 +0200 Subject: [PATCH v2 1/5] mmc: sdhci-esdhc-mcf: Constify struct sdhci_ops Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240414-mmc-const-sdhci-ops-v2-1-262f81faadac@kernel.org> References: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> In-Reply-To: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> To: Adrian Hunter , Angelo Dureghello , Ulf Hansson , Vignesh Raghavendra , Orson Zhai , Baolin Wang , Chunyan Zhang , Ben Dooks , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=797; i=krzk@kernel.org; h=from:subject:message-id; bh=FSDsyMrRocq18g4fLSqC6+AUZYzqe2fK9hdMDuAh6QE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmG+MzDoL8lrBdv9R8C6qmMqUjwplc1m5xYrfV9 NrCRNMyeJOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZhvjMwAKCRDBN2bmhouD 14prD/9nlRkNlLM/QIo2blytG5aPzmgHbhGwm0yTMFBi6vvnB6nNCQejT/LYXmFxXNxaFiFrnPC YJNE9cr7JB02D+rigbNGPmHrqipvLiwrBMnycjYTp+FCCApqLm+Qu3Vl9mWzwgXCPTZ4dRZZmGR FADjRf5vGVyosUOoKztiAw8N9ByMuoHAz5eLm5uleAQWcw7A72YDZQxuAM9ymDDGAVCtGo86h/C GNfWUorijHmsbY9kfc4wV1FvFwJoFK11zAOc/tfD60TmTTiwgbALsf4KNIpEA10WZGIZVO1WKjV SHzlm5xXPdlYYSI7P+Hfdlqm8NUccthLax+Jjo0W8pgo4uK78eVLyAb36IYw0cS8EJyfp7c7ftj 62Kxd0G8paAx+izIWDPgztTwithZpA2MuKq89pKQr/H7Y5mir08yufuQP0c1RCm+aAKc7j/5r9d AlZs1Xd+/ycMPhmxaM+dx8GwLwTpjC+GL5Fruz5f6gLblS4jrLeKVJUDuedvC4geSA4CbP/9iGN x4u7bzTHdWhx19X+N5gI0amN+MNGLcvbWSgIsc6WSr6J7hfd5w7Dlyi+ACzFtr8tjUe3RW8s2fU V8Wkw/fotQzdHw6hfsOqL3HCC+S/eoLzjwd6IZKPjSILAszHRXBpDJ6kcwRxY8UXt63+sknvhom m+wMXmQnI/dI/TA== X-Developer-Key: i=krzk@kernel.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B The local struct sdhci_ops can be made const for code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/sdhci-esdhc-mcf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c index c97363e2d86c..3ad87322f6a5 100644 --- a/drivers/mmc/host/sdhci-esdhc-mcf.c +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c @@ -335,7 +335,7 @@ static void esdhc_mcf_copy_to_bounce_buffer(struct sdhci_host *host, data->blksz * data->blocks); } -static struct sdhci_ops sdhci_esdhc_ops = { +static const struct sdhci_ops sdhci_esdhc_ops = { .reset = esdhc_mcf_reset, .set_clock = esdhc_mcf_pltfm_set_clock, .get_max_clock = esdhc_mcf_pltfm_get_max_clock, From patchwork Sun Apr 14 14:07:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 788899 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2AFD5D752; Sun, 14 Apr 2024 14:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103684; cv=none; b=UvoRksaaglOEk9Trgu3xJVI0ZHTgz0+59VM3Ai9DwopexPyxhxE99PBlz75yNt1tEv6U0W5DNA9sQLUsJitLRICEFgSu+lgrV3wWg12RiPM7BdZdFNEHpyX7lKxZliqdazpO1FA/x2+54gwHcg0mdUWViSFIEZsUW/CbUev0DrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103684; c=relaxed/simple; bh=+gq8/HaBFcrh+lOjt/oiQ6thVO5EDI++3a+IpmyHbZs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aj31/YlgadofGs4MrS8W2C7esSaIx/U6G4UFONQ4cPIcka7P7R5qbAmVYapTGle/yL40vu90akGg8Qb3p6rQFVly4GRd1xXnRoJeOV/KyfbaJje5LdwfsNGr3oT3n5rG/oX5tFGVAE/hTEmsD4uCSXVbBeRhGfDZx5qUABBTC4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NVzWBU4P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NVzWBU4P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE5E4C2BD11; Sun, 14 Apr 2024 14:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713103683; bh=+gq8/HaBFcrh+lOjt/oiQ6thVO5EDI++3a+IpmyHbZs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NVzWBU4PN/xiazJK0sW/Bbtr17AGruIVuVKnYeLRP2DSDcaxGqCOTF2XufT6w3WgK Em2a4m73XkZdJCzytrGeejY0f2cEdfAtyIq04ojGiwjpn72tEiJGTKh3ufe4f0tNE0 ah4kXsazgPP8N9uKm0qsWkAci8NjZuKCU55NmPtjqBWvR3HLKoMdgklrilj0Ld68nr pUceJB0GPLlHJtxplHHveA2x9oFT64Q6sX6vrh3MTyOyyyylG+G6IzT/ug6/RJf27f cozDRoMkFR6eYb/UP1GY7O+vUZh/C8TTI156WraOwQeo9LMLWbfcXAesFyzIEpvJdU 3eddmo2D6994g== From: Krzysztof Kozlowski Date: Sun, 14 Apr 2024 16:07:32 +0200 Subject: [PATCH v2 2/5] mmc: sdhci-omap: Constify struct sdhci_ops Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240414-mmc-const-sdhci-ops-v2-2-262f81faadac@kernel.org> References: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> In-Reply-To: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> To: Adrian Hunter , Angelo Dureghello , Ulf Hansson , Vignesh Raghavendra , Orson Zhai , Baolin Wang , Chunyan Zhang , Ben Dooks , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=754; i=krzk@kernel.org; h=from:subject:message-id; bh=+gq8/HaBFcrh+lOjt/oiQ6thVO5EDI++3a+IpmyHbZs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmG+M0sMmroVOABrRU18XGA8lkH5YvcXp5tj6yr Xem1IzN++uJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZhvjNAAKCRDBN2bmhouD 12LiEACPENmr/f55rPy2PNYmBSKMIE92z0bbRpP/zs4tSn5dvx6xTsS3SHhRHhJod8y5Lfld9Xk dyP8bLzPX670WDi51FvbmNQ6TLqWOc+ZVAXtjpMJ278yuy+jSN2qwkafy1kC5O2QUpi9sSLorM3 yXsBPXWW63QE+HbVsrngT9TrxaFUZOEQ9fxgjYWKOdFkwV9ZuUDiu84F6hTHD82YzGI4WYjuFGy 3F+hHkSbtIzYPC7D3tm2DavRCwtORM8cwdX52APhog5l2vfX1cskjCQJRq2dCbbh20p5WIf8Vym pbwmN6nt0m+hDtBKHkkY3EJTqxaLJtCfSdHaKQbIHNEojSmrMl3jOVWeErO/9O4nJeVYoyPyHv/ /AAaXSYDnXmxToW65oj/aoq66JDuogTbMVMLGt8H0bDEsmSq4B7RIjr/bSrbDMhNDDeyuSDBaT9 UOenre7DQ5IywQbkJZh9kMNyklgdb1ENlPrsGnQuc86KARgS/cq0rwBi/uasHt4xasUMShVizNF P0hUOdtSXkACyiFdCm50lwmqjVy489PUucnpqALDwJHm3+hzpcrFVwK+2apPzfkWPxvSgrNk2Rm Pte4gXYfZGFcPEtiRtEeb0mbFjONXtcU/KmY8iPJmVJi46x/ATPRw/TyzhsEKa8Ub9BEZEfzktd WNx/72UFo4Norww== X-Developer-Key: i=krzk@kernel.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B The local struct sdhci_ops can be made const for code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/sdhci-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index 94076b095571..5841a9afeb9f 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -925,7 +925,7 @@ static void sdhci_omap_set_timeout(struct sdhci_host *host, __sdhci_set_timeout(host, cmd); } -static struct sdhci_ops sdhci_omap_ops = { +static const struct sdhci_ops sdhci_omap_ops = { .set_clock = sdhci_omap_set_clock, .set_power = sdhci_omap_set_power, .enable_dma = sdhci_omap_enable_dma, From patchwork Sun Apr 14 14:07:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 789135 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A80BA5FBB2; Sun, 14 Apr 2024 14:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103687; cv=none; b=hyrrCaHogcUyWWOtSsS/TP4ezyHhJsrcKrK+jNHSNgBxaQvgQ5e9PbrmiZ5ww4EXgQ1m7EL2gfvgMvM7GdtowCjY29tNo1ch06/UeGN3ZS1xalkJSXCOjuwWgMkVrkwQ1gqRl8fDUkKxfTd9H9dMlbu6qbCbjdnqpSbxgi2ONZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103687; c=relaxed/simple; bh=6xewGZjyB3FgtC9pR8X505+HKwYWfSCoiugoRhC/E3c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NeXjoJfXdBdDVyNnYLofuqN68Uf0fNhkuMZVMDCFF1/g73CVDTyjjPvXZ4Sh8rWQwPQqAXOiE5V0SUp7iIYdE7kF9JLCazNfyHW4Bb4Dhc1oyKAmdZMqt2Pb5k6FbFdaDLF+rVxgwBDiJXEIxiJeYhg+a2FnADZ0xYkhZAqQGf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qRLTY4MX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qRLTY4MX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 017A6C072AA; Sun, 14 Apr 2024 14:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713103687; bh=6xewGZjyB3FgtC9pR8X505+HKwYWfSCoiugoRhC/E3c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qRLTY4MX68kxa6M8vARqsOX7U3DUO5EwZhtfo6KEW/cd0Wg+2XDLLv2R/CNVJ/WET e0YXaWbg4iO1jjnDwUGganVlooKSbM4XwihOA+K7r8T+eiXTqHwKXnGdWVjMK5cFzC XU7ROGPTRHDG1m+6RpZYcLirC4GVrEmKhKDvfdDJQMuUoJCHcC0elpXjN2O65zRz3m eKx1Objl+3YTO8DULPbxIYp3COlEcGa6OK+ycvCRHQvUSNI5loTBEr86GtCKGSEONy 0gNl2um6LCWNfDaQWCNKh1ztlJ0RaL1bVUdIEQz0ecYBBSza0eWneBnCGO8NHmJtoU l62Y82315FZow== From: Krzysztof Kozlowski Date: Sun, 14 Apr 2024 16:07:33 +0200 Subject: [PATCH v2 3/5] mmc: sdhci-sprd: Constify struct sdhci_ops Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240414-mmc-const-sdhci-ops-v2-3-262f81faadac@kernel.org> References: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> In-Reply-To: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> To: Adrian Hunter , Angelo Dureghello , Ulf Hansson , Vignesh Raghavendra , Orson Zhai , Baolin Wang , Chunyan Zhang , Ben Dooks , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=723; i=krzk@kernel.org; h=from:subject:message-id; bh=6xewGZjyB3FgtC9pR8X505+HKwYWfSCoiugoRhC/E3c=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmG+M1HdNDD842vKUlU46JiescmqInXpP7Rg0m8 f3vk1+YlyuJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZhvjNQAKCRDBN2bmhouD 113oD/4peDmVoH23QGbpugtwZCbLonWFjZnrWL6FlULLtscTG3SnvdG1PXRbTh3sRUGXsfYF4ez GAdsFpgpVNF1sHlRE9xty52FVD6TxzD4yDRCuEvNdWFV1ARsoQ7yO9BWQFILTZ5o0AkMXlfBwOi kq0gw5N+bkcO1g2423yju97ySHS/0M/vhFm8UTCJmerk6cUJdm7Z1m8J6Mqz1R3f+Vy+aeVwT3L YB8lvddhRTyBqlcXGseNfQosEv4Bl1gSJm23Y7FMbVtJvz4VpmTTBNcLo2wFwUuf9QyJCjKRGxo bWaSpXuKTLy4Jk8JcL8OqKkRzmgd+xs8G3feN9R1k11VoVOHcAcqfslETC5Zmcn3OpTTfmiktSu pUkr6DQOvXbW73F2yeebb4avOS/9Q6pvXn1UrGO6bbJ8a0zAR6QG9kfip1FUKXKPTIEVbDPR4Ob hJx83nnNQ9YHui8fo01lwYFgFHtxbLFo/dG/QHgEL7KOGPErWaAlVchWmG7ZRroihV3m5CFAd0z LKZWipyQw132CAZkvhqitCM0BYeRMGYT/76dyEvGfQKjqUJB2D8XBzW/H5Fqcvj8b2PFh7Z9ItX OAcaBuoyJGY2k5nnD9e11HO68fjAhxhxnf2fzzpr6GTuPsQMH2wmRTCmMz25jB/K4bPeGRp6mu4 AWVPSSuKigRsdiw== X-Developer-Key: i=krzk@kernel.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B The local struct sdhci_ops can be made const for code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/sdhci-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c index 685b1c648901..8776f4287119 100644 --- a/drivers/mmc/host/sdhci-sprd.c +++ b/drivers/mmc/host/sdhci-sprd.c @@ -439,7 +439,7 @@ static void sdhci_sprd_set_power(struct sdhci_host *host, unsigned char mode, } } -static struct sdhci_ops sdhci_sprd_ops = { +static const struct sdhci_ops sdhci_sprd_ops = { .read_l = sdhci_sprd_readl, .write_l = sdhci_sprd_writel, .write_w = sdhci_sprd_writew, From patchwork Sun Apr 14 14:07:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 788898 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA6AC65BAA; Sun, 14 Apr 2024 14:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103692; cv=none; b=YHvsDFafClte5QiXkDxdDy5LsfL2LIsILF9U9+wywmWqh7JxtnZU6Q4Q5tmMNhwWWtZSJPyRbuzffVjLCaneCwUoFYf9NUHniY3qd1lQH0ZnOS5czRKA0kAS4fwKsJzJV1CXqDwgxNp4jLe3olSDJjx9tcMAmLbkC0Vr7yrYaJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103692; c=relaxed/simple; bh=uD+ViLOa9S8ut1fdu47zbr3AGnB2izGuU5i0gc4OfAY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pQUeFDh9DPpoW80kwVPDmRaZ+HmBe7FLVykMkqFbrgJTa1uIHDqeB3f9/VqKlB8bkls/kdKOZr1G8vuyuSJUrlcdVcZSqBnAONKiKUu7JMxogM9Z/DSLHBSjPwVk0nquOKcBgwGGbVUY9lKu7NJplRROkrwe9+9uo9WUSqDtWZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oaQ6dpy0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oaQ6dpy0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31D3EC32781; Sun, 14 Apr 2024 14:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713103691; bh=uD+ViLOa9S8ut1fdu47zbr3AGnB2izGuU5i0gc4OfAY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=oaQ6dpy0/bZFcrzx0xa6ZdKbwZ+HWYPcJpZbV3mJlc9Dq36IRF4LECxztrPqtiNPC 7XVN4abjlpbnm8/njQc1ykYGjnh/adrBNBtj1xIAb6PZRu1j1rziVUHcobqRsbPh9r BvfAUCOHJiePZQwdDsQo0NU/jOQT3+DQUP74PmizQLB7j5L750DQ3iTDZLFQIATRWG U0qADXTKUBgiN5/L2aN4Je1lVHnt0VOTGlYjnpI/hTQFHD5HZjjGgpcAE8Oe4x6Dl1 hLBQaly2j27I6y50BVtTx9hS569sX19l54TYnChlmyHBS3u3XKm6JdDo06Xl0dd8Zq 9Z6nDTnohqfcg== From: Krzysztof Kozlowski Date: Sun, 14 Apr 2024 16:07:34 +0200 Subject: [PATCH v2 4/5] mmc: sdhci_am654: Constify struct sdhci_ops Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240414-mmc-const-sdhci-ops-v2-4-262f81faadac@kernel.org> References: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> In-Reply-To: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> To: Adrian Hunter , Angelo Dureghello , Ulf Hansson , Vignesh Raghavendra , Orson Zhai , Baolin Wang , Chunyan Zhang , Ben Dooks , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1685; i=krzk@kernel.org; h=from:subject:message-id; bh=uD+ViLOa9S8ut1fdu47zbr3AGnB2izGuU5i0gc4OfAY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmG+M2zh1fbUOLMtUAgWd7ZaDBybdesu8Pqk3Wr ulA4whRsXyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZhvjNgAKCRDBN2bmhouD 1yYND/95N3oZCFrYMsBGYpC2+FcOAL1vwWFiaX2dVzYix51XGD4L+7ljS4t73rlJcOghBqeCq45 iCWZbuAH1Z8kjiHgOxqEtuGs4fPbqpNLowqd7gKj/rBT8F5Oo540Crx+XXwsscM6eELN5pdZbo9 zrc0UBIWtlFX+GmJzFXwJ9zSezRhLL4NKBasO7/fp4Uf69gOQ661N7wgFAWvjLMN8OgcyFAMcFx z1Qtyu+EhbbUjs2TFCQZ1s5DWaURgdZfgOBJlMXKosu8lYSTewf/XBXoQvQ+3ynoN0F8Ev7Cxva oqdwjCZho35QWIKTqI0LrdCHf7x9llXmpClJKA8BMhOtU2A+eWz7UGJNRXukem0s/8r27ceyyOb x4ZCzemfdZS/ll+imkOnmbTJQ2jjZizHWXW96EtEbKFrl8XWfSmFExVriWKG0B439bswW+7EMrY /kVR5Mp8EkM1VvYumIpmXFdWM81LpWEo0EzUmSJDOPxLD7l76CwHnOd6LRRMDYZu46CNtICegnv MGSb/h23VixJvHV4wjpja3ZBmCNSoRsuV7yKZMCBkoSSAY2rt4Nw8s/ZMKzstPknVSumTrYF/bW bnbJG686tBvYyXX7Nnlk3bPO9hXPz5u+1hZOr3oF1HGgbFrO9UN/SOcLkSfGDdyvi7GZMAMEXS3 HbeDvXXuNf7T+nw== X-Developer-Key: i=krzk@kernel.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B The local struct sdhci_ops can be made const for code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/sdhci_am654.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index ba36123e4ccc..17ad32cfc0c3 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -543,7 +543,7 @@ static int sdhci_am654_platform_execute_tuning(struct sdhci_host *host, return 0; } -static struct sdhci_ops sdhci_am654_ops = { +static const struct sdhci_ops sdhci_am654_ops = { .platform_execute_tuning = sdhci_am654_platform_execute_tuning, .get_max_clock = sdhci_pltfm_clk_get_max_clock, .get_timeout_clock = sdhci_pltfm_clk_get_max_clock, @@ -573,7 +573,7 @@ static const struct sdhci_am654_driver_data sdhci_am654_drvdata = { .flags = IOMUX_PRESENT | FREQSEL_2_BIT | STRBSEL_4_BIT | DLL_PRESENT, }; -static struct sdhci_ops sdhci_j721e_8bit_ops = { +static const struct sdhci_ops sdhci_j721e_8bit_ops = { .platform_execute_tuning = sdhci_am654_platform_execute_tuning, .get_max_clock = sdhci_pltfm_clk_get_max_clock, .get_timeout_clock = sdhci_pltfm_clk_get_max_clock, @@ -597,7 +597,7 @@ static const struct sdhci_am654_driver_data sdhci_j721e_8bit_drvdata = { .flags = DLL_PRESENT | DLL_CALIB, }; -static struct sdhci_ops sdhci_j721e_4bit_ops = { +static const struct sdhci_ops sdhci_j721e_4bit_ops = { .platform_execute_tuning = sdhci_am654_platform_execute_tuning, .get_max_clock = sdhci_pltfm_clk_get_max_clock, .get_timeout_clock = sdhci_pltfm_clk_get_max_clock, From patchwork Sun Apr 14 14:07:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 789134 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D872524BA; Sun, 14 Apr 2024 14:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103696; cv=none; b=bIgCCgwk0kmCrjn2h4r2dmLHFJ5NlqGmC4IF3z/IfQWYOgc0mN5DDfQEtKuxP3MSp4NzCyAVWLjaZeiwOC6gMc9mVrfRSExf0igQntl5Je1DZ8wS4/iXHFJqpjeO2vEEursMp13St8I4u4BgjUwVYp0oL0ngcDrB6i/s8ZLSOvw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713103696; c=relaxed/simple; bh=P6C2uaZWdzkaxUS/4whafeWniP5J9sza+c4EUKItEQ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NS1MSkt2uAhl6OGPsiRPKDIMATtm81xYIoC/qbyNR0gZEVQsR9BzQQPiUQimBsfncYz+1Q8g5CL1kp7kglybhM45a6FPwTA1g0SIERAe/fPYdNmR+INoVjAHjmp9UhHxbgVjLVIF9OxtAgxhP5lFFZr7rbU9d51eXVp6sgA5k2w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kct0spDp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kct0spDp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AA64C072AA; Sun, 14 Apr 2024 14:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713103695; bh=P6C2uaZWdzkaxUS/4whafeWniP5J9sza+c4EUKItEQ4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kct0spDpdnU+Oef1efVYeGuX1xs7cslj0SveDcqa/6NQjCikhXkAI5Vpg/Wf5NvFR E3IY6hlSiEcE88JrPAH1K81YnpFWBYcuxb80gK1oymF8ME3pqnUX88g8DcRDmEaTX+ wQ+Fx3q8jIBmFhM5/bUE/UYSnkWBWcraOTaezFBHZ1kfHddWa3M9mKHw16QQhmQ+jl Wl0o5XcYxt7W06fqiBp/GoKzyk/YvMIjIl3cRlvVCtbob2edABcDlO7qWZglqhRTP8 SWcn/juxtG3VcXJRvbZcByeliZX+NR0knteaKUL1jd7YE69HV7Bgj2dMEfYlO5uBm9 H+jpOmx3BdZ+w== From: Krzysztof Kozlowski Date: Sun, 14 Apr 2024 16:07:35 +0200 Subject: [PATCH v2 5/5] mmc: sdhci-s3c: Choose sdhci_ops based on variant Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240414-mmc-const-sdhci-ops-v2-5-262f81faadac@kernel.org> References: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> In-Reply-To: <20240414-mmc-const-sdhci-ops-v2-0-262f81faadac@kernel.org> To: Adrian Hunter , Angelo Dureghello , Ulf Hansson , Vignesh Raghavendra , Orson Zhai , Baolin Wang , Chunyan Zhang , Ben Dooks , Jaehoon Chung Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3968; i=krzk@kernel.org; h=from:subject:message-id; bh=P6C2uaZWdzkaxUS/4whafeWniP5J9sza+c4EUKItEQ4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmG+M3tp0WY1HbY6u/BNP3jUZnARS+VLivgrLfQ xZoFJE26eaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZhvjNwAKCRDBN2bmhouD 1+K3D/9tSh2DQGQf+DmCy04xDvumNPYmDIpDPVyW4wfJgw7T9zk5EIXLCiUwH9ANA2lbc/6lyOr V935AQHhWr/vTg0YcxydmTIlMPvFbDPKVfDor5P5RBGgqfFVJkUkAUYzISrEs/XtJ4aWIQPltnq 8NhPi4xuuQhBds5/EPgJhmi3gms0Rn/eGLNDYveal+Khc+AEStzrRT+/GUhe/WqFhkVa6IwfUE5 lUVPOb0a137J9ZkwdVj73AklRdpqoLd2HvpPq9WOhH/GPxdcdy8mjI8v9i6UtMuokzJiodl0q9I 0/uj+V7prdUhUirtynRhczYanYjkJpAjSpOPp0wXJ/xach5T9CvVtu8xFgdETC+R119di1ErMCR +6rgliO5WZIfSsJhs91HSsXAHX5CXx4JhGbKkschwKTse5RR1/t9d9dDfXNyWAgcijxGhL3GS4P ORDf4QUXEM40foi5F5L8YU2YXIQnUPmHDMXdlAeP/I03kbc2OXS0om+wC06SgkU70I9Fi3IXSKg QpOcYzaJ/29d4wTavSK9NoYGm7Yg5dDHpezgZa32mgqOeqONaKCxcYben8zrrGL68aw7Ez7jGq2 UkYlJLcWz9wIMlvfD94A+D/X/r8E1m/i+DV6sw4JbzEXrJnT8fgo3vAfMYf2ytEuPSwXwDQIBr/ FOP/AfYmPt+mF4Q== X-Developer-Key: i=krzk@kernel.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B The difference between old S3C64xx and newer Exynos4 SDHCI controller variants is in clock handling (the "no_divider" field in drvdata). Choose the proper sdhci_ops based on the variant instead of patching ops in probe, if Exynos4 is used. This allows making struct sdhci_ops const for code safety and probably opens further options in the future, as the dynamic pointer ops table is not anymore that dynamic. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/sdhci-s3c.c | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 6493b0edba34..a71d56c7031f 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -130,14 +130,16 @@ struct sdhci_s3c { * struct sdhci_s3c_drv_data - S3C SDHCI platform specific driver data * @sdhci_quirks: sdhci host specific quirks. * @no_divider: no or non-standard internal clock divider. + * @ops: sdhci_ops to use for this variant * * Specifies platform specific configuration of sdhci controller. * Note: A structure for driver specific platform data is used for future * expansion of its usage. */ struct sdhci_s3c_drv_data { - unsigned int sdhci_quirks; - bool no_divider; + unsigned int sdhci_quirks; + bool no_divider; + const struct sdhci_ops *ops; }; static inline struct sdhci_s3c *to_s3c(struct sdhci_host *host) @@ -412,7 +414,7 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock) sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL); } -static struct sdhci_ops sdhci_s3c_ops = { +static const struct sdhci_ops sdhci_s3c_ops_s3c6410 = { .get_max_clock = sdhci_s3c_get_max_clk, .set_clock = sdhci_s3c_set_clock, .get_min_clock = sdhci_s3c_get_min_clock, @@ -421,6 +423,15 @@ static struct sdhci_ops sdhci_s3c_ops = { .set_uhs_signaling = sdhci_set_uhs_signaling, }; +static const struct sdhci_ops sdhci_s3c_ops_exynos4 __maybe_unused = { + .get_max_clock = sdhci_cmu_get_max_clock, + .set_clock = sdhci_cmu_set_clock, + .get_min_clock = sdhci_cmu_get_min_clock, + .set_bus_width = sdhci_set_bus_width, + .reset = sdhci_reset, + .set_uhs_signaling = sdhci_set_uhs_signaling, +}; + #ifdef CONFIG_OF static int sdhci_s3c_parse_dt(struct device *dev, struct sdhci_host *host, struct s3c_sdhci_platdata *pdata) @@ -560,7 +571,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) pdata->cfg_gpio(pdev, pdata->max_width); host->hw_name = "samsung-hsmmc"; - host->ops = &sdhci_s3c_ops; + host->ops = &sdhci_s3c_ops_s3c6410; host->quirks = 0; host->quirks2 = 0; host->irq = irq; @@ -570,6 +581,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; if (drv_data) { host->quirks |= drv_data->sdhci_quirks; + host->ops = drv_data->ops; sc->no_divider = drv_data->no_divider; } @@ -617,16 +629,6 @@ static int sdhci_s3c_probe(struct platform_device *pdev) /* HSMMC on Samsung SoCs uses SDCLK as timeout clock */ host->quirks |= SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK; - /* - * If controller does not have internal clock divider, - * we can use overriding functions instead of default. - */ - if (sc->no_divider) { - sdhci_s3c_ops.set_clock = sdhci_cmu_set_clock; - sdhci_s3c_ops.get_min_clock = sdhci_cmu_get_min_clock; - sdhci_s3c_ops.get_max_clock = sdhci_cmu_get_max_clock; - } - /* It supports additional host capabilities if needed */ if (pdata->host_caps) host->mmc->caps |= pdata->host_caps; @@ -758,6 +760,7 @@ MODULE_DEVICE_TABLE(platform, sdhci_s3c_driver_ids); #ifdef CONFIG_OF static const struct sdhci_s3c_drv_data exynos4_sdhci_drv_data = { .no_divider = true, + .ops = &sdhci_s3c_ops_exynos4, }; static const struct of_device_id sdhci_s3c_dt_match[] = {