From patchwork Wed Apr 10 11:24:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788114 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6AC21598F2 for ; Wed, 10 Apr 2024 11:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748310; cv=none; b=LRXwdAtlZ+xK2Lqr5hC2mCpanauIH3pYJ8PP+BgLUMefP+KxK3CxGikTcMr50j8Qjtlk7HJiMYzdQpBsnofx3R23sGWsLyfRfZC/pYnI+O0OuaN+DXKfpNje9k6OqjP7YFl5oBTpCqmMjQ7iPAl0b2Q275/gog1s5MpcL18e0QI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748310; c=relaxed/simple; bh=n9EZeQuSQmBJRMMjz9lb1sRhifEA7wA3wrruEYieoeI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=esix7janLMoOCLXALlZodTn7e4DSSMl+NdkO9+0kdBa51ji9y4wybCD7fdMKWF5tZu+h4NdO30KIe17u06sDBjzZGRMgBaYfCnK1vFXjosvAppnESm+O1s5AZ9ke/eKXKCznVBxVYibJ4YOmH3AZQ1r9a4kpZGQGZ1vnxhlbSak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=XqNqXHKq; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="XqNqXHKq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=g8alMqK48I9QhL3+4HvdPnnuLkdA4QOsMgnkT/Ultao=; b=XqNqXH KqxLFkogTA3zf784DTUGVZrJlnFkcqAUey3BtoR4FoF1KSdkHhZ/fN7CC7qITyCK rb8djWae4TKmyCwY3w2ke627cmkh498XKMmAgOQu9AXKKh1K8ya5KHAteYwkNy7s Klkbcw90ixoO4u4/1F+qe2bc/WVhG46/6reYmEzcQW37FTboAnMiMmq/eKLFhsFL kr5hGRO6oOSY24T7/cJAOLQe5lceLjq7zL+qBliz++NcB4Fgf8mzv0cvVoDZ0K0i gyiQ4yHrN1a5YNz9FOQ1Ohq6qfVSRFsJXPeu2WXg/HoSBSZBO50UNIcTsSsWfCxu kGQTFW7qICIiiotA== Received: (qmail 521337 invoked from network); 10 Apr 2024 13:24:59 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:24:59 +0200 X-UD-Smtp-Session: l3s3148p1@dNDtSbwVhm5tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/18] i2c: at91-master: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:15 +0200 Message-ID: <20240410112418.6400-21-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-at91-master.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c index d311981d3e60..ee3b469ddfb9 100644 --- a/drivers/i2c/busses/i2c-at91-master.c +++ b/drivers/i2c/busses/i2c-at91-master.c @@ -591,7 +591,6 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev) dev->adapter.timeout); if (time_left == 0) { dev->transfer_status |= at91_twi_read(dev, AT91_TWI_SR); - dev_err(dev->dev, "controller timed out\n"); at91_init_twi_bus(dev); ret = -ETIMEDOUT; goto error; From patchwork Wed Apr 10 11:24:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787735 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C358C15959B for ; Wed, 10 Apr 2024 11:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748310; cv=none; b=tgT5UTnrmbTahCMe7NxMAllfHrD+UwKwV01tJVBg28hNxQ26k7VjiGfD6b7jreiiMyJg3xKWrarcElaS224yD4qFcSN/BmL/wi5Q6MnIh6dtBYxvHxO4bUdKog7BYlv4phvcKCg1b9r/iByT5Vq1UY7zdHTxYmGzBH2Bhx7SMQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748310; c=relaxed/simple; bh=rML+54KQxwJwfHqQB1Xs1kpoGt4Fp0NfJJiMWEPs+08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=riOBl97EVOFBXQ0Yv+iznPmp3sDMV4SNrdJ6j0xqP6HJHd/vvHZ8IlN0jrkIgqCY60hBxDrHRYrMHilyAwzbT+EcFzgZ3xmkppwxmHz0HftLaa4G3uEsufizb7amF659MwjVs/IFYInjrIgxYkv8n5KXxLHJwWHO+FMTPDZN75U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=bT56KSqE; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="bT56KSqE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Q2XuHTnpBIWpyQZNHPcbLppoXDYJ4UpElNhcDdmY5jE=; b=bT56KS qE/8jdTPtzKVw2Ql1egR3fsIujU6yyooIfip4LLJuwCIwiFEVnYf4cJk3MF5AgG1 lViwoGWmMBRNYcFlrDHP8D4F1gA7UiHBIJXqw/xL592owDRZJvvZA6mJnXea7zER RU4D3At3BuQwZXPGy/dEhD7KSR8RhtmzgrSEEF5VCgPT5fxIjYjCHXAab+1g71nL wkhCFyxZkp9dG0SQNjR5ZsyuYEKtHBZ5xzWufQAhPK7SHvc7noOMJdUrgbDH3otw RXKQ0TH9Uw/dKTgvDYtZUDAqliK8B2DgNx2tQq7L3KL4p8YUrgE0rcuTn0CiiyZp fRh8SaupDeeDUvng== Received: (qmail 521390 invoked from network); 10 Apr 2024 13:25:00 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:00 +0200 X-UD-Smtp-Session: l3s3148p1@xiz9SbwVCgdtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/18] i2c: bcm-iproc: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:16 +0200 Message-ID: <20240410112418.6400-22-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index e905734c26a0..133d02899c6b 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -811,8 +811,6 @@ static int bcm_iproc_i2c_xfer_wait(struct bcm_iproc_i2c_dev *iproc_i2c, } if (!time_left && !iproc_i2c->xfer_is_done) { - dev_err(iproc_i2c->device, "transaction timed out\n"); - /* flush both TX/RX FIFOs */ val = BIT(M_FIFO_RX_FLUSH_SHIFT) | BIT(M_FIFO_TX_FLUSH_SHIFT); iproc_i2c_wr_reg(iproc_i2c, M_FIFO_CTRL_OFFSET, val); From patchwork Wed Apr 10 11:24:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787734 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37A71598E1 for ; Wed, 10 Apr 2024 11:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748311; cv=none; b=EEADPKvWhXWntwoyiddfDDM32RlhpabfMiNDVX2zrW4XWnWpCNqk3leywgl6sNauykZshumBl+8yAXCcLm54yx46KTzpYgfuc7GNf//ZziEtB5tVCtYUoZQkwpuQhyuE5sveipRarMmaMx4KybGR7H8rIJDMOSlh+8Sq3XnaXOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748311; c=relaxed/simple; bh=dVv3yCapRGHqaKbd/raKqVqecjajjR0ihwDqpWezJvg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MS0hO1DVUFbiypeWjhuF3+UqlA5UIYxOVkwmE/eVq/DaJeQ1RdB7aogJoS+uvkBiR5ddRQ5TBxHQXtVrQmA6CuZH2ltTeD7s63dEV0gY76D/KGpljdyUYRVOMRluu8S6MOvs0XlSKIG2Y0Ts01/Tz2jU7yRt56uBjyGXjZcQrc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=QphoD0Ic; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="QphoD0Ic" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=4EUSyGzomATeNIcG8P0cZgKgvqo4WHF+lzVzVLKSadU=; b=QphoD0 IcmvSEdfsDJaszWGUfYISArnr7pFEh3iVuEliuWPXsaTgp99s+8UAb1PeiQ2J4Gu YVzkQFx3QKuRWskt4wncxwHVmjHKjJzyR7pgQVM3JZumJ3aMUasyuyrdbjPI09MX orqntkK7cBII9SSeznWLuksgjiYzPM25iII9cciqsLVPmcQPgblgN2v6WFy+xDAR GYaOcP6HHNAsj3qUD8mkxKXUqEpyl8BtH28WnzKa1Tn7BnuTR3JmA+ZZr0FdXKwq nFtZzB+Yb9qVvDlZJkJ2v7nmQEJW9ryYrinepeH7aZSYWbDr2HyBE0CLJiGG1swO lMVX3FG5Sbd7o0jw== Received: (qmail 521447 invoked from network); 10 Apr 2024 13:25:01 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:01 +0200 X-UD-Smtp-Session: l3s3148p1@AQUNSrwVyC5tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/18] i2c: bcm2835: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:17 +0200 Message-ID: <20240410112418.6400-23-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-bcm2835.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index b92de1944221..3045ba82380d 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/drivers/i2c/busses/i2c-bcm2835.c @@ -370,7 +370,6 @@ static int bcm2835_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], if (!time_left) { bcm2835_i2c_writel(i2c_dev, BCM2835_I2C_C, BCM2835_I2C_C_CLEAR); - dev_err(i2c_dev->dev, "i2c transfer timed out\n"); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788112 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71C915ADA2 for ; Wed, 10 Apr 2024 11:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748313; cv=none; b=N0hDbbVdD7sKBfu4kudq3nfmN97jXykND+uTumpdtFn1XM3UdBS7EuTG0qWsLOjIaPjxG1cPTFw9phPQJ1m+3z02yYsW2fguNg8WI454HAFahd6mmk2BO8P4GPuVKJnRY5Y+EfDHA5wpZQd8sKj9RwTc5gVU1L/jbaadGnhw9D0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748313; c=relaxed/simple; bh=EEUfTeoa9Foy7qAXuzOsrCEqiYrisx6cg3y/4vq3/C8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lDe30MjtXuKHUY6K/ovh/DMOCcptRU4RBFQfF1GpvdeQtD07lqIV/mYfDSxpSRfb/wxkqqJj1TDMgzyp2bSYxhh3/opoAeSaOvuxUvvp84ng5Wm8MkqLP8OyMsAv8wn0E5CKTCRw3VlhwYCN7khcVssxg4pVKK/yIXJo/ztAVl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=a6oVtxBh; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="a6oVtxBh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=hD8uz8cN1ScOd8WPchdst4mxCACdD20Wmh45ImGI/X8=; b=a6oVtx Bh1gvv6bITBD1Cz3DUhfELjmFMxhEhR+AHoeksfm5KrUSRVeoTQikoU/us2SJR36 rqhzW6yJBUHl7MfBms5eST+3Y5CC5UJ1MuHezo3gp8VXpRwwjOOg/8rhgsMCskuF 4kgy7RaL4OCO2tK/P8srJT2kFViURleSD/lh+JjCUqSVLQCTDpHLB0ve+pzwFifE Pyz8EWOzPRxhwJj0gt3aNTVOi+tPxvtNMLR9t/vS/RZmprV/kWIG/G7cE4I5fTp5 gzwrWLO2uV0sO78yYo2yAFoG6TXLqyFhb2BMuq7eorRE5aoF/PYcKhXZzZXokYVg 61UO01t9i8Cf5lpQ== Received: (qmail 521473 invoked from network); 10 Apr 2024 13:25:02 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:02 +0200 X-UD-Smtp-Session: l3s3148p1@iO4iSrwVDyBtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Michal Simek , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/18] i2c: cadence: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:18 +0200 Message-ID: <20240410112418.6400-24-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-cadence.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index 4bb7d6756947..1b0006e3b95c 100644 --- a/drivers/i2c/busses/i2c-cadence.c +++ b/drivers/i2c/busses/i2c-cadence.c @@ -789,8 +789,6 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg, time_left = wait_for_completion_timeout(&id->xfer_done, msg_timeout); if (time_left == 0) { cdns_i2c_master_reset(adap); - dev_err(id->adap.dev.parent, - "timeout waiting on completion\n"); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787733 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4AA915A480 for ; Wed, 10 Apr 2024 11:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748314; cv=none; b=f2zNAI9ay4RPWsfqcmFOokfolNNehqPXZtBFHsnIrL3TZsbhey/opxkmUrzcP+u3e69tjrpmysAJz7vNzou2ZZ+HvI4gUSqFem7cschfqaxxedr1QpDkBciutHjE6W6UyqUaCrFgoe1GexVjOCOjzUC6vBnpmhr+PGrEKdWthAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748314; c=relaxed/simple; bh=LuYiLQYpXnLNQ7RViJwM96fp2OtM5TMOTmCzc8ieNjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pl/dvx4HgBH4/XGEjE4HvoU7vnVREN1BsltFxOSiQnfqTzzMT0nmMpBQ8kiAhI5JMSm2WicJTt+CcGRxHl3RlUFprd0gMifrCZoKekZk5cVUFEabn1/V7FR9mLzkBCyu/FtcRIfGvQhHkTWaVKBjYZdmg01TSbeFJ4BDftFn378= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=lWenHIyt; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="lWenHIyt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=q5jkr9/WM9vH86xqE+ltTHo/KtY4HZuCeBtACkBfJFo=; b=lWenHI ytoeCjSQDSkx0iz1ocAdTupCRi3QvuCSWs9BjyFctMM7jbinxlmB0DDLVZ9IVdTC WJB2GPpFINtxSKOmuUGqhtoEOoji6KndgfHhIzarj1T8MVueDYlCXOxU/6I6yDYI ENtPl0mMrV/KL2nBY+z6njeFHn0i3HjdxgF2qPbf/R6nWDfvGgNuYBxd5XVr71cq JCCZpi75etxa5d5Bjy22TX8uN0H0z6JH0bYEDST3X7BPuh/zh3Uk+93Jn+vMy/YH XcZDocjV5wMEQRh1xnYWA91DZFo3elBiSVsFEXtIXI3K9E+abOQVoL4959teXxNx UHyGT3gkagV/b/Jg== Received: (qmail 521490 invoked from network); 10 Apr 2024 13:25:04 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:04 +0200 X-UD-Smtp-Session: l3s3148p1@sBY6SrwV/yZtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Bartosz Golaszewski , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/18] i2c: davinci: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:19 +0200 Message-ID: <20240410112418.6400-25-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-davinci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index 02b3b1160fb0..7ae611120cfa 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -489,7 +489,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) time_left = wait_for_completion_timeout(&dev->cmd_complete, dev->adapter.timeout); if (!time_left) { - dev_err(dev->dev, "controller timed out\n"); i2c_recover_bus(adap); dev->buf_len = 0; return -ETIMEDOUT; From patchwork Wed Apr 10 11:24:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788111 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE7BC15B0EE for ; Wed, 10 Apr 2024 11:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748315; cv=none; b=cXXfubS40fhk8VFNZBfFW5yHu9bKwBtQ1YSoa1kmfu+i6fkJ/l5nrIHmxxf9CPbbhW+mV+4tHhwQgbgxIajOge6wPcTQCQWo0/+CHZ0xbNvfM8ZRoKn7qo+yTWh8u7YIKLtrmytSH2GxU1FvZAonsP03Y/y8fhZlBWfe+D6+FL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748315; c=relaxed/simple; bh=YcRydtjXNLVuXa4H/6WF5MRtX2A+FlVhs2A96BKY3U4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FPZu3Ff5WSIiSZlUEJgPs9UxAiNzTdL+UxxN8bY/nvelEewm/O6nqli4OEtjCCn7LtaWiuA1RJLFaUrHbLiBfLcSatTrJhBgamQr8lH19hrOwKOtUR6NEMiFv/TXdah35CoAMvZ/9N2OZCyTzHwrD14UX1QeFwq2GP7msRbfgVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=RenlmC1L; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="RenlmC1L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=KtqWGbx2zAusZTYwsY4cWx/AjOyEcwI/aftE7eByqLo=; b=RenlmC 1LB35XLh8+w9chF68T65rl7eY0yq78VMEN87td+UQGkXO5ydB5cHoWZ64cShv8U1 TOFXT/7A84131Ihj6rsOK9/hdxTYfR2c6pWS/7G/KAHkxwxNPnuCZ6pK5d7zBpbK hUGeZ16mTryaKpScltBUeXsq2x2tqDK2woO4MyV973pDCV/XudPplTS3MxMB41yH SbTpEALhyyZGkNZt2IZiJ6JF90HcUCDJ2ltbdD/kSLLWaawGjQOdJo/eFws68GRu BB9ymH0YIb5ncxvS7NB4XHQAcC355JZkxR9GDwT0U1/HwtopFb/YUjVwVelz8ToY Ygz5n4lJTITDERhA== Received: (qmail 521532 invoked from network); 10 Apr 2024 13:25:05 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:05 +0200 X-UD-Smtp-Session: l3s3148p1@rkBOSrwVtFFtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Jean Delvare , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH 06/18] i2c: i801: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:20 +0200 Message-ID: <20240410112418.6400-26-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Turn all timeout related printouts to debug level. Signed-off-by: Wolfram Sang --- Here, I did not delete the printout to support checking the termination process. The other drivers in this series do not have this SMBus specific termination step. drivers/i2c/busses/i2c-i801.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 4294c0c63cef..a42b5152f9bd 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -400,7 +400,7 @@ static int i801_check_post(struct i801_priv *priv, int status) * If the SMBus is still busy, we give up */ if (unlikely(status < 0)) { - dev_err(&priv->pci_dev->dev, "Transaction timeout\n"); + dev_dbg(&priv->pci_dev->dev, "Transaction timeout\n"); /* try to stop the current command */ dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n"); outb_p(SMBHSTCNT_KILL, SMBHSTCNT(priv)); @@ -411,7 +411,7 @@ static int i801_check_post(struct i801_priv *priv, int status) status = inb_p(SMBHSTSTS(priv)); if ((status & SMBHSTSTS_HOST_BUSY) || !(status & SMBHSTSTS_FAILED)) - dev_err(&priv->pci_dev->dev, + dev_dbg(&priv->pci_dev->dev, "Failed terminating the transaction\n"); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787732 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89EE815B106 for ; Wed, 10 Apr 2024 11:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748315; cv=none; b=i4tlxQmTJf/l1+rhPCdv+mbse6uGeEH8BvKI1cljadPef+PCxekZM+FXx1aaApzGDPt7D86KmO9JoiWCwVZ/uhgD4LN/xmxVmTxpilHaDuHOysAoN0fl7DhEVxihs+QPhiffHMlWOQltrAfWz/bFm6xcPIEkxv08XtwYyp8XAuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748315; c=relaxed/simple; bh=wluySLpxATwK5WykRORCd63slQvqphsUlCNn3aw7kJA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qd8PVdDxZa1CarcyK2ON3mxtHUnzzSqT0+sTdKhquv/oGZ8KwxtOhX62yvocqa79LvQlDX+JOhqESpbbmuCvgWEpHoPqVNgsZcBqE/edYMBmzPR+elHzXKzgBBgFcSs+dCOAsnLgcn6ayrjdXUYb/boKQH6F8hIPMrWfoMm5Spo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=RRYk8cY9; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="RRYk8cY9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=fPQu434kXThfULnzqmFJ6qbKKgAHLHiDMKWRonVt0mI=; b=RRYk8c Y98o9opRGfncDNxc2SUmgucPbmi+sZZKCbIfbyfLYKGzlUOjqZGuMIak+k5U85mc XKKN+mpX5UxPPHx8JVtXiOF/zhH946SOYGLltYAzMF55+OGFj7MJwrhA2uF+1xKP WsckbvJzqJ9I2mSGATIzppZh4Dy6ePNS54i5THw6bStHXisPM+34m2caSMDy8mEO +uB8WkS5JieTGSQVQrgWjBgFKlDBKDm+xhtJegYC3Aa+3f9XxmYAO0/F8+SVx86b OyV+m2Icj99UzMFK6YCR8XoKGsutaYQoU1yIJbia+892zUlXvzTDVS1zCKX/T+hj n/qDdFZuGwMCEefQ== Received: (qmail 521554 invoked from network); 10 Apr 2024 13:25:06 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:06 +0200 X-UD-Smtp-Session: l3s3148p1@KBRfSrwVDlptKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH 07/18] i2c: img-scb: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:21 +0200 Message-ID: <20240410112418.6400-27-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout and simplify the logic a little. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-img-scb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c index f9d4bfef511c..e0e87185f6bb 100644 --- a/drivers/i2c/busses/i2c-img-scb.c +++ b/drivers/i2c/busses/i2c-img-scb.c @@ -1124,11 +1124,8 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, IMG_I2C_TIMEOUT); del_timer_sync(&i2c->check_timer); - if (time_left == 0) { - dev_err(adap->dev.parent, "i2c transfer timed out\n"); + if (time_left == 0) i2c->msg_status = -ETIMEDOUT; - break; - } if (i2c->msg_status) break; From patchwork Wed Apr 10 11:24:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788110 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB11915B143 for ; Wed, 10 Apr 2024 11:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748316; cv=none; b=ZcdzSRud10OMtwti3yzCvsRBMDj9N7pkAjncesjPmxnO3CCqUWZsffwt0CoMmbqcK1eUMD8hRDJIJWCt0tqSq8Eaudng6iIFfdfi3+CxYkK6bu5N7krQQ8pLFEgc1HrTVhqSiyepq90pgYEi7uPj3vxyQSlsHEjHqNJ5ptWKZus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748316; c=relaxed/simple; bh=pKNy6/uLelc9atfAUxjk+L5JFkzaKEwH/YQAY44xMp0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rRe3wyA2JeMPS+9qV3UL1qo+P5GVm96vEoehIaAQKS/vXqj4CHwkW1gPrpHjlIrYPPacpVV6QwkW0t4x5ebWhDnNX5tgqI7Ojwlga+HtKEQOMMV+J27dPFmiAH6dE/MitmNMHbXMbmNfvdrfnsbx2zBETJExuqLtCY5FFZHKnUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=epXvFUdE; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="epXvFUdE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=jy0TzjFxRzkI83BTDaZvBAgFgJJl0WCFPH//vHbPFOw=; b=epXvFU dECEpEQU7wwUDKH0L4A5dnk/KnufSLIU8+tcYgj9N+Y7K2XSjveQ4i76654T98Mj ozYnMJyETZh0WX/FvP24CG2SBD9inGEqSg2XiRL/+UdMCSSIQyaiih4tTmbr6wlC qGGm6jbmS3e8gXzHk10dPK8ISWC/o4AsTOhQqpIckZ7ZZFQfJ7KW+jXfH+PmQFsI 1+W1kiKU76tI7mxSTP4YOpyTtst33VNudWbaN5z/aDIZR3gqcSJGQH/IohbeXxuD yW5Ce3mCbUR9Aq6QEz4ejpgiCsi0AZ0dUhO6dGZMkxpsFloH8Ttm4bi/vjgF0poA Vzine1zU4fJsjt4Q== Received: (qmail 521574 invoked from network); 10 Apr 2024 13:25:07 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:07 +0200 X-UD-Smtp-Session: l3s3148p1@ukRvSrwVgwZtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Seth Heasley , Neil Horman , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH 08/18] i2c: ismt: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:22 +0200 Message-ID: <20240410112418.6400-28-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-ismt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c index c74985d77b0e..655b5d851c48 100644 --- a/drivers/i2c/busses/i2c-ismt.c +++ b/drivers/i2c/busses/i2c-ismt.c @@ -623,7 +623,6 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr, dma_unmap_single(dev, dma_addr, dma_size, dma_direction); if (unlikely(!time_left)) { - dev_err(dev, "completion wait timed out\n"); ret = -ETIMEDOUT; goto out; } From patchwork Wed Apr 10 11:24:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787731 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A28315B541 for ; Wed, 10 Apr 2024 11:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748317; cv=none; b=Ckc9LF35YvguCw2LzeMrQhyi0560PPIcciG7USPZTZimL7ZIvxWHlB1FfXM9s8OWSXou3zP9CkCz7A/lf827YQeEpHfwCMv+16bACGGCuGLJvLXrTp+TobITPM0pxnFkkwXQ63PeUP8DJ83zUbiIG8P3TVjx1jY7j2c4bRBIoeM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748317; c=relaxed/simple; bh=KPt2uGhm9EdfH7F5fIbK6qEcblJ4g2P2Nirv6Vrgn0E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q7vpxJlo+efHNnSlQJLniNDJ30g353NpNMAM7OJkhp1M7+epFM1YxdsZkT47BnjKihdQIe+4ZjUhoeBh+sbA5oNRml1rbQZrFQp7oaNIQ6gxl3We2uaEhiuXfrKd0M0QJY2LzJb8UKCtt2DPDpd/bqDOvgKdmEBfUgDnebUFTbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=Vr6qAr8i; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="Vr6qAr8i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=3esuL+DU1erk/gYHtm2gF1OBGVxFNyh1r/SypUa9yCM=; b=Vr6qAr 8iFkO2wOh0d1gYTcxzNKRyDBqot/1ghiSOBRenx8UjsO+5PnOwwgoljk8Bs/UjIQ kbTetXqSgGkGWju9mEG5XkPttMpOltFo8bPzQwTAte/ly+rE108AWwHLP8sAtiZj diJblVIrmuAlp9n2ASvIDo9yY7FXDSOFWXfHqJ4sNFcPO3D/2OiY4q+t4uqm0e/f q8QmDwWXO42uR8VA1W5j5/WFcbOq6LzMSrn3wvZ5jYrLQM+c1XQhE3zlg2+bLwYP zgG8WxIPhfFPh0+uULC/GQpyFKVXQQUW+QiQkzK3WqGAGQ4YeBeVzrIJJ6N8Woqp N96as7wrkefpS4xA== Received: (qmail 521590 invoked from network); 10 Apr 2024 13:25:08 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:08 +0200 X-UD-Smtp-Session: l3s3148p1@YCV+SrwVeGJtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Linus Walleij , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/18] i2c: nomadik: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:23 +0200 Message-ID: <20240410112418.6400-29-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Linus Walleij --- drivers/i2c/busses/i2c-nomadik.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 4f41a3c7824d..45c6df26fcbf 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -542,12 +542,9 @@ static int read_i2c(struct nmk_i2c_dev *priv, u16 flags) xfer_done = nmk_i2c_wait_xfer_done(priv); - if (!xfer_done) { - /* Controller timed out */ - dev_err(&priv->adev->dev, "read from slave 0x%x timed out\n", - priv->cli.slave_adr); + if (!xfer_done) status = -ETIMEDOUT; - } + return status; } From patchwork Wed Apr 10 11:24:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788109 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47AD15D5A2 for ; Wed, 10 Apr 2024 11:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748318; cv=none; b=cWwm9NK+VY7cONLZNwOmQHiq4snCR7a1AKUi6Rjyx/cdLhmjDLGKKmPymzqev7OTnBbQF6w23NQdRA5kR+c0rq1VKZxXSqD+ZOPIRX7mYN/ZdTa06tNeaLHK3nWe36oceU8hUnMiv4Xea+qUZPKr3UaEnd6qlxzY76N4jKi0MNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748318; c=relaxed/simple; bh=xQvUs1HAINisoxCUqYyynmQYCCX1o0BOa+VKS52/pn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UtRFDN7Jo133xYEdbO8UecQshDLgUpK9ZYyCBNfVoQ9Gt9B9WKVVjWExGqDKdMMpboMpRel1bDfOzndLdhQ28yKYQFtf0pJ83UwSvRd/AaDJMDfyA5+BcSSNmDFAyatp2J/vg0P2nTryH3BmQfTlyRzF6c6PVMEj6OYEhvJG/CI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=LndvGka0; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="LndvGka0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=NWNvhOQ1P1l2OPQ/ikbk/yVi9ub/Dsp7Etl7kO7Xtms=; b=LndvGk a09V581tPWlWHw0Nn3N/rn2lMHLvDSseKEe/RL8R3wS7xyMWuNxZ+yfs/0pfsSny rTNWkdh//T9P7OK1KhPmr9NOTz2tPhCStjoqeldajfBIgwHMoBz2CWDzyOpmsSDB 9kUKl/aTVwj3bTzsTx5b6igiXvJ06zjliEa8JhkuVxo/fs+Ct664NUFbikR6OVGh CN/NKSAMRgAm+9KSZuPBvJJVHaYxIH3vf4jsYdN6HvRV8DEIEhtefH6JhWUux8Ko RqwaET2H0+KEV9xPKTAjTkpNXgygoit4zgL/md4dN6SJndDlAUPCyIAcX37DFPzw dQPg4Z31mECCwYxA== Received: (qmail 521623 invoked from network); 10 Apr 2024 13:25:09 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:09 +0200 X-UD-Smtp-Session: l3s3148p1@ndCNSrwVqwhtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Tony Lindgren , Aaro Koskinen , Janusz Krzysztofik , Vignesh R , Andi Shyti , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/18] i2c: omap: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:24 +0200 Message-ID: <20240410112418.6400-30-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 42165ef57946..36bebef36740 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -752,7 +752,6 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, } if (timeout == 0) { - dev_err(omap->dev, "controller timed out\n"); omap_i2c_reset(omap); __omap_i2c_init(omap); return -ETIMEDOUT; From patchwork Wed Apr 10 11:24:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787730 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C58515D5D7 for ; Wed, 10 Apr 2024 11:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748319; cv=none; b=S5t8KW3eWYPHTARsYSJho0QGrUCMPw2COoArMV/meCHtYYGAEBPYXFs2qYD797gP40XPaBs9yPLt6RNAZjwRMteNaonltnGM1/H7DZtuuH6b/rDw0UK9GDdGjzMifRmBrVrWMQ16hBw5Txb8Hxnt53R2qNWqQrxNJ79Q4x3PmSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748319; c=relaxed/simple; bh=+pdjM1s6Ki6mrvtt2IV5vM61l9m948tojzNqs2Jkx7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kNok9+Rja85aHyEqYISOrK/HwK8Dqpks8zoj7/dvtT5eZQW/EwYicVnv3KLjaDNQ3ED/W1WSYL6J40k+rMInG3KQ9DDQq5KGaNJhxsROwgmfdP2X2R48AwyHKxYWguj0l3tTkk6jOv7cVKj0QE1slDczLr6pN3ZKmn25uBynxCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=O35o9sA/; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="O35o9sA/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=MIh2Te8HRB16dLWCZQy/u503SxPLZR4I/XrMPIptOnE=; b=O35o9s A/QrxQdnKtCJc5CK2Acr3z8X5R8hpnyPciX8LmYASeqN1ZEpbMmFbgFXvLwgE7YN kH6BRRwlzqFFXmQwHItosHjSMm/ZqdZXrBq/lG1SckthpkilUm2XBK1MJtP+q/2x qXfy62rIR+sHfUj65K7+0R83adECJYhroq9Llm1isGbk3b+0gaM1dKkOORdPbN5a 05o2Zb78BVnIfGCC/gZIa84AhHuTdo23+0FgxYAsqigAklFoWVFR9IWAn9Hb/tQE YUx8UctlUXT1kj5xY5Dcyw0WU8bxD4vZ8yEE41Tg2cbQhrhWGbZg/QZcq7toT0uW aVcRr7QRkCZdT/1g== Received: (qmail 521651 invoked from network); 10 Apr 2024 13:25:10 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:10 +0200 X-UD-Smtp-Session: l3s3148p1@A06eSrwVZz1tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Bjorn Andersson , Konrad Dybcio , Andi Shyti , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/18] i2c: qcom-geni: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:25 +0200 Message-ID: <20240410112418.6400-31-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Bjorn Andersson --- drivers/i2c/busses/i2c-qcom-geni.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 11dcfcf13d8b..6054c62cd2ff 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -642,11 +642,8 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i dma_async_issue_pending(gi2c->tx_c); timeout = wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT); - if (!timeout) { - dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n", - gi2c->cur->flags, gi2c->cur->addr); + if (!timeout) gi2c->err = -ETIMEDOUT; - } if (gi2c->err) { ret = gi2c->err; From patchwork Wed Apr 10 11:24:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788108 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE6F15E5CD for ; Wed, 10 Apr 2024 11:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748320; cv=none; b=KuEzQqKCjIGW00z75cjDeNWhgZg02iwivbfBpU6yDMZaf2Z+UGOZuYeLX+/Cox7uIhN/R4ZLSd01gb8Lq4xW42nvLa99EJEMtFpMbz9uROzQwt45YOvXtNqpej9FI2rFmtgpEiRBN2lib//8W/peGMHpjU9bjBKxaUQQJxs1l8I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748320; c=relaxed/simple; bh=sxi3WEpwgXQI9JfKHETzDTiVADUhdiDC54vmSGW+gcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P1/o/Khl+ilPxK4e66JIzBR97zf9bRgTvPRamsix4mMUMtnGiN1xSIxZwQ1YmYm/y2x4rAqdLZ4AD5DuLAWGgH9Lj/aXDJwHYbds8ptn5D3XGC5LlUo9aDSOHhR9XbpLBhpWSbwzNJ6Fh9x4Lif4v6lZyg7uKX52Q4U29+aVNI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=jGE3GHSr; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="jGE3GHSr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=k+7gyTeoVGWoiQtUP2kx99lHQC+xHgNqfgabFZlIt1A=; b=jGE3GH SrEt72iicQl3z+Wma4LyoJbEUhwq4GtkhjTCBT86qz3m3dKyZqNgvIgN9ulyjctM zLhTn30TwyJBvhhIIPmbV4hAa3R87lCupIZ3t+oD4PkwDA99PKFuG94FDI+dyrEz ZUA9x3+ENczhqRVFL1LWAb2IO9vnpQtip4k1s7DJu7RmyGmF6K8hhuMVpjV5zb5U y9zMdP26ZYjAvSqATF2aJ0iL7nOBFQgKWflgArrd4gQCViSeqV0NtV23+NkihG3F y32+rxjyjiMR+WFFmsSFDKxyeRRt6pzWF0PMRg88Zya8AKgv9km7NUci+W1GKuVo 5+K/SLLwioe8w7jQ== Received: (qmail 521729 invoked from network); 10 Apr 2024 13:25:12 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:12 +0200 X-UD-Smtp-Session: l3s3148p1@5xq1SrwVmi1tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Bjorn Andersson , Konrad Dybcio , Andi Shyti , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/18] i2c: qup: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:26 +0200 Message-ID: <20240410112418.6400-32-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-qup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 598102d16677..c9b43a3c4bd3 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -793,10 +793,8 @@ static int qup_i2c_bam_schedule_desc(struct qup_i2c_dev *qup) dma_async_issue_pending(qup->brx.dma); } - if (!wait_for_completion_timeout(&qup->xfer, qup->xfer_timeout)) { - dev_err(qup->dev, "normal trans timed out\n"); + if (!wait_for_completion_timeout(&qup->xfer, qup->xfer_timeout)) ret = -ETIMEDOUT; - } if (ret || qup->bus_err || qup->qup_err) { reinit_completion(&qup->xfer); From patchwork Wed Apr 10 11:24:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787729 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1257C15ECD4 for ; Wed, 10 Apr 2024 11:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748321; cv=none; b=SWaaGBS5klbbainiuYOPV25RTTkwwrSPjf5kE4qVBMd5TtPtDTIqS5C8/mFhPbQqsLdx0FFGMQ9+HRDNgU7PBDZuGrlOJB4bc34h0W5sv0U9co6UUu+SpULYxSRM1rlpqVFGnbKjsv222TM8w66N2wO5shyUZuW6BNeSssWoH9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748321; c=relaxed/simple; bh=y2QeXjoOMiwMA543m/jKRgEBhto40dDwX/umjYl1yiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GQn/Pn/nC7YgIe1zk1gfvVWQlkyPQ9t494WpQlCy5HvfasU/mqE0ezltN1NTqC4Vfnt03HPxFZTZBjhuCaUvq/3oCuHmLa7TzhuknUrbIhsMRuiV6bJGiM74uvX9TMm7gzC2NzJprnwjbqovUPx7adoputrfft87Qkwgqx3NMek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=e61aOThH; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="e61aOThH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=tTh5gHnHTO8tnn3N/EUqm3Hs/2cCwpj+zf5vzhI2jO4=; b=e61aOT hHkW2NOKlDMp0TsvrVPjYTmQqz9G6Xfcy4dHz+uo7EKsZwsdYFgTTcGXuAn7f+hN PfX+75V6R6IdoC8PKSbQrHZht+Z8lwzqghjNxgf6NDV/Q1eq6+QWkooxVjjytOoF m+j5jM1//kWHUH3M65OJFa6CFln6Z20DJE5R68iZuhIAtGClWAkld7cvKeWG96gq OytNpo2VNSVE5AKSL8nl3TZvZW9zWokIbnswIEBw7J9RzT2+6qsa8QkyX9Kae2vF KPk41mjCQLuUsJZWVYzYK/4n6kn3jL9Y6ZwEmUDbCUkn4AUTtb3+EjN1DBxsliIn 68yvSpKSLylj7xwg== Received: (qmail 521797 invoked from network); 10 Apr 2024 13:25:14 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:14 +0200 X-UD-Smtp-Session: l3s3148p1@25HGSrwV9SJtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Heiko Stuebner , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:27 +0200 Message-ID: <20240410112418.6400-33-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Acked-by: Heiko Stuebner --- drivers/i2c/busses/i2c-rk3x.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index 086fdf262e7b..8c7367f289d3 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct i2c_adapter *adap, spin_lock_irqsave(&i2c->lock, flags); if (timeout == 0) { - dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n", - i2c_readl(i2c, REG_IPD), i2c->state); - /* Force a STOP condition without interrupt */ i2c_writel(i2c, 0, REG_IEN); val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK; From patchwork Wed Apr 10 11:24:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788107 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF06F15ECF3 for ; Wed, 10 Apr 2024 11:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748322; cv=none; b=Rq3Swzc2lhwQprxS0iH8e9HJ1Dt6YF6Gpik+U2A2dTwUGhpyA7GXREIfnqJzYnJfz7CrRIHWXZNGCSU8VDwb0QUiqqxCYzJVbFTXOZgIpt/1Qc6wPNNx0T5WMzqA+HkY7Asm7HaOk638zkQ6fIWK5KAwuWXQSFgMnAmF8pmM73k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748322; c=relaxed/simple; bh=6ti3SWFJMR5Y6I9U8oFT41WoQzKqT/mu6zUNKBYaZts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WmWyUdv4tToQfFKtr7lb3KyIAEnOr4BFARyHGT2+36OfvbdMB/GJsLbcjmTpDgMpfaZkg+SUjxWBB7iT9IBoB/5UFWw+PuAnWQ86m4Dyv/MYQTCZzEdFYA9lyF9FZYAUjxv8rfAYtlVABWNthlGFwx/JQC+F0VYno4+6UlfCWUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=Q/EeJLh5; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="Q/EeJLh5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=H2M3c/E2psp04OEJP71/aPZMCtP301eRKvl7HlHS1tQ=; b=Q/EeJL h5gXXNW4pUqGnbnQ8DJzpOIdRhGR15jG60kJnBCywek14NFPfubVSM3Phs3wOjOt zH1tx6A7LEQaTEWm8XmRQAEsaSpGsM65lg2uzpTu5aUDVrmnnqbsOqi2PFPcCyRr CJqcpsWUEgXaj2lGVzRMHwGf56VpZ3BgesjG7E1T4pvnFS8574Utor5wVkku4w4c yqXky4wgUovKTBg+yWst/CjjeBxgMi24/vBKIURoMvHLznG/UERYksUmyTYszjh6 YAGXWJ0Yp8Jo2X6SBguJHB0GbF9M05Cq+HAyjcf4yr9OGH+rPaJPHvdTPaS3QGPi ueHlHkTxV+BV9Z4w== Received: (qmail 521837 invoked from network); 10 Apr 2024 13:25:15 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:15 +0200 X-UD-Smtp-Session: l3s3148p1@5KbjSrwV6yBtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/18] i2c: sh_mobile: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:28 +0200 Message-ID: <20240410112418.6400-34-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index c65ac3d7eadc..f86c29737df1 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -688,7 +688,6 @@ static int sh_mobile_xfer(struct sh_mobile_i2c_data *pd, } if (!time_left) { - dev_err(pd->dev, "Transfer request timed out\n"); if (pd->dma_direction != DMA_NONE) sh_mobile_i2c_cleanup_dma(pd, true); From patchwork Wed Apr 10 11:24:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787728 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC3715EFAD for ; Wed, 10 Apr 2024 11:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748323; cv=none; b=Iyslh0PekatdbMMtVZdJTOCeYUawjlbLOaR06gzYPzKRjZbsou3xcF0wwcYVojK6XsIPiCVAZrZ6XYhvwIyIAtfNuqLo0xs5YRxyPZKfFlB5d2cm017FAjsacTV7fmHJzUkKnhdL4cGBDmoxgVXyWnnwIUX+hP4q/lTw6l5OuZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748323; c=relaxed/simple; bh=VbT5U8ZfhwgSJUluudK7lvicyVZ007aXNFKLal9Ih8Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Metze019kZuuGe6EyuPQItQH7dNI5pVapdNGBkHQsEmRE7hi13RooW5DINmWxrB1q4H9Mg3KPlONfsesrLqC2cUCEOZ2algvQU2lE9wqK1zvP45QldzUY60KxhR45ps1vM0z1O4Ti9S+A7j/XWrZc+106SYV3b4E2jmugCkxiF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=PKAMFF2d; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="PKAMFF2d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=X7d+g6GmFE6xmFhmuPXFDnzDcw798Dd53vujZTSLEyU=; b=PKAMFF 2dGmeXmjkFQh4VLGO9ahOzd7m3cQAUQF27XMFlDxU2MFkPjfPwebZM/2DObDBa0Z LeRpedKIml6vzuUsJGQVa35jts19EyAcml/wUVHDGxDue5BMe/AaBrTrLc5EpqwI wsXlvha5j/soHtNQ9s5+t8aBrbNQiBOw1MM5thC+WHeBXkqomwlM7UfRmCalc++Q w37nbeaKUNpocTlHK65IQOQbcZCpQ0uWSJUZyoILOgoZE5JMNKN2IeF978hvP5fH 0IcZuO9tczGuL7Aer1RI4as0VaM4cbtUwD5wrsxZsGqHK/894Df8sprTkyTxifOq q6utamIoTepr1SuA== Received: (qmail 521909 invoked from network); 10 Apr 2024 13:25:16 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:16 +0200 X-UD-Smtp-Session: l3s3148p1@oQz1SrwVMHttKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Patrice Chotard , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/18] i2c: st: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:29 +0200 Message-ID: <20240410112418.6400-35-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-st.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c index ce2333408904..dbb93394ff94 100644 --- a/drivers/i2c/busses/i2c-st.c +++ b/drivers/i2c/busses/i2c-st.c @@ -689,11 +689,8 @@ static int st_i2c_xfer_msg(struct st_i2c_dev *i2c_dev, struct i2c_msg *msg, i2c_dev->adap.timeout); ret = c->result; - if (!timeout) { - dev_err(i2c_dev->dev, "Write to slave 0x%x timed out\n", - c->addr); + if (!timeout) ret = -ETIMEDOUT; - } i2c = SSC_I2C_STOPG | SSC_I2C_REPSTRTG; st_i2c_clr_bits(i2c_dev->base + SSC_I2C, i2c); From patchwork Wed Apr 10 11:24:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788106 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5B115A4BB for ; Wed, 10 Apr 2024 11:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748324; cv=none; b=kW2NMl0WaOC3RWb8bMztZ4crk8wR8PRkJbEyID9x8Ctt934U9Ty7ICbsSFDIXUgzbtms/M0peb1z/ZrO9M3121cFszIii7wqRmFsKxz5mPI4IfZ18XM73xAyy4FksBZoV5qq97Na29ejw+6jyVt2asWjVq7huckatCHop7v76Xc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748324; c=relaxed/simple; bh=ThHy9SIXt6aBrf/B2/hW2hu4s6jDQ8sFpoOCGbGodJk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R8HXWUdEJ+cRRlm7xLrU3FhyTydq7+/UouD6PE2DDcq1pYem2ovQotqCQJ4oyUZfllS9NoJKbgd1xQG5cDLXaPUsLFsCw7EMFG80JSUCuQmvWXoEB/7NTXve1MRPfDmAjuDBu4KBZGCbeEqlylq9n0sOincsyMsdLQc51R35Wzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=Yyi/KdM7; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="Yyi/KdM7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=qnoZs139XKAMxVPkE0adXp3TqolMOAUOXJsY19exsqc=; b=Yyi/Kd M7R6vZohSpRBgAtEIafDn6GLbwBAroivxmArDdI/4FaDqogZ3WhZByxC+Tt71Kg9 RZukTV6NUMJ5oYhaM1Y7D2F8P4dajrU/IGlNwLAY2QPGpWEfnbA1VE0jCyCu4WtO He/TolKpX+kmvgrmaQuSXRic5gVCjpbybcvjePeLXzLUiDST2jH8f6fcnk33vucN j5SWaeq31MmfELL+Mb3uu1fGbv5XSen84y6O5+YdlWafPsWgZaUZFzjJUyxQeWc2 nxbFzGes9JCeUDtdHT/iyffBrqAnSDp18t3K9BBb8MakJFVMoJd6Hbf971FWA5nC LCHVGS+QNrVxW2sQ== Received: (qmail 521961 invoked from network); 10 Apr 2024 13:25:17 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:17 +0200 X-UD-Smtp-Session: l3s3148p1@PmEHS7wVv3JtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Laxman Dewangan , Dmitry Osipenko , Andi Shyti , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/18] i2c: tegra: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:30 +0200 Message-ID: <20240410112418.6400-36-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-tegra.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 920d5a8cbf4c..85b31edc558d 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1331,7 +1331,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, dmaengine_terminate_sync(i2c_dev->dma_chan); if (!time_left && !completion_done(&i2c_dev->dma_complete)) { - dev_err(i2c_dev->dev, "DMA transfer timed out\n"); tegra_i2c_init(i2c_dev); return -ETIMEDOUT; } @@ -1351,7 +1350,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, tegra_i2c_mask_irq(i2c_dev, int_mask); if (time_left == 0) { - dev_err(i2c_dev->dev, "I2C transfer timed out\n"); tegra_i2c_init(i2c_dev); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 787727 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F13D915F3EB for ; Wed, 10 Apr 2024 11:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748326; cv=none; b=XwcFerFRGctxbTlT3ida6IWArXHttGKwt9WlkQplQSDggtBTCxN3JPPTdWp/Q/KDiLTCDXvlOTSwwRM7JLfznqC6/cIrx2qG/GtWsFv5qxkh4uscJg6n3jpcDYpGKgYH6W87M5/71KEwVXJoXN5ZNroiA89RQP899/Cacw7dcRk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748326; c=relaxed/simple; bh=Ghz9+8PwzOj+sFeiknrnmVHidJRUARy2afaqvsOCeIU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QihC5X3LacEQiStDmKNwaj3X3UYlaJ653EEE2mv6ZVzy5SkJ4An+/eRHAiHXVKGdD4AXVviHeJOo3/lDjLIXAxWMu1TPel7UAmgPM8XKYgp5F31GEJT7bgY/RRPsvIO1qkoEmCnf31KsnpQoMiSEMRZ5XmHLX5Gn0acQ4GmlDFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=mDWAnLgN; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="mDWAnLgN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=gKURZrg2dPN47J/dR48oUq5R0Q8Z55DZunehHrLXhjY=; b=mDWAnL gNfGa3lR6+tkelsSUPEL/OPRCw/MYUCnsojYR12yqanKWlWbcLUtepEPKg4D7ixn Yih1ykxaPomgjuJVvSkKSmalYM8qukeKuawv+zNpbX/LkYHu2Ztz0SN3QTsEC3PJ aAjVWhjvNGxOWpb0lcSu9nA42kTRmlSxpYV4IVTtxSDDljvdNrM1up2MX23RnP4p IvFaDILeaTM03sbi5nMkBD2WFrupmGEKvXuPGFSqSYnGJVtTv61pwIdUDqRHgnsP GeTLaQmA77GN9fJ6754G4myNWE6Q9SO7fD7GdkqCbgrRRv82b0Cc7woJtkD+ZuSU zYBkqnLk3LQrCVxQ== Received: (qmail 521989 invoked from network); 10 Apr 2024 13:25:18 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:18 +0200 X-UD-Smtp-Session: l3s3148p1@YP8ZS7wVeW5tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Kunihiko Hayashi , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/18] i2c: uniphier-f: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:31 +0200 Message-ID: <20240410112418.6400-37-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-uniphier-f.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index dbc91c7c3788..6c3dac2cf568 100644 --- a/drivers/i2c/busses/i2c-uniphier-f.c +++ b/drivers/i2c/busses/i2c-uniphier-f.c @@ -358,7 +358,6 @@ static int uniphier_fi2c_master_xfer_one(struct i2c_adapter *adap, spin_unlock_irqrestore(&priv->lock, flags); if (!time_left) { - dev_err(&adap->dev, "transaction timeout.\n"); uniphier_fi2c_recover(priv); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 788105 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C072315F40A for ; Wed, 10 Apr 2024 11:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748326; cv=none; b=Hj/4KVpu9REtjWppIDAbiQaWUrDj9KVltnr3wtNYXAs1jLL4WoGghjvcZasptBmlt4Q8rej9a7b8/A/HKO7IaoSAGT40NQ+r+O2ngGp7pmqaeDy1DTx5hvTh8yj0yq0hYx1iPjmnvFr7bm6HQmPpW8Bdvs3ELa50es2rm2+WJjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748326; c=relaxed/simple; bh=ZiIjtM/8yvx4TeW2A4HFmO5GY6NQemF+7DUdEnuG66E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kWIFNLETI1+LeJ1P2z1A9wW8LMyNIXXMq/axGEIRE45PHVN2g5Pxl6VJFrLsyIXm1pjglAlv+Q2DYHCS/ogdLvJNmlqUn21swUADUirzm5oyl3ZhVkV7kDKNrG59sGN+goq/UAfX1NdKFiyrmE5/FucX0wUY06o6Fd9XYP/dDw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=IViNnxeH; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="IViNnxeH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=61Yt0QJyesrW2fxW1vjW+vSic4XhfkDmhgxF5NliaQY=; b=IViNnx eHj5O7F0ATf1ZZxzzvdVQShvxXYAouzRxRIxxXNaHE6LWqn5DqSsZEc2Zs0Q4tbY LNAG8XFS2dYtwS6Z79oh8bi3bFWPTp2k8OO41KzviQFrX4OYBsLoZkWWjdssFGb8 gXL3C/0XjyZUDsaG+77QnuyuY+OCMho73iTthf3YS9WAFiFNETFTD9IT0d7tMkPY wc/FlE4DsHk2WncjxqpAdEvpy/7k/zOd9FTdFOcIED0ZywK7pDkE81XnkqrIrw7m NSLNbw2gZfg65WUxHxWM1226ovjfS3RByq9vRwKXYAnJfmVMNwhcueb0fujWHKXG Qs2aPyepbCwSftYg== Received: (qmail 522049 invoked from network); 10 Apr 2024 13:25:20 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:20 +0200 X-UD-Smtp-Session: l3s3148p1@u+osS7wV6xNtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Kunihiko Hayashi , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/18] i2c: uniphier: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:32 +0200 Message-ID: <20240410112418.6400-38-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-uniphier.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index 854ac25b5862..e1b4c80e0285 100644 --- a/drivers/i2c/busses/i2c-uniphier.c +++ b/drivers/i2c/busses/i2c-uniphier.c @@ -71,10 +71,8 @@ static int uniphier_i2c_xfer_byte(struct i2c_adapter *adap, u32 txdata, writel(txdata, priv->membase + UNIPHIER_I2C_DTRM); time_left = wait_for_completion_timeout(&priv->comp, adap->timeout); - if (unlikely(!time_left)) { - dev_err(&adap->dev, "transaction timeout\n"); + if (unlikely(!time_left)) return -ETIMEDOUT; - } rxdata = readl(priv->membase + UNIPHIER_I2C_DREC); if (rxdatap)