From patchwork Sun Oct 6 17:21:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 175287 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp3297917ill; Sun, 6 Oct 2019 10:30:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvEhBcEVcOoXJfNN+0ctEnScX6G87sw6nDxni1NFmsxAhi4l18CPJFaDMVRxWCbQjocUKL X-Received: by 2002:a17:906:2f10:: with SMTP id v16mr20262706eji.247.1570383028111; Sun, 06 Oct 2019 10:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570383028; cv=none; d=google.com; s=arc-20160816; b=v8eSZUre5pcJo4+Eq9r70Pyd9t1WsXyQK2crb3QANaKkprK2Uiyh9NN3a76AMTiWRt hmzb2vDYky/VzeymCgsC5GCbh6JNSRb1d3ItmX3szwIUS+DHerlCqUCv7iWjLQb2kpbo aZph2v6UORQpdlwhftBcogDlVsUg0TqUAd/9mlg88lW8uhodE6eVkeMqJhiveqFdEXRu sl09PslVUo2niJU+3D7e+jPhX+eF1iuj0Zb9AJq8VcMJ4dk/ZvSPw6t8t83Ukl9vOmT0 NPT0MDZhyLJlb79wk4zYiBs6L09kRm9k3CloZT3zjNbtbZ6fpDurjKvsZtBFryudWUrg T+dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kjfhxqC/dT0l6TqRCFJyDtDMrACA8UIZnr/wjEwhfpo=; b=Rbv8g6Z6/5ZoEvm4oa5+BlqPX17pLdQTp7jQIzRCCEliCv1F8G+oxd66sxg94lbHWt 03dxMMd2jjlUFTW4K3h8VEOzgXe19d53FILlAF4YJciDt3JzHRZoW0HyIxxgezWs/pvL PIh/yfTMpNE1HWO6lPhMO1J5pD52p9t2PacazVKFMfgTffabMnC8mRzthvOqGfwm0toM SmBBNJtMPylnWpbfEy1qwkY1ZzjX9L3HRFYTQZgHyFHFSswcob91Qb1hchvByN/XYEkV lBGIK+VaCq32jcwC/iwWCK8Pa//kxewPR1N6bGui0cnFIURsMKjKScMCAVVgo0Y6yWkv xtyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LRZjk+72; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si6595664edr.446.2019.10.06.10.30.27; Sun, 06 Oct 2019 10:30:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LRZjk+72; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729233AbfJFRa0 (ORCPT + 27 others); Sun, 6 Oct 2019 13:30:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:56262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729216AbfJFRaW (ORCPT ); Sun, 6 Oct 2019 13:30:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DB092133F; Sun, 6 Oct 2019 17:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383022; bh=hfNg8Nm40zRI8TDF/Icp+MSffb6Vg+BWyaWKFeR4cw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LRZjk+728IAntQ3/DJQxRUoWlzEafzlLf4ERhTICJUy0wZVMIc9ipb3CppTMF2VXG X02GnqX9Y4TQEAXOzVAdBygDc4sh3rj6s7FA/3+HYePTdJlNFswJ90z0HRIEDz97Qj dGf/56050kvO3k1f+402S068F37B/alv8WcH9YGo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Nick Desaulniers , Linus Walleij , Russell King , Sasha Levin Subject: [PATCH 4.19 057/106] ARM: 8875/1: Kconfig: default to AEABI w/ Clang Date: Sun, 6 Oct 2019 19:21:03 +0200 Message-Id: <20191006171147.869327445@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171124.641144086@linuxfoundation.org> References: <20191006171124.641144086@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Desaulniers [ Upstream commit a05b9608456e0d4464c6f7ca8572324ace57a3f4 ] Clang produces references to __aeabi_uidivmod and __aeabi_idivmod for arm-linux-gnueabi and arm-linux-gnueabihf targets incorrectly when AEABI is not selected (such as when OABI_COMPAT is selected). While this means that OABI userspaces wont be able to upgraded to kernels built with Clang, it means that boards that don't enable AEABI like s3c2410_defconfig will stop failing to link in KernelCI when built with Clang. Link: https://github.com/ClangBuiltLinux/linux/issues/482 Link: https://groups.google.com/forum/#!msg/clang-built-linux/yydsAAux5hk/GxjqJSW-AQAJ Suggested-by: Arnd Bergmann Signed-off-by: Nick Desaulniers Reviewed-by: Arnd Bergmann Reviewed-by: Linus Walleij Signed-off-by: Russell King Signed-off-by: Sasha Levin --- arch/arm/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.20.1 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 51794c7fa6d5b..185e552f14610 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1586,8 +1586,9 @@ config ARM_PATCH_IDIV code to do integer division. config AEABI - bool "Use the ARM EABI to compile the kernel" if !CPU_V7 && !CPU_V7M && !CPU_V6 && !CPU_V6K - default CPU_V7 || CPU_V7M || CPU_V6 || CPU_V6K + bool "Use the ARM EABI to compile the kernel" if !CPU_V7 && \ + !CPU_V7M && !CPU_V6 && !CPU_V6K && !CC_IS_CLANG + default CPU_V7 || CPU_V7M || CPU_V6 || CPU_V6K || CC_IS_CLANG help This option allows for the kernel to be compiled using the latest ARM ABI (aka EABI). This is only useful if you are using a user From patchwork Sun Oct 6 17:21:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 175289 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp3299318ill; Sun, 6 Oct 2019 10:32:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRzEa0kx9MNptB+KdWsJh6ZGFq/oZfwtKGCpP6HXK5aNdq0F6FF3bxexKqJyVmyfd/ey0y X-Received: by 2002:a50:f703:: with SMTP id g3mr25329521edn.43.1570383123860; Sun, 06 Oct 2019 10:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570383123; cv=none; d=google.com; s=arc-20160816; b=ZFSjZwR8cLTw31/Bpz8f/SykyjX8/t75BWhFaxl8VO861hwOn+3VztBHLX2eQ1/V1l 4eWqKKj9uhM8Pxr7AWYr8cR/4+Sl+0xJIy1cMfAR4ikcD3+dilXPdsP1Qx66UBvGX5M5 28/y8nDfder5Dr/0Q0/6gz8d5Z68HqAlRcnbXxr6EojUVXkvlXbNVD/L17tgH9BmdPm+ /OOpFGb6J9DHikyaWKQPLOaOuHJdOYmJVM7xzb+UPiNP9c+RKEGKifEJybm8PSwCeLCZ 1HzJyDV+VI//Ddv6fs9BoWNw3nr6N29e3o/C/VH+YBjYH1guk1hxnUr1HIhtYMA12kXe IY9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0X4PyE+/A0pzc0nrYoqO3ss0n4+zHg2FYbq6rwTnoCY=; b=Q8ETkh3LZ07oFHDjLZM/wVc5uXooWDD2x1gNVDpLsw3GN2SRcf1rilLdM1VGfRh2yI cleGF/4AlevVpw7JBJKRe2jP9Yy3Dm9CNRMMG/3fK/4OwimOch1prmNF0/Nm5gKI9ZJl P1ZSKL12U/s5v01r+HCIyt29dYYzpvQGWV7grwQ5oRz1WKLzpc/+cTfg4qQ4O9AgGkDK mR/DGKexVAWtm+PKj35RucWlEG4ZuabPcXTkIAOEV8LKgTa3ZItRWo6yKqXtZCjmP/9R r4R3k78/el1F35yGmaAu8/OUHbN40Ok7t/y8qfx97ox9Q1KoxEbzLIspPra/82WqwcKn rcwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rSsbawUN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci22si5881803ejb.162.2019.10.06.10.32.03; Sun, 06 Oct 2019 10:32:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rSsbawUN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729088AbfJFRcC (ORCPT + 27 others); Sun, 6 Oct 2019 13:32:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:58350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729060AbfJFRb7 (ORCPT ); Sun, 6 Oct 2019 13:31:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A7EB02080F; Sun, 6 Oct 2019 17:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383119; bh=qbJambDLBU2iCC1IS1jCXXoXh7F8TMycRq4h3giH+D8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rSsbawUNn75B0DOQpHEks7oYh2Vd27Ad+TYoe0Q8Ei0Z2QGaRjJkOypiZVzc1UXsf flvXsZXE+t8bwqvP0oddjI+WaliWYNN1vgJcYeHsIz+1oY8T7FApIfWlXEPG2XHUYh RW/TA/kmb8TtPXJC9tlrWli/57lwJeMFh7GAfTsc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Walleij , "David S. Miller" Subject: [PATCH 4.19 094/106] net: dsa: rtl8366: Check VLAN ID and not ports Date: Sun, 6 Oct 2019 19:21:40 +0200 Message-Id: <20191006171201.248363083@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171124.641144086@linuxfoundation.org> References: <20191006171124.641144086@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit e8521e53cca584ddf8ec4584d3c550a6c65f88c4 ] There has been some confusion between the port number and the VLAN ID in this driver. What we need to check for validity is the VLAN ID, nothing else. The current confusion came from assigning a few default VLANs for default routing and we need to rewrite that properly. Instead of checking if the port number is a valid VLAN ID, check the actual VLAN IDs passed in to the callback one by one as expected. Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") Signed-off-by: Linus Walleij Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/dsa/rtl8366.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/drivers/net/dsa/rtl8366.c +++ b/drivers/net/dsa/rtl8366.c @@ -339,10 +339,12 @@ int rtl8366_vlan_prepare(struct dsa_swit const struct switchdev_obj_port_vlan *vlan) { struct realtek_smi *smi = ds->priv; + u16 vid; int ret; - if (!smi->ops->is_vlan_valid(smi, port)) - return -EINVAL; + for (vid = vlan->vid_begin; vid < vlan->vid_end; vid++) + if (!smi->ops->is_vlan_valid(smi, vid)) + return -EINVAL; dev_info(smi->dev, "prepare VLANs %04x..%04x\n", vlan->vid_begin, vlan->vid_end); @@ -370,8 +372,9 @@ void rtl8366_vlan_add(struct dsa_switch u16 vid; int ret; - if (!smi->ops->is_vlan_valid(smi, port)) - return; + for (vid = vlan->vid_begin; vid < vlan->vid_end; vid++) + if (!smi->ops->is_vlan_valid(smi, vid)) + return; dev_info(smi->dev, "add VLAN on port %d, %s, %s\n", port,