From patchwork Mon Mar 11 13:33:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 779415 Delivered-To: patch@linaro.org Received: by 2002:a5d:604e:0:b0:33e:7753:30bd with SMTP id j14csp1531505wrt; Mon, 11 Mar 2024 06:33:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU0FHQs1TVQwXAPyLu75KgLh9HZ+Xapdo3+i7u9WQ9hT83Q78ludSenziJDxowSMBcWBhhkG3OAEyA7ZRB3ZieL X-Google-Smtp-Source: AGHT+IHVKeLKh7HlLUx5zvtwhAVzqU0gE0zhxmmm7YtVqOmXUUzqLbblBrHXuBh8CjzSRlb2k6by X-Received: by 2002:a05:6358:599b:b0:17e:7c4b:bb56 with SMTP id c27-20020a056358599b00b0017e7c4bbb56mr1869083rwf.15.1710164036448; Mon, 11 Mar 2024 06:33:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710164036; cv=none; d=google.com; s=arc-20160816; b=vvViVRq9PG1cr9mEk0WflGDHlEn4esSbSzGxmPhFEFDC0mqbN00pxK29otUPNNI/Ar t989+mYAruntDBWxND46l0qD46B4LF/odG+Q8XvXC7AaLAr0dqT2Iv6YgIlEXMl5sRlI YryuDdk9wDrYpw6ujTIK4qKqyCzXQFAgwSqaxWksyQoBSVUwSRWuDOiV7EeOMmm8469X d3KBkOPsKG6Q0EsdVQivNpDF71qYSkxtnvWc5GhBW9FudCZIy7NmxGRgB2sd/TexBLM/ tV8kGACoxMVy/tJS2HDcTViuHAkpmzcEs8Tn46qDLN4WdUJfRpnh+FptdJq/0+VKvb2/ R4gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=oGT9eNu0PxBnJlxZhPsk46LUsox3J4QaHKuu+0usPQ0=; fh=911GO4DHcASSPTqaf3kyMBMxcLODsD15dWgsmO0YtVk=; b=HteJxQSkoGcgMEfm9ND6yb/vglbOIw5kcN9XGYSOWlsek6xiCgHh5t9AUyPl6N19S2 cM0clO/TLWR3jpV8nUGWmiLrJ3kkQP8lX5Ud0PF9WBUG5z3mMjpCmeQ2zPB7TUU6fms0 sWRZYtaZG2yOoZrt1BCwPRwQL+hBCzwXJK3IDQx+tuD55QOsjioOpvSLbOAiXB6Sx5c4 Z4iphf0LVNsDOxTZwBVkHLsGQC9cbsMlKQfG02JjYZGK55T7TktbhOIEylGFf2m9X+Im 3zjQ+g20nMGJuGuvxAdgQBtFKMf0PsRJ4EABji7wTf1luGk/Lg9w6OwbyC8NiWoTdtEU saVQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AwNkE3HF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o16-20020ac85a50000000b0042f4e38dc65si719714qta.241.2024.03.11.06.33.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Mar 2024 06:33:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AwNkE3HF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjfmf-0000Em-GD; Mon, 11 Mar 2024 09:33:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjfmd-0000EN-Pr for qemu-devel@nongnu.org; Mon, 11 Mar 2024 09:33:39 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjfmc-0006tB-3C for qemu-devel@nongnu.org; Mon, 11 Mar 2024 09:33:39 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-33e76d653b5so3002714f8f.3 for ; Mon, 11 Mar 2024 06:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710164016; x=1710768816; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oGT9eNu0PxBnJlxZhPsk46LUsox3J4QaHKuu+0usPQ0=; b=AwNkE3HFPICaLYkN8mWp7DT6siL/juX9HVnv8TuAxBpqScXLNPLktwzp0ecndwaaVL Cw1VaAdJKsWok89HBD4oUUZxfLmWfw21HbDt8qH3avPoR4Zs62ajXkcqWvpu2JSpGg7i Dny+wrZ8ncJc8igCAgbTCBCgcvbrc1wcTV5V/qQIUwWgV7KKetNy9LL3DnwHvK9ClNr7 5vRz0aG/ohUGc3wuLEAysJEHRhrfL3gA2BMMLiN26MfOXq5BpaW8SS5IXlbLDHLWCMNJ ec/TV1yGtfjy9ga+/0m0RydRdgs4Hzk76i4hz5hnaDDcqy79oG1wskan+CysvpvrARfQ Eayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710164016; x=1710768816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oGT9eNu0PxBnJlxZhPsk46LUsox3J4QaHKuu+0usPQ0=; b=eTIwBDHggTsO219sXTl3kQGyS1ULb5IHmYRWgr85V6+eEaxSx1L04lAIg/ESnkXPPz 1iWvnYujk02cqNxf7FvDmL0+c7S6/ZRLsWpkoENJiEWnHTT24erOJvNV1zkVrxyvZqjU RlH07ys1H3t/YuSDc3Jinx0lmVkJyrOUPo2VzwS9YDqDsB+3PB6hyB1ww8+nkyVsJVF8 tz/3Xblfy6uf7Pt9aH7y6Zx8Vh09MPr4EIPFoV6JMny1gZqft4Yj4twNtPn6GF2QXWg6 ZiW5CC5T3Lmksdg0ishWKma5bqdl2eEgMvzViMOl+IQ2KxyEso6CGpxpFeSTTj8FpBcd bJ0A== X-Gm-Message-State: AOJu0YzbBz9fy8v51R2KvbqO4O+gQv1ETzA3PbdlnH+2sFeR9+NBx85q THd5PAA59KaRdirqJ3UOoAZVFP3MW+hLOAsTTQW2l2ZY6WW5xTwcGd+8JE/rvbiYJnqyotwfDDn C X-Received: by 2002:a05:6000:2ca:b0:33d:6fd8:90d3 with SMTP id o10-20020a05600002ca00b0033d6fd890d3mr6315944wry.4.1710164016277; Mon, 11 Mar 2024 06:33:36 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id w3-20020a5d6083000000b0033e75e5f280sm6459007wrt.113.2024.03.11.06.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 06:33:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PATCH] meson.build: Always require an objc compiler on macos hosts Date: Mon, 11 Mar 2024 13:33:34 +0000 Message-Id: <20240311133334.3991537-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We currently only insist that an ObjectiveC compiler is present on macos hosts if we're building the Cocoa UI. However, since then we've added some other parts of QEMU which are also written in ObjC: the coreaudio audio backend, and the vmnet net backend. This means that if you try to configure QEMU on macos with --disable-cocoa the build will fail: ../meson.build:3741:13: ERROR: No host machine compiler for 'audio/coreaudio.m' Since in practice any macos host will have an ObjC compiler available, rather than trying to gate the compiler detection on an increasingly complicated list of every bit of QEMU that uses ObjC, just require it unconditionally on macos hosts. Resolves https://gitlab.com/qemu-project/qemu/-/issues/2138 Signed-off-by: Peter Maydell Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- Per the commit message, in theory we could allow a no-objc build and disable coreaudio, vmnet, etc. But I didn't really see a reason why that would be useful, and it's bound to keep breaking unless we actively defend it in CI. So I preferred to simply require ObjC on macos. meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index f9dbe7634e5..e3fab8ce9ff 100644 --- a/meson.build +++ b/meson.build @@ -66,7 +66,7 @@ if host_os == 'windows' and add_languages('cpp', required: false, native: false) cxx = meson.get_compiler('cpp') endif if host_os == 'darwin' and \ - add_languages('objc', required: get_option('cocoa'), native: false) + add_languages('objc', required: true, native: false) all_languages += ['objc'] objc = meson.get_compiler('objc') endif