From patchwork Fri Mar 1 01:42:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 777864 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EFEC2C68F for ; Fri, 1 Mar 2024 01:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257335; cv=none; b=kBiEBlFwij9GlUE6LJhq5uAjZLyBxMehU2vPXCnSq3zJXsR3J0ogIYu/4PVyKTenH1vzgH/ahoUbzlHPzsi09Jkl3ZkqDApscTfTotsNPyCMw9X/9H/Bw34giqKIw6wG0pOAypIwjFKoZFJBgKsCAYIltHiaZv3+IMNF4wBuhfU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257335; c=relaxed/simple; bh=RNUeX2QswcUV/QEhcNBHWEj8Ccpf3D8EvbFjfCOMyUE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LkFqs1YdniW99m4J1LqKGZRxU0hlmHtoOTki1gb2qpdSkHuuTGk7mqr3nqnsydpXZK8+A0YcktYSNF1b+hEMeCZ70rb4Jz8SoZSM0T40Ypw/CmHu6wFMYNLT8Nl2ih+sLjINaCfAIx6m11ED6D+6UK6ld4Ap9oQ/5TmU0hjBo+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=k0PcmdhK; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="k0PcmdhK" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 443812C04EC; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1709257330; bh=zWXVDcjqgm2q5KyAz8sgdgp4FZWDT7x0PrMhgI7cPiA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k0PcmdhKPs/9cboPxvtOFHvfUzIdthQ9LqF/xKRmwRptHtx1TXLLCoLkigNAgDiKb Jz6oO3xqsK3KjBwMVSkBAQ2ilskb3UOQGAhxgONBWXp0k93Xk8WRkK7jR+JKIP7AXB 4tlS8EfHc6c1QEV8IVn51LZBc3dpmKnVeAtvLYmNtOhih1i6fRNoCOaMzUwMogrbXz u6Kcd+PdjmxOdhIt7r0KlZeLS83ArER3WWb8TynYH9sJAfa1CK22vDqE185b1dpmPf U6Erg24lamFtAu0vBFFUU6cDy00pXcomrGy9mnH8R4fCbvzR2aHgMVq+upr+BkQTWI yhmDWbwFyZHTQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Fri, 01 Mar 2024 14:42:10 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 0BCCA13EE4F; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 07A38280062; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) From: Chris Packham To: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: [PATCH v3 1/4] auxdisplay: Add 7-segment LED display driver Date: Fri, 1 Mar 2024 14:42:00 +1300 Message-ID: <20240301014203.2033844-2-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> References: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.4 cv=BKkQr0QG c=1 sm=1 tr=0 ts=65e13272 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=K6JAEmCyrfEA:10 a=F0jKMMnsshfnaHI64i4A:9 a=3ZKOabzyN94A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Add a driver for a 7-segment LED display. At the moment only one character is supported but it should be possible to expand this to support more characters and/or 14-segment displays in the future. Signed-off-by: Chris Packham --- Notes: Changes in v3: - "7 segment" -> "7-Segment" in Kconfig help text - Update after feedback from Andy - Use compatible = "gpio-7-segment" as suggested by Rob Changes in v2: - Rebased on top of auxdisplay/for-next dropping unnecessary code for 7 segment maps. - Update for new linedisp_register() API - Include headers based on actual usage - Allow building as module - Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy drivers/auxdisplay/Kconfig | 10 +++ drivers/auxdisplay/Makefile | 1 + drivers/auxdisplay/seg-led-gpio.c | 122 ++++++++++++++++++++++++++++++ 3 files changed, 133 insertions(+) create mode 100644 drivers/auxdisplay/seg-led-gpio.c diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index d4be0a3695ce..898ecfb34ed7 100644 --- a/drivers/auxdisplay/Kconfig +++ b/drivers/auxdisplay/Kconfig @@ -211,6 +211,16 @@ config ARM_CHARLCD line and the Linux version on the second line, but that's still useful. +config SEG_LED_GPIO + tristate "Generic 7-segment LED display" + select LINEDISP + help + This driver supports a generic 7-segment LED display made up + of GPIO pins connected to the individual segments. + + This driver can also be built as a module. If so, the module + will be called seg-led-gpio. + menuconfig PARPORT_PANEL tristate "Parallel port LCD/Keypad Panel support" depends on PARPORT diff --git a/drivers/auxdisplay/Makefile b/drivers/auxdisplay/Makefile index a725010ca651..4a8ea41b0550 100644 --- a/drivers/auxdisplay/Makefile +++ b/drivers/auxdisplay/Makefile @@ -15,3 +15,4 @@ obj-$(CONFIG_PARPORT_PANEL) += panel.o obj-$(CONFIG_LCD2S) += lcd2s.o obj-$(CONFIG_LINEDISP) += line-display.o obj-$(CONFIG_MAX6959) += max6959.o +obj-$(CONFIG_SEG_LED_GPIO) += seg-led-gpio.o diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c new file mode 100644 index 000000000000..01aad84d0c82 --- /dev/null +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -0,0 +1,122 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Driver for a 7 segment LED display + * + * The GPIOs are wired to the 7 segments in a clockwise fashion starting from + * the top. + * + * -a- + * | | + * f b + * | | + * -g- + * | | + * e c + * | | + * -d- + * + * The decimal point LED present on some devices is currently not + * supported. + * + * Copyright (C) Allied Telesis Labs + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "line-display.h" + +struct seg_led_priv { + struct linedisp linedisp; + struct delayed_work work; + struct gpio_descs *segment_gpios; +}; + +static void seg_led_update(struct work_struct *work) +{ + struct seg_led_priv *priv = container_of(work, struct seg_led_priv, work.work); + struct linedisp *linedisp = &priv->linedisp; + struct linedisp_map *map = linedisp->map; + DECLARE_BITMAP(values, 8); + + bitmap_zero(values, 8); + bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); + + gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, + priv->segment_gpios->info, values); +} + +static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) +{ + struct seg_led_priv *priv = container_of(linedisp, struct seg_led_priv, linedisp); + + INIT_DELAYED_WORK(&priv->work, seg_led_update); + return LINEDISP_MAP_SEG7; +} + +static void seg_led_linedisp_update(struct linedisp *linedisp) +{ + struct seg_led_priv *priv = container_of(linedisp, struct seg_led_priv, linedisp); + + schedule_delayed_work(&priv->work, 0); +} + +static const struct linedisp_ops seg_led_linedisp_ops = { + .get_map_type = seg_led_linedisp_get_map_type, + .update = seg_led_linedisp_update, +}; + +static int seg_led_probe(struct platform_device *pdev) +{ + struct seg_led_priv *priv; + struct device *dev = &pdev->dev; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + priv->segment_gpios = devm_gpiod_get_array(dev, "segment", GPIOD_OUT_LOW); + if (IS_ERR(priv->segment_gpios)) + return PTR_ERR(priv->segment_gpios); + + return linedisp_register(&priv->linedisp, dev, 1, &seg_led_linedisp_ops); +} + +static int seg_led_remove(struct platform_device *pdev) +{ + struct seg_led_priv *priv = platform_get_drvdata(pdev); + + cancel_delayed_work_sync(&priv->work); + linedisp_unregister(&priv->linedisp); + + return 0; +} + +static const struct of_device_id seg_led_of_match[] = { + { .compatible = "gpio-7-segment"}, + {} +}; +MODULE_DEVICE_TABLE(of, seg_led_of_match); + +static struct platform_driver seg_led_driver = { + .probe = seg_led_probe, + .remove = seg_led_remove, + .driver = { + .name = "seg-led-gpio", + .of_match_table = seg_led_of_match, + }, +}; +module_platform_driver(seg_led_driver); + +MODULE_AUTHOR("Chris Packham "); +MODULE_DESCRIPTION("7 segment LED driver"); +MODULE_LICENSE("GPL"); From patchwork Fri Mar 1 01:42:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 777863 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F1632E3FE for ; Fri, 1 Mar 2024 01:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257336; cv=none; b=eV425iuUB9naFQMgy0aEFi/XKk2+8kywbkPhQoFX9H3F2n5o7YxOkl+W3eLr6sPWTM6aCb8IqOuAnEA124ZeyKq7+lcCU7mExj31Cz7GLhdvoCR1pLFTuhj+AvDFWRBB0zEQvNiEjKKRW3VgPKWMZPhDto/Gu1f+hkyC/McHpN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257336; c=relaxed/simple; bh=+K2NA3pCkHMP4WVGu6nTDubCMHmDN2IFGsQxB8tXWZM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pUsSpnIzJNDI8PhMqaSByjwToj3DGpBAQ+UGOLwO8dosYsNvddfHKW0vMjIbkF2a4LsVtpmyNufnlOOJer5oSyhNP7qP1KvT5XjdVdqnhNKySDcH1bFWpK2MGivIAo631YJf5PMBGsg5p/HuMW4YHB4xPxzw92p2jBjp94Crv/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=G/Zkkep3; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="G/Zkkep3" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 6D5AB2C061F; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1709257330; bh=JW2bMplHMgFkl36aF3i5UY7E0A+/8mHR15PnOH9d9ek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G/Zkkep3XzfHlKmKvzBs6P9Yso6NjjSoJyj4FDMCLIw2WrK1p84ThJ+x4YziJ6zfM g/Duod0tr8tQYMojeUoR20WJ9r6+oJUyHOoQiawlwhovRLKU9nfck2K9L1mTU9PGTU flvSc7eaIwXTubOTTm1NSSB7TxJM0YwxyrIEbKUq3Z3B+1q8G7yeHwMZNfGO7m4jI3 4WiZEzv9QTq1Zje47UeN7KeZl2nkIfp3SnoqZZJAl6KWPDX8LN4d8g4TayZ/cWxROa jBsNN/yovkU0WI3e6jE+eMGayXFM3xsB0HDihJC0lbicAUhmGpWsROCu/eKn5J5BMB axCHyyvsnC6eQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Fri, 01 Mar 2024 14:42:10 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 12B8313EDA8; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 0FBE8280062; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) From: Chris Packham To: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: [PATCH v3 2/4] dt-bindings: auxdisplay: Add bindings for generic 7-segment LED Date: Fri, 1 Mar 2024 14:42:01 +1300 Message-ID: <20240301014203.2033844-3-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> References: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.4 cv=BKkQr0QG c=1 sm=1 tr=0 ts=65e13272 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=K6JAEmCyrfEA:10 a=gEfo2CItAAAA:8 a=UL8_YvhhsuCliVb0JXoA:9 a=3ZKOabzyN94A:10 a=sptkURWiP4Gy88Gu7hUp:22 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Add bindings for a generic 7-segment LED display using GPIOs. Signed-off-by: Chris Packham --- Notes: Changes in v3: - Set maxItems: 7 - Expand description of segment-gpios property. - Use compatible = "gpio-7-segment" as suggested by Rob Changes in v2: - Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy .../bindings/auxdisplay/gpio-7-segment.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml diff --git a/Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml b/Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml new file mode 100644 index 000000000000..76af4bf4e9a6 --- /dev/null +++ b/Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/auxdisplay/gpio-7-segment.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO based LED segment display + +maintainers: + - Chris Packham + +properties: + compatible: + const: gpio-7-segment + + segment-gpios: + description: + An array of GPIOs one per segment. The first GPIO corresponds to the A + segment the last GPIO corresponds to the G segment. + minItems: 7 + maxItems: 7 + +required: + - segment-gpios + +additionalProperties: false + +examples: + - | + + #include + + led-7seg { + compatible = "gpio-7-segment"; + segment-gpios = <&gpio 0 GPIO_ACTIVE_LOW + &gpio 1 GPIO_ACTIVE_LOW + &gpio 2 GPIO_ACTIVE_LOW + &gpio 3 GPIO_ACTIVE_LOW + &gpio 4 GPIO_ACTIVE_LOW + &gpio 5 GPIO_ACTIVE_LOW + &gpio 6 GPIO_ACTIVE_LOW>; + }; From patchwork Fri Mar 1 01:42:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 777266 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F35D2EB0E for ; Fri, 1 Mar 2024 01:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257334; cv=none; b=F+e4iWXZL0e/UKGb3H+P9md3UGCT1XQ8m9dnqvDorr2fVISBsh7T2bLT1A8+6W9t+UisrJVz+efLMfh/SbyVXp5tV4wjxIW/R48DYMjBh7JEfdJiZbmoYqohnv4dF73kr/WgJ+k2Lqhy76XmkIywpCnq1ZqNDzpafPM9pdiCCrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257334; c=relaxed/simple; bh=mqJ/h7AKCJjaQlaxgMWt2R0Pal/NayZ3fO20oRdoXeU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nsvrumeSnyCXE6THz5UsUqmxKsAAhOQnnZhdl1hvLtWTYr82XTjhCbv3ZZW7RXUktXGvnTIS9WkbnkitFl5l6LlHt1FS0X20qgXrceHXRe7TU81s9vSVGSsfoipBc2+QdLJliGwmeuXdjxddVm49bjbh4ISNNoy5yvSamC1Bmew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=l67SaZlz; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="l67SaZlz" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 4DC852C05E7; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1709257330; bh=2OH3OgCTooM4dlx8pTy20vLATdgGUykmG4vimpbjzRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l67SaZlzE/pE9H68zgUNjYcx621jCphPo5OKM+07TZ4S8tEhsanBfIVODaMgfdTom DCdFRTr0RGMvz4XgP8I7x38fHpSPgYsra51iFAneZSgFCkVWwpR5vmw4hrQ00hOw+g IWVcf8RM3Z/vqCP5KRP90ax2xvhhLFkDSKc6BgG6p85GpIXjdJSlbwFCgAtAFQ49PO 7QQJgb9Y17CEtx+VQSEh3pmWatc5EhBK/WeTafgpmYMpJJe0tCx3d+/G4fXLmRAL3/ uaSKytU1i0VghXyRUEnJBGe32kHprkMRnI6tn8T8OodRlaGSVZ/TuPMjYUWnW+Umnq uzoBUhZxlR+rQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Fri, 01 Mar 2024 14:42:10 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 1974113EE4F; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 16C3D280062; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) From: Chris Packham To: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: [PATCH v3 3/4] ARM: dts: marvell: Add 7-segment LED display on x530 Date: Fri, 1 Mar 2024 14:42:02 +1300 Message-ID: <20240301014203.2033844-4-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> References: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.4 cv=BKkQr0QG c=1 sm=1 tr=0 ts=65e13272 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=K6JAEmCyrfEA:10 a=ZwCSNx74X_mE_I29kl4A:9 a=3ZKOabzyN94A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat The Allied Telesis x530 products have a 7-segment LED display which is used for node identification when the devices are stacked. Represent this as a generic-gpio-7seg device. Signed-off-by: Chris Packham --- Notes: Changes in v3: - Use compatible = "gpio-7-segment" as suggested by Rob Changes in v2: - Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts index 5a9ab8410b7b..60c2abf572b6 100644 --- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts +++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts @@ -43,6 +43,17 @@ uart0: serial@12000 { }; }; }; + + led-7seg { + compatible = "gpio-7-segment"; + segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW + &led_7seg_gpio 1 GPIO_ACTIVE_LOW + &led_7seg_gpio 2 GPIO_ACTIVE_LOW + &led_7seg_gpio 3 GPIO_ACTIVE_LOW + &led_7seg_gpio 4 GPIO_ACTIVE_LOW + &led_7seg_gpio 5 GPIO_ACTIVE_LOW + &led_7seg_gpio 6 GPIO_ACTIVE_LOW>; + }; }; &pciec { @@ -149,7 +160,7 @@ i2c@3 { #size-cells = <0>; reg = <3>; - gpio@20 { + led_7seg_gpio: gpio@20 { compatible = "nxp,pca9554"; gpio-controller; #gpio-cells = <2>; From patchwork Fri Mar 1 01:42:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 777264 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F09E2CCA4 for ; Fri, 1 Mar 2024 01:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.36.163.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257336; cv=none; b=FyiKNpnj8fGWI0LKJ0+ZF62AXD6CWIz/PuoAxT50poD4puv1sTxenYYZljab5HogY53kdQdA7O2sNTA0x1I3JzevuwWc4ANKbeJ4XzYkKaSr4MlLAyBKmgC8T5KvlishZAuN9oeJKzlysBGStR7ke1P9qlt27iLkF81EXm9Efis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709257336; c=relaxed/simple; bh=T3tc55CjSPYJyIAovpoXkdcFIV0zyYFo6IMzOwHWL8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uem42vLF0apPMII9Q+jAVV4X3+7IuPuBrE17tOK+YTHytjKinxCX4hpKfBHbXOwmOLZV0Sjgvs4J6sqzhWo9k/BeVsatnbHD+KoDyuyanRMlDDw6ILQMb8erPX9szlfDzH0Lyx4Uukk1sMPmJFQv6J4bdXTQtgTZ3rxP4qDP7xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz; spf=pass smtp.mailfrom=alliedtelesis.co.nz; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b=2wusa/eb; arc=none smtp.client-ip=202.36.163.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alliedtelesis.co.nz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="2wusa/eb" Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 798782C072D; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1709257330; bh=vRjZk3VBvyhAZ+OC2mXTW8QEEJfhOQc/xglfRGmeFco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2wusa/ebssKuW+lliQHpTr0usxdeNBmkOeXeHg6sBrG/Ub7VZA1ZnvUE4xjTrUrT6 S2Qg4HDcbvM+z74ERWKjjC19KtKOHCb6CnmIMuk4RGlWHKpp1XuszHnWNhas0I9Y+8 gIV30TOToLZDXNo2cM+l0PGirEoQ8QarHGIbbFC73EAK/iRktN4PbWYNa1w1Nrj+fo VG5Zg5XpSGATbsX9UkOTIOkZqc6g3CI1t+igS4x6T8y9TX3IjjQHluulnoTiZrY/3f 2tbDos/CgdmuPXPVayOA/JgBYNsvEFgTQN1kSgW3z3VFlObrIV3/Eh5fvnl0MdZiBa /GtZvHJjNW2bQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Fri, 01 Mar 2024 14:42:10 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 1D5D113EE85; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 18EC72807C4; Fri, 1 Mar 2024 14:42:10 +1300 (NZDT) From: Chris Packham To: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: [PATCH v3 4/4] ARM: dts: marvell: Indicate USB activity on x530 Date: Fri, 1 Mar 2024 14:42:03 +1300 Message-ID: <20240301014203.2033844-5-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> References: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.4 cv=BKkQr0QG c=1 sm=1 tr=0 ts=65e13272 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=K6JAEmCyrfEA:10 a=syfxfRYH0sAgbFgdTt0A:9 a=3ZKOabzyN94A:10 a=zZCYzV9kfG8A:10 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Use the dot on the 7-segment LED block to indicate USB access on the x530. Signed-off-by: Chris Packham --- Notes: Changes in v3: - None Changes in v2: - New arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts index 60c2abf572b6..a53dd17d11b4 100644 --- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts +++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts @@ -54,6 +54,15 @@ &led_7seg_gpio 4 GPIO_ACTIVE_LOW &led_7seg_gpio 5 GPIO_ACTIVE_LOW &led_7seg_gpio 6 GPIO_ACTIVE_LOW>; }; + + leds { + compatible = "gpio-leds"; + led-0 { + label = "usb"; + gpios = <&led_7seg_gpio 7 GPIO_ACTIVE_LOW>; + linux,default-trigger = "usb-host"; + }; + }; }; &pciec {