From patchwork Wed Feb 21 06:20:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 774593 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A342C38F9B for ; Wed, 21 Feb 2024 06:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708496426; cv=none; b=Sm3t3/ezU5orT3/p8CF88kPV+BRwrni1cD0WU9yvrCRwRrUB6TxMphgyffkY28ra2PMvz5/reJva4x+Y4MCjxUre8xHsje9asv9ctZLIrdljO3lUiC/hRgL2SdVM2NuwekOa7Gdxif5ElDiuql16i6smkQ9BQ917vV2o1SYEGyg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708496426; c=relaxed/simple; bh=Aa84HSv1+2OvUetKNGlbuxpski5nWr6VCsHSEhRtETY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DL3rf3Z7Ec/O+X6nMRGPVj8PTHOxEj0FYBFfudXNbMRTUFvMNqqdml80nIRKfv5CFCN5jy5MtwIbQPd/Xh1VeUt78Qqeq6W0rMZipf4IUCsq3OOLRZCDGVrn90TREpt20qAKbcOTSFBwYACKijwPE6100eBdzv2mlLFMqVocxBo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=m49MalvU; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m49MalvU" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-564e4df00f3so1120880a12.3 for ; Tue, 20 Feb 2024 22:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708496423; x=1709101223; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=z7BDvVnOFI8EfULdSJBhx0Uoarr0dwLKho4DFLKCbPE=; b=m49MalvUruAIQhB9yuPc/uMVxLpvLNAfVqHVv4KhEPUMQhYBLJRobwiUpuh8t42HdY ZJMQoNnDsIVTIN2gvvcttjk1Bi9c8/m5O6XS4ZEsVMm1ihQCeNjchr16KKWRoh8RFg3K LmGqxYNXggdcg/gRSiaNkJZPl0UrTx5qLBdC+meD+BGxSBNNrBjqeu4qYfT1rIEhp2WW zUKe1uoEiv3AsYzGmJD8RCNhP8EUQ2tFPYleHp2iWdHz9s3kjZM7Pr7058HBAB1q0GZn 3wvMVR6sfBeZdck2lbI+ftSDI8GnZ2Tlacx50uPhhpbvNX4VklI0tFjXVhRvnYBEvPGs 4Hvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708496423; x=1709101223; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z7BDvVnOFI8EfULdSJBhx0Uoarr0dwLKho4DFLKCbPE=; b=KL2bOckzC+1YM8lzmawQrZYX9BUuK49ULtw0KLZvL7bGICPVAQRXTyDTmrMGBgUX3a nTn6MTpc3IIiQPP/KWjzQ6IvxNXx6os3e7BrRtjaYr0gA4nUhBKB6h9vkrYN5wNX+rB9 njx3pDPcpacByBSrfEdbX/UE0dGdxMPd1pcDuCD9ypo+txkn5SQUQkCIs9U6/C7HwTTa 2IwhEm/alUfSM+GzbKGWiMUjqvGlPpLWyCOdXbHszA4WdNopxG56U9hHdeD0ERYyVk9L 6IAwctHb/zZClurJo1AUJ9wkd80FtpT1Mi4PIV1MJWkvCV21aSJk4g/9bzCd6jzKrsPx I4wQ== X-Forwarded-Encrypted: i=1; AJvYcCWF/kAPUB6bSddK3201PzWbwCRZXXVQFfJCNa1FAfBZYlPqujZpOd4w9//U2zN33ZxpUZ7GOQga/5VPzlJOLCnff2NzPng0MLJTomR32w== X-Gm-Message-State: AOJu0YzGTry1+3auXUgqlvOcbiBwcSufKYZuyV7ssXQk8BQoKNzxryMr 3qKrY5+jR6CazxpxqgPjKyK0Ijh9kLxtFtbzLp0zyaFciIBr84zhumGQpQoM/7I= X-Google-Smtp-Source: AGHT+IEo1seUMFO75qlMhw5YgJjVl6BOsKnCUA2331SaQXoJuA959myuBNCXTpBpJJToej8dHPipIg== X-Received: by 2002:a05:6402:17c4:b0:563:ccd1:26bd with SMTP id s4-20020a05640217c400b00563ccd126bdmr9951812edy.2.1708496422990; Tue, 20 Feb 2024 22:20:22 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id c1-20020a056402100100b0056486eaa669sm2266459edu.50.2024.02.20.22.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 22:20:22 -0800 (PST) Date: Wed, 21 Feb 2024 09:20:19 +0300 From: Dan Carpenter To: Manivannan Sadhasivam Cc: Alex Elder , Jeffrey Hugo , Erick Archer , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller() Message-ID: Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding There is a copy and paste bug here so it checks "ev_ring_el_cache" instead of "ring_item_cache". Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable") Signed-off-by: Dan Carpenter Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/ep/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c index 8d7a4102bdb7..f8f674adf1d4 100644 --- a/drivers/bus/mhi/ep/main.c +++ b/drivers/bus/mhi/ep/main.c @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl, mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item", sizeof(struct mhi_ep_ring_item), 0, 0, NULL); - if (!mhi_cntrl->ev_ring_el_cache) { + if (!mhi_cntrl->ring_item_cache) { ret = -ENOMEM; goto err_destroy_tre_buf_cache; }