From patchwork Wed Feb 21 16:26:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 774509 Delivered-To: patch@linaro.org Received: by 2002:a5d:6ac2:0:b0:33b:4db1:f5b3 with SMTP id u2csp338800wrw; Wed, 21 Feb 2024 08:27:27 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWdMifznpGjtkL6nsPBmeB3ibRNRH5/IBQke8I8ZQmjo6v4uHNbjbWcxEuTs1MSaXlO7QtWEA2hSLRZy62u6NUl X-Google-Smtp-Source: AGHT+IE6PUWVDq6Al5I+LRjt8fx2N88jK21pls82+QW1hYI3dA11hT3+Y2qnXZpfc1Jym1btHwi+ X-Received: by 2002:a05:6358:724e:b0:178:9b37:79f0 with SMTP id i14-20020a056358724e00b001789b3779f0mr21462986rwa.32.1708532846806; Wed, 21 Feb 2024 08:27:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708532846; cv=none; d=google.com; s=arc-20160816; b=GZLLQlOqdcks9ojp+fjLP4l+0blOgymxgy7siz8dSAmcCPukrLBUEBqq59aEIu3Zjj 0GUtRx7/j+lQ4/RePwwXg4ih7WPQ6Zoe8OYNuBKklua9XblFZbYgZKuok89zbRVsNlaT r3+Pf4xAqN9Cgpv1dLjc9EAeiiuEFU7buWUp3/2zhCf8zvDcEE3dPA+4Ih0tEINwu7g/ J06fyqqni8kXnmN0hbimLqFOQVuDKiA2Tnukzjr1zBohoG80EhnwWV36wqWXV5OSALjb c0UvBV4O4FPGob01QUaTGKNfxA12VdxAjx64efKOtSdcXE7HUuJiJeJjwa9UZEgnCY2c vNcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wt6FO/BOJi8+tOHcjCIUSz3bCg3PpFu/35Ra4LjGzGg=; fh=JgLLwSLADNhQVZagQ/xwTjJQo9+XJEBxMJ3l8cpOSig=; b=ZzNy0+fKlHBf7BqRnUaBLLB7ZWiVfekDgr579/C514p3KIsL1GqK2J/KX6wOkGR7hg d1j7n1YrEKshmJbjazt8EK7wCVwMvFZ+I4ZKLfvOxINqaxH9k0gi65HZdk54lB4jWkpU CHmQAtxROO3wrRX+nquugtuGNu1fef+oEMl5hWLJ6RaRv0Dx06GR+baL0AYcYtFzhQVB leWRDSbLRigQBoxZFZ91Ij94Db47/DgEUT82/ayEV9ewQmowtGV2gNgr7iH7NC1xAzIz NxhIEm7E4PN4MJItDhrZXfT04QjF1qTS2FDneWKwwSmfOcfLQDY/8josVe6rvPrcXC5W n7aQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C7M1LVzd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id pa27-20020a05620a831b00b00787318d29bfsi10882510qkn.217.2024.02.21.08.27.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Feb 2024 08:27:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C7M1LVzd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcpQz-0007fU-IV; Wed, 21 Feb 2024 11:27:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcpQx-0007di-5I for qemu-devel@nongnu.org; Wed, 21 Feb 2024 11:26:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcpQq-0008ID-Dh for qemu-devel@nongnu.org; Wed, 21 Feb 2024 11:26:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708532811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wt6FO/BOJi8+tOHcjCIUSz3bCg3PpFu/35Ra4LjGzGg=; b=C7M1LVzd4TwpS5tZHHi+MdDEjiWdqCoO/mPH8DjoL0iURb8eTdp744DEUMaxmrqEjY77/R qQQuv/bN3tQi/hSv5Th/MEwqyrRFRyv7zD3gskti/7HGmdLQBUMenYhnIgyq2wKn28/wej VGNbWu/0WU4VFz6PXyfEGGJEcUFEQXM= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-0OdJL2h_OeGEQATgiojoYA-1; Wed, 21 Feb 2024 11:26:46 -0500 X-MC-Unique: 0OdJL2h_OeGEQATgiojoYA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 404B63869150; Wed, 21 Feb 2024 16:26:46 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.194.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7552120169D6; Wed, 21 Feb 2024 16:26:44 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-ppc@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Nicholas Piggin , Daniel Henrique Barboza , =?utf-8?q?C=C3=A9dric_Le_G?= =?utf-8?q?oater?= Subject: [PATCH 3/3] meson: Enable -Wvla Date: Wed, 21 Feb 2024 17:26:36 +0100 Message-ID: <20240221162636.173136-4-thuth@redhat.com> In-Reply-To: <20240221162636.173136-1-thuth@redhat.com> References: <20240221162636.173136-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell QEMU has historically used variable length arrays only very rarely. Variable length arrays are a potential security issue where an on-stack dynamic allocation isn't correctly size-checked, especially when the size comes from the guest. (An example problem of this kind from the past is CVE-2021-3527). Forbidding them entirely is a defensive measure against further bugs of this kind. Enable -Wvla to prevent any new uses from sneaking into the codebase. Signed-off-by: Peter Maydell Message-ID: <20240125173211.1786196-3-peter.maydell@linaro.org> [thuth: rebased to current master branch] Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index c1dc83e4c0..0ef1654e86 100644 --- a/meson.build +++ b/meson.build @@ -592,6 +592,7 @@ warn_flags = [ '-Wstrict-prototypes', '-Wtype-limits', '-Wundef', + '-Wvla', '-Wwrite-strings', # Then disable some undesirable warnings