From patchwork Fri Sep 20 15:36:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 174142 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp2647918ill; Fri, 20 Sep 2019 08:36:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqycPq1kkaOzf4svvh7PYDXe9avlUSChS+jwFkwAUnsjf+WH2Bj0BLfAcMxvU5ESPKMgMQt2 X-Received: by 2002:a50:95c1:: with SMTP id x1mr22186286eda.180.1568993786539; Fri, 20 Sep 2019 08:36:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568993786; cv=none; d=google.com; s=arc-20160816; b=G+gDNMemawFCSVoe7UWfEsImESum7FjsqIx+Ne20pTkB8v0LQqbL54/RpJ34bn7vT0 wSky1VBGEeCdJd9VNxhg4Ijq9Gxybh3Aps6njhbrGU6d4kHSaWOhA5B57reU2cgrPrTC xqpI0p4eScTmvps2Y8EukjhxqpwgV2XsV9pl19YJB1ZJeb+aBbBiVSSw/K4+fXvI0Yxu H87CmbypXnmbJC51YWHX/CUFnWnAFgFn2XxrUTHHfCK2MOeLvGP8WqZEDKIiXQI1YZIa c/ZdbnvOhEwlOOkY73NvSv/uG/+8rORHjMmUE2UhDLuX7Om+roOSNhfOmtyDOYNyB57g h2CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wZ4E+3xQPlRfGWiHf91pAqjECWWINrd5qiSpF9xPch4=; b=d/Q1tPeAEuVlt57KEoQUmuXxSbOFM+qOaxdWHxAazF80v7RR43n1lYGsfepRni6izH +52gYzskK3uKRqb77hmgdvtHGm9YI6kLYnIy6VuZwd2HAc6Y4P+u+J0Ah9hMR/unTp1G 1c4os/o+fFcjITWMR5086FAdM1thoGyxr/K1103WnaHTeZqCFtLScK4wLQ6tcH1ePutg I0EtUGXmmNdBqyNH6+NSVmjmQFep9fPuCpsJAuTx/g9glQzQyYpxc/mlAuFh+yQbHZv1 ZPKwVlXwql6GbdcMhypY/j1B2ALvfA1shPio8nF9I3O3l8abK7UOQ0NucWztOV+Fb5qu 4z/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11si1516482edp.247.2019.09.20.08.36.26; Fri, 20 Sep 2019 08:36:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404127AbfITPgY (ORCPT + 8 others); Fri, 20 Sep 2019 11:36:24 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:39449 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404126AbfITPgY (ORCPT ); Fri, 20 Sep 2019 11:36:24 -0400 Received: by mail-oi1-f195.google.com with SMTP id w144so2114017oia.6 for ; Fri, 20 Sep 2019 08:36:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wZ4E+3xQPlRfGWiHf91pAqjECWWINrd5qiSpF9xPch4=; b=PD2d8JmV5QqMLgzAEbD+jyXP3UiHgGZ9tjTGUMEhQdI9lOY2OaMfEfUtgVe0DJmMDD 9vR57YcpejOlLfH5nRr43gJFDHy96OzjFIe5+UMBjDO8wQ6CoOjK7KV5L2flLI1j1fcO Ei7Kh4KyJ4doLhfwWdVI0aQAHu4Tzv6T0zkzFlQ0xKVMNl+YbX3yyWX5ZYuyWTYf/15w 3blSb5H1ZyCVfY8cfwXKIKNe6tnie83MJfltITAj447lnbBYpjgJjieg4N/+NTtNA8hA 3CRcS8VsV1lIf3axnsgFs6Jm0ks/y+P2d/G+kZZVvHT6fQF7G649a7Xooohw5nVe0ajR Ta4g== X-Gm-Message-State: APjAAAXDGtPqJc2bkLTtx5F5AkDFM7n1NyBsayjjfikX8tdVgl/8N2aC u1bjoZ+GJcOuLJoPnKCcUA== X-Received: by 2002:aca:b2c4:: with SMTP id b187mr3487644oif.93.1568993783178; Fri, 20 Sep 2019 08:36:23 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id b5sm737419otp.36.2019.09.20.08.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 08:36:22 -0700 (PDT) From: Rob Herring To: Linus Walleij Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH] arm: dts: integratorap: Remove top level dma-ranges Date: Fri, 20 Sep 2019 10:36:22 -0500 Message-Id: <20190920153622.14616-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 'dma-ranges' at the top level doesn't make sense. 'dma-ranges' implies there is a parent bus node with '#address-cells' and '#size-cells' which is impossible here. Likely this translation needs to be moved down to sub-nodes that need it. Cc: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring --- This probably worked due to bugs in dma-ranges address translations (or lack of). AFAICT, only PCI needs dma-ranges. The TRM says inbound PCI addresses are 1:1. So a translation from child address 0x80000000 to cpu address 0x0 seems wrong. The v3 PCI driver also fails to look at parent nodes for dma-ranges. arch/arm/boot/dts/integratorap.dts | 1 - 1 file changed, 1 deletion(-) -- 2.20.1 diff --git a/arch/arm/boot/dts/integratorap.dts b/arch/arm/boot/dts/integratorap.dts index 94d2ff9836d0..198d66181c50 100644 --- a/arch/arm/boot/dts/integratorap.dts +++ b/arch/arm/boot/dts/integratorap.dts @@ -9,7 +9,6 @@ / { model = "ARM Integrator/AP"; compatible = "arm,integrator-ap"; - dma-ranges = <0x80000000 0x0 0x80000000>; cpus { #address-cells = <1>;