From patchwork Thu Feb 15 16:16:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elad Nachman X-Patchwork-Id: 773254 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6186133417; Thu, 15 Feb 2024 16:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.148.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708013790; cv=none; b=b0hTAR2WyD7nHInN/HInhG7CiWWofP2CdjG2342F1VAkpCx5hje4dpgzfHmmNVugI1RdinocDR0rP0rxwmleOLQ7DQ6X/VhJNP7zVLralJqYYHQvKzgfHEoZh69WsJpBvGd1164GhGHW37sybtsv0WvRT0CG3Gnu8/+u/zbn7D0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708013790; c=relaxed/simple; bh=l/GTee6P7REYJKfuhX7yJpI1AapDko/ki83mODVn3Yk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tGWVX2GyUciZ3mjEVdOHccRog42Yh9wP7ECZHF0O32v+zXmx55kKU6kuA98pqpc/P2XHV2cbJuCNEAgTGf1ERBpOXz9Rm7ViRH9Jb6Q6tkipZlSRmSpdsOdDl/q063N125O+8ISijf0QytxwVttwiqdcW6ZsQmc5CvDLdXkzJDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=none smtp.helo=mx0b-0016f401.pphosted.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=Sfa7fVF4; arc=none smtp.client-ip=67.231.148.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.helo=mx0b-0016f401.pphosted.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="Sfa7fVF4" Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41FACOap012499; Thu, 15 Feb 2024 08:16:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= pfpt0220; bh=r5Jq5tM2b891p35YD4FZwN/lnlNdgn+jPK5zhAqmnTs=; b=Sfa 7fVF4BlYtiIN23r0yZb/cwYoO4+rteIrulLWF1C8e6bl61QwLU4asgRx9GddfpGU uCI5VJSr9xALLURzxZK06p26CUbrl54SL/E3h7ac4miB3fIZjcR0rEw2Vk0JgSvm v6T2UwmCNJhEtS3XYDqQBWFTif3ObvZqrgdo29GgjN1NAG422hSZ6J+em4/TgLn1 SBhnqcyJyeTM8+J7lU0mqs9icnWIWFJbTYPMR0PbZMd3lQg/sJwsYlRNgj+ytbZ8 44uWJUdxf8piT6qJIGpuFiLuWRHRHAkoVhd+Fo8AZqDo/sF2vO85IcYvkd88E8EE VI1P4ja4p88lPJWJEZQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3w9gnch7wh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 08:16:20 -0800 (PST) Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 15 Feb 2024 08:16:19 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Thu, 15 Feb 2024 08:16:19 -0800 Received: from dc3lp-swdev041.marvell.com (dc3lp-swdev041.marvell.com [10.6.60.191]) by maili.marvell.com (Postfix) with ESMTP id 8A85D3F708C; Thu, 15 Feb 2024 08:16:17 -0800 (PST) From: Elad Nachman To: , , , , CC: Subject: [PATCH v2 1/2] mmc: xenon: fix PHY init clock stability Date: Thu, 15 Feb 2024 18:16:12 +0200 Message-ID: <20240215161613.1736051-2-enachman@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240215161613.1736051-1-enachman@marvell.com> References: <20240215161613.1736051-1-enachman@marvell.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: h4iAQVJ_IHC5IlC5Q9j2V_nHadTX6tiG X-Proofpoint-GUID: h4iAQVJ_IHC5IlC5Q9j2V_nHadTX6tiG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_15,2024-02-14_01,2023-05-22_02 From: Elad Nachman Each time SD/mmc phy is initialized, at times, in some of the attempts, phy fails to completes its initialization which results into timeout error. Per the HW spec, it is a pre-requisite to ensure a stable SD clock before a phy initialization is attempted. Signed-off-by: Elad Nachman --- drivers/mmc/host/sdhci-xenon-phy.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c index 8cf3a375de65..c3096230a969 100644 --- a/drivers/mmc/host/sdhci-xenon-phy.c +++ b/drivers/mmc/host/sdhci-xenon-phy.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include "sdhci-pltfm.h" @@ -216,6 +217,19 @@ static int xenon_alloc_emmc_phy(struct sdhci_host *host) return 0; } +static int xenon_check_stability_internal_clk(struct sdhci_host *host) +{ + u32 reg; + int err; + + err = read_poll_timeout(sdhci_readw, reg, reg & SDHCI_CLOCK_INT_STABLE, + 1100, 20000, false, host, SDHCI_CLOCK_CONTROL); + if (err) + dev_err(mmc_dev(host->mmc), "phy_init: Internal clock never stabilized.\n"); + + return err; +} + /* * eMMC 5.0/5.1 PHY init/re-init. * eMMC PHY init should be executed after: @@ -232,6 +246,11 @@ static int xenon_emmc_phy_init(struct sdhci_host *host) struct xenon_priv *priv = sdhci_pltfm_priv(pltfm_host); struct xenon_emmc_phy_regs *phy_regs = priv->emmc_phy_regs; + int ret = xenon_check_stability_internal_clk(host); + + if (ret) + return ret; + reg = sdhci_readl(host, phy_regs->timing_adj); reg |= XENON_PHY_INITIALIZAION; sdhci_writel(host, reg, phy_regs->timing_adj); From patchwork Thu Feb 15 16:16:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elad Nachman X-Patchwork-Id: 773565 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC143134CE5; Thu, 15 Feb 2024 16:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708013792; cv=none; b=dEAEXv2qrP+1VnjUGHLBZAc4sI3pqhcuNf3XC1Qn78wj4wiv/6ZSG+3xsx0bSA/lguAil/RgM9p6vusY6CNqqkEMgijje9bltU164KT6+qGH6eisxfe7EZ0kHY+cXC3/fgQtwODL7qngDhnXV00+DZm90a/yCN/4xwkv61CrInk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708013792; c=relaxed/simple; bh=sxn7UvNEBwbljcxUhLwE3xC0K2n3sgRbv9rYziqHTh4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G1gmV7VhDcmtlf/RpSR1irMRxCk2cH7fq6Rb02cxRmCy/6BE86gvh+c3/n+9MFgX+s9aBWtO/8W+QYb80y+7q2++S3J7QkJOMpMeLKLo1p46YQqiDo3qyK4EKbtBPjtAQtr9sMP2k3Ol5pbSXQ0wvJp4e5ekj+wpl38MSmqZ7po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=none smtp.helo=mx0b-0016f401.pphosted.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=LGagqFPU; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.helo=mx0b-0016f401.pphosted.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="LGagqFPU" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41FCk83l026995; Thu, 15 Feb 2024 08:16:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= pfpt0220; bh=q4P5OHmYn080DFP0oyNUcqHRE5wGOZYP+WFeEgOmAgY=; b=LGa gqFPUBOgstb+/dxfpSmFAvULiXVz79ve9YkWjuY0kYH4ndfGKfVbVdphXY0QW5q6 K9WbaCfZot114PQcUuxs8w6YOXf5EEbhHx6VFRGaQ1XddC6NzqHVhv/dEmhz5Dp2 o0jftu9T8yfEiYjlqATb+13fM1XvaWuBE9PX/n5GkWtTbcoorB30MoZiFRbepGct l1v12vLSXkrJWC/rSoq90CdnNtUUg+5nlDhpc3IoAKxQrjS3uqa0jZ3WyGU7vOAp 9rJvx4iDSvMBgigLuwVFDMRgMOy24us/FfkJdT/xNR1OEF5QPn65Ln2zJat08Yd3 X6FHPCmKLv6sgbShg0A== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3w9jw98uux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 08:16:23 -0800 (PST) Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 15 Feb 2024 08:16:21 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Thu, 15 Feb 2024 08:16:21 -0800 Received: from dc3lp-swdev041.marvell.com (dc3lp-swdev041.marvell.com [10.6.60.191]) by maili.marvell.com (Postfix) with ESMTP id 9BD893F7095; Thu, 15 Feb 2024 08:16:19 -0800 (PST) From: Elad Nachman To: , , , , CC: Subject: [PATCH v2 2/2] mmc: xenon: add timeout for PHY init complete Date: Thu, 15 Feb 2024 18:16:13 +0200 Message-ID: <20240215161613.1736051-3-enachman@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240215161613.1736051-1-enachman@marvell.com> References: <20240215161613.1736051-1-enachman@marvell.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: qAKbCKW2zkABzLMFkT03CAb1U7QXl2UQ X-Proofpoint-ORIG-GUID: qAKbCKW2zkABzLMFkT03CAb1U7QXl2UQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_15,2024-02-14_01,2023-05-22_02 From: Elad Nachman AC5X spec says PHY init complete bit must be polled until zero. We see cases in which timeout can take longer than the standard calculation on AC5X, which is expected following the spec comment above. According to the spec, we must wait as long as it takes for that bit to toggle on AC5X. Cap that with 100 delay loops so we won't get stuck forever. Signed-off-by: Elad Nachman --- drivers/mmc/host/sdhci-xenon-phy.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c index c3096230a969..cc9d28b75eb9 100644 --- a/drivers/mmc/host/sdhci-xenon-phy.c +++ b/drivers/mmc/host/sdhci-xenon-phy.c @@ -110,6 +110,8 @@ #define XENON_EMMC_PHY_LOGIC_TIMING_ADJUST (XENON_EMMC_PHY_REG_BASE + 0x18) #define XENON_LOGIC_TIMING_VALUE 0x00AA8977 +#define XENON_MAX_PHY_TIMEOUT_LOOPS 100 + /* * List offset of PHY registers and some special register values * in eMMC PHY 5.0 or eMMC PHY 5.1 @@ -278,18 +280,27 @@ static int xenon_emmc_phy_init(struct sdhci_host *host) /* get the wait time */ wait /= clock; wait++; - /* wait for host eMMC PHY init completes */ - udelay(wait); - reg = sdhci_readl(host, phy_regs->timing_adj); - reg &= XENON_PHY_INITIALIZAION; - if (reg) { + /* + * AC5X spec says bit must be polled until zero. + * We see cases in which timeout can take longer + * than the standard calculation on AC5X, which is + * expected following the spec comment above. + * According to the spec, we must wait as long as + * it takes for that bit to toggle on AC5X. + * Cap that with 100 delay loops so we won't get + * stuck here forever: + */ + + ret = read_poll_timeout(sdhci_readl, reg, + !(reg & XENON_PHY_INITIALIZAION), + wait, XENON_MAX_PHY_TIMEOUT_LOOPS * wait, + false, host, phy_regs->timing_adj); + if (ret) dev_err(mmc_dev(host->mmc), "eMMC PHY init cannot complete after %d us\n", - wait); - return -ETIMEDOUT; - } + wait * XENON_MAX_PHY_TIMEOUT_LOOPS); - return 0; + return ret; } #define ARMADA_3700_SOC_PAD_1_8V 0x1