From patchwork Thu Feb 8 03:46:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 771161 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2082.outbound.protection.outlook.com [40.107.243.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0372DF7D; Thu, 8 Feb 2024 03:50:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707364261; cv=fail; b=ZkM+jVX5Y5d93LuDKwOGAQtrovU0WTt3W/LO5wt4V10KhyQORMlrobZHMWDyOpP/jyM1qQPJYYTncBtk34TLKy1plrF44Y7uCUsO6bje9IHlzMG80gH+uil0kZdkuonPyp49kM3S25UfCNZBhPXCjWv4u0e43/CGKvIl/onvrGY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707364261; c=relaxed/simple; bh=parJunbqZZM7FLADqKwaaiZMdZ97E7FxPQ3zim1LUl0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PeOcnFeGIZjvTM1aQCM/Y9kJJRVFnWqq12AX/6wccZL1A+tgq+FKrRhHbyY6j+rrC4UKgZ1k5thi1rZlB4glBE60M20/kp7uG4YtyckYm/oiLre8k+5E70VDjgkEzmcuipZ2SZq8wh8s/4WC0y64lcJgkDlKz/EoeUncTn05czs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=aw2xHJfD; arc=fail smtp.client-ip=40.107.243.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="aw2xHJfD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P78X2N9uFCsPnrJjJyEjhE6YkCLTwSkHRp2EJnVcZ/zE3PGzSZEL9yiJ5gz79AWCb4XCug7aCgSzvtsGxpKIjtTyxFt+k5VqxSdOEtuNARKHPWx/+hOw6NqvsSIFFt1gIEEy0iIU0nXmIh7GCRoQImsopUkPQLvRWfgOdJrU7zWqXxGhXnnAj92PvECPhPNxgpsmmDbyNzGZY6FopqUilvSPklK+mEfW0ANaTVW2J/7sbhF+e/NGmVQRpnUiuSvqlqdsoVWvRXz4Rn2dEcNOfvP6lTJBs91BgjHjk1uZik7pXFpPk3GlZ8PAp6ED10HnVHZ4G4xZuPmIvzhb3sS/sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K1QpCmGfGhowPUaMtKNBh5csgXHDS1etmh/Yo0jzAQY=; b=B2cKdInZr34YoBjoyaIf/SLpDQWRX37N0n7JCmq0/vhYyRq1feWw61BAMRnXcDkSY3AFQZhJHuQWN0NumKDh8O1vJgQ2KCHl1Q2VHF6+lHgvT87ST6TkFbkXYTWOB+fdryJxnEgjnzRkqS1dhZrKVavyrBtODc2+P/C1dnRn52QXYxZ8fNa782+L+GY9oAbielupVSQMiET60AJG6NWcdki6ITPTn9KUNCq/iDrXviGVzw9YBT/A5gLOwL6Ag/exRxdPnKj9R4me4N1g/oOsiHSaf5GhICnLtgseiPLD1p3kP4G9uz6qg2s0tEIRY8NoFT9GyVJgTJDX6vGdw/zA4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K1QpCmGfGhowPUaMtKNBh5csgXHDS1etmh/Yo0jzAQY=; b=aw2xHJfDfSlyIPHbeHR5ZmPTeLSVt1+otu0JqdS2FL1c+8zI8ruujlvXwTvpGlqV+BDRDavG0ZVF4ckUGlu/f2/TUNwBhxXdAOvTOZyELn3LFZtrqIYsxmgKptrKWszV3GtxU9IwsPovQSKbOSQ/aVd99kPlsEjM0hXJgmF/6Vg= Received: from MN2PR14CA0022.namprd14.prod.outlook.com (2603:10b6:208:23e::27) by CH3PR12MB8725.namprd12.prod.outlook.com (2603:10b6:610:170::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.15; Thu, 8 Feb 2024 03:50:53 +0000 Received: from BL6PEPF0001AB52.namprd02.prod.outlook.com (2603:10b6:208:23e:cafe::86) by MN2PR14CA0022.outlook.office365.com (2603:10b6:208:23e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38 via Frontend Transport; Thu, 8 Feb 2024 03:50:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB52.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7181.14 via Frontend Transport; Thu, 8 Feb 2024 03:50:52 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 21:50:49 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v6 1/6] ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors Date: Thu, 8 Feb 2024 11:46:28 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB52:EE_|CH3PR12MB8725:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bcf8b26-fa84-4692-7111-08dc285925b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z6KMbRB0I1BVj44YpYD7sgghmEIOdMi+BE6982O0w0Juz1cANS8MsN9YEDlXmq6CcHNVa5QO4SMKcVs7kmioSB5pNyEfe+Qb/EucPr2QkimjdCsYe+z7jWq918vK2HgY6FAX3EFIRo2FGlHgGR1bbkjS8TUrI99y8V/SMvJJkTS1LIJESWghg18LyLgeIaj7ioZ1HYxpeYvq89D3IiXTJc8t3jOqTkE5F0XcSD6mI2z3zznqQ3aphhU+ri8NTb/FVGOap8WC646CccWn464RaHFXgNHec3zLDmxvOQwVHxWdX/P+ADnxxZS3/KDLEwml0/E/UHqVCMv21H7ItbThnM2k07jMGT2uRDBN0UNPbYk9r+Pj9zEHYyr/5L0Xv2yhHZEX6iylaN6JeoZaLCssso3nf9HymfzoLkhcGBKg6xh86DpZcrvMbJuWem6JZHN963j3nSM4WfDpagisvC12PuxdQPb6Bm4ZQl54k7oSBlSNWZftGgJU4L7c3LfeONwqnDF1DXFX7wtJEnYAyplhpWKVxG5bCsh2+lCifT5MnbqudKN6mfDfHuXEf4W4oEtLVE4M2BYV2WYg4wss2iNGKg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(136003)(396003)(39860400002)(230273577357003)(230922051799003)(451199024)(1800799012)(82310400011)(186009)(64100799003)(40470700004)(36840700001)(46966006)(316002)(86362001)(478600001)(16526019)(6636002)(83380400001)(82740400003)(426003)(2616005)(81166007)(2906002)(356005)(26005)(8936002)(6666004)(70586007)(336012)(4326008)(110136005)(5660300002)(8676002)(70206006)(44832011)(54906003)(7696005)(966005)(36756003)(41300700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 03:50:52.8975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcf8b26-fa84-4692-7111-08dc285925b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB52.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8725 As there are some AMD processors which only support CPPC V2 firmware and BIOS implementation, the amd_pstate driver will be failed to load when system booting with below kernel warning message: [ 0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled To make the amd_pstate driver can be loaded on those TR40 processors, it needs to match x86_model from 0x30 to 0x7F for family 17H. With the change, the system can load amd_pstate driver as expected. Reviewed-by: Mario Limonciello Reported-by: Gino Badouri Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218171 Fixes: fbd74d1689 ("ACPI: CPPC: Fix enabling CPPC on AMD systems with shared memory") Signed-off-by: Perry Yuan --- arch/x86/kernel/acpi/cppc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c index 8d8752b44f11..ff8f25faca3d 100644 --- a/arch/x86/kernel/acpi/cppc.c +++ b/arch/x86/kernel/acpi/cppc.c @@ -20,7 +20,7 @@ bool cpc_supported_by_cpu(void) (boot_cpu_data.x86_model >= 0x20 && boot_cpu_data.x86_model <= 0x2f))) return true; else if (boot_cpu_data.x86 == 0x17 && - boot_cpu_data.x86_model >= 0x70 && boot_cpu_data.x86_model <= 0x7f) + boot_cpu_data.x86_model >= 0x30 && boot_cpu_data.x86_model <= 0x7f) return true; return boot_cpu_has(X86_FEATURE_CPPC); } From patchwork Thu Feb 8 03:46:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 771160 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C63342E632; Thu, 8 Feb 2024 03:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707364266; cv=fail; b=A8sauSlNQLef5i5imoIXbn++P4NxKKGDgrlJpIpG1Z8JTa6oh9MQoHI42oa0AjuMN0WkVKBCk1u7LkB4wzpDvJlAys9ejYShiTCscX8sd4ZO/nzwrzv5k1ezvBvS2Dz94K9churzpL98JW9cxgjYaSw1E57Uyxy/23s3PP7UF2s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707364266; c=relaxed/simple; bh=i0/3Y1RcrmO1kxZ8mQEqBybxtj69hjageTPfY0V6nOk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W6XdLlbbV2Ei97Xc0eCsUCQOtGhdnhU1OZurwbPymgXVsjqb2HBGSwQgubTH2OClYZLfqftQrwyiJBAo3Ps4HWn2MZpxwsNj055ZAM39HusqwHr6afzeRucW6cabsCev+7LXiWaKFo+W0sHXAwbVM6wZ1CmhErA8vzNraDJ5kcY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=QhSowdYi; arc=fail smtp.client-ip=40.107.244.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="QhSowdYi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7/i6advmWLZQcYn86kKb1iFOvQvacEx6YEniaLq37pJ6hV7KwasuPVIG+EMu30PeFljReZOKhX4RCwCMLbXKOHFri4lvEZDaUaSQ+rHRtOnpqQZVc2+YugUw7ixxdE6jQJjnkjEKqxaZGIvhgCA2wyzQSPZWM1hxjqYLYX0dZNHBurQbNthJGOcX3X0q+0a9z0dyVb1jsbQmkiSAMncgA8t2fL+olTXgkP1/Nyl8xTwkz0xaVrJkI6cd/Ml+ic/aLwUPEjHJflAxEGWaTN9StT72fF2e1Ke/Zg4gO3FvRczrhXXfNMXtrFVLbW3TUNGNzDreYQIHnrsWfdLmKccqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xJsNScROKFRLlT8Fo4CMnc5T+PlU3Oq4bkHlyx0RmNQ=; b=XLxAFR85aQZIQl8pd6QQAiPnTl8LQXqbwRh2UIedlhtviF2bLhEtHl9lgWLXJzy6xUAPwl5dEq4IU5nzWiarKZYfwgVJKzjRxDimLImxrAHhcyZaEhmmyUrnOIK/ZUbWxR5zR4qd2RtTn/5/Dv/wIiPYnJtwzsQEYyftjYO7hhS/nf20YS9hF4Bpd4rDmRpkvqINdO8Q14bu/dLjZGk2cutpn+NiiK9dRbZQUhiJdSjB0GO6NQdYjphNlQxR9OQ5Wh8skDI0Y1FeidGHtdhTZB122NkkT/iy1bJHROnFdlr8ugodVH/04DuxTaI9dCB94NxZFKRonXI0YsvZN9hOUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xJsNScROKFRLlT8Fo4CMnc5T+PlU3Oq4bkHlyx0RmNQ=; b=QhSowdYi6zCm+aGMaay8ZWAmRvjFXNB9aZ7iwYMjty9RsIY7RZmiUZquuJbGkCRvh/09Zz2kpYnGK5Sg/DzhKuprItxf6lQ1onxpJOw88++sdFvCtECmnx6xQ/+PAH0f/nshYOX8SqEGRoAcajOCWyGw1SKnZM9fn/NAI+o/3wE= Received: from MN2PR07CA0012.namprd07.prod.outlook.com (2603:10b6:208:1a0::22) by SJ2PR12MB7798.namprd12.prod.outlook.com (2603:10b6:a03:4c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.15; Thu, 8 Feb 2024 03:50:59 +0000 Received: from BL6PEPF0001AB56.namprd02.prod.outlook.com (2603:10b6:208:1a0:cafe::d6) by MN2PR07CA0012.outlook.office365.com (2603:10b6:208:1a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38 via Frontend Transport; Thu, 8 Feb 2024 03:50:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB56.mail.protection.outlook.com (10.167.241.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Thu, 8 Feb 2024 03:50:59 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 21:50:55 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v6 3/6] cpufreq:amd-pstate: initialize nominal_freq of each cpudata Date: Thu, 8 Feb 2024 11:46:30 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB56:EE_|SJ2PR12MB7798:EE_ X-MS-Office365-Filtering-Correlation-Id: 459b2eac-697b-40cb-0981-08dc28592965 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kbWdOg56A5UfejTeRMiHLG0OdfuX4Ti716WkQE4qGTod1j2GEzCUUGuHMlMvOFD2EXMPqko9Ry+WkWXmKLhPZ2ZKbvcBEjmKfyK29K+G5CsTnHUutqB9C+uMS5ZtdUH21SlYZ1ThHbX4ubTv3xeCab7mTKcKVXi8b3Ko0WCTmruZrYnZyey4iZnXdBtZIwcYiI/5R8+OLy6eDs6ARHS014Wm74VzNRddhGz8SkE2jBgQtMEjEJstkGk6TuHVPA6TJE4jBJDg9FHJXX5NM7V3/Ds7RTJRoCtxDvu4FUUWBp/hYZk2ObXgyPM3fZxOlGNG6UTy8ZdDKaqj9mHKcbmvFNsfsoyxBxHJBZZWW5DUuZa4aOyhqzC+VaW+WEcMVLx7VNeOIAs6FunEtw815CjYkkYYaRG3sXb8KuV+uJIpmXfdG4g06qYObSXD+L8lx44KO0aotbSto9H9KSUXKqrvW0xOQRbbTIvTTIM55W0I2SELmNVKwJ3d6c8Yczx0gqB657U36HLF/R9KelE3oj+DRVBYkYVB1P4HY1rrX7C80balMmnHuaYh/OD59qU/v9jR8TqRGFszcGmuSJtrjaTtVf5xXXpGoBdx85HwFOsmi88= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(376002)(346002)(396003)(136003)(230922051799003)(82310400011)(186009)(1800799012)(64100799003)(451199024)(36840700001)(46966006)(40470700004)(86362001)(41300700001)(478600001)(16526019)(336012)(36756003)(7696005)(426003)(2616005)(356005)(81166007)(6636002)(83380400001)(82740400003)(26005)(6666004)(2906002)(70206006)(4326008)(110136005)(44832011)(54906003)(5660300002)(70586007)(8676002)(316002)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 03:50:59.0986 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 459b2eac-697b-40cb-0981-08dc28592965 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB56.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7798 Optimizes the process of retrieving the nominal frequency by utilizing 'cpudata->nominal_freq' instead of repeatedly accessing the cppc_acpi interface. To enhance efficiency and reduce the CPU load, shifted to using 'cpudata->nominal_freq'. It allows for the nominal frequency to be accessed directly from the cached data in 'cpudata' of each CPU. It will also slightly reduce the frequency change latency while using pstate driver passive mode. Reviewed-by: Mario Limonciello Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ac7faa98a450..ea8681ea3bad 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -619,7 +619,7 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata) if (ret) return ret; - nominal_freq = cppc_perf.nominal_freq; + nominal_freq = READ_ONCE(cpudata->nominal_freq); nominal_perf = READ_ONCE(cpudata->nominal_perf); max_perf = READ_ONCE(cpudata->highest_perf); @@ -654,7 +654,7 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) if (ret) return ret; - nominal_freq = cppc_perf.nominal_freq; + nominal_freq = READ_ONCE(cpudata->nominal_freq); nominal_perf = READ_ONCE(cpudata->nominal_perf); lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; @@ -848,13 +848,14 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) goto free_cpudata1; min_freq = amd_get_min_freq(cpudata); - max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); + cpudata->nominal_freq = nominal_freq; + max_freq = amd_get_max_freq(cpudata); lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq < 0 || max_freq < 0 || min_freq > max_freq || nominal_freq == 0) { + dev_err(dev, "min_freq(%d) or max_freq(%d) or nominal_freq(%d) is incorrect\n", + min_freq, max_freq, nominal_freq); ret = -EINVAL; goto free_cpudata1; } @@ -893,7 +894,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) cpudata->min_freq = min_freq; cpudata->max_limit_freq = max_freq; cpudata->min_limit_freq = min_freq; - cpudata->nominal_freq = nominal_freq; cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq; policy->driver_data = cpudata; @@ -1310,12 +1310,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) goto free_cpudata1; min_freq = amd_get_min_freq(cpudata); - max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); + cpudata->nominal_freq = nominal_freq; + max_freq = amd_get_max_freq(cpudata); lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq < 0 || max_freq < 0 || min_freq > max_freq || nominal_freq == 0) { + dev_err(dev, "min_freq(%d) or max_freq(%d) or nominal_freq(%d) is incorrect\n", + min_freq, max_freq, nominal_freq); ret = -EINVAL; goto free_cpudata1; } @@ -1328,7 +1329,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) /* Initial processor data capability frequencies */ cpudata->max_freq = max_freq; cpudata->min_freq = min_freq; - cpudata->nominal_freq = nominal_freq; cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq; policy->driver_data = cpudata; From patchwork Thu Feb 8 03:46:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 771159 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2068.outbound.protection.outlook.com [40.107.92.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93ECD31759; Thu, 8 Feb 2024 03:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707364269; cv=fail; b=Wd6SO2pODrxBUbMV+jYtD2a9AjrRdSRZFlocoyodWE9RH6YiSfd77YyzC+11d8l7BRX5I4VT4W/FnvbEN0OT3WCcWmCme203+VWLFmKi57UxKvQNUgudr0U1CBBjNuW8QiYmSSFtaeD8+O2qjf37VMT5Coqv3zwmFOudaCXlIsA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707364269; c=relaxed/simple; bh=/faDvRJteyXqZPRAcoZKXoQ2KPMAH3/GzFGupp3EFhk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YDp5/3PQi0S0B6w8o8YE9F4Is+g5C9XvuaOh7t8QH+vY6B0Zy4LLah9d/CW/DXTQUUTw4JUhlpP5l+gjxo5YINHvIwbOIm7sp23PcMDhj+yE9tOijIwBJrI8XxPN/mHoDIaE/1lZE4y1kKr+NLNv3v7kkt28+4AgkvZ1ZtDgYTM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Jhq/1dEW; arc=fail smtp.client-ip=40.107.92.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Jhq/1dEW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ufx9cj1+axwXsScJb1HzRgS6/N3vug7286y8KKmU/MQ2DCdAYdKckwHIB3mO9ILyoyoLkOS4ZjqyeocRJoYKqkzYoIOzW21wsiRSwZHJhKcv9gmUOFNQclXZaMpzor5iaQexQKoWVlwBfCweNKMl19aZxs0SH0Uol34qurxmXKMRzWw6i3uOnnbmhlo+u0+KRhoPZwmRFXpx5M9i6g18KdxKJzCbiiyMhA6Gcog7akzrLp1DLTzB6VBU293Ysn5Fg3Z69GwQRTiwNzNb0zS+6w6VHuUrHHASuQc6OQSjXOJPSmE0Gh7HfDynHefbEQHBmbdwSYIXP/l8UjM8AQFBYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gy9SNyIn/2SjYTda9oDK5zWZekhmoOyMuf9jAWZS5R8=; b=oWdROs7twzKydMBufk91UrcAuFIrVszLq2Dlfxg7b9HCqkORFcdj5nG4pLx1U/Cf68ys1XcHCQF2/w3uI/7uos7BGzdJXKNkvbnE5n5ZLdGRGmLBUv8hBXGKcaiBEHVxkDtlOJKjyVKVLFOMskWDGG0/kJf7iswPekuPASTDaatjZSPquvhSZtj3ifKSY377wz6YGXBwnX6m3SLqwfxoflEzP0xdg5heCVGwAlASJENYtvzWaLT8fW5waGF9JzRdB6ss+IcjpMPSL8MQFjBnKyqB94pS3fIDGjzf8x4g2huHWuVyqkibDGEaXVWyGFAOJX+Z+HH2ARK9FWh5rmYQdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy9SNyIn/2SjYTda9oDK5zWZekhmoOyMuf9jAWZS5R8=; b=Jhq/1dEWPVpsAbsrDXbQ1WJSCfQiIY/HV7G5apblWEqxGLcLlSvhlahnY0OJMSd2A2y7mRH954KphxEk/IO9QsbNBACKmwvaEmraSiVuzEibky+aJiYzrAPiKN78s/XLh7G0XPH8nW8kxK6yrEghbSq1O+EE99kSscV2izHxsWI= Received: from MN2PR14CA0010.namprd14.prod.outlook.com (2603:10b6:208:23e::15) by DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Thu, 8 Feb 2024 03:51:05 +0000 Received: from BL6PEPF0001AB52.namprd02.prod.outlook.com (2603:10b6:208:23e:cafe::c5) by MN2PR14CA0010.outlook.office365.com (2603:10b6:208:23e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38 via Frontend Transport; Thu, 8 Feb 2024 03:51:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB52.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7181.14 via Frontend Transport; Thu, 8 Feb 2024 03:51:05 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 21:51:02 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v6 5/6] cppc_acpi: print error message if CPPC is unsupported Date: Thu, 8 Feb 2024 11:46:32 +0800 Message-ID: <2343f6c652bbcfad9cb462b5fd05fdb49e833e1f.1707363758.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB52:EE_|DM4PR12MB5055:EE_ X-MS-Office365-Filtering-Correlation-Id: 628327cc-5dd7-4aa3-0c1c-08dc28592d1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5PrCQ91vVShGgXeWH44RS3t7exisbm8nEi0HFMxMD1NVmZePcOqIgip9pTNQDBdv/c5KXY4q/DnWnECcYTtXllfC7RxCXr//gZdbAlinptkfjn9Aa1VxkPI+Th8o9j5WgE0QLURN40ZJbpZKANzrfkDwUyePr1l7z9/fFGCpl0svVAhel9UT3zo3ubx8w2Mzy3+69iZgkjKvwy16We6rLksUNe8B9+nzacont8oRYPUCFYE01uxepcIi0jVJdJhYBUmJKZT+pyvj1FQRRFkxnUIExX2Tg9pTgJpptXyBth33OHB9yfoNao3ian+vp11c3Zp8LnP1rjmGzIEpi32SxReheYXPU53nrWuAeW8qoJnqfvjBuKK5wUUCIYTJF7vwJUFuz5/5wLSTyGXcmaIxEyNIaCELrxMs0NsSP3ne8TIwch4jw/z4DaRhRhOskuPWEh0FC9ZM5t4iJpktwzOimfV78uMDrJOtEa1g/4ibEut4DQCRatrKjozKq8hSj+aAwXLpGGmfmpNYeb2L8YbebFqNxRRdQUyEblkbweg11FWBI0MykAF3abCbZZl9YevEiFk03ew6mQEbsoumsK9N64Go71vNieNabBTZKuiyTLM= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(346002)(376002)(136003)(39860400002)(230922051799003)(1800799012)(64100799003)(82310400011)(451199024)(186009)(36840700001)(46966006)(40470700004)(36756003)(478600001)(5660300002)(41300700001)(316002)(336012)(356005)(2616005)(15650500001)(426003)(81166007)(16526019)(82740400003)(26005)(8936002)(70206006)(6636002)(4326008)(6666004)(54906003)(2906002)(70586007)(83380400001)(8676002)(44832011)(7696005)(110136005)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 03:51:05.3508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 628327cc-5dd7-4aa3-0c1c-08dc28592d1f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB52.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5055 to be more clear what is wrong with CPPC when pstate driver failed to load which has dependency on the CPPC capabilities. Add one more debug message to notify user if CPPC is not supported by the CPU, then it will be easy to find out what need to fix for pstate driver loading issue. [ 0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled Above message is not clear enough to verify whether CPPC is not supported. Reviewed-by: Mario Limonciello Signed-off-by: Perry Yuan --- drivers/acpi/cppc_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index a50e70abdf19..e23a84f4a50a 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -679,8 +679,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) if (!osc_sb_cppc2_support_acked) { pr_debug("CPPC v2 _OSC not acked\n"); - if (!cpc_supported_by_cpu()) + if (!cpc_supported_by_cpu()) { + pr_debug("CPPC is not supported by the CPU\n"); return -ENODEV; + } } /* Parse the ACPI _CPC table for this CPU. */