From patchwork Wed Sep 18 19:57:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 174004 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp101122ill; Wed, 18 Sep 2019 12:57:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLTBuIrC6IFU/NNWg4biqAzCxFqVa+sjU/Y2t9n6sECq+M1c4TwuhfKP+oeQ7VcE7pR5c2 X-Received: by 2002:a50:e701:: with SMTP id a1mr12543811edn.108.1568836678342; Wed, 18 Sep 2019 12:57:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568836678; cv=none; d=google.com; s=arc-20160816; b=TVI+P+2NykTUWnkVX6i5L4nnQhB1PGIlfkQzwICYTx7dOkxfJDYD1mCMOcUsQzpKks d0sIPJieNy6JGxN5I+2JsT8QCMi4F3QIK9SKLKY1RpN/P7QOzGqA/LdThXdkLywXfMlX 6fhqOrZSYI8CH5C8bIqP+5dv94LGyE+Zhc1oCxQM662kQyMc6qbBLLLvl+w2TDpUxEU8 4NlMQOVZf0skfjoWHziwtF3SzJILJcKUcgHyqswJyx6BZkQK/s+7riXK2UAXFFx6jthu TSdkn5Ym7GrOMqMOdifuxqE9PGUzmp4WIrA1BNgBy9Yr5sVZUqvOX5a0HBRnIA6krnrU XlBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=PWaL9RxfgsR/B+oBzU4OhMzRbRURbwHhwiRgkIK7Pxk=; b=G+4RLzBpgS2vxdsLBQgWYt0HFWRwoB3IX8X3UpJaMGxPDGBz5nOHfjiKd/aoxnp3Q2 vIO5+xNCrnM0p52+tiES9MZte6gQQZivLiYihTWliOJmtCvwZWdjQZxXG0ccDDkYGhUD 2oyK5yLr/Rxqbt0iBKG1hrQWQeZ4QA/4rFQIdvyUD0EqmhNlmFsPIpQe7sKucj6QDCKB tbjN7+DGn3hhOcyrpOwvsDnzBwOu43D9LC5B9sZ3tGDTgobOmiFvcXlt/FnSoHA71xJd e6jNOb5jOILsz5X0IWaspjTAxGdMoNyakx3YyIBrkNRfe8eo29sES+zWOqkedEl/Dy3j Z5Hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si3993824edm.80.2019.09.18.12.57.58; Wed, 18 Sep 2019 12:57:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389039AbfIRT5y (ORCPT + 26 others); Wed, 18 Sep 2019 15:57:54 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:38151 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732201AbfIRT5x (ORCPT ); Wed, 18 Sep 2019 15:57:53 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MBUZr-1iMWhv1hy3-00CwcX; Wed, 18 Sep 2019 21:57:48 +0200 From: Arnd Bergmann To: Shannon Nelson , Pensando Drivers , "David S. Miller" Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH] ionic: remove useless return code Date: Wed, 18 Sep 2019 21:57:35 +0200 Message-Id: <20190918195745.2158829-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:tGFs0j53Jb1jMYkS2hCvPmKoxnLZMVIP3N3je8VWvQ5S2zgKuOG eRLzmZZRrnOViO/Nb+KEwoZQfjnNaRv4CBfx6fajZLUXaHleqA/VqQfmdYphluD3TZYl9z5 Yfm3r1ze9i5irbHYscYwYmHHInCXbyzQgM92NJz4YuwaYdvF/K+aKiOG2LMYsKheRJCPHa2 qNGClUNe8K3p3SkrFcxzg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:luKqPByHVkE=:opdo+VkX6Q+A/eJ1A6bg2i HKHF/nTEQZgnlDKLcYSraBMPoydxMYmpSm9xXpCxAecESwcR68I1YakaJbZI/mTqg+97ixphp PDsicnKNxxMDqFFRHrJDOf89sDZ+LqKSswowLtLLX72FIY/rDNUe8QbwHKqc65IPgVCh+BAhW DhP4FYOSQeuQgLg71++ec6edSlFuLpO5Tle6oDOVwhh9B1jwdf7eB2B3r6mCTZ2daguflSY0B 17yyXEZgwENwt/tE9zRsYZK1ivcmOd6gOa/o9eIhSOZI12VOpQ1mqdYFi6BB3VIrWm2TRo9Xy PfrXkBcCvi0u0jeV6xcf4RWsI6zdW9s/D663ohUgBEM1I745TCg8g4pBnlNZRfIcdg3FYcs3g e/bvTpQOtYnOGcBI34gVeb/GBhkYukpkx6l/OkduA2Tg3BmzCj/+Ma7wdPMRCqzZ/8RCXi04K f0bPh4E1DS/Ez5FXjMst0BAHjs0Hm6FLbsDDrR9NlkjglTFpuN2s28PbD/z+0IFBDVd9R/leD 4NO5K3AdbGqBUYPz18992nkrGUIRWzhFGeBiwXpxEwomjPqjwzy/V4o9IX0MfnttMtP+LzrmO yr4lGtB/atE68UviXuZb7MMX5CC0RkL3bKDFXOjjCM3g59MSAjvH5M5tDDukuY6mUm/BEUAll t4pxdss4cRaPApB7zdTp/21CGS+8uyhxeF8uhbDr7Q/LfmHMsjzdQyNJZDJNqZkBmoZTt2kRk YDTx9YcZxeo/AC+pBOu3dl+JSiyi2OFtTcGTv1AaFgiSg0ztB+67SRpBGB70TWAMFq3t3KCWT 3iBUWKgxmDrWQGqjrKuqdGJzeSV15u7i7K2cq4bCw7urLEItHvqrtNmp4yEyRMVhdLJ8YmKxn Hq1f+6loHFbXxxloKZsg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The debugfs function was apparently changed from returning an error code to a void return, but the return code left in place, causing a warning from clang: drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:60:37: error: expression result unused [-Werror,-Wunused-value] ionic, &identity_fops) ? 0 : -EOPNOTSUPP; ^~~~~~~~~~~ Fixes: fbfb8031533c ("ionic: Add hardware init and device commands") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Acked-by: Shannon Nelson diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c index 7afc4a365b75..bc03cecf80cc 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c @@ -57,7 +57,7 @@ DEFINE_SHOW_ATTRIBUTE(identity); void ionic_debugfs_add_ident(struct ionic *ionic) { debugfs_create_file("identity", 0400, ionic->dentry, - ionic, &identity_fops) ? 0 : -EOPNOTSUPP; + ionic, &identity_fops); } void ionic_debugfs_add_sizes(struct ionic *ionic)