From patchwork Wed Feb 7 09:21:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 770772 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C023920DD8; Wed, 7 Feb 2024 09:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297762; cv=fail; b=Nf8zL6JL6n2jSlcxdo4FrHndZxNhTxjwJZ3F5lR1gcIAGAmI16h9D+PVXAuI4rHIi8FE3plg4bKBa7P0ykDhWuu+8A6XJXmp9qUHKbLKPXp79TrYa3GTCLMom/dccOJxw0poQ9fAcwx1+pBXLuHsSLOnECx9K7MHaADParBZ99o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297762; c=relaxed/simple; bh=Ak9+f1ImxIgmiCcWaGOJrghRlhQB4em9uBqxJIcJATg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZWPDfHSw6qA8kPZklM87qVvV+R7Si2STgYIbFYWuGDQA685zlKrep1H+dw9FBEENOj0/SniNUmKEW2TH91wwsacYNhzTwd7ZxzwFrNbA1fORg2zzCoLPO6nHZZl8+lfb8wQpa46oPoCaPST++Ho7lDJUdJ/zvKk2tg94vosG15U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=cOibHX0N; arc=fail smtp.client-ip=40.107.237.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="cOibHX0N" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N6dc9HHOZIg4T2Og7h2mnratUGZYn4wI9ys8Y9nzPR6nRaOoE+BA1oPDjelrQwK4VEEqZHwME3/apQNQr781UUr7UC0X0P69jC8NEnqzQ0jhMsDYiAM3xSxZvvsHulm/9LK/mzs53ruqnyqRQ7xIupZNVPNWMbb0EGSFjHJfJ3JVJPIufop0m834P/WJhLgnB+0gVUTb+YdzecUQg9C3LW8VeYhsXnckiI+MoKxTEKMg0IWUKl0Ir+SUrOHgDKHj1eWpRQzCWw4yBi73+vwM0lzrull7FouVoyfCNDUzUZt6ezEZKRly5teEr/V7fxiak90RlQcBKZpSdUjqXYRBqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9mSWjzc1phkK/5cOO9MgCydnoFOD5V0YGb6r7BmpUeA=; b=FnpyZF3eNyFHP+igNQbQ5+tewkzZKyND75coTuz66ozf6jqHWc8hpZxmQtAzummiyINf5RY7qUKZhTqi575pp9vQei/V3cyDoeLRdewzOqRmCU/MQrmP8DzGLFzLW/V7gVgV9pB+dWAkHlsalPSGPgIk02MZywHcUJ/crcd/NvmvkI1F11i2xVqH2eAd+sZrHb9XjdXNVji9C0ZkdCTHoJHIpnBjtkDgSG1Xl/lmRDRrwuikM87p9hivZUMpKPqjHkakcTxY3cl45xa/DeYThXuGYdX5CU3MBOKexXS6+0/9bgTDkrK9G79K7+8w4xGQuATo+p5Bd8GbIS8QY1ikrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mSWjzc1phkK/5cOO9MgCydnoFOD5V0YGb6r7BmpUeA=; b=cOibHX0NWUjInYkbPP03lQuykhUmjV+WuydkYgNBzaBW8ItABGeCKFXNxYUjcxiD3pRM9BG1C0S3LBrn2Y4ghFfi3e6/goX/Exhc+JpyXujdKyEy826wlRdoWrkGfn+lXSD7aPbbm8sp9TS6AyFQocQ8E1Utl9CWFKFgSpH9rKY= Received: from BN8PR04CA0013.namprd04.prod.outlook.com (2603:10b6:408:70::26) by BN9PR12MB5226.namprd12.prod.outlook.com (2603:10b6:408:11f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb 2024 09:22:36 +0000 Received: from BN1PEPF00004680.namprd03.prod.outlook.com (2603:10b6:408:70:cafe::c7) by BN8PR04CA0013.outlook.office365.com (2603:10b6:408:70::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend Transport; Wed, 7 Feb 2024 09:22:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF00004680.mail.protection.outlook.com (10.167.243.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 09:22:35 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 03:22:32 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v3 1/7] cpufreq: amd-pstate: initialize new core precision boost state Date: Wed, 7 Feb 2024 17:21:52 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004680:EE_|BN9PR12MB5226:EE_ X-MS-Office365-Filtering-Correlation-Id: b5baf410-bb00-4052-45a6-08dc27be5268 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QYVjvwQLmrSYM/b3GbcK519hACoWK+WdBaa62vfEZKMvQrLEQlDNDl//8oHtNfm+NDKM3opaDEbDDO7nYNwHBQ2Amj+8GRG63kNzbDhSLbekuUz1hXoCKbexiw3FA2x8AgcaB7GiJmnOHnJDokjpugIi11DpE1chkUpc9yREGd8eUWlm8V4iNPIW5ZedwY33hk2NjYxwmkt3cSxx40B9EaXvhn5hAVTnxxXuWD+AqdqzrlEJHjxnta2MDrpksvqx1Wse3zA/IY6X0fDM73hkvuwVH3jeaHvBFtt6aM9Q+nVNbbp1P55+k95QsUi+9kbsaSgiT++PJBFwPj6jEfOHB4YFiIsfvjIX0e4Gt3QBfRccGlmOmkPij2kwzCrDjZzBPjiDfLmPpbJzf8BTt+z0l8FYE6FpM2Jsj2wLTNJOUu42Vfid32rn2RS2cdbsYhAqn5XQ73wKVma+vDNrYS0kdVcqDDeJtoJkbEUm7ay1kx17JGj9gCPbfwZ3NGyGs3gMcMUs2JqKSZmNcgiCnsI61Xz0W0fjdx/1GVFMREV7++JO4uG4dwESMloKvZdeuosA2tHQcEyM33si745NTJ3n+sTqUeYylPfBR4wtbXHaov/lzN/N2vTn46eKrq2mKcbpwQN0Qq0mH6mER4viXxoO0ikdL/JuDlJYVjLm4mW53/yB+G2yVU1YR8NcwW8lMx1Ve4pDUbqKANZpvALSBrjmbhumqmCJM51ahQyHkHCXSDYrbCTvWWicARh+XB9hpNlMVM2Vv7vRN4+uNz8efl18hg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(136003)(376002)(39860400002)(396003)(346002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(82310400011)(40470700004)(36840700001)(46966006)(426003)(2616005)(6636002)(70586007)(54906003)(70206006)(336012)(966005)(36756003)(40480700001)(40460700003)(478600001)(316002)(7696005)(6666004)(26005)(16526019)(356005)(81166007)(41300700001)(8936002)(2906002)(110136005)(86362001)(44832011)(5660300002)(4326008)(83380400001)(8676002)(36860700001)(82740400003)(47076005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 09:22:35.9290 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5baf410-bb00-4052-45a6-08dc27be5268 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004680.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5226 From: Perry Yuan Add gloal global_params to represent current CPU Performance Boost(cpb) state for cpu frequency scaling, both active and passive modes all can support CPU cores frequency boosting control which is based on the BIOS setting, while BIOS turn on the "Core Performance Boost", it will allow OS control each core highest perf limitation from OS side. If core performance boost is disabled while a core is in a boosted P-state, the core transitions to the highest performance non-boosted P-state, that is the same as the nominal frequency limit. Reported-by: Artem S. Tashkinov" Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217931 Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 49 ++++++++++++------------------------ include/linux/amd-pstate.h | 14 +++++++++++ 2 files changed, 30 insertions(+), 33 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 08e112444c27..3772f71f525f 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -67,6 +67,7 @@ static struct cpufreq_driver amd_pstate_epp_driver; static int cppc_state = AMD_PSTATE_UNDEFINED; static bool cppc_enabled; static bool amd_pstate_prefcore = true; +struct global_params global; /* * AMD Energy Preference Performance (EPP) @@ -669,43 +670,21 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) return lowest_nonlinear_freq * 1000; } -static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) +static int amd_pstate_boost_init(struct amd_cpudata *cpudata) { - struct amd_cpudata *cpudata = policy->driver_data; + u64 boost_val; int ret; - if (!cpudata->boost_supported) { - pr_err("Boost mode is not supported by this processor or SBIOS\n"); - return -EINVAL; - } - - if (state) - policy->cpuinfo.max_freq = cpudata->max_freq; - else - policy->cpuinfo.max_freq = cpudata->nominal_freq; - - policy->max = policy->cpuinfo.max_freq; - - ret = freq_qos_update_request(&cpudata->req[1], - policy->cpuinfo.max_freq); - if (ret < 0) + ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val); + if (ret) { + pr_err_once("failed to read initial CPU boost state!\n"); return ret; + } - return 0; -} - -static void amd_pstate_boost_init(struct amd_cpudata *cpudata) -{ - u32 highest_perf, nominal_perf; - - highest_perf = READ_ONCE(cpudata->highest_perf); - nominal_perf = READ_ONCE(cpudata->nominal_perf); - - if (highest_perf <= nominal_perf) - return; + global.cpb_supported = !((boost_val >> 25) & 0x1); + global.cpb_boost = global.cpb_supported; - cpudata->boost_supported = true; - current_pstate_driver->boost_enabled = true; + return ret; } static void amd_perf_ctl_reset(unsigned int cpu) @@ -848,6 +827,9 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + /* initialize cpu cores boot state */ + amd_pstate_boost_init(cpudata); + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -899,7 +881,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) policy->driver_data = cpudata; - amd_pstate_boost_init(cpudata); if (!current_pstate_driver->adjust_perf) current_pstate_driver->adjust_perf = amd_pstate_adjust_perf; @@ -1310,6 +1291,9 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + /* initialize cpu cores boot state */ + amd_pstate_boost_init(cpudata); + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -1360,7 +1344,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return ret; WRITE_ONCE(cpudata->cppc_cap1_cached, value); } - amd_pstate_boost_init(cpudata); return 0; diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index d21838835abd..465e9295a60c 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -124,4 +124,18 @@ static const char * const amd_pstate_mode_string[] = { [AMD_PSTATE_GUIDED] = "guided", NULL, }; + +/** + * struct global_params - Global parameters, mostly tunable via sysfs. + * @cpb_boost: Whether or not to use boost CPU P-states. + * @cpb_supported: Whether or not CPU boost P-states are available + * based on the MSR_K7_HWCR bit[25] state + */ +struct global_params { + bool cpb_boost; + bool cpb_supported; +}; + +extern struct global_params global; + #endif /* _LINUX_AMD_PSTATE_H */ From patchwork Wed Feb 7 09:21:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 770771 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2079.outbound.protection.outlook.com [40.107.94.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D5D32137A; Wed, 7 Feb 2024 09:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.79 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297764; cv=fail; b=FgzQ8KiyzGOCdBfGwvWGutlJy9X1b/E9EX+eBwemf3f0MRhSHMHLbG0axEtZnk/EIfrPBRZk6M6nvbdLT0UAVFEm6ep1tnaIZKuSE7EaveX4ZKlUrl/E64chivbNofUqDpUUm80zTBKh9HN19n31ZqFt2sMenNLefpjCUMXXvhQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297764; c=relaxed/simple; bh=64jBJYA4Cs075/f/uPjvw/FTIdn6ik0Gs19e7wdlMOI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fIIyGYLPuCKsAWCRv2ZlvWpo1KYJGRDb0Z5nk3P1B7FYjN5gzkMyRDpCS1zwvNGFcfHBYPWyTMUX1dRUOngXMGHSNMnfoLvVBn7EdMHqSlnsRlkFv7MpYqquWxw7QWzIEtMIESkwQjcl42FAcEnDaubhJTgA+wTGSytahyCe8tg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yzdNJSBx; arc=fail smtp.client-ip=40.107.94.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yzdNJSBx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SU5AP0Bm+TaMbh9sPNer7RiCMjfcmmmkgtXiO+0hME3HB2dVGNPm/BlgAI/sQGRgma+5Uva7Lrr8+lvtnQMOZW5CmX0VIGwlsp0BlHqdt3NnGMum8AmglBdqYXq0vZM2haAYKQlyBZMMhfeSn7QvKVfkqBg4Xy5rwvWTCHr43JJCobj+ZToZCv4MzkRtbzC3V+IrvHUQaa3ARnwURfVH/9f2Zfa4FrEIGYD77vQEFV8vOm/ZaUHQ1yJTv0PW6KSKmiZxHo2At0WIoqXdj877zCLyXgbHDXL6K/xTyIUbq9sxLBfV/KelwkO8epXhrogAxbZQ4O0lbMgPuzSzy34hmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H/rVk0283MxXHy0R/9Vif05RiEbfK6zC0NjlWRGWqUg=; b=iyXy3Jd0uEYKEeBv5UXIdUOIOysjfQwDzjuJ8djvSKZ7+IFMOQcygJncQMlXAGXVtzT2zuSBbMuN6XRR5pUi6ZO37wWzWBzT7+uVEwVyRsYVGo6/0Slk95DySRNXz81hLQe4LTFxhE6NEOtoly7re4bfyteVxKuysXzq3xx22BcXABYOLN74uzZl2iemGlkczFUkIfSgFuTmGHs4Csw7oCkgMIOUea/BjON5FDkrIHc7VTRsAkeWE2kgCPKCvXM5EybbJYiJk9keFxxFK8P1nAxUc1TbjMueI7MFwehFW/hpUMqo872j60aLRJ27oyAfGV+2iYA6iHxS5NQZCpf3Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H/rVk0283MxXHy0R/9Vif05RiEbfK6zC0NjlWRGWqUg=; b=yzdNJSBxlXFLQNTnqSFRCemWQteMTWseWusglVfBdBZUB8+U7itBVg6H562cSNRdu/YrY+hsTFprp9J/N5qaJRI8LNP2a90tYAZ+6DUKg/F/M6+7YZJ7102c9QqlheeDZjAgaRmd2hGBz/ZL67xFWx80RzRzGRHK++3ukMBztf4= Received: from BN9PR03CA0102.namprd03.prod.outlook.com (2603:10b6:408:fd::17) by CYXPR12MB9280.namprd12.prod.outlook.com (2603:10b6:930:e4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 09:22:41 +0000 Received: from BN1PEPF00004684.namprd03.prod.outlook.com (2603:10b6:408:fd:cafe::97) by BN9PR03CA0102.outlook.office365.com (2603:10b6:408:fd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend Transport; Wed, 7 Feb 2024 09:22:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF00004684.mail.protection.outlook.com (10.167.243.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 09:22:41 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 03:22:38 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v3 3/7] cpufreq: amd-pstate: fix max_perf calculation for amd_get_max_freq() Date: Wed, 7 Feb 2024 17:21:54 +0800 Message-ID: <34e61ea5f1615ee0d464197ab4f521cf8b02617d.1707297581.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004684:EE_|CYXPR12MB9280:EE_ X-MS-Office365-Filtering-Correlation-Id: ee044cf4-6f76-4e1f-2542-08dc27be559a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UUDlskq/+lA95TKy1u58J47fQ8/MFEfg4+WbOs0HinomWpAfoN3vlZ2mGoBJbEPp5NQTL7Gm5MmZu/yrkMqRSfX+4uI088fXe11DbE7P4WB3d5d8CzD6AUCdJ158It9MLWLtA+ric7N1h5CH4byVwI1o3S+Ew7gPPi5mPZZRcISAi6F54pEd7BS0GQjcYcYWTgHP3w19Xa6nbHrXFoTuawQSCP7opPcbzY9fhDH3LX5nIrgM6Nh8CdaKGRvD8l00+T0AUFMSTvU0yFnMxJoc9aheoMQDY3DQgXlrxrinV+pYQvHQw7feVLIHNCPTQAyB+5lTx++5K//ItYItj5lPN9oSa2FJu30O6+55H6hTKBKWGY9IR41yU4t53wML0L5QvHnpMxXHUYv8BncYK7Km4ySjG09s1uOhuwVfSuSxGlyZWPzvwm4dW4VUkSdxSYkMCkWZXz3LNrWlWjSk4M7pyKo9zxZO/velTYrGl2E3l6ZmFi5vQ2/OSSymX/Z3IvapeCcm2rFCePfaikVXcl1jQFBXb4RvscA5Y14vDn09pG4R2tPt5e9/CKDf5XB/umaH6PxTjTHwL18mUxwioBChCdZ1JQ0AryePXcJVCSTB/X3jAky2S9QHpR5lrR6h0nivf5DUQvW+ZwOkpd1FUA4e8e68zGMoDcLFAtaI83yPqV9tCrtTRdEtv99hmIpNeaYrfwNmoFQvRyf61TqOqKGODrZpZQbPoJrB9ivL4sdawY2a/4K4PhIWABICH0RUViEqybz6HeCnMxcKFhp6xS4Ziw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(39860400002)(376002)(396003)(136003)(230922051799003)(64100799003)(1800799012)(451199024)(82310400011)(186009)(40470700004)(36840700001)(46966006)(83380400001)(54906003)(6636002)(82740400003)(110136005)(356005)(81166007)(16526019)(47076005)(70206006)(5660300002)(6666004)(26005)(7696005)(2906002)(2616005)(86362001)(478600001)(4744005)(4326008)(336012)(316002)(70586007)(8936002)(44832011)(8676002)(426003)(40460700003)(40480700001)(36756003)(36860700001)(41300700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 09:22:41.2734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee044cf4-6f76-4e1f-2542-08dc27be559a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004684.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9280 From: Perry Yuan When CPU core Precision Boost state changed, the max frequency will also need to be updated according to the current boost state, if boost is disabled now, the max perf will be limited to nominal perf values. otherwise the max frequency will be showed wrongly. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 82b43bb2ab83..1f86ce920d6c 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -624,6 +624,10 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata) nominal_perf = READ_ONCE(cpudata->nominal_perf); max_perf = READ_ONCE(cpudata->highest_perf); + /* when boost is off, the highest perf will be limited to nominal_perf */ + if (!global.cpb_boost) + max_perf = nominal_perf; + boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT, nominal_perf); From patchwork Wed Feb 7 09:21:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 770770 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2059.outbound.protection.outlook.com [40.107.93.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C8625630; Wed, 7 Feb 2024 09:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297776; cv=fail; b=g4phJeLUpai/AHroGKWIMaswtgUfJw6iWdnymGeA+QAxmv2VAYAH//nAF4tWg/pQI3jrQUUOeZCS3vBv8GBBBeyEvIbrwWnGz3OOrckaJQvDlCytq/TW9DaKCy96hcd/5ZVvr9fVKHzr5IoG+CvzY7l/jGU9maZvY/fxZLGcgXE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297776; c=relaxed/simple; bh=TJFAg4I2jHFGmdAh0oRR9ZBrmJM2j6B8NgGO4bpN4jM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eyUcSqzqhapqXVahvwK/p9rXKi+gC+FMgBeBBNP+iAw6YxSRmoCoJgQEZRsHfKqKj0w1Hxl034FIwI+bgghQhRIbyNsM3AY8Ajcok1Wd8V0v/n+TLQHPJuZlmUPC6DwThinaFKBMyTZN/gzKJcgNPAtT5sDrzBBuwGAQz++sBeI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=oFcMU9MP; arc=fail smtp.client-ip=40.107.93.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="oFcMU9MP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0LZ7TVO1J/oVVgM5G+OWoG0hAVgL3ebOPkzCIFTIgl1oLFpUB3KT7BSidVDZapxrCbkaF30w8qfAjPSDBDA5pyjADJQE2V9UiVXoLkkYfdQGrJnsKbAkjdpHkchcpkIhf5fcTVlsCl/EO8Sy/bLV66tbiiEpfVn+9Im/L3LQFfOJ7AMJNIFxJSrClVobS2LZnoPuyWII7XlZZGRaYLjXxjUZayKZXJ1bAVtm5dBMMWns5czBdF/lrfFqXnbUZXSeN4PS5oIZHWsuZOK66tFjxYhpm9uwUxZXh43fiLar3gDFaM4CXak1FFHjWPqpZr1zUSuXEAyVaflTbV0FS+Qxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=to88gmxh1QF8HEJXDCCFWLRhtdORll1W6Q1f49gQCBo=; b=N57jATBIiEiy5m9pSHT3bJFfQ366pF/f3nc7ehl5dSrOGL2AA0c3uz8+Yz4PRXhYd/OxbhYCiTKzNcrVrCeARFvky60ahzZe2KDu52vuhKGk/Vx7h6hBn5L6p53Fp0OlDpbT2rwAE4Xguz0fiHYC8EAKtIDDJNAa2cRxDKoCe0x+dlvBPCAT9bchsCuycd+g8IC+qZwuy/023fWjGgmw8LUhyGkEPpale8PkZw5dmN7SDXhrhGnM8c1j6vj4YVtgt5fbke7GZNvJ1R7zLXJbdvTjDZOeNTOn3o0uGo+XotI0J59XYxK7bXl3HDJOvtj7okAwTE/x2DZIQirlq5E2SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=to88gmxh1QF8HEJXDCCFWLRhtdORll1W6Q1f49gQCBo=; b=oFcMU9MPbgipZgDBHFwJQVxbG3YEgRei7Q4NHpeOH/ojvxuBpvG0lA/31n+9Mx5i3/6hcRN/lBqLkelxIbrGLCLGfSHwfvSAs2v13aCQF8mIzMJbn8y1Z173XSbBpvoOM4ImtOXuFbRxeyBDYIZDA6xlSyCMFHZvKlGs8f8r5xU= Received: from BN9PR03CA0098.namprd03.prod.outlook.com (2603:10b6:408:fd::13) by SN7PR12MB8433.namprd12.prod.outlook.com (2603:10b6:806:2e5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 09:22:48 +0000 Received: from BN1PEPF00004684.namprd03.prod.outlook.com (2603:10b6:408:fd:cafe::ad) by BN9PR03CA0098.outlook.office365.com (2603:10b6:408:fd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.39 via Frontend Transport; Wed, 7 Feb 2024 09:22:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF00004684.mail.protection.outlook.com (10.167.243.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 09:22:47 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 03:22:44 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v3 5/7] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Date: Wed, 7 Feb 2024 17:21:56 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004684:EE_|SN7PR12MB8433:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fc4be82-c65f-4e5d-3472-08dc27be5956 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: empCAzgWmz6oIuSWkD3t4QJSKCSXiTMIhuzBnR0U98GPwF0x9OVR261TZCSiPtid9ZBPIs6v5BUHlqCFUUSnzOJHvc0ThElZ8ZuqVKrbdffUgC5Z2oVBOhTCImiu91fcZhE0hrX2yPc+v355mMRfF6w8AWt8I3hFQwx7KFA4cvyPiXqapPS/hH0rjOegphIQuj/8DWzleUiTI754O2o2KQAtn1eQsyqzzABEL6PTOtBWY4+W1C4JPGP4oVX87ld0VKg3Mrx55N51RTGQ20vv/W9zuWFtskHT3dWo1kvtnwIcmR2Za3aF73RKaweFJReB8C2JXQbdz6JhpFtjaYp5ExBG1q5jI7wBuhyngTwI+56/2kMaAyKxV28IX8hEpvVkSfG2Yfgr8Epa+JTU+YWBAZYO3Uyc1/gDklXqwmJCSUdFUibIkb2gFdRykJTvPeI09jOQjOqn6qfL9PyUQYSvYrEWWqReu1SmcRTrFUGSEln+vLp6jSdPUDsIW/OPRr36JvRLRUO+LxQody36JN1glKUxD5T+SF733s5ZR9AD+Q7gRW22jciQQjiW6FqvdxdmQQoiJ2VFnVx2yxU4pv69ZBiyr28L2q/X0DfyVrQ7BLZCAOSg5ap6qRGM2oELWpn9jHEApD3ujRr6WHXDbgSJwpRFhE39sq1E1qCHGMMV+qLAD0YoIV7DHQJJzLca1E2/mVt4iNL3g0CXJIGb+pT4QAYGaavv6KBlvMLJphsXuVRyYRtDq8DDM7xXF1MdgHRpQM5nSW7yGz6GamVgLYR9pw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(136003)(396003)(39860400002)(346002)(376002)(230922051799003)(186009)(1800799012)(451199024)(82310400011)(64100799003)(46966006)(36840700001)(40470700004)(41300700001)(336012)(4326008)(478600001)(7696005)(2616005)(26005)(47076005)(70206006)(6666004)(54906003)(426003)(70586007)(2906002)(86362001)(44832011)(16526019)(8676002)(81166007)(6636002)(316002)(83380400001)(110136005)(356005)(82740400003)(36860700001)(36756003)(5660300002)(8936002)(40460700003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 09:22:47.5390 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc4be82-c65f-4e5d-3472-08dc27be5956 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004684.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8433 From: Perry Yuan Introduce AMD CPU frequency boosting control sysfs entry which used for switching boost on and boost off. If core performance boost is disabled while a core is in a boosted P-state, the core automatically transitions to the highest performance non-boosted P-state The highest perf and frequency will be limited by the setting value. Signed-off-by: Perry Yuan --- Documentation/admin-guide/pm/amd-pstate.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 0a3aa6b8ffd5..fcf5b75a5341 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -440,6 +440,17 @@ control its functionality at the system level. They are located in the This attribute is read-only to check the state of preferred core set by the kernel parameter. +``cpb_boost`` + Specifies whether core performance boost is requested to be enabled or disabled + If core performance boost is disabled while a core is in a boosted P-state, the + core automatically transitions to the highest performance non-boosted P-state. + AMD Core Performance Boost(CPB) is controlled by this new attribute file which + allow user to change all cores frequency boosting state. It supports both + ``active``, ``passive`` and ``guided`` mode control with below value write to it. + + "0" Disable Core Performance Boosting + "1" Enable Core Performance Boosting + ``cpupower`` tool support for ``amd-pstate`` =============================================== From patchwork Wed Feb 7 09:21:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 770769 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2056.outbound.protection.outlook.com [40.107.237.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E58922323; Wed, 7 Feb 2024 09:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297778; cv=fail; b=jQ1X0rfpde8mQ5d3iT9sj09YEsNq6eKlbtaW/hQeLf4TNlI7/fXDxgvhe1QBPe8t2ePVsU5vbs9aNgyWyIju0yJuCk9gvOkV9nQFxOP0l2mNiI4aU6qQGvm//aiBwNIVVoPWe8cYvaVBo3HGBEz5zkRt3z9ZgaaOEjd9QQeBheg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707297778; c=relaxed/simple; bh=uAfvgz28dDSg9yIY0HdANuXRN494fB5lKk5vDyKyq2Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iNSxK9+HLQXPB/keFMLgoVuHkg0Dbkg975TlPMw0dAVn8hAd+a1Qc4eSW1pmIHV3gdFvhXKfJ45tlKKQ0IINLXwseHptwDaon/4qaqOXDQnC5glYRjYo3MAggohs0tQN2HUkE4ZXalvdJngc8tSGOQLI1vaqezyWl5aPLII0w2g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=1csYY+Xz; arc=fail smtp.client-ip=40.107.237.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="1csYY+Xz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SfxGHobp7jYbaQodvlFdgGeXkhBhDcn6h+RLLx+JcMPdY0/rH77/2xZwFPKXohTZFUz7ezpUCCykPUZP0Wv22K6mlPH5u9nmNCgVgbf33KLyp9cqoLhT/6x9Kxlvb9ji/pBPY2XRi97f/mqDp6y0yTIroDaK5Ty4zyt7Ob25wlu6MrEhU13DyfdE64Yak7V0etVEhN8xKEFcyzGa55ebGH+LeapgDtY99RPDJHv/gPXLFX7Vc8BaF+YHeaLWDKbAdmVbKLWXEim4fyA5sAUGuT6fZ5dLkWASfczPX4rNgVa8lozDXRPQLzCRKswViqiCACJPsIC0ZmAiebt8/3P0OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kyu4cTOLR0GWzUT2ptQ7PupidvWOS6sQztS7R6U6U1E=; b=eGsctP0myys0zR3m8OGSRsrRNLvGRh5XLWJkhe/PEthPRIE3XA4TE7qFcC9S7Wf5U34ZkIe0+bhz4DZ9RfNsLC4mYuzHNBlkGN0etgLqyvYAnJSQ9R1xvZoXH6GvwKnNGdU4fX/O7zxFi0Qp0hoNjlka/OVpe/WsQEAbOuska8EhNf/3AEuTRrIQpZ/Yg7LUDYrGm+8Vritx/Um1jY/brHEB9Xb6khrRiB5nzwozmIVUpsjnTZwSgzHOBSdkNDjypgKcIx2Mso7mOBcTxcJOVi2eQEwjnKXvUk6AC15eRBx+xYhsy6dMCUSQQg8J2ak9jClz/N9/TFeHjzu2dIqiFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kyu4cTOLR0GWzUT2ptQ7PupidvWOS6sQztS7R6U6U1E=; b=1csYY+XzAFIceMMyMprYKpAtSign/ECdtX33xSKUr/gcKB7Lfq1vPI2HsazWgHm7Z4TDaSKgC/QY1YVF0Jdb4f7vEcVXCWnB9tCGRrwhc+KIkXlv/+PG1Ge1EnHwlMplx5m/SaMKTSdkmlce7Flex7cgGNfobmRHYf32wjKMCi4= Received: from BN9PR03CA0104.namprd03.prod.outlook.com (2603:10b6:408:fd::19) by PH7PR12MB6858.namprd12.prod.outlook.com (2603:10b6:510:1b4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb 2024 09:22:51 +0000 Received: from BN1PEPF00004684.namprd03.prod.outlook.com (2603:10b6:408:fd:cafe::4d) by BN9PR03CA0104.outlook.office365.com (2603:10b6:408:fd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend Transport; Wed, 7 Feb 2024 09:22:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF00004684.mail.protection.outlook.com (10.167.243.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 09:22:51 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 7 Feb 2024 03:22:47 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode Date: Wed, 7 Feb 2024 17:21:57 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004684:EE_|PH7PR12MB6858:EE_ X-MS-Office365-Filtering-Correlation-Id: 90f26a81-8f7b-4103-17aa-08dc27be5bc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KXBkW3ZOime8q5D6zybN4IgTDjtGiQwU8xJT3KkYqSgJdIQ7cqM6a/Iz6uPJae5Wk61WqOK2dtWTT3R/ehpY/fBSmWsvj3tP6QYvWT5rfkIdb7PrXSiR9tDNBOz+ZmafpZZISEUQW0gEtRZQIJcJV2MgjFUaNmmpWnuejmoyN6TyPnqU3T0IwFyMhJ3960NHo5c2Uhx/s+X+DMWQVmZagAoiO4zwetr4gFWixgNckIrBoPKYMu2a2jEph4qqmNN3jR3Wgnj2+Czbcyfjby3uiUcU9DWcorhlviPG9g0AQNwjh1Yab59SLatwhn5HXCmhW9ua1FSnk7afI+DJM2ODjUJ92QRmSwSk+9UQM7Q/Gi75JFQcywOgnaoOceHY3aol7xzYn4fT7lLNqgj71JnsQFO5vuYc/B9BgQqWMMwknCsQuxtL5U6iIULE00BBSLLXJW3U/lWz7bo1XumEzdGhav6LrbVhsf22sgRlAl/Iv/HfaG4w2e/gw4wc0W/W6t5CJzXm1Zt0iOdKQMoR7eqSeBHec0U155gbRh6lp8EZ6dmoDIK7opqnEIojgQdVPZLWy5+EH/obIAATRYONM/x6gv426IixhSh7bDZVfh8lnVOw60a3oCL9Lojrk2Dw1JfhPbdTXe9IR/iM6eERZQmtUbad/srOEkpHSnn6ONbTP28B9Pvs58qUj7SSJ33NlbOuDyjBtNOdjO3CX9nWhv6l6VljYdAPywvS2TKM4tfX9fdcSEBX/DRy0e5RWxEV8izXRE9ubvPVfLDqiAfcC5h4pQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(376002)(136003)(346002)(230922051799003)(451199024)(64100799003)(82310400011)(186009)(1800799012)(36840700001)(46966006)(40470700004)(86362001)(4326008)(8936002)(8676002)(36756003)(81166007)(70206006)(47076005)(316002)(6636002)(70586007)(2906002)(44832011)(5660300002)(54906003)(41300700001)(36860700001)(356005)(82740400003)(110136005)(478600001)(7696005)(83380400001)(16526019)(336012)(6666004)(2616005)(26005)(426003)(40460700003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 09:22:51.6015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90f26a81-8f7b-4103-17aa-08dc27be5bc2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004684.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6858 With new freqency boost interface supported, legacy boost control doesn't make sense any more which only support passive mode. so it can remove the legacy set_boost interface from amd-pstate driver in case of there is conflict with new boost control logic. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 1 - include/linux/amd-pstate.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 35791efc6e88..1dd523db3871 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1675,7 +1675,6 @@ static struct cpufreq_driver amd_pstate_driver = { .exit = amd_pstate_cpu_exit, .suspend = amd_pstate_cpu_suspend, .resume = amd_pstate_cpu_resume, - .set_boost = amd_pstate_set_boost, .update_limits = amd_pstate_update_limits, .name = "amd-pstate", .attr = amd_pstate_attr, diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 465e9295a60c..ab7ca26974da 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -93,7 +93,6 @@ struct amd_cpudata { struct amd_aperf_mperf prev; u64 freq; - bool boost_supported; bool hw_prefcore; /* EPP feature related attributes*/