From patchwork Wed Sep 18 17:21:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 173990 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp2734023ill; Wed, 18 Sep 2019 10:21:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyV7hnFatZYke5tUIX7nGdTc6zM5Mx/tiU09UFiv66hMinfO7032FIupdffFg3Ir3cah6+3 X-Received: by 2002:a50:e40a:: with SMTP id d10mr11784049edm.194.1568827282924; Wed, 18 Sep 2019 10:21:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568827282; cv=none; d=google.com; s=arc-20160816; b=z9qvKfJUJj7f2uyao4MCE4dUTW19aQsr/wk2xHd+Se34r5p0VrhoQ/R4b6kec9Eerw NT1n/Ru2KhOxxXIN5yUSx+NUbGDvTPGnO00NCJ0TaMLlNNikF9/XW234Jat3dRxvOHQv cq13sb0wUEYv9nTaZqP6BYU4eYuJ0Vt3UJgXbBmRPWe8CmTspWeydeuwPNAVSTTr3LTa QHevHNaxNdx6kBLFYnS6vhyrBuCBvOHtqYjy0itBq92xGsqLBSk6pX3h0Al8y9yB74n6 D66/iZOMMSFEqKvZp9ydb/dqgPmOLTK0NGVeQPw0LFua8Kd93/2VjpsWj+824MpwJmfF KJSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=4LdTXDWq3Uv3L2zd/NR5TCqm7My244nHQo+ObnVgt58=; b=cCK3P2WhMBUK55iAMyxptxQiUsdHl4Acb7Mzncc8pIZ9EaIPcFZQicTIIWtgsetIVk ncuYFeeNb5/gCh78OOoBA+hl4UVxvJR1dSGbphW5C52Wut/AUHz8Ei2f5wzAa2ipnfua 7cUYzaLn3U/qe377OOLVnNZdq2pz55J1pC5b6ugH4m60GanEPd9Pgezw8wtUBdm2hYTJ tDGMa3w6n/BshZeIx/UEHe5WIo32hW3byU7/d0sWpvIhA6XosXUTekCgwmISP/IFQXOK nB4l0U1bwcx8gAE5KnTnitC85uD/uxu8tUcfMOYApedJWNt4MtrGp/rXZBtOpVtpyQXy dBtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FqHH+Zoi; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si3704106ede.255.2019.09.18.10.21.22; Wed, 18 Sep 2019 10:21:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FqHH+Zoi; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729711AbfIRRVW (ORCPT + 14 others); Wed, 18 Sep 2019 13:21:22 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46688 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfIRRVV (ORCPT ); Wed, 18 Sep 2019 13:21:21 -0400 Received: by mail-pg1-f195.google.com with SMTP id a3so198329pgm.13 for ; Wed, 18 Sep 2019 10:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=4LdTXDWq3Uv3L2zd/NR5TCqm7My244nHQo+ObnVgt58=; b=FqHH+Zoiq7lEG9/x/GOxUNp3JykuQnt4TdgW49TajHQUWWepwS/HhcutIkbTc4TJAE 4AbCZ075/oyErat+7EzcRPMlsw1Tuq9+zLj1jiNvm389RDdDz4BbUTjHMYxbPadBeIZd AfR111JYfHvEOUFNCxRc/7NN+KyNPcw+NrlNkitfevmCkybcHhr2WyKWdy+/J5Y1xEmJ YXOY/2Fv3axFRAGi7dDcS61Kn2TdKu0obx78TJWYSkFLNgkRUdQTZALdXujWzPCdwZxh 8gtu1fggCs8ry8ZHBOmL1OBKnHT0DeyHLfNo2xrbWmSNpmpBpNvQAWqNPcCc0rRu1qrO xA6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4LdTXDWq3Uv3L2zd/NR5TCqm7My244nHQo+ObnVgt58=; b=Pj/f06zm8jxy3CF9xJ1VcIkFIMdBMfLuCygh5T3v+E2aVgeXnEvMLDfr8drQH5eaVq 2MEksuA/W68iSDkWgGHzeaAUOPMViD8LWkt6bIp066dqPoxLbjSjKIC5vF/7iFjRABox iltknZMc+28wQjkGNkjshyhOQgELRr0YRDjrGo6h4Geol+qNeQUvu5Fabnk7n6wPPvKx ymlk0Vi7hxCujHhWn+m6mhUvbDb2hS7jl4f89r4ikcJnDm6bd4PYzhMCZHGQ95G6XFQW adpyUogW8gEH/UAwXhyfxmiMaS8wGBpHjR2mXVo6in4mxbOchK1eu8Od/5RIvi7O2yiP I3mA== X-Gm-Message-State: APjAAAWDmDWz4ubDGfOhrEf/mShuASU1eVCHRMdfwbYXjws8bLy/Gfaz xfrYM29hROIKkPs08FcSUXj0Dw== X-Received: by 2002:a62:ed17:: with SMTP id u23mr5387020pfh.147.1568827281215; Wed, 18 Sep 2019 10:21:21 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g5sm6977032pfh.133.2019.09.18.10.21.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 10:21:20 -0700 (PDT) From: Bjorn Andersson To: "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , stable@vger.kernel.org Subject: [PATCH] net: qrtr: Stop rx_worker before freeing node Date: Wed, 18 Sep 2019 10:21:17 -0700 Message-Id: <20190918172117.4116-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org As the endpoint is unregistered there might still be work pending to handle incoming messages, which will result in a use after free scenario. The plan is to remove the rx_worker, but until then (and for stable@) ensure that the work is stopped before the node is freed. Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 1 + 1 file changed, 1 insertion(+) -- 2.18.0 diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 6c8b0f6d28f9..88f98f27ad88 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -150,6 +150,7 @@ static void __qrtr_node_release(struct kref *kref) list_del(&node->item); mutex_unlock(&qrtr_node_lock); + cancel_work_sync(&node->work); skb_queue_purge(&node->rx_queue); kfree(node); }