From patchwork Mon Jan 29 07:52:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 767752 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7306D4EB53 for ; Mon, 29 Jan 2024 07:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514750; cv=none; b=NBl+zMLkUkHdw3aRaSS2SzGscPuV4L6JTj5Lif2r0bCn5pOdlBirvY54lW97AJYD9MZ4rAD0zOiC2L2r3n8a/8iZoa2d7kyKf9EmFuNauRp7GLtcrB7i2GInYO5f82xzAcLR2N2bN123Kz+77fzXmSS4aI1WreF3rr4x1nfXzk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514750; c=relaxed/simple; bh=tTQT9Ku7RM1FLsAH3vWmzrAWVFN9wIhJQ1xDZJNKp4M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fIALoANM7n4AZ1QEU72MJbjZaVArbmV8/JXRdCphUFihYSDbS4apigN4q0p+F+qTvXfxcUaKcp57XAxEr0Hw1pwNtVwWpfFWMywMqBM/TuFxqqgGDUGiVFVP2MI+dIlC9xjWyYyG2o9GOG+UPBM5s/fPb1x5p8LehI3qCqHSWyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U7uXVklI; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U7uXVklI" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6ddc0c02665so780496b3a.0 for ; Sun, 28 Jan 2024 23:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706514749; x=1707119549; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hKwoviPF9lK3MXodrfrYqIC6rePNJHWY3NWvE/KNFG4=; b=U7uXVklI6V+bqjGhgkCveo05yEQd8svuDNluOwLk9kJWyR87Vq9dza+UeLyCi3Y736 x7mCw6gnmQWuujnQK+ESYbgeg/jDauLzM6sPGoJf884sfSois95itnIJRXW4DeXPL04Z plBzn3DZyLDKlU2MnTMGGWcOjX0zRquAPVCgSzJhrxWAhmEr608id+DS/0kqi+dCKDBB tiPTHqE0uIRLRCVI/s5nk97ijqEec4igZmYsi93Yt4M92BjWXTBBDC4yiiDvB7DtLuBA lRivEjK61IvUSUlYDW0WP9+AHpxMWsWWyiJ81r8sPWTyPssp+4iUADkRateto+HzIHku R3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706514749; x=1707119549; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hKwoviPF9lK3MXodrfrYqIC6rePNJHWY3NWvE/KNFG4=; b=nkADQK6YaJXERzSGhuBY4Y7jFPpTm1pJw3ZXthu7ICE82iEpJvT3K7wz5QKRSfJym7 40EKY3KEd1VlKjvYCPcGXD9860Xor2Yn0knxae/+IZ6QPCxLFOZjJVpQ/nRPlAqDc+mi ULzFqF2GZkTFlRzzYjMe/FsXsN/GtHPKJOe0ngyjEWA8HCVLaMa8kGi1BNm+CVOQH+za qCGUHWjLjIX59QDNumYK7/ylVXId3WHf9BUTHxpaopT81g2lR50HUKLrX5fbk5bFfEEp r5ojEqKm/uohikLDt8FvkRSrQgHMhXm0kq4RaQWhOEuA166ZoIO+V8R5NLQ/e286JQtK SvUQ== X-Gm-Message-State: AOJu0Yz5ZFrJ+1vRvjPmnSrnzLnPE6YQw5LUyW7vkzWrlPinUwy7sq8U Z3oaqhxbZQ7gjow20Yu8NYxQRbq3MvzcdbjN39HeBRlgzufjUiK8os3biEC2hw== X-Google-Smtp-Source: AGHT+IGeqfu9dp2sjT94pd6qtcHQFzY9slmsKzbOpFB8yRIcm2BqugXLuSHM1wzJ+Y/sUQaIjfRiow== X-Received: by 2002:a62:d159:0:b0:6db:d4f8:bb1d with SMTP id t25-20020a62d159000000b006dbd4f8bb1dmr1559157pfl.2.1706514748782; Sun, 28 Jan 2024 23:52:28 -0800 (PST) Received: from [127.0.1.1] ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id t19-20020a62d153000000b006dddd685bbesm5467329pfl.122.2024.01.28.23.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:52:28 -0800 (PST) From: Manivannan Sadhasivam Date: Mon, 29 Jan 2024 13:22:04 +0530 Subject: [PATCH 1/3] dt-bindings: ufs: qcom: Make reset properties as required Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240129-ufs-core-reset-fix-v1-1-7ac628aa735f@linaro.org> References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> In-Reply-To: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=902; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=tTQT9Ku7RM1FLsAH3vWmzrAWVFN9wIhJQ1xDZJNKp4M=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlt1ku3SWI50z6DJN+7R7fmRweEhh0xY3/ioY31 p0C1ZBGJuWJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbdZLgAKCRBVnxHm/pHO 9SXMB/4ye39b1v8wXzuxS/o1v4RtjLlLVKqi/NF7kJjRDBql/AeZp2Hf9+s5yn417kUWlbcsLVO Hv3+1bV8Qbw+vY5P9VNH9VLyX1ZbqEbk45/TCxNp9Hf++u25PNjappM18E0ZRSOZ6EIFrmMHdXl eMcLxBY1kDQjvrbiawIdtPEG7SVhafiLkxL/cnOfCj1bWhvr2n/LljnEtLqsu9eyjHnrXmEjSTI FoGhc2e0gJCJADNnkl5dQLibYNJYd+8yNws4LHbb1L3+A0AfU/lTkaSXNsBnqZ86OO+Nsuj2kWn OpJjH2fcgHiXyuNP7M6bKXa44uyTFSawclFl3gxssnvZ1wIO X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 Apart from the legacy UFS controllers that were not supported in upstream, rest of the controllers do require reset property to reset the UFS host controller. So mark them as required. Even though this is an ABI break, the bindings should reflect the capabilities of the hardware. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 10c146424baa..03dce5e402d1 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -108,6 +108,8 @@ properties: required: - compatible - reg + - resets + - reset-names allOf: - $ref: ufs-common.yaml From patchwork Mon Jan 29 07:52:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 767751 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B81C5578A for ; Mon, 29 Jan 2024 07:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514764; cv=none; b=u+7IIAveoUbE/K92Akko4YiTSCgJkwNsBLhaNrsUpMeegN/4Hl8RHzi7kRVkJKSPncEd13OoHEaDrMMAxkaDA9TVk7uEQ4StKCqiIsZeH6+LK4u8q9ygFIqXf+m2m1NwWaDN7ZgFpaIav4XDNFrtWKbC3Jn833wr4HFAom3oXro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514764; c=relaxed/simple; bh=RDS3ZoaA8gicslZTrtrM9BW7KEYbWoKjgQpkJyCx8uY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iR+wtY5V3pE5fn8cXcfXT+MGJkEqGK4B+GHYTUedD01kxCtgVnu0uhntKTdbuyPFNi3AzUV5QHo8bQddbQ5IGtn+ShYMzVLSaXVqMttQCQG+Y40GV7YNCzuCI67VHY8qkr6/ThCxw0hveYs2GhSOMbZCkpoG+utogUqINDXVkdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NTriMtlb; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NTriMtlb" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6ddd19552e6so927460b3a.1 for ; Sun, 28 Jan 2024 23:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706514762; x=1707119562; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HGZmbpiHB5LcToFKY964Ba6HaP984WWJZXhD/o2NB2w=; b=NTriMtlbgQ9gWGdhuTLfp7kOfewZ9dOhrShHIqE04fgyjiv0oLnuMashYpUGSoDKUS Os6JofK2JZN1yMKVBybAinCkyOZvmYo0sBIpMBdT9gN7Q9OzdCfTyOK98shb3pVpeqYs 2Gchyak6cR0mk1LNpNk8vOXqDT2t/tbPaMMlRw5nkpSoFaVXeEes5vljQTsVU8Tr4Hr4 Tiv49PpBDp3RfhZSOoJPlJ8mRisef9YRv3zW8KPq4uMtwkn8XiehEMhghOQd22gaXPI7 /1tHuGBaR6oWD5MfV1luEVaScaMMj5tsz+0N0Xrs1nT+tTrq544HFl0xgiTUtbBgV5c6 roxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706514762; x=1707119562; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HGZmbpiHB5LcToFKY964Ba6HaP984WWJZXhD/o2NB2w=; b=HHlfr6fzXm3bj8AWK0GfCghoQca/6c9lknS7YMKaicrtu7MB4TugL3o6cVSWBnU5Ak 5yTYAQvs03xrZFIo070BlS8rseNADzVQQWxC+e58bRRLJHL6zpWU1D0WSdJ4jFzOurxF WMF5ftzmoZdyTZZKAAPNaFWx1f92bweMCnc7vFgQTogyFh/3b6MRD60MZvupfUze7KfW +hMFQZLFVevUg33s30CDxsiU4bAGd6zhFuCzNMADyBZnH404TsDZhtpnfdZqcOYlHAxV w2QUMzmC/dq3Ny/YYKg+EojpojRkRX87I7UTsOk95jY6M2UZ4ljVptsapAbNrkasv9cd 5HCw== X-Gm-Message-State: AOJu0Yx41cylZrjqa6zcwcsx/mq4ZAzRHqzXNTG0bHTebXH9h2eqF1R+ UI7wXw7HYSZzI7yWSFrGvkuujW9yDQiCdlKxaVS6D8KYpiKmRh1QcbGawRqY8w== X-Google-Smtp-Source: AGHT+IG7K/V3h+UiJFEyIIYzNIW2m4V7VPWv9oD65gGdio9qLk5mVc2U/DAxYQsCC9mZ0qepdxBZUQ== X-Received: by 2002:a05:6a00:138f:b0:6dd:dbb2:8ee9 with SMTP id t15-20020a056a00138f00b006dddbb28ee9mr3441304pfg.6.1706514761954; Sun, 28 Jan 2024 23:52:41 -0800 (PST) Received: from [127.0.1.1] ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id t19-20020a62d153000000b006dddd685bbesm5467329pfl.122.2024.01.28.23.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:52:41 -0800 (PST) From: Manivannan Sadhasivam Date: Mon, 29 Jan 2024 13:22:06 +0530 Subject: [PATCH 3/3] arm64: dts: qcom: msm8996: Add missing UFS host controller reset Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240129-ufs-core-reset-fix-v1-3-7ac628aa735f@linaro.org> References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> In-Reply-To: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=871; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=RDS3ZoaA8gicslZTrtrM9BW7KEYbWoKjgQpkJyCx8uY=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlt1kv3559B3ZmFp95EfvcA/qs983RKuPwQsFLJ LOoamFISWeJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbdZLwAKCRBVnxHm/pHO 9RiWB/9WYqXIx/kGqIVlP6rmJnnmWoZjyVR89BVi3fUMSh1HRZwHrR2Qbe0sfSxB4Kr5zeeQcrD 3XfbKs+eu2nqNfxqSlUXVurUkB/bFQCGu4oQHvhiWxCYTA4/s3R7XM/7HmfClsFlY1UaYFUujXa AGEHJrzYPPK+XWMEuM4aQ2WEOYUikKu1BzU7755v2OPYwKeDcIH7WlHdDg6+/N4VNUZmjPq375P eFKciTWzxm3x2bSxck9/uOJ8dm3p0BmjFkgrZ4Cmg3J2tiV2zlZBfgXrI1BgPaKG9/wud2jkPUN gH73zWmaXnDESGrKZZOaYYP4+0kApTt1ReGO+UV60bG1TzO4 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 UFS host controller reset is required for the drivers to properly reset the controller. Hence, add it. Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 8d41ed261adf..a6592b3e2db7 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2114,6 +2114,8 @@ ufshc: ufshc@624000 { <&bimc MASTER_AMPSS_M0 &cnoc SLAVE_UFS_CFG>; interconnect-names = "ufs-ddr", "cpu-ufs"; + resets = <&gcc GCC_UFS_BCR>; + reset-names = "rst"; lanes-per-direction = <1>; #reset-cells = <1>; status = "disabled";