From patchwork Sun Jan 28 20:45:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 767265 Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473252E832; Sun, 28 Jan 2024 20:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474926; cv=none; b=aoyJQ7kZ64KPauof89tLXAZvdXwq8JqvHihMdFG4Wuw1L2dFlLQLL0cmZn3v5YkGRPn3xH+F/tGfX8wLsQTAw3LRCly0msb3FShPhoD8YyKM3nv+4AilkSFpbZcKmNTwo0UpMeA1VI99KrY3p+4Bmuqp+EgiTktSgdl6a4P/8tU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474926; c=relaxed/simple; bh=ag9tr2tiU3unZXuvPUm4zcESACgalTxlviYKmkloah4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nxIMx0TR3bZVBwcdG5Z/rBrBzHFz1UYForxoh8XoH8fiVZsnzgXPz6ipZ43jrpwvKTjsVT9E7R1MkW/L9uQGo2Frus43hwBTwhvqmCC/55KSLdIbuug8E1JmPiIH6JXyb6/RsqtPsG+TH+kh0JCdloTfGE4e9dQ1LiO9W3mzbSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=bFmkZPm/; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="bFmkZPm/" Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 414794653B; Sun, 28 Jan 2024 20:48:42 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Date: Sun, 28 Jan 2024 15:45:09 -0500 Message-ID: <20240128204740.2355092-3-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: ** X-Spamd-Bar: ++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474923; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=LF65+XU8LGrrA9Zpn4EYhMkrdltaZDZoBBCOReuYI8w=; b=bFmkZPm/+Yyttzt/b7BF92FqLnBgnS1PONw3BdS3t253B/ffa43+54TaQ8sg3Rb4Ig/Wzo Paho7iUNgddGj8+9a/Thzyj9W38GTjreOru4TPAdIPqVdQGr8aeSPsNbTA5wIMUqVQiH0F fn/n6G+oE80ZW9yQmoCUfHCDouUFUd8= The red, green, and blue leds currently in the device tree represent a single rgb led on the front of the PinePhone. Signed-off-by: Aren Moynihan --- .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index ad2476ee01e4..6eab61a12cd8 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -39,21 +39,21 @@ chosen { leds { compatible = "gpio-leds"; - led-0 { + led0: led-0 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; - led-1 { + led1: led-1 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; - led-2 { + led2: led-2 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ @@ -61,6 +61,13 @@ led-2 { }; }; + multi-led { + compatible = "leds-group-multicolor"; + color = ; + function = LED_FUNCTION_INDICATOR; + leds = <&led0>, <&led1>, <&led2>; + }; + reg_ps: ps-regulator { compatible = "regulator-fixed"; regulator-name = "ps"; From patchwork Sun Jan 28 20:45:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 767264 Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CB33D568; Sun, 28 Jan 2024 20:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474932; cv=none; b=okGhcue5hG0yueaezKnh0BqhNSMRs2PUEa0GFzhGfQOxPQuzc6KXxc1VXESqT8VaLxiQidz3VSNrJGav2F/Hf4orXc7l7GrwosEakVorVGnM1XPD5ps0FMsQ5wcunksgnqxviaceQHxl7G+Sw3nQYxXN/UKPqudQU7wreEejSyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474932; c=relaxed/simple; bh=0llpIrBcrSsgkq+tDt1UudYHAWxp0O8mGXQOF1XSgn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VOFuyXajjpI9cES4T0zLQasnOgyrkULcFwVe5ivt21yCcPbzRoKzNTbaGUHyeFMsxj3RAuZ/XH0hzh1L3gPHcARMMw+0hFKRQWvK/pSgB+GlBgx9KRuD5y4q1J36Zg7mhCG50AUt0S16Oz9gPGUQWBh6hdIFocvHfLHSLsVRCXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=LCKLWsPl; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="LCKLWsPl" Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id F2CFE46366; Sun, 28 Jan 2024 20:48:48 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Date: Sun, 28 Jan 2024 15:45:10 -0500 Message-ID: <20240128204740.2355092-4-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: **** X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474929; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=d/DBwpJ+je99z0h/gXOCUsLpwa/Zbmn1hRkJbFumB7A=; b=LCKLWsPlqvRQtiFZG1vk9RGo0PpHdusVxfhM+KBizv3IAzHDsEBOKiiqeQm2cRJysOQFlj yPD70phfaq/ONb8DwmyRcEqXprMWwQOEdEHKTscwSMPBAhH8XM4LwjOs+hHD/8GPzG1smq Sh/bcnY8qMKjVHRvgiSCewPgy+j4XG4= The status function is described in the documentation as being a rgb led used for system notifications on phones[1][2]. This is exactly what this led is used for on the PinePhone, so using status is probably more accurate than indicator. 1: Documentation/leds/well-known-leds.txt 2: include/dt-bindings/leds/common.h Signed-off-by: Aren Moynihan --- I can't find any documentation describing the indicator function, so it's definitely less specific than status, but besides that I'm not sure how it compares. Please ignore this patch if it's not useful and/or just causing churn. arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 6eab61a12cd8..4f39cfeb13ec 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -40,21 +40,21 @@ leds { compatible = "gpio-leds"; led0: led-0 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; led1: led-1 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; led2: led-2 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ retain-state-suspended; @@ -64,7 +64,7 @@ led2: led-2 { multi-led { compatible = "leds-group-multicolor"; color = ; - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; leds = <&led0>, <&led1>, <&led2>; };