From patchwork Mon Sep 9 15:21:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 173384 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp4504808ilq; Mon, 9 Sep 2019 08:21:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqyfwYyOE3Upgjbtlnk4wpjO9whXPDEHMYvjrlkUbPYhzRL16vKQuCqvsKKC3qI5pRv1UdSo X-Received: by 2002:aa7:d899:: with SMTP id u25mr23744444edq.289.1568042482476; Mon, 09 Sep 2019 08:21:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568042482; cv=none; d=google.com; s=arc-20160816; b=VCpbx4VR8FpF4A5ckllg3aYrxRr9IJnJlL5EoushR1h7cVItYkAXlN0qR91SQ+WFsQ WQ+2aYd2XdYUNg4guXFeiYj9+xQTY10jvqTNNTxufyJOS1B4u933UjyyFFOP4fTOiqou G9rGBVVbnsgVl+vcGIkivCIOhOuGnTib9LuTRj/XbFSVhAR7ukff1MSrU6WZ4f9k8fI9 PzFaDAZ8Q9HfmpYetkefRtRQ8NlpESgV9y6vEj5bJlybTJF0CtnDFBtrgTIYAQcvR/j5 jARo2m6R71nt31Y0cfnENCTjCBCrSKTXGJYPYz2aH3lzLlfTnFokjKLXLJPfh7SSU6rs JZHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=O6/G6l68m4DRquWTjAU4CSEvzlcQw46vtPXqcLpWZGw=; b=BpW5XNqbOVDYtWBdQfOy4KNbHFVhFv0is97q4NBvdWEqchxVTWTfWVtn3iwlWO7Tyl sLioGqIxLnoiL+Io0rmT4fq73Ap5Wl02HqWzunQjDNKejnqtopqD+ljYLm1TbAmqAWvV 5CSzJulLczqT2e/7nnPhqVHYofcV7djgl4zLlfaJeLPk3yarfjiZuNpwYqtA3miXFEzC HBfP6P6QI7gHg1U1wyiIT7KrYsMFkC7wSmohBwG3i7JwCLeUCT90jHDzmMGF980t7Pe7 fB6OKHuoC+jMSYvCeDBs1U47gS9RVfeqFuPl947T1t/guOqtIqPIhmyP/obYWivrpHog kPuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id um3si7818214ejb.391.2019.09.09.08.21.22; Mon, 09 Sep 2019 08:21:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728698AbfIIPVS (ORCPT + 28 others); Mon, 9 Sep 2019 11:21:18 -0400 Received: from foss.arm.com ([217.140.110.172]:52494 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbfIIPVS (ORCPT ); Mon, 9 Sep 2019 11:21:18 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5285D169E; Mon, 9 Sep 2019 08:21:17 -0700 (PDT) Received: from usa.arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CEAC63F59C; Mon, 9 Sep 2019 08:21:15 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org, Etienne Carriere , Philipp Zabel Cc: Sudeep Holla , linux-kernel@vger.kernel.org Subject: [PATCH -next] reset: reset-scmi: add missing handle initialisation Date: Mon, 9 Sep 2019 16:21:07 +0100 Message-Id: <20190909152107.4968-1-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org scmi_reset_data->handle needs to be initialised at probe, so that it can be used to access scmi reset protocol apis using the same later. Since it was tested with a module that obtained handle elsewhere, it was missed easily. Add the missing scmi_reset_data->handle initialisation to fix the issue. Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI") Cc: Philipp Zabel Reported-by: Etienne Carriere Signed-off-by: Sudeep Holla --- drivers/reset/reset-scmi.c | 1 + 1 file changed, 1 insertion(+) Hi Philipp, I can either take this via ARM SoC as the driver is getting merged through ARM SoC tree, or you can apply this once it gets landed in mainline. I am fine with whatever you prefer. Regards, Sudeep -- 2.17.1 Acked-by: Philipp Zabel diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c index c6d3c8427f14..b46df80ec6c3 100644 --- a/drivers/reset/reset-scmi.c +++ b/drivers/reset/reset-scmi.c @@ -102,6 +102,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) data->rcdev.owner = THIS_MODULE; data->rcdev.of_node = np; data->rcdev.nr_resets = handle->reset_ops->num_domains_get(handle); + data->handle = handle; return devm_reset_controller_register(dev, &data->rcdev); }