From patchwork Wed Jan 3 20:15:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 760446 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1125C1D52B for ; Wed, 3 Jan 2024 20:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dOm3VXUt" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40d5336986cso106972435e9.1 for ; Wed, 03 Jan 2024 12:15:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312950; x=1704917750; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kA0goKiU/w/eOBM3jnw0mpxXWTxX87LBykvS1BaWQpQ=; b=dOm3VXUt/EeoIsMTvSAnDt/XmoLhalSCRx8G014/9eMD2CtkoIgCpNibv09ZWATFMU Vg/2jRcWgIc8+ZslYud81p0OpfjW7YA1T2dKtQPAhPgu5UtMan1ABaLRZU9q6+w3M9OU 70wyWjgOrt54Cih4a1LGIj+/7Lyvely+s+HRQpnWR31KnpypX6c8gg6qdnytLcRI4hqa 5VzAjrEyaKqsWIMJnRnUKMXUQ7A0HigCEtoGJn6yiEfcTYx7HVidtuvpkw8huyMpUKvn uxsTHyD86Fkt2Nxlw2APJy9zW+FByCYfMGWgVbzlyyTIU3DRWf62hN2Pj/4MTLUN8ex8 2pLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312950; x=1704917750; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kA0goKiU/w/eOBM3jnw0mpxXWTxX87LBykvS1BaWQpQ=; b=sGH4KZGGbgfKFN/j0YiWDmD1xFe52PWrCM+NFrWteIPfV4IAOu5EG0ROZ6HiA7zmqq 0ROHvXkrCPL1vWEznB+eXI5HrxjdfjPFA/rbk4ri/8OZoQmxDWGHIfmGgAVlJjsvzZTV dISyF+YrnrxxQ+J+uckX3XN3y0E9J6QjJq52oH/kp5l3BtYTpokKP6rhbniTubmAN4rz 87VnfwbcUC65/eux08bMMMkXZqymbDyPNpByyA5krBTdjs3j/p7xGtSa6d6jIIyUpl9f Rj4MTqXXOpu3vBCkMYl88PpPxh2+unxfnL94C1Be4hrMFkk5IvUpxHMZD4t2R54IjoW0 dPSw== X-Gm-Message-State: AOJu0Yzv/vM2Ua80BCq2CgcXh/FoyXBK4S4rzX5bDVGqSBd+ELYTf9Ia fvcqMfLZU23gsRNDEUHehLxUsJ0QbCEdJA== X-Google-Smtp-Source: AGHT+IG4C77xT/Mm6jNN5jpYils2zCkudK+B5GjU9oJeIhDRBtCpW291etSan+mLgVzx4z+hpzglnQ== X-Received: by 2002:a05:600c:3d8c:b0:40d:83c4:ff34 with SMTP id bi12-20020a05600c3d8c00b0040d83c4ff34mr3624896wmb.133.1704312950359; Wed, 03 Jan 2024 12:15:50 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:50 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:31 +0100 Subject: [PATCH v3 1/9] dt-bindings: usb: qcom,dwc3: Fix SDM660 clock description Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-1-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=1330; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=2zYtbmnPKi8lLyIi803aWMWnlOZwvsMRdhGUfkJMl0w=; b=Ouo9OU8f7I6J1dCDUCpa1GERSaWBKioAqR3dCOfE7I3avHasuEWB2EY+44edvTFHYUr61p+bf EGvqd07Mxp1DSnrryk+PoSgSVMrzaWXPbXLwU2u4YWIZciYElrAoae4 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= SDM660 was abusingly referencing one of the internal bus clocks, that were recently dropped from Linux (because the original implementation did not make much sense), circumventing the interconnect framework. Drop it. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index 473c4bfaf8a2..967cc6db56fa 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -291,8 +291,8 @@ allOf: then: properties: clocks: - minItems: 5 - maxItems: 6 + minItems: 4 + maxItems: 5 clock-names: oneOf: - items: @@ -301,13 +301,11 @@ allOf: - const: iface - const: sleep - const: mock_utmi - - const: bus - items: - const: cfg_noc - const: core - const: sleep - const: mock_utmi - - const: bus - if: properties: From patchwork Wed Jan 3 20:15:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 759812 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A61CA1D541 for ; Wed, 3 Jan 2024 20:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LaXd1qRG" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-55642663ac4so3156757a12.1 for ; Wed, 03 Jan 2024 12:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312952; x=1704917752; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pDBL+ZocNtOP6hdOYdCIjY2YelurQjTsh53hsAvej2s=; b=LaXd1qRGQ0wa8uJINhDf0axDrJbOUQvQ2XG70f6OzCKJGjJ+iyaF3YQRf9Anc7+IN3 2FzUyvO3jjjRwlWWkdK1defGim0FtMZGON89EqchFS2+YIsc0K/eoVxb/Xk25wEVBPzU UU44XzMXayA7MOiOHw012rZwtcopXIgy2uuxffqJubXVLqk4xUhi1yxGpJ0sYSUmW4PW 5HldCB9RF25QsrSarbmOYf4J/Uwiu+fQuiaZy/EbOonlJWnlvkdqHJuZQxyVCgKXxXY9 wxhl/JfVM//YBOMSYsZwg7dNSqq2y7UtdFKF+X52KF5NrhpP1OuGlIcWvvKOp+BW2QVg wX/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312952; x=1704917752; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pDBL+ZocNtOP6hdOYdCIjY2YelurQjTsh53hsAvej2s=; b=C8L6fl/loQwYNprmlb15pRY9jZggfjqtBMC901yZLjn7S6JSfziW4tShKeiqgBPOYD XtH/OGr2WPliriZsHAgaWQuhKD8aIblRhlgfHCJgsmhS9aVcl7Y0xaChY3Gne+DiQMMz C42IzPPQe2/pUDn3EyUhoNvWl/0nxcrUeW81ibmfSDbMS1PeqIrs8G3LaAMTqCBxXFV/ U2xLzdjxyB+yiYONBXfskOcumKtJq6JnmBjZgnMTVrjdehVZxLoS9cAX6lI78UI18UML hBhNd/+cgBStKRzztlylGOKcXJSJGtvEMw+UpH6szlaaExRU3qlt2+EbtzW3ekirDscI Y0og== X-Gm-Message-State: AOJu0YxaDJ0bXtmugyFq6rwJIO9d7wiNOAzqL72z7yRW9tS8wGOGEyd0 CSJu64pzGGREX6hfIoi5RjB0bv7CL1+Bww== X-Google-Smtp-Source: AGHT+IFq8/tH9MdIJtzW2XmGC4rUW27NUasEFUqz6pRuL6RPg4bUdev1qVb/uaXX1RqljrAB4L8dtA== X-Received: by 2002:a05:6402:228a:b0:556:f13c:f537 with SMTP id cw10-20020a056402228a00b00556f13cf537mr104634edb.66.1704312952133; Wed, 03 Jan 2024 12:15:52 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:51 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:32 +0100 Subject: [PATCH v3 2/9] arm64: dts: qcom: msm8916: Drop RPM bus clocks Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-2-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=1623; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Cb6EkrvDlISC/vJRhBJBoI3xr7u+kqmI1z+hE1DNnAQ=; b=XAndl2eWyF+UJpGi5bb0fmCJjHBpe4Yha4R6ToFN5IPMmLxgOzRBBsv9MrICCEYrwn72ddNcN wciE6o3Ppu2BOeRkwg7Fb5h2MWLZLQbtRennRYZ5K7vDjjc50G5ELXb X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some nodes are abusingly referencing some of the internal bus clocks, that were recently removed in Linux (because the original implementation did not make much sense), managing them as if they were the only devices on an NoC bus. These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 7f8327b0dbdb..e423c57ddd41 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -540,9 +540,6 @@ bimc: interconnect@400000 { compatible = "qcom,msm8916-bimc"; reg = <0x00400000 0x62000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, - <&rpmcc RPM_SMD_BIMC_A_CLK>; }; tsens: thermal-sensor@4a9000 { @@ -575,18 +572,12 @@ pcnoc: interconnect@500000 { compatible = "qcom,msm8916-pcnoc"; reg = <0x00500000 0x11000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_PCNOC_CLK>, - <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; snoc: interconnect@580000 { compatible = "qcom,msm8916-snoc"; reg = <0x00580000 0x14000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, - <&rpmcc RPM_SMD_SNOC_A_CLK>; }; stm: stm@802000 { From patchwork Wed Jan 3 20:15:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 760445 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BBB1D6AA for ; Wed, 3 Jan 2024 20:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CUcD8wsR" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-554e902064aso8605825a12.1 for ; Wed, 03 Jan 2024 12:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312953; x=1704917753; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QG+rGUp/aDbPyreho5pBvmK90jeiza6JiQ/BR4I5Rh0=; b=CUcD8wsRiXRm8uk694dGxz53rBzS8E5Nz/4HYu0rx9Wgp3IRcK16XxXtNXsg/b6GKN VEzgyuLeTLoXoAN9p9sDT9Agw7ZeQHI5Q0bC5Li2fhVAf92nVCS5j+HjPxb4qkWe/07+ J8lhucf04ZJp8jdzShh0DJdfjP9MWHo6tm/ramzycPe6ZhfMh9unIlu+lDIMv/Lwn4yQ 5SlDJXZ1Dvgd8GRZglFAafVc4xjXSp/pBnmj541ILaE0Gma6qkJHVfu2aE7Qy7TsheAy ub71iEyorLOOcoT/2Qm6VTV9fby0MIKFdFllgmZeWI3wtPdkwt89HRdIDfVw25ky83u0 FEIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312953; x=1704917753; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QG+rGUp/aDbPyreho5pBvmK90jeiza6JiQ/BR4I5Rh0=; b=dAc7S22CQ0yxjeXY8+PcvSV8GLrbvVCLwlyHUqRSYzHtYjoD74bXfxPcUno5Tc9MgW NxQgG6dSB7F6/S4QiLlW7p7Xo8MpJhuEEY8KydUslRVHOqOEA6RUggqc9xxoYG/WUP9u Bpq8Ibop/zAIDp/zlObO47jdYLnf5FIPylIt7TSpOZDFo0EQpW413sn9DRmUuV2clTaf dknQmMAOFfmrOrkQtxYtfIHfUsNpJnFrBdZLirXE+FeMXkTSfI5xomwgvskUzCEK18Yf TcDNiDOwxDq8CEFd1ttutxLxxpCbHc1f2NnLdSJXBLPnL7RenPmPiRWRzculpnYWScZ2 lkrQ== X-Gm-Message-State: AOJu0YzNwg76uDbr5wDsBN8wZUKY45aapUedt5l+1RNvrQ7xMWwr7V8u CSllBO3hGsklTNy2yc/ptbELKRv86ZEpdA== X-Google-Smtp-Source: AGHT+IHQmGjzP5vgapA4A+rsvLd/epbRl1zsiwJh/v4sKcG8w8L/6Wy20/D3bS2kHz5i+oOyNfjbtQ== X-Received: by 2002:aa7:d997:0:b0:553:9c31:b4ab with SMTP id u23-20020aa7d997000000b005539c31b4abmr11520614eds.19.1704312953788; Wed, 03 Jan 2024 12:15:53 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:53 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:33 +0100 Subject: [PATCH v3 3/9] arm64: dts: qcom: msm8996: Drop RPM bus clocks Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-3-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=3085; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=YxJ1U7v2W6bIKmc1zORJCie36EHFesuD+RzyvvnJwE4=; b=Ib8hCQrhv5eBT49OArc3ay46lRUDtnr9udu3AJdS6d3VAK2bMeZkXVIvdF0bukxrsE18F3G7n NAeD35/S/gBBR5+my4I/uHa0PK4B0qdbzzrwKmEVwhVxhZRsJeRajGV X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some nodes are abusingly referencing some of the internal bus clocks, that were recently removed in Linux (because the original implementation did not make much sense), managing them as if they were the only devices on an NoC bus. These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 27 ++++----------------------- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 8c6a7efa90c4..4f465ac573f5 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -838,9 +838,6 @@ bimc: interconnect@408000 { compatible = "qcom,msm8996-bimc"; reg = <0x00408000 0x5a000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, - <&rpmcc RPM_SMD_BIMC_A_CLK>; }; tsens0: thermal-sensor@4a9000 { @@ -891,18 +888,12 @@ cnoc: interconnect@500000 { compatible = "qcom,msm8996-cnoc"; reg = <0x00500000 0x1000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_CNOC_CLK>, - <&rpmcc RPM_SMD_CNOC_A_CLK>; }; snoc: interconnect@524000 { compatible = "qcom,msm8996-snoc"; reg = <0x00524000 0x1c000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, - <&rpmcc RPM_SMD_SNOC_A_CLK>; }; a0noc: interconnect@543000 { @@ -922,19 +913,14 @@ a1noc: interconnect@562000 { compatible = "qcom,msm8996-a1noc"; reg = <0x00562000 0x5000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_AGGR1_NOC_CLK>, - <&rpmcc RPM_SMD_AGGR1_NOC_A_CLK>; }; a2noc: interconnect@583000 { compatible = "qcom,msm8996-a2noc"; reg = <0x00583000 0x7000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a", "aggre2_ufs_axi", "ufs_axi"; - clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>, - <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>, - <&gcc GCC_AGGRE2_UFS_AXI_CLK>, + clock-names = "aggre2_ufs_axi", "ufs_axi"; + clocks = <&gcc GCC_AGGRE2_UFS_AXI_CLK>, <&gcc GCC_UFS_AXI_CLK>; }; @@ -942,19 +928,14 @@ mnoc: interconnect@5a4000 { compatible = "qcom,msm8996-mnoc"; reg = <0x005a4000 0x1c000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a", "iface"; - clocks = <&rpmcc RPM_SMD_MMAXI_CLK>, - <&rpmcc RPM_SMD_MMAXI_A_CLK>, - <&mmcc AHB_CLK_SRC>; + clock-names = "iface"; + clocks = <&mmcc AHB_CLK_SRC>; }; pnoc: interconnect@5c0000 { compatible = "qcom,msm8996-pnoc"; reg = <0x005c0000 0x3000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_PCNOC_CLK>, - <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; tcsr_mutex: hwlock@740000 { From patchwork Wed Jan 3 20:15:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 759811 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 109391D553 for ; Wed, 3 Jan 2024 20:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Hcsnh19l" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5534dcfdd61so1500260a12.0 for ; Wed, 03 Jan 2024 12:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312955; x=1704917755; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4Lh+gX4BfitGRmiyCa+I+reBWxcyX/LBKMQuNUp0UDA=; b=Hcsnh19leAkOapYDv0PoJGXelrH2ZPbC2xJYS3CM3EF4sFAReyi2PCBVSZVVWV28xT pBa+NLGE2W+csKxFvHB+3qOJfmzhVKMDlDUU3jjXWUKFYp0kbcpPc+Cx373vtGQQKli2 PcNHtByODljypjmqlh7IJTJlpi/IPy/E1cR+5EP8lnL/+Xg9ALpgz1U3n8OoKTR5riUG u85W+5a7BFXT1QpLjgH7OaMBnIRZAuBNWgHgMK6njWInKykT5YRwveRswgA8SUQ8gtTC ekaxA6v4/OnLA7wIZgBMPnMw4kty0BPg/4EGfn7ttgi0t12NgZy0JwNL9y0FdTLYwaxM +VYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312955; x=1704917755; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Lh+gX4BfitGRmiyCa+I+reBWxcyX/LBKMQuNUp0UDA=; b=K5WOmPe5SVy2pSaUhUA34PB4Keb+4lvLtkdE/IRKBISO8OAw/aDjUVQVXtFQz+8DK2 5TCT+xwbqIEnfDRN2UYGzSCSooaCN5HDHoWuoEH2guqoBZWbAkEe64yDK5iPOFh/X3vb 6/0YxP65JkIhg1wNQ4bumAB5Rwu1MuSsfVyygs646D4wVCt5JJ67wq8HmQ37w53sg47+ hWqYbQqkOlU9+GTBFzeNbF5axPyyLDz35SmEzUqcpLGVnZlYagrRlR31J62SidtsFO+o SWxYr6Fv0414nLLpBEYUU5qvWZhkIcLhsZHMySi1dQ1EwEsfmIVIHoZ5ZwfgDPsYSw0i QHPg== X-Gm-Message-State: AOJu0YyhLknbNqbqijd1vpnZKLGbsKFH6nytaIBdRI0czq2+b2kqz2t4 VDQMLLh5gxwVh9uRQSPDL8arN14MMg9pBw== X-Google-Smtp-Source: AGHT+IFyNHI/21NMgd78PoKefXi8DOIpxVyqBZolldwU+OuruHiNPgHIf/Jm/DhZTUUnerNIJHtYNw== X-Received: by 2002:a50:99d0:0:b0:552:574a:5390 with SMTP id n16-20020a5099d0000000b00552574a5390mr1581036edb.15.1704312955616; Wed, 03 Jan 2024 12:15:55 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:55 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:34 +0100 Subject: [PATCH v3 4/9] arm64: dts: qcom: qcs404: Drop RPM bus clocks Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-4-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=1629; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=PsNkQMZIizOIi2f/yNcFOg+NCxoRsS9FEjGHx1dSF5s=; b=VxrgrvAwp05inPdPB+oyWRuE5+jWuGB4k/ubcB1SjcLwr5TQh1LtdeCAk3DBP24OxDi9ct7h4 BaEMKkjXx5HBFMvuoNzCdH9SPtiD6EAAEkIBzxMWsjcrWMunTUXQRwa X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some nodes are abusingly referencing some of the internal bus clocks, that were recently removed in Linux (because the original implementation did not make much sense), managing them as if they were the only devices on an NoC bus. These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index 6ac64ce9bb68..2f2eeaf2e945 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -558,9 +558,6 @@ bimc: interconnect@400000 { reg = <0x00400000 0x80000>; compatible = "qcom,qcs404-bimc"; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, - <&rpmcc RPM_SMD_BIMC_A_CLK>; }; tsens: thermal-sensor@4a9000 { @@ -601,18 +598,12 @@ pcnoc: interconnect@500000 { reg = <0x00500000 0x15080>; compatible = "qcom,qcs404-pcnoc"; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_PNOC_CLK>, - <&rpmcc RPM_SMD_PNOC_A_CLK>; }; snoc: interconnect@580000 { reg = <0x00580000 0x23080>; compatible = "qcom,qcs404-snoc"; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, - <&rpmcc RPM_SMD_SNOC_A_CLK>; }; remoteproc_cdsp: remoteproc@b00000 { From patchwork Wed Jan 3 20:15:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 760444 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A8B01DDE9 for ; Wed, 3 Jan 2024 20:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j0n2mIwV" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50ea9e189ebso528308e87.3 for ; Wed, 03 Jan 2024 12:15:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312957; x=1704917757; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WlRGkSxspqLt8e6uj4TsPbjrXxLpOwfPHKo5tpzsP1U=; b=j0n2mIwVTvGSqDWyYser0LZwVW95yXczmYnenMlGuJOClM7NXi+3c8E/gUopyfkB7n idLW0Y/ECQC8kzuMvNbI2v8XIes6SWAR5FtfH67pJ/N7gFEQoYJCdwTgIEx0TfWpl/Nt OrOnAIg8lYGDWrLDGsWy6S9KvRMBo8bKYPghWHgLLT08utjbfyd+oRJsqFDV4euUB4m+ YKpyR2Ee3mRfgvzI+GihQsDBaLGDIF6f7oJT5IbMIIoINGSyC1T/0AMYpFLAxQvfKsJE oBUMjZfF9fDraSKyd+dflxywqoY6u7NQF+Z5zGlMGeCPLdKn8Q20kL+K5f9Z1STxYMlM d0hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312957; x=1704917757; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WlRGkSxspqLt8e6uj4TsPbjrXxLpOwfPHKo5tpzsP1U=; b=Fe1vf5/zhDRtpYA4+YQOhgm1t0Oy3YoLsnN+xjgswABWHj8+xncCrECcooH5xaJi1d 5Pne5r6yfnmnxAB/vpbPZ8cHKkVu7wcV/mIbCEY5rOLKfQ8Kw7aKvgJQc6CkS+2M3PHJ DZCmrat6xCslGy6K8gSIluqFbPr/ETm0FrPWPFXmzos7zqbxdo21HC3IcDQw/7FM6nJ9 hQgGOivUAkGzKsPy5jJnsuNrEC7DVQ1dig8FjvFwcEzOt9dSQ+tSnztZ95XTx670JREH R0XTM27KWDyH8U5UUBSIECrNDSEjm9+Na2y1w+WKplmq/urH8D2q1Kz2pDsbPUUnigWl So+g== X-Gm-Message-State: AOJu0Yz46oRc/1AA1AAitvM4gpcG3Zwnd/3kp83LwPbyyiZAZEj0ySIb MF4L1xBf8fb3sQ2ScERzHLjVGiipmROzxg== X-Google-Smtp-Source: AGHT+IEVvy0cSxkpkQE7xYVxHf/U0MKSkUruQtZANnzecQeQ2YZwnD/BWk8zALBpd1fT9kVrswLqCw== X-Received: by 2002:ac2:58d7:0:b0:50e:2737:f603 with SMTP id u23-20020ac258d7000000b0050e2737f603mr7182940lfo.48.1704312956978; Wed, 03 Jan 2024 12:15:56 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:56 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:35 +0100 Subject: [PATCH v3 5/9] arm64: dts: qcom: sdm630: Drop RPM bus clocks Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-5-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=5031; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=cl8sg1LTCxzGU52mzB+vk83BznWR80LOUN+g9wXpRf0=; b=pvj8+pAQlY7Mrw9NDRswB7bRzDGoa0CzPM1aqi5SgUUCLigue33wE/7OY8OyV9EaJGEsyVmEu RxTOKHepsBQCfIH8MRcYuTLSVHAyZ3EilGt6Q2fSgp7YQK+vvmOC7jk X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some nodes are abusingly referencing some of the internal bus clocks, that were recently removed in Linux (because the original implementation did not make much sense), managing them as if they were the only devices on an NoC bus. These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 53 ++++++++---------------------------- 1 file changed, 12 insertions(+), 41 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 775700f78e0f..513fe5e76b68 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -606,9 +606,6 @@ bimc: interconnect@1008000 { compatible = "qcom,sdm660-bimc"; reg = <0x01008000 0x78000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, - <&rpmcc RPM_SMD_BIMC_A_CLK>; }; restart@10ac000 { @@ -620,28 +617,17 @@ cnoc: interconnect@1500000 { compatible = "qcom,sdm660-cnoc"; reg = <0x01500000 0x10000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_CNOC_CLK>, - <&rpmcc RPM_SMD_CNOC_A_CLK>; }; snoc: interconnect@1626000 { compatible = "qcom,sdm660-snoc"; reg = <0x01626000 0x7090>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, - <&rpmcc RPM_SMD_SNOC_A_CLK>; }; anoc2_smmu: iommu@16c0000 { compatible = "qcom,sdm630-smmu-v2", "qcom,smmu-v2"; reg = <0x016c0000 0x40000>; - - assigned-clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - assigned-clock-rates = <1000>; - clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - clock-names = "bus"; #global-interrupts = <2>; #iommu-cells = <1>; @@ -686,16 +672,12 @@ a2noc: interconnect@1704000 { compatible = "qcom,sdm660-a2noc"; reg = <0x01704000 0xc100>; #interconnect-cells = <1>; - clock-names = "bus", - "bus_a", - "ipa", + clock-names = "ipa", "ufs_axi", "aggre2_ufs_axi", "aggre2_usb3_axi", "cfg_noc_usb2_axi"; - clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>, - <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>, - <&rpmcc RPM_SMD_IPA_CLK>, + clocks = <&rpmcc RPM_SMD_IPA_CLK>, <&gcc GCC_UFS_AXI_CLK>, <&gcc GCC_AGGRE2_UFS_AXI_CLK>, <&gcc GCC_AGGRE2_USB3_AXI_CLK>, @@ -706,10 +688,8 @@ mnoc: interconnect@1745000 { compatible = "qcom,sdm660-mnoc"; reg = <0x01745000 0xa010>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a", "iface"; - clocks = <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK>, - <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK_A>, - <&mmcc AHB_CLK_SRC>; + clock-names = "iface"; + clocks = <&mmcc AHB_CLK_SRC>; }; tsens: thermal-sensor@10ae000 { @@ -1186,7 +1166,9 @@ kgsl_smmu: iommu@5040000 { clocks = <&gcc GCC_GPU_CFG_AHB_CLK>, <&gcc GCC_BIMC_GFX_CLK>, <&gcc GCC_GPU_BIMC_GFX_CLK>; - clock-names = "iface", "mem", "mem_iface"; + clock-names = "iface", + "mem", + "mem_iface"; #global-interrupts = <2>; #iommu-cells = <1>; @@ -1288,20 +1270,16 @@ usb3: usb@a8f8800 { <&gcc GCC_USB30_MASTER_CLK>, <&gcc GCC_AGGRE2_USB3_AXI_CLK>, <&gcc GCC_USB30_SLEEP_CLK>, - <&gcc GCC_USB30_MOCK_UTMI_CLK>, - <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; + <&gcc GCC_USB30_MOCK_UTMI_CLK>; clock-names = "cfg_noc", "core", "iface", "sleep", - "mock_utmi", - "bus"; + "mock_utmi"; assigned-clocks = <&gcc GCC_USB30_MOCK_UTMI_CLK>, - <&gcc GCC_USB30_MASTER_CLK>, - <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - assigned-clock-rates = <19200000>, <120000000>, - <19200000>; + <&gcc GCC_USB30_MASTER_CLK>; + assigned-clock-rates = <19200000>, <120000000>; interrupts = , ; @@ -2204,10 +2182,9 @@ mmss_smmu: iommu@cd00000 { clocks = <&mmcc MNOC_AHB_CLK>, <&mmcc BIMC_SMMU_AHB_CLK>, - <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK>, <&mmcc BIMC_SMMU_AXI_CLK>; clock-names = "iface-mm", "iface-smmu", - "bus-mm", "bus-smmu"; + "bus-smmu"; #global-interrupts = <2>; #iommu-cells = <1>; @@ -2324,12 +2301,6 @@ gnoc: interconnect@17900000 { compatible = "qcom,sdm660-gnoc"; reg = <0x17900000 0xe000>; #interconnect-cells = <1>; - /* - * This one apparently features no clocks, - * so let's not mess with the driver needlessly - */ - clock-names = "bus", "bus_a"; - clocks = <&xo_board>, <&xo_board>; }; apcs_glb: mailbox@17911000 { From patchwork Wed Jan 3 20:15:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 759810 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166071EA84 for ; Wed, 3 Jan 2024 20:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="je0E91ZM" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so8019970e87.0 for ; Wed, 03 Jan 2024 12:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312958; x=1704917758; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9hbiB6tdnnMQ24hCb1VT6gYRHp21EZ3VUAmZLEGkw/Q=; b=je0E91ZM5QdWXGqCP9KoguqCBQOyUD0YD+nDpCmDqMrMo/kcJ4dZWT9nrNX2Xt+HHV OFelW/zKjM7oa1mnLaxKgBwN4Pa24db6zwrH90O2LtK7o14RxzmmNY6M2fKYzwoCR/Ds be1kynAGADWA469HJif653hdxEGUmcdnjT4yh8dT9xxW+OXaJbiwxb1A2Jg/+OnTLaCY zeA2fknGSgIs+J9fceJnaXDvYRuvB9iJIxisS2vPklcBFp6f8AmTTp5RtihCgOPfugyb bt7HohvOKZCS3IptkzfrgAYkAXt3L5S8I7WJsHm+QU6iLlv23n1EoJXYRbvDkN6rEF0Z Pv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312958; x=1704917758; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9hbiB6tdnnMQ24hCb1VT6gYRHp21EZ3VUAmZLEGkw/Q=; b=VE5Zxp3m3b1r1ZMOHwmeGLRdeOBCNHxrrGlwoAafTqWePpBmI1FHucETblAVtKVj1D YC2hcfZlJ3J/KDmjRwvK+asUZfG18FrpTc6s0+bJ3NEO9WxButuOORjsoN9mjueD3VFl Dpb9sn5q7Y4mMjR5/Roy3Nj89/eZQfVgIDtaGiv0Zp6p7PjhiIYBPimu6r52lg2yb9SX XMVcV5T9zbDNaN5MUQnYUC9eEZrk1npfI5t9lSsq6cJtxPHG/yFJwpc++r8iVoyvhAk7 GC8qioJ27Zwvg8/2XeocWJji5po4G3Cj56JYX4MAUzV8GVDkj87TY29rFmgy8vi6xnwU 45OA== X-Gm-Message-State: AOJu0YyNR1IcjnyDaVusfGz8JHOXyPn3QrGQmdv4fOizN7IGplGRw/T9 epxaReGe17GlCCwMwftNl/3BXcSXyG41FA== X-Google-Smtp-Source: AGHT+IF+PX1H5YpNkKHol6f02kdPeRx82Wa/Rkf4Fpbw5Q1iLBaNpm5ydmT3t4fBzavvFWxbsSKc9g== X-Received: by 2002:ac2:4e4c:0:b0:50e:5aab:a287 with SMTP id f12-20020ac24e4c000000b0050e5aaba287mr7355382lfr.8.1704312958294; Wed, 03 Jan 2024 12:15:58 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:58 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:36 +0100 Subject: [PATCH v3 6/9] arm64: dts: qcom: msm8939: Drop RPM bus clocks Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-6-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=1930; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=iAST6Bi3i5Py4hFCq2uz7LHvVl/s5kvpbNjyyM0F4x4=; b=2R6ks9a76Dvsfe5auiqvqhip6ClBOvXKYnTJ/pC1kYCapQIL5V0+tMo0rRPly12pPuyHEcmVG iL8baUaPiu3DK2b7qA+EF263xvgEHrlXW/wWUiNYedw8B+8WEeBL2hc X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some nodes are abusingly referencing some of the internal bus clocks, that were recently removed in Linux (because the original implementation did not make much sense), managing them as if they were the only devices on an NoC bus. These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8939.dtsi | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi index 29f6bd9df2eb..82d85ff61045 100644 --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi @@ -602,9 +602,6 @@ rpm_msg_ram: sram@60000 { bimc: interconnect@400000 { compatible = "qcom,msm8939-bimc"; reg = <0x00400000 0x62000>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, - <&rpmcc RPM_SMD_BIMC_A_CLK>; #interconnect-cells = <1>; }; @@ -648,25 +645,16 @@ restart@4ab000 { pcnoc: interconnect@500000 { compatible = "qcom,msm8939-pcnoc"; reg = <0x00500000 0x11000>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_PCNOC_CLK>, - <&rpmcc RPM_SMD_PCNOC_A_CLK>; #interconnect-cells = <1>; }; snoc: interconnect@580000 { compatible = "qcom,msm8939-snoc"; reg = <0x00580000 0x14080>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, - <&rpmcc RPM_SMD_SNOC_A_CLK>; #interconnect-cells = <1>; snoc_mm: interconnect-snoc { compatible = "qcom,msm8939-snoc-mm"; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SYSMMNOC_CLK>, - <&rpmcc RPM_SMD_SYSMMNOC_A_CLK>; #interconnect-cells = <1>; }; }; From patchwork Wed Jan 3 20:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 760443 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC6E1EB4C for ; Wed, 3 Jan 2024 20:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HzbOpo2c" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-554e902064aso8605947a12.1 for ; Wed, 03 Jan 2024 12:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312960; x=1704917760; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yKEX12Nc6DjhIWZVWWjaSHZ/t3DyThSHvq2IuZgMy9A=; b=HzbOpo2cyGZFFT6+WlYsqlA+5C1WdLM34TYKq76XxxqDS4JxZqOeZ/CGm7K7iTTZWF syxLV/iSHp6ZYWg4X+DALhlAsB8iIozeQ4d9dXYyZgM1Ok9yimpkPxFWa0nAr0epGjd/ hqV/8IGycZF8V0Qg82rKbYW9w5IxXi411XLCBfv7v8aWEtym8Od9oQpdm/F5BarRJwgA rKXFWILNLVxMpsITZ6lVgAR6un08Rj5Z5XsAymxq54Joq36izl8dZNp9qJ2KIMNK9ZPw vxo5GqNWkGkZ9zsxSbENE6d0Kw1IoN+2Em4oEv83PY5GH1qOHtSRgssakvim8yKNtEBj cYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312960; x=1704917760; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yKEX12Nc6DjhIWZVWWjaSHZ/t3DyThSHvq2IuZgMy9A=; b=CshSk5Dx4isbJ/3sIl+5pPFYhcoiPGn6uaj9iUiUKmWxj6FNxYO3A6VJA+KTyrhiJk WASJAiaKyTAzfskPUOuKr3y9J3QU+VfDnm2HmAp13lz9VYn3Ip/y16jahUQOxfH7u4Qr SB/vwbY+jsuBhG3aqUqF0tNjNPRG+/NmsZ2ZlyeXwGmlunUauHZDADw4GPvimwSiICvG L2WpYYpW4qwFkM/vVHJuo+Tp/w2T9Yp40ou6Z2MaxvDJhDiraMEvp0kWz/dPPfResR2d rvcfDL/WnHdj4rFVs4LNDo7VpOtqiuBqqihMyCfowenDch1lv4YpKN1oxWy7FsNJDRJL iT1A== X-Gm-Message-State: AOJu0Yy0uKKKbAfdLsiXfWlWPzHufXjMlD6tjdrKfHNmnEpuxy4eGfTa zpN4svwkO2OBbElrz1AR72bxCT11zUoYwA== X-Google-Smtp-Source: AGHT+IHGBkq46I3bFv2XJv6gtLYhVLjB1InDN1jLNbKI/me2ByK5wd6gPOHoPurroyLMqn+nmLf0jQ== X-Received: by 2002:a50:eb0c:0:b0:552:d00a:2837 with SMTP id y12-20020a50eb0c000000b00552d00a2837mr10533229edp.52.1704312960076; Wed, 03 Jan 2024 12:16:00 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:15:59 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:37 +0100 Subject: [PATCH v3 7/9] arm64: dts: qcom: msm8998: Remove AGGRE2 clock from SLPI Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-7-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=889; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=QUVffHTCSnWfsgGf1+xud40WCLg0YN+mizl7weLMh3w=; b=F9SiuNHQoFhocMEUUpWIY06aYxFlcou+Qit2pKRbW8/aBdr8x3BX/URHRZ0Z1OVahQFaFYvZA y6LzikAvXx8DrTM0qgTxDZcR5Qu63KADCZLgPyDs/EaxS3JcT5zIS2l X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from within the interconnect driver. Attaching it to SLPI was a total hack. Get rid of it. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index bb591c6bf573..2793cc22d381 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1605,9 +1605,8 @@ remoteproc_slpi: remoteproc@5800000 { px-supply = <&vreg_lvs2a_1p8>; - clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, - <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - clock-names = "xo", "aggre2"; + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>; + clock-names = "xo"; memory-region = <&slpi_mem>; From patchwork Wed Jan 3 20:15:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 759809 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6241F94C for ; Wed, 3 Jan 2024 20:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wN/8VzZI" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5563944b3dfso3305127a12.3 for ; Wed, 03 Jan 2024 12:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312961; x=1704917761; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dsVDDOKbbcbcVH/q5yPVUfnBtFtphc4WlPKZOWq+eRk=; b=wN/8VzZIyd809Z/kBBBYZEZHZfAUXZitd5Vy4oH/DrwzxGoUGPi3rzS8jDvoFzvljy w1mlPSKPzIrz+YRppdunMVEihFcRF8nHnj4ae4wJTF7YKiFGwxHQ3iWcU9T+lGzvGHej ucNFHr9pqxip502r4TomjOjCbrcUvt4lgMSfrai/CYyIrx5LJbDrBmzU87TCADvGTjLd k9oHS9rlxsDE1EezXQDBGfROHrGJxTa5a91xG4G+dBhrWr5fEuh3sKijH7a8KRBRXZCd b/fgp96NOCB88Uz0GWVeWivvb4orDXelcwB/4FPuiVDCMuRndDYHscHcfHt/TfRT5oIG UEBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312961; x=1704917761; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dsVDDOKbbcbcVH/q5yPVUfnBtFtphc4WlPKZOWq+eRk=; b=WKmro3hvD7OouMu0leCdj/QLVi7Vyrs2Ik3CcCB5z+ABmm6irrG7ivZ1feebjJyDRX n75S7kze1V5qG7DEzT1f64wgHvsQIr7xZH4FMSHI4M2V9vw3Sn3ALLpMa/PDbDA9R3G+ B1e+LrbQV76ZMd+HoqbJiasoPMi7yWiFJBD6S7VoYVL70C41SYjLnuYY2zcUwyFe+66c 5AURJg6pp9NuHVqTAAT+MKSw+ElUL1rF4f3qLzcIDXtmTmVqPiLh52n72mVpnYw4sszs xd5/7q2iYZLFZmpIAQDQxKTIT0KXEEd9ctptGj0koC1s/MKTvz+fSPBODCwXS6htoAa9 XlmA== X-Gm-Message-State: AOJu0Yz+SOU2uo0YWf8fabvayHyLnOVCYVUO18mR5infb5z3IxQpZtoZ LsiokDj30+osox5HCdcZmNXB9183CEicBg== X-Google-Smtp-Source: AGHT+IFwXGfx9V/fM2mIkflGRTIoBmR8LHL0J3DrV6BBIx5R47IcyH1v8+lE2bhbV+83jom3f3eLIg== X-Received: by 2002:a50:c21a:0:b0:555:5259:956e with SMTP id n26-20020a50c21a000000b005555259956emr6606293edf.20.1704312961685; Wed, 03 Jan 2024 12:16:01 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:16:01 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:38 +0100 Subject: [PATCH v3 8/9] arm64: dts: qcom: msm8996: Remove AGGRE2 clock from SLPI Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-8-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=853; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=HHArVul1RHFFQ6r2bVO5FLrY8PkiyEDVDWk91JfzQ5w=; b=vBPyfWgMfR5o5L1Rfy+7PloGMzFVW/bj/nam1vYaO9GqVWnZ/eFmERwC0iC+MHqQZ8NUCtJTU erdzs3CaAnJClw7EVgK/WdnQSCrXwXOHcCfAYPmd/YgE5j541COiSbm X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from within the interconnect driver. Attaching it to SLPI was a total hack. Get rid of it. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 4f465ac573f5..174eb410824b 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2467,9 +2467,8 @@ slpi_pil: remoteproc@1c00000 { "handover", "stop-ack"; - clocks = <&xo_board>, - <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - clock-names = "xo", "aggre2"; + clocks = <&xo_board>; + clock-names = "xo"; memory-region = <&slpi_mem>; From patchwork Wed Jan 3 20:15:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 760442 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7AE200DD for ; Wed, 3 Jan 2024 20:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yaH2ymto" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50e835800adso6940798e87.0 for ; Wed, 03 Jan 2024 12:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704312963; x=1704917763; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=agWOk7w6rgV8y2OB/j9TiP5HID7PZwKq37+MydcMd3Q=; b=yaH2ymtosQorCjffDM2nq133azvGr/KkHcFP2jkaXGKV3hh+uqJV5wI42eNBMnTHGb tEjGWN3xgf8s07+C0L4KsA+8tSh1gPVHuUh+JlFWUJnEUcnXwCvi1yta/ZsFV1qGDn0l upDS8XYcVQ7PcsSSHr+15vt9k5GlzE0x/u0fM6d6SWDpSOtyu1KufVMOv7DaEZcJDnuK DfVAgLpog2eZUTtufVi2SR9N71gZF/s9w6z2AVrp3LU7J43qW1t2w+Aqdqj7JH46ZE/2 QDlhqoKKNSEgTmgmm6ew9kcZWmWInVbqCHd1iLDFGu/URiotvGZmVUsBl2elb+ir2P2U mlzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312963; x=1704917763; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=agWOk7w6rgV8y2OB/j9TiP5HID7PZwKq37+MydcMd3Q=; b=nqxmIcIgTd7xRN8xE3wb3KwIxXy/Y5cEkuqH/DhmcB259/Vd3J1qORtIGtmmo0g0b4 ITG+nmeFyDq/QhA2uhcnRVyup9SKCIvIQSZGfotA7h4JeIkYKkZ+5pyl5B1gKTaW6TdU GlFIt++QR8MEWUdcRnSWqKRyz121WhNTMK88hyydvVcGWuSDylj+EwC/9eBic4qdCXUK 0MDSvQ09boV2cuSYcpO1JFm1W9QoEvl4CHnhVS5N936muxFT7HiYuufNWOQ4ZTQcByJa uUPylNtWOqpp4r5xSOpJN+ZqoYg6GFclvAJVVFsV7Gjl9p6gl4xze7NkZ92KXrzU6AH1 h0MQ== X-Gm-Message-State: AOJu0YyoB9QGg6uw9LNNGRMyrUvI0OvFsyj72bE3hATFs5XIFONDKNNl O0DmMKVsIAx8Zv0Zy/3eV/xKOSCbLVzM8g== X-Google-Smtp-Source: AGHT+IHKQKRuYd+I0nrZXegy4ZNvuCWzu8ez/JtqTR3BixAbs6pNVBJay8L2h0a30COQ6YXXT35IFg== X-Received: by 2002:ac2:41c2:0:b0:50e:7044:704b with SMTP id d2-20020ac241c2000000b0050e7044704bmr4312375lfi.90.1704312963418; Wed, 03 Jan 2024 12:16:03 -0800 (PST) Received: from [10.167.154.1] (178235179036.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.36]) by smtp.gmail.com with ESMTPSA id fg9-20020a056402548900b00552691fc7f9sm17549670edb.66.2024.01.03.12.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 12:16:03 -0800 (PST) From: Konrad Dybcio Date: Wed, 03 Jan 2024 21:15:39 +0100 Subject: [PATCH v3 9/9] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230721-topic-rpm_clk_cleanup-v3-9-a66e698932e3@linaro.org> References: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> In-Reply-To: <20230721-topic-rpm_clk_cleanup-v3-0-a66e698932e3@linaro.org> To: Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704312946; l=1234; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=lDN9I443Hl2d8DVCOQ4aNKeHtWkZFlxqcP4xR6KB6zk=; b=EL7JckzCpuqfY1C5Jg62k+EicmGHKeLrQolwseYXNXDeyuOumzO8IUKBRA1/gjGZHSoJP9ld0 vGGnQXQ6jTrDDzjCYW3tjwB9ltzeS8AaO4BPUKpSSvZ2h7SNgJOFm1t X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= The PNoC clock is a clock for the entire PNoC bus, managed from within the interconnect driver. Attaching it to MSS was a total hack. Get rid of it and take the liberty to make the clock-names entries more readable. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 174eb410824b..8d41ed261adf 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2513,10 +2513,15 @@ mss_pil: remoteproc@2080000 { <&gcc GCC_MSS_GPLL0_DIV_CLK>, <&gcc GCC_MSS_SNOC_AXI_CLK>, <&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>, - <&rpmcc RPM_SMD_PCNOC_CLK>, <&rpmcc RPM_SMD_QDSS_CLK>; - clock-names = "iface", "bus", "mem", "xo", "gpll0_mss", - "snoc_axi", "mnoc_axi", "pnoc", "qdss"; + clock-names = "iface", + "bus", + "mem", + "xo", + "gpll0_mss", + "snoc_axi", + "mnoc_axi", + "qdss"; resets = <&gcc GCC_MSS_RESTART>; reset-names = "mss_restart";