From patchwork Thu Dec 14 18:13:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 754219 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VrUyXg1C" Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78CB0116 for ; Thu, 14 Dec 2023 10:13:50 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50c05ea5805so9957181e87.0 for ; Thu, 14 Dec 2023 10:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577629; x=1703182429; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yVQf3dbyT14ng4SO14NJqgagpvGCqqxla+LEC+UJVYU=; b=VrUyXg1Ck0uRtmA0qq+4EHsgo06J0qHEDi8kRxD//82wtPzVbR1+ztIlaWs9qpByyE aBuNjeq3u6waNuCgZmUpclJw66mSH6iAV/QNEqUynxqahaIDXPAnTwNyyW76HmrhPid6 LyBXTid3qAQQ0c2Uge1nc1/hsXUiycRrauKwSDgWrlheOMUjs9PsIrsZqWDt7v8Bv/Jc S4hjlmzOo3hHL5uHOpflVy/zuIt4tAdf3uzxNae8jeMWz4kjolD8d63lPW7jE5qIlvAK +lz9eIqPXmPwMwcI86EErV09yrSEat8yX23lb68xLKzDqqUpIiuAA2jA1fYnyNwVvN9y +xVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577629; x=1703182429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yVQf3dbyT14ng4SO14NJqgagpvGCqqxla+LEC+UJVYU=; b=IrAjNpTqKrYw+nQHOIp/9Fn1gxfuAaJLz9v4EDoD/4Ivo1n1yTeldd3s199ssbrsts Y3pb24wgxs2XG6IYjsZrF24xpwMHOznlP3Y9rtW//9irxAz0kPLXk9SjXxbIe96qDj/N RBaRpan5EsJ2vuWNJfOL4+Av04oXPj/RXxMT2DFtzMC8eBpUG43FRpNr+mHxG7U3L0YP 5a1LfuJsxjjXCDkEjbiwOzL1isqY658UxPIQis0dDCmnksOth50Td3wXws3crUiBpb87 wKizg/2dit/6VV067r8REV8tEKnX/iGxmhuTkm2CcAD5Z4fuvrU2Wo9yUeXFiAPKG7KR b55Q== X-Gm-Message-State: AOJu0YwOEECgfh0+WfT7q7B+bTehugBxlDFMIaRW9VoIJ+0dfmkUT1PB k4cy4lfKOnBf6ntyOfx6N9eRew== X-Google-Smtp-Source: AGHT+IE6Y+zGN2MX4oNmeEjKqUQAvJwmAAdCFaira+2M3Z3fMM7AKCqXMPs7r9pionVuu9nbZZXonQ== X-Received: by 2002:a05:6512:48d9:b0:50b:ecae:d8b with SMTP id er25-20020a05651248d900b0050becae0d8bmr4821204lfb.105.1702577628609; Thu, 14 Dec 2023 10:13:48 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:48 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:38 +0100 Subject: [PATCH 1/6] interconnect: qcom: sc8180x: Mark CO0 BCM keepalive Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-1-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Level: * The CO0 BCM needs to be up at all times, otherwise some hardware (like the UFS controller) loses its connection to the rest of the SoC, resulting in a hang of the platform, accompanied by a spectacular logspam. Mark it as keepalive to prevent such cases. Fixes: 9c8c6bac1ae8 ("interconnect: qcom: Add SC8180x providers") Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/sc8180x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/interconnect/qcom/sc8180x.c b/drivers/interconnect/qcom/sc8180x.c index 20331e119beb..03d626776ba1 100644 --- a/drivers/interconnect/qcom/sc8180x.c +++ b/drivers/interconnect/qcom/sc8180x.c @@ -1372,6 +1372,7 @@ static struct qcom_icc_bcm bcm_mm0 = { static struct qcom_icc_bcm bcm_co0 = { .name = "CO0", + .keepalive = true, .num_nodes = 1, .nodes = { &slv_qns_cdsp_mem_noc } }; From patchwork Thu Dec 14 18:13:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 755361 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XmxIajsw" Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D3A9120 for ; Thu, 14 Dec 2023 10:13:52 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50bee606265so9040038e87.2 for ; Thu, 14 Dec 2023 10:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577631; x=1703182431; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IMx4XjMEUXuFYA5pBx18NGkYFcvy16oralmVb/gOmdY=; b=XmxIajswJcFXJA6CjCTt/SIx+EnQ/Sk1L7t+9xvQTzWOM+4vx01B5F7nYqL35QJIYb Wc6s+mDrRb6V/NgsT6BUxTjAWesM7tSO1iqGWqaZxDueVCwWwS8CJ++V/TJHac6w6y8q JT1EYuASd4Eokhs5kt4DaSCRzFEgBBn+54NvwsK5skVK4WgMcGrajmuk7i3RgDX8KWhL UUkcdPWh57HvYjcSvbTihs/BYZNned+A13RgoHBmHluZe1pTVYoAqne9LBNXLEfO5vTG 40PfbJQ/e3e9Xj3uruXBxo1vbnG6agc7W08r5K3kzFs8+OKqPiBuZE7GkkmIvjVbHmDX 3plw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577631; x=1703182431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IMx4XjMEUXuFYA5pBx18NGkYFcvy16oralmVb/gOmdY=; b=tTGskhoGKXwuDq+inVPP7W6oY1UDWJkXrBDSh0i7x0iYQ3oLSenPOnv3oOlbYY/Adn zTKdIwrj5UKCNC+iYuO8EQsdLC+oE+nOGqSqK/ae9KmjWdUrtf69It6LjfM/egmEWzZv KLrOV5Xgc/WItiWCKZVLM6rhm/HuOlaQ4AUOGOWRdrN7jSIHs83fCU03qJxjcwUrk4pa +VHWCndUOn0B9fSO2XiPwdNsKsWu1bpMu43n6YTpDK5/m46GoWtHf/DloKCKnKeJ9gri en8UqUbQ/5uSDb9AS8dvD2xGcZTOqfazrWrvAQjpSDvcndbxCPi2rxos2erHH2oEDWRt t2Fw== X-Gm-Message-State: AOJu0Yz928abB8SfxUCHwE9ln0km48+NuA6OWHFdys/oxu6vt1iZ1y+H Hiz6PUJBk89ArluRS7crZhWP+w== X-Google-Smtp-Source: AGHT+IEu9dXQFBaqMYJ+X69RlJ4+zf3oIcdvrbMBRHhbl71TJdITQrXpgbz1sLqSWFMJZE916w9O+Q== X-Received: by 2002:ac2:428b:0:b0:50d:ae2:2a9f with SMTP id m11-20020ac2428b000000b0050d0ae22a9fmr4280323lfh.24.1702577630824; Thu, 14 Dec 2023 10:13:50 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:50 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:39 +0100 Subject: [PATCH 2/6] arm64: dts: qcom: sc8180x: Add UFS GDSC Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-2-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Level: * To make sure the UFS controller and some relevant clocks have power flowing to them, hook up the forgotten-about GDSC. Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index b857959a896b..09b4e66367bf 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2110,6 +2110,8 @@ ufs_mem_hc: ufshc@1d84000 { <0 0>, <0 0>; + power-domains = <&gcc UFS_PHY_GDSC>; + status = "disabled"; }; From patchwork Thu Dec 14 18:13:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 754218 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cln9RAwO" Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEEC6123 for ; Thu, 14 Dec 2023 10:13:54 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50e1112b95cso2275168e87.0 for ; Thu, 14 Dec 2023 10:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577633; x=1703182433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tC67f/rlpMpveywW17PnxYzUi/Glfsd8AP6R8y378/w=; b=cln9RAwOuYvElTMK4ZHTDkUWfsbWwFug/0gLM48BVqe9c6QtQL8d9P4JKqLe1hEtuc QJ2xdK7cQvgcQUO3KCZrlCH5oRQZwd/kNFtTWC+C7LozGH1a7Xh9qnvmAr4aJ9uEZbDR tcvvQsU+wQVr/Klc22LHK4bnrklt/RnBCWJkXF2CL3y6pQlkvkYz/xa016kcrsEi0gdp lxJaGiQAiy0FMZrlWpXBNW+8kI3Bs2Lh3UlUJYr8Joxp57ZdVTjLANCqiXt5/X1KrKCF WDXTWEMecEsbXerEop1GPTjDscfSl/YAQITgPRJVKRx3h2vC8fbpau5kFo8U3/eDW+7A vxJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577633; x=1703182433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tC67f/rlpMpveywW17PnxYzUi/Glfsd8AP6R8y378/w=; b=jxBn5qXrnNStu43rkY9Uzg2o9cxRsAf198DSxpsaW4nckvFECxNv3SkBvvWzR/irY+ DlmKeYyzq+r1XoaJQ+XTQfnLdFeeh2U0Qrio0cgDb1GcCeimdH/yFMQOf2ws/0HigoHN 6WlGuNyD9ZK0hgrkzt4/R9VHvum5ii1YOjd/zvZB1drYwqvLBvTVAnBL6DQnzuODWeyC /wGtEAeRAsYaZOa5whKn/bVUFfMV/874UM24LqBFroqcZstTmFvkwsKamD6MzkZpSF8f Ai5MrhbZ1dxICDfn8vUcQxVKYMWqJFU2bXzUR8OYmBwjJioA2lMOB49/kkOigp/6ilf7 qVtw== X-Gm-Message-State: AOJu0YykT2OwTXRAGEXfx/kaKQwchkIwjLFccvWOqU/Tf3HvJqBApC6G TcmZBMWpwhB/E57NWOoRka79hg== X-Google-Smtp-Source: AGHT+IGcbEe+tBDd6I6AyNkwGs0Ia75MCyM7k6vMNAGHeogC80Iy8W/qiWyD2+XvGIc/Gbj8bqpTqg== X-Received: by 2002:a19:8c1c:0:b0:50b:ef5a:d022 with SMTP id o28-20020a198c1c000000b0050bef5ad022mr2770578lfd.41.1702577633070; Thu, 14 Dec 2023 10:13:53 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:52 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:40 +0100 Subject: [PATCH 3/6] arm64: dts: qcom: sc8180x: Add missing MDP clocks Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-3-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Level: * The ROT clock is required for the MDP block to function (looks like some others depend on it), and whike the LUT clock's purpose is not clear, it's likely better to turn on all of MDP's dependencies rather than not doing so. Add these clocks under the MDP node. This also makes Primus work without clk_ignore_unused (as far as the dmesg-visible errors go, anyway). Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 09b4e66367bf..c970dfb11fe5 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2702,11 +2702,15 @@ mdss_mdp: mdp@ae01000 { clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, <&gcc GCC_DISP_HF_AXI_CLK>, <&dispcc DISP_CC_MDSS_MDP_CLK>, - <&dispcc DISP_CC_MDSS_VSYNC_CLK>; + <&dispcc DISP_CC_MDSS_VSYNC_CLK>, + <&dispcc DISP_CC_MDSS_ROT_CLK>, + <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>; clock-names = "iface", "bus", "core", - "vsync"; + "vsync", + "rot", + "lut"; assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>, <&dispcc DISP_CC_MDSS_VSYNC_CLK>; From patchwork Thu Dec 14 18:13:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 755360 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CI+NnKSW" Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C6F2122 for ; Thu, 14 Dec 2023 10:13:57 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50bf4f97752so10900861e87.1 for ; Thu, 14 Dec 2023 10:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577635; x=1703182435; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KDl/5My1xLkJRpwqZFmnSzRYwMADfJleMVV/jfBPrF8=; b=CI+NnKSWadXCpuDa34yiX6u4IC1a2qIIsxtyPnBx7emBjTLvpawGgG9G9gC10H6QzA B2G2bk/0fjInNyqg5UAM5P4YlBy4rdnhAeJUvs7oHTCwmlLHRZIULiLEjOlRihWpd1ng iR/NHTEjuvsQzHoFrYC9QilIb9/6neytEekOpnLCIxuk3n7ujJlwujBqt1+hb+MpOi7S HYbD9HXblbYaRowYoaYWXs3bOQlKqEUuYjeHGWiINpwB6iSRlltRj4GKScK4PQquLSCJ 1NRSZNnwQJP7JpOCGQ52ReyQHxnA/o6OyPAe1xmxJVMrk/HtpnNSIXzoI7jngPSms9gj Qhaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577635; x=1703182435; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KDl/5My1xLkJRpwqZFmnSzRYwMADfJleMVV/jfBPrF8=; b=HgDVZ4M8fy4TfWPDxXVc7oeGjLFGwc6j/Ez/B2YUni1pHGDiN+VcgPQVAjQXNDSyUs BP2r7lIIxvYkleMvf/WsxBWeZLMkkMkicd/+uG3NuMCNBlv2FKEq7+3PYPNZBSmE5Xu/ GzTZ9DxgFCxgE8ltyLURCvIvjt0wjw83iazsD/dsNVmtOCv8nwGkPnoNtcPX5QL5LWTq ucVmjTipjBblHvx38h1PUoyiH8iTgSoEeENE7VgAKfLQGwKjDB4kdOA4rnqFpvFnBz7W KAJMMhHdRBKgwFif5s7Dqw0IkR+Z8nyJ8mZS6snIBF7jEh/ka+VuJMto7ZNOWFuOibIg 3Mdg== X-Gm-Message-State: AOJu0Yzi7OnEtHU7uS0Zq7QktauRbHXdnHUB+rkrrvrmTszscEXsfOqb cgJG4EAh/XIi5EuaWpgFJY1lvQ== X-Google-Smtp-Source: AGHT+IFiqxfsAnPjpTM4RI3tV+Q1YP0UXWmiaY7vOr7muxEYy1b5pZbdq+7ZX1Mhwflskp6g/OyciA== X-Received: by 2002:ac2:5399:0:b0:50b:f8da:23f2 with SMTP id g25-20020ac25399000000b0050bf8da23f2mr5190095lfh.135.1702577635312; Thu, 14 Dec 2023 10:13:55 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:55 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:41 +0100 Subject: [PATCH 4/6] arm64: dts: qcom: sc8180x: Add interconnects to UFS Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-4-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Level: * To ensure the required paths don't collapse, add interconnect properties to the UFS controller. Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index c970dfb11fe5..98fc3ec881a3 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -2112,6 +2113,12 @@ ufs_mem_hc: ufshc@1d84000 { power-domains = <&gcc UFS_PHY_GDSC>; + interconnects = <&aggre1_noc MASTER_UFS_MEM QCOM_ICC_TAG_ALWAYS + &mc_virt SLAVE_EBI_CH0 QCOM_ICC_TAG_ALWAYS>, + <&gem_noc MASTER_AMPSS_M0 QCOM_ICC_TAG_ALWAYS + &config_noc SLAVE_UFS_MEM_0_CFG QCOM_ICC_TAG_ALWAYS>; + interconnect-names = "ufs-ddr", "cpu-ufs"; + status = "disabled"; }; From patchwork Thu Dec 14 18:13:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 754217 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BtMVHhqC" Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60279128 for ; Thu, 14 Dec 2023 10:13:59 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50c02628291so9046716e87.0 for ; Thu, 14 Dec 2023 10:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577637; x=1703182437; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o3r1bVN6/4LrrGw5N6lGME8swP3TVIC1FuDgOiCIYg4=; b=BtMVHhqCysRUHwWJ73akUFQC1nfiyOUsguAex6zNmRQeXlCLD/IUc3laFaacULo3HQ Jt3y9AyACu4vfVd/Dm882cElZAwNCYIIcDIU0Ok7o0t/cAA5p4HRT4DCbl2bW8lgtslR WNWCIC7jKs7CRH0tyOyz6OD0yR+rUzjcHLkr5zJuvlYdk6GAi4zSnKb/11NVlbQbntrO TLrodUfm0fFfvPrqb5KuSFuHV3vdGGNe+pTI1rlihKB3MD/IAuhKS/uGjfccDZIG01zo 6dqg5r6bAjA4gRCbWjUs12LtAmGXeWf3G7hRNJSvoYc9nzyjU1X9KB42atIq0GWWADBc h+OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577637; x=1703182437; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3r1bVN6/4LrrGw5N6lGME8swP3TVIC1FuDgOiCIYg4=; b=h/7bZppLZdW2SOkU8XvlwK6ey2xNmhVV4RjiYv820Z1Jq73Zcixuz9mXBrGmRi34Ol YwzXpClKNVjdUGu4ZmCkkxzV3vFlaZHBX+GM2Tl0rWJgQMxuT/3JDUyW10LzFTIniIHq mydtnJz7dkwyo8vxzyLgxfQc0wfBJEsrWE3uqsl0XjRGQAjrDvozrW+wI3ozpUbXk1sA Ul/sP96naS4RE0c1CqwwtXPfxQyVjgvqUgApV9deJBFA95VA6ckpk3lIz/0QpsT3kM9p ylSQAkdzNc0ay9ip9pnYJEfi85WTY1Iv1pXLYycVvFszycXKNLNUWC8U/eC59Nr3zdks nEFQ== X-Gm-Message-State: AOJu0YzWUFFuJhCjPZMtMuhtTRmsHCyxHucNmcyfg/3dR3SCvHuR2Pt0 amogRQ3Z/a42fLhnlhlGvtCcVw== X-Google-Smtp-Source: AGHT+IFPIcdi3YU4QH0WRzX5cow7BNQovSiBGe4ipKRLZtpdKnnMSnIkKUjU+kYaS1ZwHlP7i4J8Xg== X-Received: by 2002:a05:6512:2192:b0:50b:e9df:b7d6 with SMTP id b18-20020a056512219200b0050be9dfb7d6mr4039069lft.72.1702577637523; Thu, 14 Dec 2023 10:13:57 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:57 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:42 +0100 Subject: [PATCH 5/6] arm64: dts: qcom: sc8180x: Describe the GIC redistributor Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-5-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Level: * The redistributor properties were absent in the initial submission, add them. Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 98fc3ec881a3..a2287ce14fc5 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -3425,6 +3425,8 @@ intc: interrupt-controller@17a00000 { reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */ <0x0 0x17a60000 0x0 0x100000>; /* GICR * 8 */ interrupts = ; + #redistributor-regions = <1>; + redistributor-stride = <0 0x20000>; }; apss_shared: mailbox@17c00000 { From patchwork Thu Dec 14 18:13:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 755359 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rypMenmu" Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2A79131 for ; Thu, 14 Dec 2023 10:14:01 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50c05ea5805so9957461e87.0 for ; Thu, 14 Dec 2023 10:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702577640; x=1703182440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jeq677NEMB1IsnQAjs4/+yBvpQgDXfs4klZEe8r6nwY=; b=rypMenmuMdO1QbcrihnIVf2JXPhpJGZC0ibYEr6hPjfqhNVsru9owGy6iOLu+yWQZL 6YzMN7WOwW1eoSfh/nzVhcIHwvdVc+LzkGmE9/+PtO6s8Tet+9a7HJ8DOH9Wt89Vco6R x2vXDNlr2A6pinNEripZvIn2kBch+KxLIqTlxBuDKMqiAmfKtoaBoa/0LK1eu+wpa1/5 fwpYE1DeQ4yc4jrGiaDL4ppnA2wxA7ikfnNZU5Fi+SzyTf8UU5ZoJZbYRUm20l8s384y r0MKAW+DxWsUi+BfQM+O/mH4y73+XHEscyElcWqMo5IM8VyhoEfCRb+plNMIKHvBvclt Js4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702577640; x=1703182440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jeq677NEMB1IsnQAjs4/+yBvpQgDXfs4klZEe8r6nwY=; b=LWVRvFyTWshGZfC6V15wQHBRTQSbVokakY6kfMkwivGmE2GBWhzs7CvQFPEiPw1Mrc nCk1v7iQAXs/KLcmYyjdEs2tvebLCgXeG2OnJ1TxUj8wVbJC/XLoRg6qS/GulgI3ETOJ wlKbuHx7iQKkbPldaBfgJ4t3L+HmhIcKO7J2hAdWnsedDZzTW/ESNndiYk7WSriXKLtu ydWIrbH7bA1aIohXGZd1CV8n1c6qDK/f9TgshR17ata6DTDdb2S67+dY9adqVwyRapq7 VKW86QwaDZ+r1sWou6Uc53QoWXWEEGmR0CUZj7aACpWvMRjj2qT/MLszKKSVnxdjxUeP XTew== X-Gm-Message-State: AOJu0YylDUpUIQv9HZUP3hq8DtqkwHjfjWQAxzjTqELHaoq78odQuJq4 13T/Dmurdx75gsQGWB/G7xmzYg== X-Google-Smtp-Source: AGHT+IH+63IBJ9rieYmdKRPNhHxIM+WiKLHtfWsJ9OIE/+7mq19A5B8k4ZmO4Euqa6cdaiIKAp6nLg== X-Received: by 2002:a19:e043:0:b0:50e:17df:a992 with SMTP id g3-20020a19e043000000b0050e17dfa992mr815321lfj.33.1702577640041; Thu, 14 Dec 2023 10:14:00 -0800 (PST) Received: from [127.0.1.1] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1928838lfu.48.2023.12.14.10.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:13:59 -0800 (PST) From: Konrad Dybcio Date: Thu, 14 Dec 2023 19:13:43 +0100 Subject: [PATCH 6/6] arm64: dts: qcom: sc8180x-primus: Allow UFS regulators load/mode setting Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231214-topic-sc8180_fixes-v1-6-421904863006@linaro.org> References: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> In-Reply-To: <20231214-topic-sc8180_fixes-v1-0-421904863006@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maximilian Luz , Gustave Monce , Konrad Dybcio X-Mailer: b4 0.13-dev-0438c X-Spam-Level: * The UFS driver expects to be able to set load (and by extension, mode) on the supplied regulators. Add the necessary properties to make that possible. Fixes: 2ce38cc1e8fe ("arm64: dts: qcom: sc8180x: Introduce Primus") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts index adddf360c7fc..bfee60c93ccc 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts @@ -386,12 +386,18 @@ vreg_l7e_1p8: ldo7 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-initial-mode = ; + regulator-allowed-modes = ; + regulator-allow-set-load; }; vreg_l10e_2p9: ldo10 { regulator-min-microvolt = <2904000>; regulator-max-microvolt = <2904000>; regulator-initial-mode = ; + regulator-allowed-modes = ; + regulator-allow-set-load; }; vreg_l12e: ldo12 {