From patchwork Fri Dec 8 12:57:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 752329 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C143813FE7 for ; Fri, 8 Dec 2023 12:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BGURX3Ck" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3053AC433C7; Fri, 8 Dec 2023 12:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702040217; bh=OSuX71e1jZxpO9PhB7QCT9A4hWvPxJ7NxD/Rhqsq+SI=; h=From:To:Cc:Subject:Date:From; b=BGURX3CkaHSVViOG1V5VQDRQ5+esvsuA8SRZodR/7mOYi2OmZY0YTIIig2EWe/08v v3E1n4bWGqpOHyGi+5jzU6i0m8N4hrKNGX8/jgWPEa4q29TEe55s8Af8NLKvRDtRl6 IuMR2bB3F4SBgvhR2Blk++JH+Fb3W+lZTx5IJ6yyEGeYqJmsoJqfXVq5eICwi6k4vG pzC1qMsDRT+WibmV/PD/CXvAXQwbGsCpEL6yZCBgZDimbODte05HFFP7mdLr9a2vl7 KwhTMc3b6xr1XVFMZYfcKGYgexXgGXNwj/hoORjPg4L+JNDDXutQVx0SMl+7q5dkFN iW8SpZ/UMaNkA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rBaQM-0002gi-2N; Fri, 08 Dec 2023 13:57:47 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] soc: qcom: pmic_glink: disable UCSI on sc8280xp Date: Fri, 8 Dec 2023 13:57:30 +0100 Message-ID: <20231208125730.10323-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Enabling UCSI on sc8280xp and the Lenovo ThinkPad X13s in particular results in a number of errors and timeouts during boot: [ 9.012421] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-95) [ 14.047379] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 14.050708] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) [ 20.192382] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 20.192542] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) Disable UCSI on sc8280xp until this has been resolved. Fixes: 4db09e7b967b ("soc: qcom: pmic_glink: enable UCSI by default) Link: https://lore.kernel.org/r/ZXL5jvDHr-MuxMoz@hovoldconsulting.com Signed-off-by: Johan Hovold --- drivers/soc/qcom/pmic_glink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 71d8901a9389..511aa40842a1 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -342,6 +342,7 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT static const struct of_device_id pmic_glink_of_match[] = { { .compatible = "qcom,sc8180x-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, + { .compatible = "qcom,sc8280xp-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, { .compatible = "qcom,pmic-glink", .data = &pmic_glink_sm8450_client_mask }, {} };