From patchwork Wed Dec 6 14:52:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 752013 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ssjWMX8b"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QkNV5dZa" Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3124D10C6; Wed, 6 Dec 2023 06:52:57 -0800 (PST) From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701874375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vaRGVoXrIlt2HgjUs7mRGGr9BwnSNs+Kf5T79EG7bZI=; b=ssjWMX8beirkCUmin8cMKUd1xR2AD3wvF5r7TUdBYjgngccpjHlwUnPKV+wDNBmarLTikY tva7GLWX+nz9bZUrnlDaaE4Zg3cZG366Qfe+nThMm/dPEjxEfBpLSa/Lv5FAwzcd0GlLsE uC8DPKs9JtyE1Q19XeGHL5E/2S5eNuquqg285KUWdnosM5j6kp1/xuf03fahXuXcwLTigz AoMqwFDKrX0A2549kmF9FebdKTKXlHudLUxqQ2uSoN9BOQvKOxJenR/PWICTfjbwlZpN3s wwLUM+mHC8JMC6EI9PY3E1hkp/kB3cuCiXMZefx5PHG+NMVHJ9LXdkiwpM+oeQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701874375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vaRGVoXrIlt2HgjUs7mRGGr9BwnSNs+Kf5T79EG7bZI=; b=QkNV5dZamHFmsLAGwjCx11EsaKISJ6lQbxSSSaBlHV1BGs2yFV4cIYQqpkSzJA7uQcAHft hCTiVAUceO/7XHDQ== To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, daniel@zonque.org Cc: Nam Cao Subject: [PATCH v3] spi: cadence: revert "Add SPI transfer delays" Date: Wed, 6 Dec 2023 15:52:33 +0100 Message-Id: <20231206145233.74982-1-namcao@linutronix.de> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The commit 855a40cd8ccc ("spi: cadence: Add SPI transfer delays") adds a delay after each transfer into the driver's transfer_one(). However, the delay is already done in SPI core. So this commit unnecessarily doubles the delay amount. Revert this commit. Signed-off-by: Nam Cao --- v3: add missing change log v2: - update subject format - rewrite commit message to be more descriptive drivers/spi/spi-cadence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 12c940ba074a..bd96d8b546cd 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -451,7 +451,6 @@ static int cdns_transfer_one(struct spi_controller *ctlr, udelay(10); cdns_spi_process_fifo(xspi, xspi->tx_fifo_depth, 0); - spi_transfer_delay_exec(transfer); cdns_spi_write(xspi, CDNS_SPI_IER, CDNS_SPI_IXR_DEFAULT); return transfer->len;