From patchwork Fri Dec 1 09:36:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748986 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168574wrr; Fri, 1 Dec 2023 01:38:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzin1jZ2RTt06LsmHk9ZpDM0axz6iHTd85gfYDgp4AzyY3xadHYJgZ/nfjqEsiirlP/20k X-Received: by 2002:a67:f348:0:b0:464:523e:7957 with SMTP id p8-20020a67f348000000b00464523e7957mr6633847vsm.1.1701423531168; Fri, 01 Dec 2023 01:38:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423531; cv=none; d=google.com; s=arc-20160816; b=0R+qL6ihdDPNl8mHOdDgKBo8UuW/Na/3JPIRvvarv9a20LT6i0Qd4QgJc0bnYDyQl5 jXZYYjSGyA8KjdVHz+O5vLWxkFlf88qgLTvDsGcHDZoHfV7X0ovZnT7IUA4QTgTl6hlB ELGm1TrHGTsnmSNViY7Nny9j2dWCUP2RUJJwJwpUdpTYgHfxKm9nI5FVdKE6JcrMjoMo GqGpm3lAl1ThIo1BABpYE1qHEd9GHEez3nuofebpNvwfo6axjyfvjRif250ymFCQyxi7 EfHLTmfxxPT63ugvuLRqF5MP8zic+NK9NQXPUmff6/3opZcR+LutLoHaVdE6MshdcyMJ fqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JqE1WlTC8iW99lEPTJa1X2LXMjo5z4bbux1ltP+LwY0=; fh=KtbzfzPPOV2cxnNVqGsu+aD3THtZy85mdMU7Z3sHlec=; b=sWbgFgSAWJ7nuiR8YuXgclU1Qc/x1RVdyCHFDLhJSfSO6XtFfLToOqgr/43u89GNrD 1SpPyFRvIvtjSHMOr2/c9gp34YYbEnfZkAMfx0wqp9CRSeVjeXxSZqhdb1zeiv2MPmCq 1FlBeRrIO8uoCGXbBtJ/3O8FYO5Q3sCCsAB60X07sWns2JO159l3tkoIxvyFNNR1fUKe 7/Gz0enlGCItgaVhozW0115S6ln5IDmcYJXBzCxfuALSoqOybVhG+QvDoIv82753NUSC j/O7x2I+Am7qQhEeHMhZkJKJB96IZQ7d8j3muLYmVkOCm91Gj9ymkvHEYHRZDQDGBZRJ lERg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jYG0BzAU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i2-20020ad45382000000b0067a94bcd063si1347138qvv.178.2023.12.01.01.38.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:38:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jYG0BzAU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zwu-0003mE-Ee; Fri, 01 Dec 2023 04:36:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zwt-0003lW-Hk for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:39 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zwq-00044c-IA for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:39 -0500 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-32fdc5be26dso1341582f8f.2 for ; Fri, 01 Dec 2023 01:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423395; x=1702028195; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JqE1WlTC8iW99lEPTJa1X2LXMjo5z4bbux1ltP+LwY0=; b=jYG0BzAUW8y2xu8GKnwNVwu56t5I4Vg6uNrXisDywfWAm9vmo9g0d9511zhWvqCL9U 5H+rXrx/z0InyyDPEnd+nkJXcOHCXaCDC9J9GpJyPNTONiUqs+qQqs9bXdjbxQGMnpJo pLIUZXc0idPd/8UgVcBd8tUmG1HjfkO1CVqXi3DbEDNz5tdNvEl1lLGRqXF7A2T7BzSc lxJOYkx245b4V3gZg2Raz3UU+MrLGa/D4puX2EVyPJCtto6pYDXk58JJnFcSvHATnrzJ MzD9/dcjjBZDkPoaQHIIXHGPL/9dHMq3GgEO1+F0sB87thOqWV/fd4SQKYu4w2S7L0KL xxUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423395; x=1702028195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JqE1WlTC8iW99lEPTJa1X2LXMjo5z4bbux1ltP+LwY0=; b=dgT/IYeuNbdKgdngy32i0OfasNBFTTHuT1C9sP+fWeTAdVSH9gizvKDYS/5BbnRHLO AkgQZVReyKheRqkZyxrAYsA+ROjiu7Js6O6mpzvrNB/sAFnMnDzAwqcOWcOwH/k1dCsU WX1vk8C0Uf3tocmtEItq5CQKAGf2wqh3JEOL4ZiVwmDU4ajrAaGXVWcVXa7ZZcf5uEya AjKTV+l87EaaJk17fgF4WMfnynN0BNDq0B6R6bMFizWsKtABkbLMVjokeiL7Hg0eJSAd lUwZGC7ua9rZFnKNFKy5MUIl0tu05S3hDafzi57QIIerK5BHUWn4/4extw5Yu1K1kryD Z2Dw== X-Gm-Message-State: AOJu0Yz/P3LYfjTFnHGTg3H/zxxsmkO2587FGKhaEPJRwuOROPmAEXqY FZhX6He/+giWPndo/qD4V451Bw== X-Received: by 2002:adf:efc4:0:b0:333:2fd2:8130 with SMTP id i4-20020adfefc4000000b003332fd28130mr545320wrp.77.1701423394671; Fri, 01 Dec 2023 01:36:34 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id w18-20020a5d6092000000b003142e438e8csm3690050wrt.26.2023.12.01.01.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:34 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 015925FB61; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Luis Machado , Richard Henderson Subject: [PATCH v2 1/7] gdbstub: use a better signal when we halt for IO reasons Date: Fri, 1 Dec 2023 09:36:27 +0000 Message-Id: <20231201093633.2551497-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The gdb description GDB_SIGNAL_IO is "I/O possible" and by default gdb will try and restart the guest, getting us nowhere. Report GDB_SIGNAL_STOP instead which should at least halt the session at the failure point. Signed-off-by: Alex Bennée Reviewed-by: Luis Machado Reviewed-by: Richard Henderson --- gdbstub/internals.h | 1 + gdbstub/system.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 465c24b36e..5c0c725e54 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -24,6 +24,7 @@ enum { GDB_SIGNAL_TRAP = 5, GDB_SIGNAL_ABRT = 6, GDB_SIGNAL_ALRM = 14, + GDB_SIGNAL_STOP = 17, GDB_SIGNAL_IO = 23, GDB_SIGNAL_XCPU = 24, GDB_SIGNAL_UNKNOWN = 143 diff --git a/gdbstub/system.c b/gdbstub/system.c index 783ac140b9..83fd452800 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -183,7 +183,7 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state) break; case RUN_STATE_IO_ERROR: trace_gdbstub_hit_io_error(); - ret = GDB_SIGNAL_IO; + ret = GDB_SIGNAL_STOP; break; case RUN_STATE_WATCHDOG: trace_gdbstub_hit_watchdog(); From patchwork Fri Dec 1 09:36:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748984 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168407wrr; Fri, 1 Dec 2023 01:38:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFB83B/DO0HJ8BKXV487bcMcd7lVGXrB0VsnPjEXU/0l54FvoC+t2M+zV2sGf8GJBgajvVo X-Received: by 2002:a05:6830:280f:b0:6d8:52e0:180a with SMTP id w15-20020a056830280f00b006d852e0180amr2523741otu.17.1701423504070; Fri, 01 Dec 2023 01:38:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423504; cv=none; d=google.com; s=arc-20160816; b=MEg5N6GftPu2pMY/3UMgKSzl8wIBW+GPXWk5ZlzEYvFub+4eb0jhNCR2qcB5RWESlo 9QFbQPCXaH12nvvKSwRVXQmag91Z35GTxPvRUc54j9Xb08nqqM/YqF8y2NpXvepdiD9c NbbCURROdq9CXgCUsA/X0aMRd5ZLyaSt54PE8rMAhAlWkTDEHhDPCU/SyWcc2xuapyyd yPH0//n4vgWp7MWxaL27iYzQ8Wdi6b5orAO1zz/BVitg5EHcEJv8FqLJORR1SY+Xqgb1 W7JcO3Y7OYKbsdpaw2AkPXRbgFRUC6TIhGsOgwSQC6T+fh/b7U/SjokpZa7knul4WdPF t9HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1fLA9HqwzG3bToXvOE1aHD3zBjzOSiUc0V1bowUocRU=; fh=O7ROGzWhTwE5UjSDIfDBUgs09C/dTUir/POGCKKHRT0=; b=HPjP3e9pjgz+MHFHsEBldzaqVHn+N/kl65hDMbzfRokYjn4PT6aonpUsfhoAUBqb9+ VfDiWJSviahdMTVCiKfvOJPXVRom9zFFIKHY51kyDs2NCyH2fmIeUwpMiR0RQ4ILMEaa tiPIdVMlSQobSu98BRBhdU1d9iVt9yKAWyxgqeKDu2/fdKhE9SwccvTx14LH6OVM3T0G AvLF7I8LXdRjf2DJhLZtmp6t6G7qMy0bpjASNEfs+uAvD7CSSsS4J3KbhgwliCTBDXS+ IUqOOEykMHKjIEURs2yhYetjD8tn+p2m/fdqJHPaGzj/dH89Uxt7RQJDZjypC7ht9gs5 +Vqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="aIWA7/cY"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ci11-20020a05622a260b00b004239cefcde8si3199489qtb.224.2023.12.01.01.38.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:38:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="aIWA7/cY"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zx1-0003rt-H1; Fri, 01 Dec 2023 04:36:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zwy-0003qx-P4 for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:45 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zws-00045c-O2 for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:44 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40b4c2ef58aso19234505e9.0 for ; Fri, 01 Dec 2023 01:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423397; x=1702028197; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1fLA9HqwzG3bToXvOE1aHD3zBjzOSiUc0V1bowUocRU=; b=aIWA7/cYfJdL6iWTk07nzxd+n2vebthfCP7Xc5qRnEtK4GWw1Rw8ahfK8UzUJ7vl85 HwZc02DXZQ3cQFS9kfCEqtKU5aI1rgbAwBPAgdab33qkhJ4n0O/IJgzrvlvFJDZVfwNO fFPbtWPxRH9/4d2aQ0tU6J6E9XXf+QkD0seq4roIBQ60KBfJCs9CUALQBdZ7QgHWw1n0 eaOPrhVXZunuEaTIEE2NClFGe1CE7ZZAHq8GmI73aXCCZPkcfDfWPxolrriGxDMN4Gx/ uf54tEZBCgyyTuwLP544IsGTeltLS7m0SSh9+x1UM6QPTMvAzN7i/aGbK4PV27+A3dRH dDIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423397; x=1702028197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1fLA9HqwzG3bToXvOE1aHD3zBjzOSiUc0V1bowUocRU=; b=dStGZ70FFLekqJbl1bQs0gz+VZ1Xe4NmDPtAUBJ1lpBBbtp9ZriXiX3jALcdPFTZm7 U012q9q0BJafCAaTcJE16r3z+WEcisFyyV2I//0rMRlNK1b3U975MhhnCum7s4POK415 cHHjjJ/PCBHJY5v+kN37WfaVeNS0dzZfowPdS4Rsz00KR39dS0tr95DLYJHNTgp5vYiz QhgO2X4lG3QEen0z7yAza6VZfyhgGdlfEhKWu8Gb2FmEiqVtgNP+a6rdd0QMO+Jx0e06 AYm9/Ysh+kXneFIwydxtJBAGc+q3yNwnlKD+/dYc2Gxbw8n+gP0VeznISrtSdPebebv3 8dLg== X-Gm-Message-State: AOJu0YzBepEYZOu6zomskMBEBb1YwKnUl+/0bAFaC13SmRGe1E502ZL7 GBtq5ZLJBy0Vj7GWPFZ8E/R2sA== X-Received: by 2002:a05:600c:1989:b0:40b:5e1c:2f9d with SMTP id t9-20020a05600c198900b0040b5e1c2f9dmr220565wmq.45.1701423397082; Fri, 01 Dec 2023 01:36:37 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id f15-20020a05600c4e8f00b0040b3632e993sm8465107wmq.46.2023.12.01.01.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:34 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 24DD35FB63; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 2/7] docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS Date: Fri, 1 Dec 2023 09:36:28 +0000 Message-Id: <20231201093633.2551497-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org It doesn't make sense to have two classes of flaky tests. While it may take the constrained environment of CI to trigger failures easily it doesn't mean they don't occasionally happen on developer machines. As CI is the gating factor to passing there is no point developers running the tests locally anyway unless they are trying to fix things. While we are at it update the language in the docs to discourage the QEMU_TEST_FLAKY_TESTS becoming a permanent solution. Message-Id: <20231130153333.2424775-3-alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- v2 - be more explicit about raising bugs - add some bug urls --- docs/devel/testing.rst | 31 +++++++++++++++--------- tests/avocado/boot_linux.py | 8 +++--- tests/avocado/boot_linux_console.py | 5 ++-- tests/avocado/intel_iommu.py | 5 ++-- tests/avocado/linux_initrd.py | 5 ++-- tests/avocado/machine_aspeed.py | 8 +++--- tests/avocado/machine_mips_malta.py | 8 +++--- tests/avocado/machine_rx_gdbsim.py | 8 +++--- tests/avocado/machine_s390_ccw_virtio.py | 2 +- tests/avocado/replay_kernel.py | 6 +++-- tests/avocado/reverse_debugging.py | 14 +++++++---- tests/avocado/smmu.py | 5 ++-- tests/avocado/tuxrun_baselines.py | 4 +-- 13 files changed, 68 insertions(+), 41 deletions(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 22218dbedb..76465b8f3d 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -1371,23 +1371,32 @@ conditions. For example, tests that take longer to execute when QEMU is compiled with debug flags. Therefore, the ``AVOCADO_TIMEOUT_EXPECTED`` variable has been used to determine whether those tests should run or not. -GITLAB_CI -^^^^^^^^^ -A number of tests are flagged to not run on the GitLab CI. Usually because -they proved to the flaky or there are constraints on the CI environment which -would make them fail. If you encounter a similar situation then use that -variable as shown on the code snippet below to skip the test: +QEMU_TEST_FLAKY_TESTS +^^^^^^^^^^^^^^^^^^^^^ +Some tests are not working reliably and thus are disabled by default. +This includes tests that don't run reliably on GitLab's CI which +usually expose real issues that are rarely seen on developer machines +due to the constraints of the CI environment. If you encounter a +similar situation then raise a bug and then mark the test as shown on +the code snippet below: .. code:: - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + # See https://gitlab.com/qemu-project/qemu/-/issues/nnnn + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') def test(self): do_something() -QEMU_TEST_FLAKY_TESTS -^^^^^^^^^^^^^^^^^^^^^ -Some tests are not working reliably and thus are disabled by default. -Set this environment variable to enable them. +Tests should not live in this state forever and should either be fixed +or eventually removed. + +To run such tests locally you will need to set the environment +variable. For example: + +.. code:: + + env QEMU_TEST_FLAKY_TESTS=1 ./pyvenv/bin/avocado run \ + tests/avocado/boot_linux.py:BootLinuxPPC64.test_pseries_tcg Uninstalling Avocado ~~~~~~~~~~~~~~~~~~~~ diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index be30dcbd58..9e9773e6e1 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -12,7 +12,7 @@ from avocado_qemu import LinuxTest, BUILD_DIR -from avocado import skipIf +from avocado import skipUnless class BootLinuxX8664(LinuxTest): @@ -93,7 +93,8 @@ class BootLinuxPPC64(LinuxTest): timeout = 360 - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_pseries_tcg(self): """ :avocado: tags=machine:pseries @@ -111,7 +112,8 @@ class BootLinuxS390X(LinuxTest): timeout = 240 - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_s390_ccw_virtio_tcg(self): """ :avocado: tags=machine:s390-ccw-virtio diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 6eab515718..231b4f68e5 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests/avocado/boot_linux_console.py @@ -15,7 +15,7 @@ from avocado import skip from avocado import skipUnless -from avocado import skipIf +from avocado import skipUnless from avocado_qemu import QemuSystemTest from avocado_qemu import exec_command from avocado_qemu import exec_command_and_wait_for_pattern @@ -1419,7 +1419,8 @@ def test_ppc_mac99(self): # This test has a 6-10% failure rate on various hosts that look # like issues with a buggy kernel. As a result we don't want it # gating releases on Gitlab. - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_sh4_r2d(self): """ :avocado: tags=arch:sh4 diff --git a/tests/avocado/intel_iommu.py b/tests/avocado/intel_iommu.py index 77635ab56c..2dd11a6346 100644 --- a/tests/avocado/intel_iommu.py +++ b/tests/avocado/intel_iommu.py @@ -9,10 +9,11 @@ # later. See the COPYING file in the top-level directory. import os -from avocado import skipIf +from avocado import skipUnless from avocado_qemu import LinuxTest -@skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') +@skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + class IntelIOMMU(LinuxTest): """ :avocado: tags=arch:x86_64 diff --git a/tests/avocado/linux_initrd.py b/tests/avocado/linux_initrd.py index ba02e5a563..c40a987bd1 100644 --- a/tests/avocado/linux_initrd.py +++ b/tests/avocado/linux_initrd.py @@ -13,7 +13,7 @@ import tempfile from avocado_qemu import QemuSystemTest -from avocado import skipIf +from avocado import skipUnless class LinuxInitrd(QemuSystemTest): @@ -53,7 +53,8 @@ def test_with_2gib_file_should_exit_error_msg_with_linux_v3_6(self): max_size + 1) self.assertRegex(self.vm.get_log(), expected_msg) - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_with_2gib_file_should_work_with_linux_v4_16(self): """ QEMU has supported up to 4 GiB initrd for recent kernel diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py index df31b2a8a8..258fb50c47 100644 --- a/tests/avocado/machine_aspeed.py +++ b/tests/avocado/machine_aspeed.py @@ -18,7 +18,7 @@ from avocado_qemu import interrupt_interactive_console_until_pattern from avocado_qemu import has_cmd from avocado.utils import archive -from avocado import skipIf +from avocado import skipUnless from avocado import skipUnless @@ -311,7 +311,8 @@ def do_test_arm_aspeed_sdk_start(self, image): self, 'boot', '## Loading kernel from FIT Image') self.wait_for_console_pattern('Starting kernel ...') - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_arm_ast2500_evb_sdk(self): """ :avocado: tags=arch:arm @@ -329,7 +330,8 @@ def test_arm_ast2500_evb_sdk(self): self.workdir + '/ast2500-default/image-bmc') self.wait_for_console_pattern('nodistro.0 ast2500-default ttyS4') - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_arm_ast2600_evb_sdk(self): """ :avocado: tags=arch:arm diff --git a/tests/avocado/machine_mips_malta.py b/tests/avocado/machine_mips_malta.py index 9bd54518bf..959dcf5602 100644 --- a/tests/avocado/machine_mips_malta.py +++ b/tests/avocado/machine_mips_malta.py @@ -11,7 +11,7 @@ import gzip import logging -from avocado import skipIf +from avocado import skipUnless from avocado import skipUnless from avocado.utils import archive from avocado_qemu import QemuSystemTest @@ -101,7 +101,8 @@ def test_mips_malta_i6400_framebuffer_logo_1core(self): """ self.do_test_i6400_framebuffer_logo(1) - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_mips_malta_i6400_framebuffer_logo_7cores(self): """ :avocado: tags=arch:mips64el @@ -111,7 +112,8 @@ def test_mips_malta_i6400_framebuffer_logo_7cores(self): """ self.do_test_i6400_framebuffer_logo(7) - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_mips_malta_i6400_framebuffer_logo_8cores(self): """ :avocado: tags=arch:mips64el diff --git a/tests/avocado/machine_rx_gdbsim.py b/tests/avocado/machine_rx_gdbsim.py index 6cd8704b01..350a73fbbb 100644 --- a/tests/avocado/machine_rx_gdbsim.py +++ b/tests/avocado/machine_rx_gdbsim.py @@ -10,7 +10,7 @@ import os -from avocado import skipIf +from avocado import skipUnless from avocado_qemu import QemuSystemTest from avocado_qemu import exec_command_and_wait_for_pattern from avocado_qemu import wait_for_console_pattern @@ -22,7 +22,8 @@ class RxGdbSimMachine(QemuSystemTest): timeout = 30 KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 ' - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_uboot(self): """ U-Boot and checks that the console is operational. @@ -46,7 +47,8 @@ def test_uboot(self): # FIXME limit baudrate on chardev, else we type too fast #exec_command_and_wait_for_pattern(self, 'version', gcc_version) - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_linux_sash(self): """ Boots a Linux kernel and checks that the console is operational. diff --git a/tests/avocado/machine_s390_ccw_virtio.py b/tests/avocado/machine_s390_ccw_virtio.py index ffd914ded9..61e75d8f9e 100644 --- a/tests/avocado/machine_s390_ccw_virtio.py +++ b/tests/avocado/machine_s390_ccw_virtio.py @@ -12,7 +12,7 @@ import os import tempfile -from avocado import skipIf +from avocado import skipUnless from avocado_qemu import QemuSystemTest from avocado_qemu import exec_command_and_wait_for_pattern from avocado_qemu import wait_for_console_pattern diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py index 53cb7e5091..0d32cc280e 100644 --- a/tests/avocado/replay_kernel.py +++ b/tests/avocado/replay_kernel.py @@ -15,7 +15,7 @@ import time from avocado import skip -from avocado import skipIf +from avocado import skipUnless from avocado import skipUnless from avocado_qemu import wait_for_console_pattern from avocado.utils import archive @@ -82,6 +82,7 @@ def run_rr(self, kernel_path, kernel_command_line, console_pattern, class ReplayKernelNormal(ReplayKernelBase): + # See https://gitlab.com/qemu-project/qemu/-/issues/2010 @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test sometimes gets stuck') def test_x86_64_pc(self): """ @@ -179,7 +180,8 @@ def test_arm_virt(self): self.run_rr(kernel_path, kernel_command_line, console_pattern, shift=1) - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_arm_cubieboard_initrd(self): """ :avocado: tags=arch:arm diff --git a/tests/avocado/reverse_debugging.py b/tests/avocado/reverse_debugging.py index ed04e92bb4..9a468321e5 100644 --- a/tests/avocado/reverse_debugging.py +++ b/tests/avocado/reverse_debugging.py @@ -10,7 +10,7 @@ import os import logging -from avocado import skipIf +from avocado import skipUnless from avocado_qemu import BUILD_DIR from avocado.utils import datadrainer from avocado.utils import gdb @@ -206,7 +206,8 @@ def get_pc(self, g): + self.get_reg_le(g, self.REG_CS) * 0x10 # unidentified gitlab timeout problem - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_x86_64_pc(self): """ :avocado: tags=arch:x86_64 @@ -223,7 +224,8 @@ class ReverseDebugging_AArch64(ReverseDebugging): REG_PC = 32 # unidentified gitlab timeout problem - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_aarch64_virt(self): """ :avocado: tags=arch:aarch64 @@ -247,7 +249,8 @@ class ReverseDebugging_ppc64(ReverseDebugging): REG_PC = 0x40 # unidentified gitlab timeout problem - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_ppc64_pseries(self): """ :avocado: tags=arch:ppc64 @@ -260,7 +263,8 @@ def test_ppc64_pseries(self): self.reverse_debugging() # See https://gitlab.com/qemu-project/qemu/-/issues/1992 - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_ppc64_powernv(self): """ :avocado: tags=arch:ppc64 diff --git a/tests/avocado/smmu.py b/tests/avocado/smmu.py index b3c4de6bf4..05b34418a5 100644 --- a/tests/avocado/smmu.py +++ b/tests/avocado/smmu.py @@ -9,10 +9,11 @@ # later. See the COPYING file in the top-level directory. import os -from avocado import skipIf +from avocado import skipUnless from avocado_qemu import LinuxTest, BUILD_DIR -@skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') +@skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + class SMMU(LinuxTest): """ :avocado: tags=accel:kvm diff --git a/tests/avocado/tuxrun_baselines.py b/tests/avocado/tuxrun_baselines.py index c99bea6c0b..5f859f4e6f 100644 --- a/tests/avocado/tuxrun_baselines.py +++ b/tests/avocado/tuxrun_baselines.py @@ -13,7 +13,7 @@ import time import tempfile -from avocado import skip, skipIf +from avocado import skip, skipUnless from avocado_qemu import QemuSystemTest from avocado_qemu import exec_command, exec_command_and_wait_for_pattern from avocado_qemu import wait_for_console_pattern @@ -551,7 +551,7 @@ def test_s390(self): haltmsg="Requesting system halt") # Note: some segfaults caused by unaligned userspace access - @skipIf(os.getenv('GITLAB_CI'), 'Skipping unstable test on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') def test_sh4(self): """ :avocado: tags=arch:sh4 From patchwork Fri Dec 1 09:36:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748982 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168401wrr; Fri, 1 Dec 2023 01:38:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuJp2iJQxTOH468z4NkoN2qsV0J7n9drODyg1xPKdlsyMEL0aGEhOFvvI8kz/pgyBQOiAE X-Received: by 2002:ad4:4f4d:0:b0:67a:9a36:eb41 with SMTP id eu13-20020ad44f4d000000b0067a9a36eb41mr936432qvb.57.1701423503680; Fri, 01 Dec 2023 01:38:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423503; cv=none; d=google.com; s=arc-20160816; b=XUorD5205mEEA8tHcP2lTM5MGZWCOJCilHEuy33BnETCNFkCJyjV0N+IW8EPV+OCaA C6uuAur426XS+10Hrn3+jTXN/uXojbC+rDdnxNU6eOHR0J3dMHTATNC9KdE5FedvMhHK 4ry5M2HjCXKfhWQTlOfzeULAQg7JP9P17mfQyXYjJ/1/pb8lqfYxSPjyEpLVRLfaF1Fg X2VF8x+G4H7QZxpcBDUuaiWxC/lYwccuAnRZ1Qhx87irBBZBftxLtZCICRxh1GgOhbNH nmZKQUJkY3pI8ctljDgh/fDsSdIrTwhYJC6ifC12g+5oy607XzKTz3Ra+wQiL5vdZgLD 9r3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nBPmW4w4M+av4eb0WryP3C6eoVDII09MJF71sUkUxZM=; fh=5ObXncux7mBHqFnIP98RpLHfzwH2akVN3xmNFORu718=; b=oLB56SbTQvo2ww1T0wgZmfZOjk1Cx9zmbXNs/fLkQRKjc5/iIh63Iyr/k7kwZwoMZo Iq0i9i+3UjA81EgR5H1g9Yl1igZL3VWgebhfvwkymaiHuPjsz6gUQc0JYi9YS+/lXYqV sj4yHUwRu12aewfOAp3vPTqbWk2QxTtjJTUPtNEgEZLdNR6HOHjP8r14tyrM9gdhVMC/ zwPfU2JuWHsTtxOt6fFTgcSv8cUSocj2F58I0uaZA1XZ65/exiV0Z4g4Rhk53qA8M1t+ 0ydWjmaGPaKIF2rAMEHvKklSd00+Ul1ODVkEtlyN8n3gV2fgZOE1bjjgrUjUAIjGnii0 mraQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iu6IKfpj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id fk18-20020a05622a559200b0040fe32ab0b6si3030857qtb.286.2023.12.01.01.38.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:38:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iu6IKfpj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zwx-0003po-SN; Fri, 01 Dec 2023 04:36:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zwv-0003nl-L5 for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:41 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zwq-00044p-Om for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:41 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40859dee28cso17081005e9.0 for ; Fri, 01 Dec 2023 01:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423395; x=1702028195; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nBPmW4w4M+av4eb0WryP3C6eoVDII09MJF71sUkUxZM=; b=iu6IKfpjF/zw3hnKI3Ahxe56B25p9mwBLSzmTpsw9b/YomLdxg8tV/Tl8itNGs8fxj rDlMWJjxI0/7GZDGMo1tf3iFWPDPe2e535Kjbi4V0xav6bCgM5LEtU5xwSBtQ2ian+5G TiJCvLjVrvXEB/ozDju9OyhETv5q/aB08rVSdjS5kJPhdgxYrSN3Wk4ZWkJ68xj+I0Cl 7wxltHSm7rwu2/ySU1hBy/6mkzNkSuUuCVUndA5lB9YZCJieqesMCjZnH/1RtH7xc5+o uOkMfMoBKZ2Kx1bRGZU0RxgnZVda6VnO6nyE0FRcPWrzoMv3RytiE/J0NFPZj76KldJJ QnSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423395; x=1702028195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nBPmW4w4M+av4eb0WryP3C6eoVDII09MJF71sUkUxZM=; b=LBc+6+TPW0+XWFc5WfaCOD3R0BZ6lLF2ktUQqIMPoze36SYdn8H6XxIsG5RfZOxxwI j9/7SifwP0g6wztqxOAOCjYK5MyiWz5UCbjLjB2z7TBfhDEx2zvYs8cDKAk3708D7xZr OIFIGH6W6Vzs1gibmbcnHiCvQJFobBlKekpsbryKtlA6EONJDErPUShOF9dCy9jBUD5z VT3xag4hi3fu9oYm15ncpQ604B7p0DW2sMBllOwV8zqpG+AQ3Us9pegSYbKiLznHSGwh FJcLtbxKHct2cA6PjsAGl1YWTpNz7LcyCrl7EwO+kPPn6Sy0sFDZLHLLYX8ZesG5VEre TOqQ== X-Gm-Message-State: AOJu0YxlJqblxuzSb+k9F7UUO0j7nfhlFSIKkHfDqaLBhC2i4eshUNVq Ku759HZS9tun09RLWoZ2mfZXBQ== X-Received: by 2002:a05:600c:3143:b0:40b:2a69:6c37 with SMTP id h3-20020a05600c314300b0040b2a696c37mr395607wmo.4.1701423395100; Fri, 01 Dec 2023 01:36:35 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id f17-20020a05600c155100b004083729fc14sm8491006wmg.20.2023.12.01.01.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:34 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3D5945FB65; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefan Hajnoczi Subject: [PATCH v2 3/7] tests/avocado: drop BootLinuxConsole.test_mips_malta_cpio test Date: Fri, 1 Dec 2023 09:36:29 +0000 Message-Id: <20231201093633.2551497-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The assets are no longer archived by Debian so we can't run this on CI. While some people may still have the test in their cache we do have more recent images from tuxrun so this isn't a great loss. Signed-off-by: Alex Bennée Cc: Stefan Hajnoczi Cc: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi --- tests/avocado/boot_linux_console.py | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 231b4f68e5..5d978f6dd0 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests/avocado/boot_linux_console.py @@ -116,28 +116,6 @@ def test_x86_64_pc(self): console_pattern = 'Kernel command line: %s' % kernel_command_line self.wait_for_console_pattern(console_pattern) - def test_mips_malta(self): - """ - :avocado: tags=arch:mips - :avocado: tags=machine:malta - :avocado: tags=endian:big - """ - deb_url = ('http://snapshot.debian.org/archive/debian/' - '20130217T032700Z/pool/main/l/linux-2.6/' - 'linux-image-2.6.32-5-4kc-malta_2.6.32-48_mips.deb') - deb_hash = 'a8cfc28ad8f45f54811fc6cf74fc43ffcfe0ba04' - deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash) - kernel_path = self.extract_from_deb(deb_path, - '/boot/vmlinux-2.6.32-5-4kc-malta') - - self.vm.set_console() - kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyS0' - self.vm.add_args('-kernel', kernel_path, - '-append', kernel_command_line) - self.vm.launch() - console_pattern = 'Kernel command line: %s' % kernel_command_line - self.wait_for_console_pattern(console_pattern) - def test_mips64el_malta(self): """ This test requires the ar tool to extract "data.tar.gz" from From patchwork Fri Dec 1 09:36:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748981 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168353wrr; Fri, 1 Dec 2023 01:38:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHN1LBLrOL2Ijc7ujwtspDJZL+xx49KvMpG3AaCG7836rcVvb7biSWvwDEUHkXTF+EQtA9k X-Received: by 2002:a05:620a:888a:b0:77d:85cd:fa6b with SMTP id qk10-20020a05620a888a00b0077d85cdfa6bmr17309845qkn.78.1701423495803; Fri, 01 Dec 2023 01:38:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423495; cv=none; d=google.com; s=arc-20160816; b=HqT985+Z0+fWChqL7L4nShNPqn+ug0Ncr5Gh09UyAIpHcNQL7mWiyMiomZ8UshVYCV hNbbbuWs9kDjEQKaay9zKuG0lh/lpMtRfw8/NNAw0R3T9XnSqiH0irXIc5z/BJpT+3xr UrQffTTT3vAd63Ng5UToA+0EOR3kPju8zlYSIzpPokvIH5K80xJ7tLorUFmhgVMInsx5 Zf6rqq33AF5swUVKO1ZN7cpel1+QOjoKJ1imbiV4u6EzRwY75CjFt1NAwlzPIIHPS11/ B6bN4P0zvdNVkg5mQaVvJtWM0CALaUYcICf9lhNYEnhbtUxm44OWwF8oy2VzWWKwSIeO 7qjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=N7oEpLW+aG0VhOA+9+YE1AjdRXhZYR6BB1KY1d7oEhc=; fh=nUw+LUW/RGBz2SNf0vgpYoxsz7YIcRha0AoZqkhC2t0=; b=Z1P7lnFV22WaQv/jMUkJKJx5LGhkoMbjSVmlnJmltOTOW+UgfpoFxzq6fmUhSYIFKU ddE9SV3JxLkgbazjkwi7LurcTVhKlV/2pG5uwUW00Gw6jhs3BW9eDnzPDlkswKgOtwJP +W/QPztnJAxsY+nWLIR0bzxIyHWrVj4nbdDz01zIvD/1hWtv1FYwUpgXsdk8hDcBHVqy OUYCHaUelQEL9YnzXFb0POp3NwIGXrULF+ovEynejCQZGNLrxbJ8TXdGK+POISBbCdXV vROoczpjoQssQY+WqgPYPCq05Emuj6afculR7a285mqcvoz1mUneuvZprBx8Z9g5qiTq HWXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DBDbYkns; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dl10-20020a05620a1d0a00b00765aafce58csi3026673qkb.120.2023.12.01.01.38.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:38:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DBDbYkns; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zww-0003oh-Jn; Fri, 01 Dec 2023 04:36:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zwv-0003ny-OP for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:41 -0500 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zws-00045V-Hp for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:41 -0500 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c9caf896b7so21122191fa.0 for ; Fri, 01 Dec 2023 01:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423397; x=1702028197; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N7oEpLW+aG0VhOA+9+YE1AjdRXhZYR6BB1KY1d7oEhc=; b=DBDbYknsL+vwpJywwk3OlLMLnQdZdsVNniKpXpG+WLvikZuxY9q99AkMRa8Lp0omwi cBmt8fyFLmTVorTHLykSUPS6OYxsgktX4F5YcAxkI8LXpY03hJbtMYacwQCPS1ml5Ok9 Mewy1rNlGh7n0SF/W0FgmemRysbHCpq2jKDm5JXoOTxE2+ANImWqCMg6O87qPce2bXZY Jo0D8B7MhF7kxquYwXv7/sG3vtzQT39qGzYX00VWqHN7Q2wByl24defH7xbmG8Aat0OM MN9DVGOWRHGliOa/8RRicugsF+c76xf0W1/q4toctI7zOFQSf0CgCokFKu6tdPR6qrly XN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423397; x=1702028197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N7oEpLW+aG0VhOA+9+YE1AjdRXhZYR6BB1KY1d7oEhc=; b=d9+jOOLV0cd4GdOt1sTdqCUOB7IBQjCVN/dqGrgIy2IuOpZfD2kh1aeGOCkEG6Z2CA qLomrBZYFDPFQk2onU0zNsZ+DZ03OLuVUgvsfraMlqhVPYr3qqPxCTIaaJlmijtTAwfR 4Sz95up6mut67wW5ajz7OgtdpFslYPJ769Ueh10rHR2pVWHXvJ5lALgXnadC4+SxeIoe 0AZu62xe/jsUWJaJSsd9VfUsx/r7QGyl8H6187IOqnk+K+WwYl3xKCB+ZbuLN4sMFICD x8bpBl5a6vN2gkA36v/41am09EPeYs3DWa+6YEpadiXB5f27pc1pyKc0/iCfgwaUdHgz z8FQ== X-Gm-Message-State: AOJu0Yz5IRw6Z9/pWfU6ka7INPUm+QmtMw/alOr6M27v5LDZV6K5N4bJ Xi/9L1touakZbFjZO4WfB0sIIw== X-Received: by 2002:a2e:700b:0:b0:2c9:bcb7:5e33 with SMTP id l11-20020a2e700b000000b002c9bcb75e33mr612086ljc.44.1701423396843; Fri, 01 Dec 2023 01:36:36 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id o9-20020a5d58c9000000b00332e1c46dddsm3662260wrf.98.2023.12.01.01.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:34 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 51E915FB67; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 4/7] tests/avocado: drop malta yamon tests Date: Fri, 1 Dec 2023 09:36:30 +0000 Message-Id: <20231201093633.2551497-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::234; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The assets are no longer available on the website so these are blocking CI. Signed-off-by: Alex Bennée Cc: Philippe Mathieu-Daudé --- tests/avocado/machine_mips_malta.py | 37 ----------------------------- 1 file changed, 37 deletions(-) diff --git a/tests/avocado/machine_mips_malta.py b/tests/avocado/machine_mips_malta.py index 959dcf5602..3a1ec85c20 100644 --- a/tests/avocado/machine_mips_malta.py +++ b/tests/avocado/machine_mips_malta.py @@ -122,40 +122,3 @@ def test_mips_malta_i6400_framebuffer_logo_8cores(self): :avocado: tags=mips:smp """ self.do_test_i6400_framebuffer_logo(8) - -class MaltaMachine(QemuSystemTest): - - def do_test_yamon(self): - rom_url = ('http://www.imgtec.com/tools/mips-tools/downloads/' - 'yamon/yamon-bin-02.22.zip') - rom_hash = '8da7ecddbc5312704b8b324341ee238189bde480' - zip_path = self.fetch_asset(rom_url, asset_hash=rom_hash) - - archive.extract(zip_path, self.workdir) - yamon_path = os.path.join(self.workdir, 'yamon-02.22.bin') - - self.vm.set_console() - self.vm.add_args('-bios', yamon_path) - self.vm.launch() - - prompt = 'YAMON>' - pattern = 'YAMON ROM Monitor' - interrupt_interactive_console_until_pattern(self, pattern, prompt) - wait_for_console_pattern(self, prompt) - self.vm.shutdown() - - def test_mipsel_malta_yamon(self): - """ - :avocado: tags=arch:mipsel - :avocado: tags=machine:malta - :avocado: tags=endian:little - """ - self.do_test_yamon() - - def test_mips64el_malta_yamon(self): - """ - :avocado: tags=arch:mips64el - :avocado: tags=machine:malta - :avocado: tags=endian:little - """ - self.do_test_yamon() From patchwork Fri Dec 1 09:36:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748985 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168512wrr; Fri, 1 Dec 2023 01:38:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZRYhRkd7RlFOe1PtcKhZf3911tXpJC06Z2sG8qOewN7j0n5XlJ1MxYTE2/Xdctc2zoBQ5 X-Received: by 2002:ad4:4192:0:b0:67a:7401:ca4c with SMTP id e18-20020ad44192000000b0067a7401ca4cmr6875784qvp.47.1701423523409; Fri, 01 Dec 2023 01:38:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423523; cv=none; d=google.com; s=arc-20160816; b=PG6INGhdV0lgH15nA1j8hM3TBsvJwrlPtAtQ6xlkbFjk4sr8DUv4cGxANOoXSa7zjY SjhcEmAYSaxwgYnGLCyHUxAABBbnUJm04J33s57iCEb3RYgxdj9aVxcMT74gnwq4SyXN DaTnwX7oM3W7Lm/ZegWIa1e7N8pwU0KP+JENnJ4ethpSnKiaj56iPmBiiZsfCYo7jEVD 5yHFkSq+Mg3BImKdHt3E40/vtNLP+a2YESnDCA/zi1xJfRSCgdxW3ddUB/GbA46mKzmN f4lfK3e9f4zPTzvU6z4f0AldtEMUBWObKLUNpvM70bkMmYs82gbdYfPwO59nJFa4LiwA /GyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q2mKYaqQwRPyOn+b0fzZNJnY6rsKfn5mWX6d/74jDLg=; fh=nUw+LUW/RGBz2SNf0vgpYoxsz7YIcRha0AoZqkhC2t0=; b=XMvsLryJbMP/lpKyngbsAus8e9E4rfaHFELa27yyPfQwGNCfwJYMo3XNrjhOVugzhp wwWufCoOYdKBsdhuPCNpS+53r37aq2c/iHhztWxRbnnEuoe7FtCbFItqmm+tMHvjpHWa J1QqnI2BXrUgHeufd5Afuuzc3Qfx2K5vmZ/6tUGgkNhQIX6mUnfIK67hf8QE3jOxJ82C T+98DsjwblofsU+2o9CjwOBVpZr29OvbWT+IaPm62dcMOGzP27+U/ozjCPAvwb+2f4fr cbIMqet9EYS9+4fufagx78TzVcAruyBC7LFHvicnwcGhfY3Vozr5SUuKXfL47LT5H1Qg KL7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DooEn7I5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dk9-20020a056214092900b0067a51d82c10si2827173qvb.317.2023.12.01.01.38.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:38:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DooEn7I5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zx2-0003ud-Rn; Fri, 01 Dec 2023 04:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zwz-0003r7-6d for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:45 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zwv-000473-Ej for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:44 -0500 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50abbb23122so2654207e87.3 for ; Fri, 01 Dec 2023 01:36:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423399; x=1702028199; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q2mKYaqQwRPyOn+b0fzZNJnY6rsKfn5mWX6d/74jDLg=; b=DooEn7I5+el7NsJXelnMCt73JPXdY9tu6QCs/dc7mAFi4QBxxjpnxHdkowtawrkXTG Qag2gkC7GpirsYOjUnD156kTBehmubcBiyZtAE40vIbXFOBRAoEsIluhtKR9TTY8fPb1 gRef1bnCd85bGbRqe4z4o7tMeiQooJi9dDRIZteBAUc+i8fIEET0qjlZknn+VrwsMlSS KdYy4ZVO1qsPLVhKgQF0iI7QnYlDUZvtcaHEJwfBN9vjJf7VkpwVFTwxpqZJdU+GzTnW aWGUqSrCzc49duo23H/58LG9uIWGnYWYyIITOCx+5vQQP3+HfTuyV4WmHMf4NGR+NdT5 Rz9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423399; x=1702028199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2mKYaqQwRPyOn+b0fzZNJnY6rsKfn5mWX6d/74jDLg=; b=FcR+pGmGUmewC9GnAycNPU5VDGDNR85eiMKy2SV0F+zyWdRfquM0qBxIqh8blaDh6k 1IV+zyLykaT+R3m5YE51IDswV7w+48Z2SkpXzTG7SBuTH19obrvFOxJ/gXOF9wSAtDB2 Zak6OVW8ErnfCI10wvicUTYKYxdpv9zkVSXhF3R7snOLqKAHTyTHhHsISKTzQ2qW8nvc ArGQmvkylJ+aI+WXDmhcYjV8XlVPpDINDC4ZDKjLM+iQvSTy/EFhnPi1uXK3ur7tyFl2 wMMSSPUqORYYJ0FApiqIjKr8WPnk1/cjVBWjveAjGR5l/y/8mjoXcTtmemdEevgZl7SW 7Uuw== X-Gm-Message-State: AOJu0Yw5BKB0XV7/Mm1UQstAJewI6MG1FUmn2m8QmdcI8wruk7QDPBJa 0k8aIF1isBp+H4E2HDeAdhPF/A== X-Received: by 2002:a05:6512:142:b0:50b:c194:d413 with SMTP id m2-20020a056512014200b0050bc194d413mr418108lfo.55.1701423399512; Fri, 01 Dec 2023 01:36:39 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id f12-20020adfdb4c000000b00332d3b89561sm3710366wrj.97.2023.12.01.01.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:37 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 658B65FB69; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 5/7] tests/avocado: tag sbsa tests as tcg only Date: Fri, 1 Dec 2023 09:36:31 +0000 Message-Id: <20231201093633.2551497-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org As firmware runs at a higher privilege level than the hypervisor we can only run these tests under TCG emulation. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/avocado/machine_aarch64_sbsaref.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index bdd1efc768..c25a691b64 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -20,6 +20,7 @@ class Aarch64SbsarefMachine(QemuSystemTest): """ :avocado: tags=arch:aarch64 :avocado: tags=machine:sbsa-ref + :avocado: tags=accel:tcg """ timeout = 180 From patchwork Fri Dec 1 09:36:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748983 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168409wrr; Fri, 1 Dec 2023 01:38:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IF47ytZTGKvBgWH8Bc2IMAD6O1cWtswqxHC3p3SiRirq9jHHFkm/vrFK8xuF60YLY8WDUu3 X-Received: by 2002:ad4:5852:0:b0:67a:94e2:6d1c with SMTP id de18-20020ad45852000000b0067a94e26d1cmr1663986qvb.5.1701423504277; Fri, 01 Dec 2023 01:38:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423504; cv=none; d=google.com; s=arc-20160816; b=zHPSRB8AixcIeVKfPCLWaqoruykk71zNzaGMMP0ocDlC80ioDKikyhIhn6ebPYWID0 CIXgB1fFiEwOY5mJwd1F68aj8ZS9atLhIVGNVbpl6OHyBCpx216O161mlr3dJ20dsA9r 6GzryfRECHZFpCpb3bWcEZQPj8BBIRbnwUCHub9q/OWmlQEBtoxKHc7/v5hV0hoRYWqD a4lW5lEdMPi5wKWmOnda67mZXYvAJjTU2y1mcn5MTVCzr1jFW7l6l49CIKDWqe5cV5pW Fcr5wcnVUDsNc5tabxpKfpSD7DbX1g+g0RevdSEy/NcD2eqPk0Kliam88a3WP+O/d/Ls 0KSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zUg0v3uMioRQGt7KqmfkhZG/6jp+lM3qQiMuLIa+vH0=; fh=nUw+LUW/RGBz2SNf0vgpYoxsz7YIcRha0AoZqkhC2t0=; b=bRg9YiA75Jil2iM0MZ5KX1RQO5mmSR5NfvFa4RjQz/QZ1dCE1rqg7PkIZYeVT2uc3U W1/DyjrjoPWv82lZTT5vrQvsmUZOL9qmxYVDxeSvYtbPhoB58eudHdWbnohUE5fQPpxj RMCwzxQF7h9VP+mbOXtmJ5UeDvlTmfRQH4bwAPbZEwJOY91ooIXwWouvGRtquSvLfHiD 3DzeJqjYV2A7Yrn+3oL4j1cZJteOT1tHfgFbAjzEjS8GHRAO+b1StlMy80m0goxAvmmh QNZ1ihuXVvk6DZCNaohJB9bEkfa5NWPdFghV6EKHaohMeSGXAUg2G/f/ciQckIVEf7Uu 4lUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oXDWf09R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y17-20020a056214017100b0067a9e5aebe0si282827qvs.611.2023.12.01.01.38.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:38:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oXDWf09R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zwz-0003rZ-Jq; Fri, 01 Dec 2023 04:36:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zwx-0003os-0H for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:43 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zws-00045m-Q0 for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:42 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3332f1512e8so614315f8f.2 for ; Fri, 01 Dec 2023 01:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423397; x=1702028197; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zUg0v3uMioRQGt7KqmfkhZG/6jp+lM3qQiMuLIa+vH0=; b=oXDWf09RmiIRCVulq4DlBdwaRrYZJwRGXZLOx0TtXyLVLCIjtV+/M77fRVzhzwjWm2 sF6ZU3+gtHGsP8GaMNRTkKNrHuYFMl7t/0HR3Q25MhdO0mvSDf2u+VImsy9RN/J4xDIh DFBqqsQvrxFzpQjZYKllBaT37m7/Lt7chqp49NkGXWTEnn3OEuHJE96g3Xy3n9OMkI2X DUC7OzxE603WGqDgoWGixdCQt9IOo1Sd/tNDMpmbEtfeaiY/FEDLaS4zDXbC1stsdQNX t5oZpAJWWF4R21HrGpvTx5X9QdYJPoekpb+F8rInNCPUIKniDD8lcC7U1TR7Uag0SwgD ieSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423397; x=1702028197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zUg0v3uMioRQGt7KqmfkhZG/6jp+lM3qQiMuLIa+vH0=; b=JXLwX6yOgp8kMHy3aIPVzPKNXWG1fItlPsyw0gqYkVmUr8YR3YsYApipU+OpYPTXBl yjhqlV/rZturcLvUvg7+TWmgVH99V/kpwnvnXU7X6c3hdIMN4x01uuA/LwSNmBEaL5cf nXXVhyOliWyQ1Fov6+s28XQ2irtEE+vU67nvUt1TByzXjtULB0xOFjKTNtfVcyN4NxNu f1i+fHBgRODnsEnoRUyrC0bguhMiRkamPRTbFOxwxMD3YahOhAuw/QFd+5nrzcE6ah8K Xn2a+vJul3qju3eMa5ig2a1PE8ilUklE1/LoXAf/2uPpP70uw+KHDQ8HxxmFJGwqO6u6 bOzQ== X-Gm-Message-State: AOJu0YyFUog4sXvmaOsPRIbpXo7SFk8sVLBsSnV28Va2E7JZ3eixJObC Hymes1LdcLLqoWz0JxzrJLdXBw== X-Received: by 2002:a5d:5918:0:b0:332:c585:400a with SMTP id v24-20020a5d5918000000b00332c585400amr608471wrd.44.1701423397373; Fri, 01 Dec 2023 01:36:37 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id j6-20020a5d5646000000b0033307ffb193sm3716885wrw.29.2023.12.01.01.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:37 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 7BB945FB6B; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 6/7] gitlab: build the correct microblaze target Date: Fri, 1 Dec 2023 09:36:32 +0000 Message-Id: <20231201093633.2551497-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 7f9af83b10..62b5379a5e 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -41,7 +41,7 @@ build-system-ubuntu: variables: IMAGE: ubuntu2204 CONFIGURE_ARGS: --enable-docs - TARGETS: alpha-softmmu microblazeel-softmmu mips64el-softmmu + TARGETS: alpha-softmmu microblaze-softmmu mips64el-softmmu MAKE_CHECK_ARGS: check-build check-system-ubuntu: From patchwork Fri Dec 1 09:36:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748987 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp168634wrr; Fri, 1 Dec 2023 01:39:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzylWilccgv3B2VeJi+CLSclZ8g+uwdU37iqoyE8FuzDAmQkHiS3WX1Rr4Qkibe7ZVlBv3 X-Received: by 2002:a05:6102:d8:b0:464:59b8:274d with SMTP id u24-20020a05610200d800b0046459b8274dmr4259742vsp.26.1701423540506; Fri, 01 Dec 2023 01:39:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701423540; cv=none; d=google.com; s=arc-20160816; b=xFq5D/WLFFMMqzqKAtmg4ciR1ZeVDFNBi6yyxvOyjsgysSLB307hbACVNOkaNmThAa nYU2tXLBCztVi6dZ8/gFCheVfzgatdXf/ozg9yenY/VmKg45llQt3UF57TJX74pFx0jD ipEIwNgwEv3gb5cAPgXHyjVmi/ov6gKLrSaS7p+Wsup11ZsHy/fbGQfa5vsJgQYIw2li vC/P5NZasfnEQQl4v0XQ/CMDYBJoU3FtrdoK7StQif7Pb/QFtx53gDgVJZwoHU994iQl lul78o/Cx67qPNDh5xQn59k5s7kKlQVvIdzIz0mE0KmGxHgocfSs5+2K/dl+G879GMgO v72g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GoNh2oMU49/LTEW/ECcUYLD8q7yKf6zjz1ExnMRKy2Y=; fh=O7ROGzWhTwE5UjSDIfDBUgs09C/dTUir/POGCKKHRT0=; b=kiETM+o/9CxQm3tnHLAZ6NzvMKk1UkOR1AQQosSRVc2y5oOnRaWpPPJP2FdB7fGZwa M2MtTRoPi0To4IbNKcGAjAYJjmTZdhPMiJK15jL6KNi15wItBh7658pl2GAp+BL+EBxJ MqTSbwZIp2SWd6Qb0aZrtCNc9d+v96uW2taWCJ8V62ZmILOw31G54sMly6WC4W0FCB+G Xqww1/gohW4YkrjFH71iDoP8rG2neICsHlTMNm/pjSTKSIdanwMxl4idJqgkzQQ0LTIF VhUDi/UbxrYVUXGtoiv3n73u/wL1dN0xZhEUQ35Te/JaIE2qFs8PxU2ZCWz90guHWZJA uoUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q3X5CY5j; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u10-20020a0cfe4a000000b0065b174c561fsi2908699qvs.112.2023.12.01.01.39.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 01:39:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q3X5CY5j; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8zx4-0003vA-O8; Fri, 01 Dec 2023 04:36:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8zx0-0003rl-4z for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:46 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8zwv-000476-Fp for qemu-devel@nongnu.org; Fri, 01 Dec 2023 04:36:45 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40b4c2ef58aso19234815e9.0 for ; Fri, 01 Dec 2023 01:36:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701423400; x=1702028200; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GoNh2oMU49/LTEW/ECcUYLD8q7yKf6zjz1ExnMRKy2Y=; b=Q3X5CY5j66SKMNWrvQRDYBzKOPVuNjZVKnGGe4mAhLoS5nFxLjQNEcjfHdSIRyCy56 3j6nq/uyk5GCBovOTzM9vk6hhcSGZZpEE/a2vENRqxOpbVsX9gUtMVMO+DiuVWUbOZGx vd3nu5UrikUR2fg74RGi2nkxLQZqDKVdY617A4UoBhaGD/yIJUgEsLKur3nwXiOtmnjt TLM9JOo6G/OUdFkwdWObWghBVluIFQNITMlUkX/pE0b7+jMZJQ+2BdFqrcLMmjz9pyNP AE6W0YCR0xPvCvJiwyWey7GLLb1jDbzdmaUNsVhQg992NTJCrMGmw2x3bmmhxSbhvd9A T5ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701423400; x=1702028200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GoNh2oMU49/LTEW/ECcUYLD8q7yKf6zjz1ExnMRKy2Y=; b=r4spnYvflAQhLwq6K7I0L8RVx7ZZbzL+LvJ6oPq/SsVUOqqXTJb/ZX9OiAcnBpnF7I tcDWnxmg1s9PhkWf5ja5wD3HnPpQKkn87cLiHOFB2ZPnXC0NE2Q3g3TxYiWrSxGA9+fv 4KVX3Z0k+6rmJfLt2e7K784iZxKNj414jEs1qEP7IDFKT0Iu2DSY5mhzRjvLuIDzJjff pnHsVrfA3yN9SBVwzCZ8X0iVJqdeIacnN+WdI4On2z+RZ++nXPuM1EdQ+0lhfUdQQNcR YGOvekghYyCfFfsUwPSlo3w6JfsJ1KqRVEcmMOPezCpUxTXFlRm2f4kuM2dn9ISwfRyJ +lpg== X-Gm-Message-State: AOJu0Yy+pZBcqzyn9Crt4RQ2/41xPthMI976m3PgYxJJhgPUclDtFjbi E2apzawihztiFPhjUtiF9QSgAw== X-Received: by 2002:a05:600c:a41:b0:40b:5e22:307 with SMTP id c1-20020a05600c0a4100b0040b5e220307mr176075wmq.115.1701423399729; Fri, 01 Dec 2023 01:36:39 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id m28-20020a05600c3b1c00b0040b2b38a1fasm4633671wms.4.2023.12.01.01.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:36:37 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id A21655FB6E; Fri, 1 Dec 2023 09:36:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Eric Farman , Peter Maydell , Leif Lindholm , Beraldo Leal , Andrew Jeffery , Paolo Bonzini , Marcin Juszkiewicz , Pavel Dovgalyuk , Thomas Huth , qemu-arm@nongnu.org, Radoslaw Biernacki , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Yoshinori Sato , Eric Auger , Halil Pasic , qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Christian Borntraeger , Aurelien Jarno , Cleber Rosa , Joel Stanley , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 7/7] gitlab: add optional job to run flaky avocado tests Date: Fri, 1 Dec 2023 09:36:33 +0000 Message-Id: <20231201093633.2551497-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201093633.2551497-1-alex.bennee@linaro.org> References: <20231201093633.2551497-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org One problem with flaky tests is they often only fail under CI conditions which makes it hard to debug. We add an optional allow_fail job so developers can trigger the only the flaky tests in the CI environment if they are debugging. Message-Id: <20231130153333.2424775-4-alex.bennee@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- v2 - add missing ppc64/aarch64 build --- docs/devel/testing.rst | 15 ++++++------ .gitlab-ci.d/buildtest.yml | 30 ++++++++++++++++++++++++ tests/avocado/boot_linux.py | 2 ++ tests/avocado/boot_linux_console.py | 1 + tests/avocado/intel_iommu.py | 1 + tests/avocado/linux_initrd.py | 2 ++ tests/avocado/machine_aspeed.py | 2 ++ tests/avocado/machine_mips_malta.py | 2 ++ tests/avocado/machine_rx_gdbsim.py | 2 ++ tests/avocado/machine_s390_ccw_virtio.py | 1 + tests/avocado/replay_kernel.py | 2 ++ tests/avocado/reverse_debugging.py | 2 ++ tests/avocado/smmu.py | 1 + tests/avocado/tuxrun_baselines.py | 1 + 14 files changed, 57 insertions(+), 7 deletions(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 76465b8f3d..bd132306c1 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -1387,16 +1387,17 @@ the code snippet below: def test(self): do_something() -Tests should not live in this state forever and should either be fixed -or eventually removed. - -To run such tests locally you will need to set the environment -variable. For example: +You can also add ``:avocado: tags=flaky`` to the test meta-data so +only the flaky tests can be run as a group: .. code:: - env QEMU_TEST_FLAKY_TESTS=1 ./pyvenv/bin/avocado run \ - tests/avocado/boot_linux.py:BootLinuxPPC64.test_pseries_tcg + env QEMU_TEST_FLAKY_TESTS=1 ./pyvenv/bin/avocado \ + run tests/avocado -filter-by-tags=flaky + +Tests should not live in this state forever and should either be fixed +or eventually removed. + Uninstalling Avocado ~~~~~~~~~~~~~~~~~~~~ diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 62b5379a5e..91663946de 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -217,6 +217,36 @@ avocado-system-opensuse: MAKE_CHECK_ARGS: check-avocado AVOCADO_TAGS: arch:s390x arch:x86_64 arch:aarch64 +# +# Flaky tests. We don't run these by default and they are allow fail +# but often the CI system is the only way to trigger the failures. +# + +build-system-flaky: + extends: + - .native_build_job_template + - .native_build_artifact_template + needs: + job: amd64-debian-container + variables: + IMAGE: debian + QEMU_JOB_OPTIONAL: 1 + TARGETS: aarch64-softmmu arm-softmmu mips64el-softmmu + ppc64-softmmu rx-softmmu s390x-softmmu sh4-softmmu x86_64-softmmu + MAKE_CHECK_ARGS: check-build + +avocado-system-flaky: + extends: .avocado_test_job_template + needs: + - job: build-system-flaky + artifacts: true + allow_failure: true + variables: + IMAGE: debian + MAKE_CHECK_ARGS: check-avocado + QEMU_JOB_OPTIONAL: 1 + QEMU_TEST_FLAKY_TESTS: 1 + AVOCADO_TAGS: flaky # This jobs explicitly disable TCG (--disable-tcg), KVM is detected by # the configure script. The container doesn't contain Xen headers so diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index 9e9773e6e1..7c4769904e 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -99,6 +99,7 @@ def test_pseries_tcg(self): """ :avocado: tags=machine:pseries :avocado: tags=accel:tcg + :avocado: tags=flaky """ self.require_accelerator("tcg") self.vm.add_args("-accel", "tcg") @@ -118,6 +119,7 @@ def test_s390_ccw_virtio_tcg(self): """ :avocado: tags=machine:s390-ccw-virtio :avocado: tags=accel:tcg + :avocado: tags=flaky """ self.require_accelerator("tcg") self.vm.add_args("-accel", "tcg") diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 5d978f6dd0..cffa4da9f0 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests/avocado/boot_linux_console.py @@ -1403,6 +1403,7 @@ def test_sh4_r2d(self): """ :avocado: tags=arch:sh4 :avocado: tags=machine:r2d + :avocado: tags=flaky """ tar_hash = 'fe06a4fd8ccbf2e27928d64472939d47829d4c7e' self.vm.add_args('-append', 'console=ttySC1') diff --git a/tests/avocado/intel_iommu.py b/tests/avocado/intel_iommu.py index 2dd11a6346..f04ee1cf9d 100644 --- a/tests/avocado/intel_iommu.py +++ b/tests/avocado/intel_iommu.py @@ -22,6 +22,7 @@ class IntelIOMMU(LinuxTest): :avocado: tags=machine:q35 :avocado: tags=accel:kvm :avocado: tags=intel_iommu + :avocado: tags=flaky """ IOMMU_ADDON = ',iommu_platform=on,disable-modern=off,disable-legacy=on' diff --git a/tests/avocado/linux_initrd.py b/tests/avocado/linux_initrd.py index c40a987bd1..aad5b19bd9 100644 --- a/tests/avocado/linux_initrd.py +++ b/tests/avocado/linux_initrd.py @@ -57,6 +57,8 @@ def test_with_2gib_file_should_exit_error_msg_with_linux_v3_6(self): def test_with_2gib_file_should_work_with_linux_v4_16(self): """ + :avocado: tags=flaky + QEMU has supported up to 4 GiB initrd for recent kernel Expect guest can reach 'Unpacking initramfs...' """ diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py index 258fb50c47..6fa5459a07 100644 --- a/tests/avocado/machine_aspeed.py +++ b/tests/avocado/machine_aspeed.py @@ -317,6 +317,7 @@ def test_arm_ast2500_evb_sdk(self): """ :avocado: tags=arch:arm :avocado: tags=machine:ast2500-evb + :avocado: tags=flaky """ image_url = ('https://github.com/AspeedTech-BMC/openbmc/releases/' @@ -336,6 +337,7 @@ def test_arm_ast2600_evb_sdk(self): """ :avocado: tags=arch:arm :avocado: tags=machine:ast2600-evb + :avocado: tags=flaky """ image_url = ('https://github.com/AspeedTech-BMC/openbmc/releases/' diff --git a/tests/avocado/machine_mips_malta.py b/tests/avocado/machine_mips_malta.py index 3a1ec85c20..9c997afeb0 100644 --- a/tests/avocado/machine_mips_malta.py +++ b/tests/avocado/machine_mips_malta.py @@ -109,6 +109,7 @@ def test_mips_malta_i6400_framebuffer_logo_7cores(self): :avocado: tags=machine:malta :avocado: tags=cpu:I6400 :avocado: tags=mips:smp + :avocado: tags=flaky """ self.do_test_i6400_framebuffer_logo(7) @@ -120,5 +121,6 @@ def test_mips_malta_i6400_framebuffer_logo_8cores(self): :avocado: tags=machine:malta :avocado: tags=cpu:I6400 :avocado: tags=mips:smp + :avocado: tags=flaky """ self.do_test_i6400_framebuffer_logo(8) diff --git a/tests/avocado/machine_rx_gdbsim.py b/tests/avocado/machine_rx_gdbsim.py index 350a73fbbb..412a7a5089 100644 --- a/tests/avocado/machine_rx_gdbsim.py +++ b/tests/avocado/machine_rx_gdbsim.py @@ -31,6 +31,7 @@ def test_uboot(self): :avocado: tags=arch:rx :avocado: tags=machine:gdbsim-r5f562n8 :avocado: tags=endian:little + :avocado: tags=flaky """ uboot_url = ('https://acc.dl.osdn.jp/users/23/23888/u-boot.bin.gz') uboot_hash = '9b78dbd43b40b2526848c0b1ce9de02c24f4dcdb' @@ -56,6 +57,7 @@ def test_linux_sash(self): :avocado: tags=arch:rx :avocado: tags=machine:gdbsim-r5f562n7 :avocado: tags=endian:little + :avocado: tags=flaky """ dtb_url = ('https://acc.dl.osdn.jp/users/23/23887/rx-virt.dtb') dtb_hash = '7b4e4e2c71905da44e86ce47adee2210b026ac18' diff --git a/tests/avocado/machine_s390_ccw_virtio.py b/tests/avocado/machine_s390_ccw_virtio.py index 61e75d8f9e..26e938c9e9 100644 --- a/tests/avocado/machine_s390_ccw_virtio.py +++ b/tests/avocado/machine_s390_ccw_virtio.py @@ -167,6 +167,7 @@ def test_s390x_fedora(self): :avocado: tags=device:virtio-gpu :avocado: tags=device:virtio-crypto :avocado: tags=device:virtio-net + :avocado: tags=flaky """ kernel_url = ('https://archives.fedoraproject.org/pub/archive' diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py index 0d32cc280e..af086eab08 100644 --- a/tests/avocado/replay_kernel.py +++ b/tests/avocado/replay_kernel.py @@ -88,6 +88,7 @@ def test_x86_64_pc(self): """ :avocado: tags=arch:x86_64 :avocado: tags=machine:pc + :avocado: tags=flaky """ kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora' '/linux/releases/29/Everything/x86_64/os/images/pxeboot' @@ -186,6 +187,7 @@ def test_arm_cubieboard_initrd(self): """ :avocado: tags=arch:arm :avocado: tags=machine:cubieboard + :avocado: tags=flaky """ deb_url = ('https://apt.armbian.com/pool/main/l/' 'linux-5.10.16-sunxi/linux-image-current-sunxi_21.02.2_armhf.deb') diff --git a/tests/avocado/reverse_debugging.py b/tests/avocado/reverse_debugging.py index 9a468321e5..4cce5a5598 100644 --- a/tests/avocado/reverse_debugging.py +++ b/tests/avocado/reverse_debugging.py @@ -255,6 +255,7 @@ def test_ppc64_pseries(self): """ :avocado: tags=arch:ppc64 :avocado: tags=machine:pseries + :avocado: tags=flaky """ # SLOF branches back to its entry point, which causes this test # to take the 'hit a breakpoint again' path. That's not a problem, @@ -269,6 +270,7 @@ def test_ppc64_powernv(self): """ :avocado: tags=arch:ppc64 :avocado: tags=machine:powernv + :avocado: tags=flaky """ self.endian_is_le = False self.reverse_debugging() diff --git a/tests/avocado/smmu.py b/tests/avocado/smmu.py index 05b34418a5..21ff030ca7 100644 --- a/tests/avocado/smmu.py +++ b/tests/avocado/smmu.py @@ -22,6 +22,7 @@ class SMMU(LinuxTest): :avocado: tags=machine:virt :avocado: tags=distro:fedora :avocado: tags=smmu + :avocado: tags=flaky """ IOMMU_ADDON = ',iommu_platform=on,disable-modern=off,disable-legacy=on' diff --git a/tests/avocado/tuxrun_baselines.py b/tests/avocado/tuxrun_baselines.py index 5f859f4e6f..a936a3b780 100644 --- a/tests/avocado/tuxrun_baselines.py +++ b/tests/avocado/tuxrun_baselines.py @@ -561,6 +561,7 @@ def test_sh4(self): :avocado: tags=image:zImage :avocado: tags=root:sda :avocado: tags=console:ttySC1 + :avocado: tags=flaky """ sums = { "rootfs.ext4.zst" : "3592a7a3d5a641e8b9821449e77bc43c9904a56c30d45da0694349cfd86743fd",