From patchwork Wed Nov 29 14:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 748285 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v3yzIOkf" Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 961ACCE for ; Wed, 29 Nov 2023 06:05:42 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a00b01955acso968082466b.1 for ; Wed, 29 Nov 2023 06:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701266741; x=1701871541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MQ8xtOf7SPY4n43K7AQFcp4yw6pnczR2hfrcA2zNKh8=; b=v3yzIOkfFadhqPhGKQCzWKANSK51Sg9KBXlQP4IfJwapYPKGtgNgqEeMMs0/Y3qv46 rDKBr174nkdSv+Ruot3atuNe4j1QBW4Y3jZRUBJClmhlHhLNZ1f83X1TCyHC7zJs3T2l QqixzXPqjcpS8Cqzfnjy8cxZuWP6a/PGKx95G6YaJPkNy9LZm7erajMx8p+V0xi7oJV/ Q5XyI7pNM4ui8yEI76JjbGSRJ7IP6Vv1YwuDnSwHzsFl/8ulcwinAAEvNyM+R0RJALDV LiJMMsuEoHy0t7DVNEh/lqTrq48QrJ9dHSs+2nIV8IOfyYMliWDtBIp7r74F0JitUkEN OW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701266741; x=1701871541; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MQ8xtOf7SPY4n43K7AQFcp4yw6pnczR2hfrcA2zNKh8=; b=HfI1YTjoolrO16w0+pV92uWJX+ziGWLRCWvN7fZqQOvAdhKm+guQMLJRip/VrKKbdx o5WKvkWGg7z+SfeIWqx5NyxWfAa2MCVgtSWkzWu7Xy2ctv0wBFya/kA35Rfn+sEOWLZ4 VZstAz8J2PYRKNy1ZyFqFPmkQz/L5AHKRV34WyQaDc0ZFLs4+luo7OifWJNE9moSMgPH 1qrr+eCyrz4WVsITS/kCoch/XLW+oYur3vpWHsKwx6c4HB/G2q/C4Lc0KjTZcKuziB6s IPvY+S2Pfb8mlFH/icLPh3R1fRm4LCrG6U1rqVFDyTTQwO5r2TicJm4U//d9bUrx4cFa c18g== X-Gm-Message-State: AOJu0YzH+lbwlk/Dt27efp5dRu9K6ZeL0Yt7e0iOQPe8+ejCjM33z1qD CHRvLF6w68FnGQB0sbeqVNZN+g== X-Google-Smtp-Source: AGHT+IEJRq0imNqnhlsR+uCWHbDWbTPaUjfqnej06A/skJff8aDf/UUnunxlBDdm3ZLjEsqjYvGRSg== X-Received: by 2002:a17:906:fcc:b0:9bd:a75a:5644 with SMTP id c12-20020a1709060fcc00b009bda75a5644mr12183367ejk.16.1701266741102; Wed, 29 Nov 2023 06:05:41 -0800 (PST) Received: from krzk-bin.. ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id o14-20020a1709062e8e00b009fe3e9dee25sm7947530eji.61.2023.11.29.06.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:05:40 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Neil Armstrong Subject: [PATCH 1/2] arm64: dts: qcom: sm8450: correct TX Soundwire clock Date: Wed, 29 Nov 2023 15:05:36 +0100 Message-Id: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The TX Soundwire controller should take clock from TX macro codec, not VA macro codec clock, otherwise the clock stays disabled. This looks like a copy-paste issue, because the SC8280xp code uses here correctly clock from TX macro. The VA macro clock is already consumed by TX macro codec, thus it won't be disabled by this change. Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS") Reported-by: Neil Armstrong Signed-off-by: Krzysztof Kozlowski Reviewed-by: Neil Armstrong --- Considering that in Downstream, the TX Soundwire is part of VA macro, there is no clear reference code explaining this. Let's just go with SC8280xp approach because it seems reasonable, but don't ask me "why". --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index a305f8c03f9e..28207c7423f0 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2314,7 +2314,7 @@ swr2: soundwire@33b0000 { ; interrupt-names = "core", "wakeup"; - clocks = <&vamacro>; + clocks = <&txmacro>; clock-names = "iface"; label = "TX"; From patchwork Wed Nov 29 14:05:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 748773 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rE3DPTLV" Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0763B1A8 for ; Wed, 29 Nov 2023 06:05:44 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a02d91ab199so923055166b.0 for ; Wed, 29 Nov 2023 06:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701266742; x=1701871542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vIpe57LK+ad4j3gXLtYhpcdtMPnG7fFGsBLCvb5Xl00=; b=rE3DPTLVdTe+gXcLth66c37DX7SHlmOGKngnUuV7dpsbAkjqxCnzvmwNN7Su83SGBZ nXGKvARiV4aMEOPSHjfyFl2zVG9+xztHErG9zsFZ0vcc97QL/PjJyEbAjvo+RI5x9442 ubwPmw8l3Ovv6vhL4mWGReiFyWSlzaAC8ngcr8xmvjcYCREzQmXaQ3/eOfi17xiUzS/j SfflkVLzvOFbZUFY4LAIoyAwoXOVTktVknOtBrGqiBEiT+rGvdQzCVTuYKt73/1a4S32 urydTKiOt7Tv2jn7l243x9sMmD2zqwT3J1pqrQvA6h26HlpcbD8BJjIQkYJjEU1KpJ7+ cuvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701266742; x=1701871542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIpe57LK+ad4j3gXLtYhpcdtMPnG7fFGsBLCvb5Xl00=; b=hSFQGXXuIHIX69rryqyRgA//561XcHiAAGkJIAN0TDxWRq3KGfYDyNjH1J36MzPpuP zf/0xnCle0iw6jz96UhN5e/fgprxLSMvTTBdVTpnTJx/M2M2fOikSdhUTNu/93haToKa RldXPRc7Us7Wctnw1Y0jV3/h5XuQ2pb84tIVoUllgze7Z2fbHyZtPkGaAcggY9wxT85k veXiYxHN2EGa+Ar99RxmQsqSDsXtmHIohA31+RfHdgEk0dXhrdDcwGv2K2zv0mr/LIZJ z+I/yYNcOwqRoUVuXQ5RlJZi3ADfwJwwRn8SLhX4wdd78TMJ9JtLR6Rjr03Pp7T7wukB Tqcw== X-Gm-Message-State: AOJu0YxRjI59Sh9W6Z/iLAIYwHwa3auuFDzWYL97tYPSfHGbssdwRp2h 0kID6Y0xhJSev6IU/5WqbtGiaw== X-Google-Smtp-Source: AGHT+IEQVZGJKNnT5Gk0etakEOWrLbSJedZgEcktiPi8arX5Jm4KIFYIq/ld/mtUihzQQFDAOFePzg== X-Received: by 2002:a17:906:fa06:b0:a0d:ebfe:e404 with SMTP id lo6-20020a170906fa0600b00a0debfee404mr9221770ejb.22.1701266742475; Wed, 29 Nov 2023 06:05:42 -0800 (PST) Received: from krzk-bin.. ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id o14-20020a1709062e8e00b009fe3e9dee25sm7947530eji.61.2023.11.29.06.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:05:42 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Neil Armstrong Subject: [PATCH 2/2] arm64: dts: qcom: sm8550: correct TX Soundwire clock Date: Wed, 29 Nov 2023 15:05:37 +0100 Message-Id: <20231129140537.161720-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> References: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The TX Soundwire controller should take clock from TX macro codec, not VA macro codec clock, otherwise the clock stays disabled. This looks like a copy-paste issue, because the SC8280xp code uses here correctly clock from TX macro. The VA macro clock is already consumed by TX macro codec, thus it won't be disabled by this change. Fixes: 61b006389bb7 ("arm64: dts: qcom: sm8550: add Soundwire controllers") Reported-by: Neil Armstrong Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 52e8f4c52426..2fd3faacf554 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2199,7 +2199,7 @@ swr2: soundwire@6d30000 { interrupts = , ; interrupt-names = "core", "wakeup"; - clocks = <&lpass_vamacro>; + clocks = <&lpass_txmacro>; clock-names = "iface"; label = "TX";