From patchwork Mon Nov 20 21:46:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745499 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gjCcrtF4" Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79F44A4; Mon, 20 Nov 2023 13:46:30 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso13258405e9.0; Mon, 20 Nov 2023 13:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516789; x=1701121589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=gjCcrtF4veDEJj9rFtx23LKukgs/iHodLwzuV9Hl+bF5vUjD4DzqCoIjhA9xERZngR FhYWhU+QVko82Ayj6ZqbhsXd302ufhF6s07LS1keUHcxGXZKDD8BC6XlwJORUhuTv81X UQU7XVpSVmbgVrN8Os/H89S9XWolzelFgMgFVlsd8zeVvmyuxhbZYLyLnLqVU/HCnLlO 5fs1d7U1qbpmhS1tOSQSd/1BJIUiFQwzBiFS15n79NMxfsZH0ubas9BtXGfZFofO67E6 VRQIBBuZOe7B5tjw4SmKxYn5rTMxDWtOY/Brlwx6ZO8XlEXWVnPdqVzPInt9dtj06SI7 C01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516789; x=1701121589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=bHo18SZnFg/5YJvIzVb+vMwUTUmfxVN1Pz2MTSkpEU5GdLBE4LoMb+2BK6swlMVSc9 BiUU/L2AXa66h/XV2Fa1yQ11fmbRBWI0ksyAS54M7gSBsyYyvr/zcQaUJhzAuQdoYSDc MLM7hMAvmoToSQZ/OA3KC4CQbLFg9iAqXDbMnAX1fBBxln1lfnrFjQdsapeEGmB34udj oXTa3je0i8cXDtNUmJTDBdxBFkC/g27hV+JDamSgJ0d15yoOaoCaf8nH/WZtdpjnjwdP xbsYF8GNe4/X5v+b0r67GhGAVlFH1hc7FK0qZUEL0dz3e+5xfYxW2fmHAxNndwkBTaj1 oUCQ== X-Gm-Message-State: AOJu0YxySbPTk03vnmzqlRa8eHIXieppw7j4MOY+K19BqKirutL+saOb rUZVfgdVawW7hsHwT6WvAvk= X-Google-Smtp-Source: AGHT+IE5KIoURghYVkvfU5wQxiGM06yHQWDaD6hu7bxfA9LnXbZJ41nQqt1tLyyxToNmpgxikLPPeA== X-Received: by 2002:a05:6000:156f:b0:332:c432:b7aa with SMTP id 15-20020a056000156f00b00332c432b7aamr663360wrz.2.1700516788640; Mon, 20 Nov 2023 13:46:28 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:28 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:04 +0100 Message-ID: <20231120214624.9378-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Mon Nov 20 21:46:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746998 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QRsEeDrO" Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44012D2; Mon, 20 Nov 2023 13:46:31 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso13258455e9.0; Mon, 20 Nov 2023 13:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516790; x=1701121590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H76sh9TJa21kiF09BweriFrW/UpEK7sOhe75l5gn76g=; b=QRsEeDrOJvqOXuhy8AvA1hY9KeECb+s+x/W1hCWBvubGYEAyfs5l1cRBk4UGrfCSpO NvB07SW1gaSEKk8Mwz2uOk6RU8kRFE0gW0POetdoHUmhfSUwdpYVD6sL6sfIHeraGufq M3EI5JPs+uSAqgmmlqAm9tbw5TA6xYyJMvS+gDZ8AaHhGLfkf6OecKvhDn08PW2em4OW y4hpZ4IupAc20zWNtCkcH0+nB9tEcQkpfUcg5Z/HxQyRXhLz0yan2xkdLwHyBI9cCRca 1vpQbN3G+NlXkxY6RmH2I+PtvHEbuH+S1akoWZJSCIouckmO1SBu1Lz+jXqRF4PdCnBh BFnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516790; x=1701121590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H76sh9TJa21kiF09BweriFrW/UpEK7sOhe75l5gn76g=; b=Zgv9kv+0o+Pgficic9byDXL4zGrWWZgjPOQ1egPut38LBL+ic2BFw9j1zeeHwqvhM+ VhOv8CyMrBWJsLQo/64ny3HNLHlMSSfDpKUeDPV0yvWgfv5vCVVD9MVdMTuZJe5OiTy2 PYItuNTRNBjlWIKhd8Lo2o3/BU2Qzd9eFeba2f2ghDu7jSz3eyvcq9QRFdNT8OD5/UpL sq/RGXvaXJn3mltFKv3SQPFXBT4Iuz62JO3ko4BMFnuxEwd5+rD6VCHRLuWs3XvM7sL4 1SqEBGl//SsMgkCHGSKEpKDYHdyjva9Ld9LbEkPho1pH+V96urG/wfiQDizxDgtyGVlp NDZg== X-Gm-Message-State: AOJu0YywHM2sVOc4kP+d6xW/ViOyiebF8M4YO7qC4jyhmPvM9fxl9S4w LEx/3VzlD+Qu1ZNQ89qi0eU= X-Google-Smtp-Source: AGHT+IE2ErATm2xBrVPTmReU5ycJuHnLDpRJNW4Slun/A9h1smmlE3tedG4RsPPOlF2k6luf9dWXyw== X-Received: by 2002:a5d:648b:0:b0:332:c726:ed5c with SMTP id o11-20020a5d648b000000b00332c726ed5cmr612415wri.32.1700516789457; Mon, 20 Nov 2023 13:46:29 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:29 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:05 +0100 Message-ID: <20231120214624.9378-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 20 21:46:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745498 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LG1thEX7" Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C0F4E3; Mon, 20 Nov 2023 13:46:32 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32fdc5be26dso3168503f8f.2; Mon, 20 Nov 2023 13:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516790; x=1701121590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=LG1thEX79vY37dfvBGGe8Cby++2C3AgY6HsuUZhsWC9/nxWYupiYWrbyZ/VpGi4qhT aZSu1Y3D/CsSE9Ed2QNy6RIuptOdAV1woeI3oK8UGs/tjgMu42ylw3aRLOCQo0+6dNjA XQLo/iUhtaaRNCs+zZr4ExWPGkA4i/AAuIomHpesIzg+b2KPdiOc8PKRl0lcRzB7GSCZ 8OqarVYASLNhTWlCSt1oF+P7RSeWDvn3qfKGDJCynMxpEQHqEGZXpg/66xa7D4v+AcSe DCDGZvvoqm6BfydjuHzGijBV8wLgZSYL6+9keTP6q8WpJv327yC4sHE4H/Vfjtdd3Gmc xDPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516790; x=1701121590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=ZuqldaePX9hN34aZwdfZppj6Rtgkn2gyA36IEKyh1jWhfqFGVOhT0VvexlsjM/NUrP ofuf7KjFYXaSinYJ6/v6oA3loGjE2GKX3CukDpRdnmL2/Rm/gKRtimcAyE3BXaKEPBey gXsq1qzsbSmDVMOZ2jqg8L1WsL/AZOdJBiOkR/1onQIVxjxGjURm+GaHzPaoGCTgzf3D Gz6yZXlTy7mOIaqphfEzM4aeR78xBFtdg3Ulxkeogbo+gbdzZdPoyU1NhLx0zxtRarj9 iCIguBcocc5EBcRgjDaEsOFrSifPFrh8RLdgq5CGu0RlBL7ZQqNS94JO10ygVt9qzo9F 4FNw== X-Gm-Message-State: AOJu0YynTGV8lxxXWEWTGFieefQ95PcrkiPoiwRHG7CdSES01FzfEjMv Q7A2oyYpbYIaiLcLGBKBjSk= X-Google-Smtp-Source: AGHT+IGkGQ59cG9edqQvwqmwpMO+1LuO35o+25wMSjuR193ctRjhKyTjuIwWviwx/q0Qr5EuxLxwOQ== X-Received: by 2002:a5d:62c4:0:b0:332:c648:c646 with SMTP id o4-20020a5d62c4000000b00332c648c646mr2880040wrv.53.1700516790376; Mon, 20 Nov 2023 13:46:30 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:30 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:06 +0100 Message-ID: <20231120214624.9378-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Mon Nov 20 21:46:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746997 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SFr6AH5y" Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07E12CA; Mon, 20 Nov 2023 13:46:33 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-32fadd4ad09so3655589f8f.1; Mon, 20 Nov 2023 13:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516791; x=1701121591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=SFr6AH5yRMa+JGHGFnzXmNMWkRHXufcNClfUffYuSlkjNAa3Lpme65FwhdwCrN7Goa dwt5s4Z9LR/y353YyqLyy0/NopOhHIUwxVFU8QoCv8wte+hM9bXg36OGv17wBDF7KmrH i3VCUx5V852o/mi3JpetMGNx5cTNWTKk9jRRuzfJmf+hUxVgp2I+3bPbJshmP8OI3jyc NWX/pLnqzcMiskJlHvhdH1LYuR8EFVOF9fPkFQo9M3xpKYf7r5W1QWwSvhqYT1WrTWGV fp7ElUKd12wfmmev+Pqlv2PvFaa63RYR84sCkF087kjZ5vbiJ2IO/0mRmM4WTIdFObGh s+dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516791; x=1701121591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=WNqv+xuP3oZhQXGhudrsoNNE8uCQThG7hm9tptO5NZpJO2hdwb6rWzHgMxLdKpWZCP CrXKDz7EWyKcSZreAjzoAqILdcU7q418y7PLfJGHUdGf26t/TfvTsM+5in4ZHlkuOWn+ haStrxuV7Xcp/1lXN6hfnZVbRXunCg0ZGe8OnWkPi2Ct3qguatoC9dHcW5AWR0XyrX8K 5FRtlg5nW/fW56lsk4l6yC3wLZzcgD895YVRc0OZ0t+wowM8HG9xi5VKWLyYJYz+2NQB phQ1sWaDJXLhWZlmnSuxyiSvg2Z2Mb3VtzHm+K+eIh5+WsUvW58yYg3tAyi8NvhTym/9 NORw== X-Gm-Message-State: AOJu0YxfQYzpshwMpW8vp+vjsfouOnNOLu+6E26JPA4HQqegDo1Ridg6 8lU2ZvI3nOijUDgch59npMc= X-Google-Smtp-Source: AGHT+IGIRCD7UdLrZN9lSzHXmAgpmrQY5+HhoNLOuQvKT6vBAsOc+D+u9/DgXsMWlG54R5krCGbd6A== X-Received: by 2002:a5d:4151:0:b0:332:ca69:2fb5 with SMTP id c17-20020a5d4151000000b00332ca692fb5mr1904733wrq.11.1700516791362; Mon, 20 Nov 2023 13:46:31 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:07 +0100 Message-ID: <20231120214624.9378-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jernej Skrabec Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Mon Nov 20 21:46:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745497 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mB9Ncvxs" Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 138F4A4; Mon, 20 Nov 2023 13:46:34 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32f7c44f6a7so3253122f8f.1; Mon, 20 Nov 2023 13:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516792; x=1701121592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3q7Wv0ykBXfyqStd9azoeaEamTJsEK38bA0+KKsVDzQ=; b=mB9NcvxsWOaeym9+DWswPk3IGfoUbFwWqMRvehhpsff/V3z6mpzRqax7QCZcc0edxS KB3YVd0yje01GLNSZ55W1Jbj18JsWggVRa0T0qPih433mTRqd1kx6DT1ZonZ5l0ISf7S W+j4Nig2ipqDHg52X9nU7BvnyL7x9wqZCGi1ETEFVOh2ht/6RtW71zLqLhu92/4+2wGK Qn7N88ieUry1BJdvhf9Wk937pdj2RUIamLqGAREssVakJcM8Lb8cMhB0JYHmbtbbVmI7 EWsYnY4eM4J2o2v+PetKxOf4k23gSKxvXz9+RkuZicMTwKwzJN77KlmR25FGPR39an1E eSkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516792; x=1701121592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3q7Wv0ykBXfyqStd9azoeaEamTJsEK38bA0+KKsVDzQ=; b=XcVSU1gnF955KJ3s3L6glurvcp2I3Yh3RdWGTXNbio4ID+L+GF3eQA/bDQeTKyWR1o QOQ1Z6f4/X2TxRJOEyaF/hYpAE4VHw+x7mhA07NYc7vsi+Wh1xpPa0/WVXlhHN8OTdAW hwkSy/Zl4KZSpnvp37F4zB3c6OPPUuTVn/c1UBqA/1U51HD0SxijLH4OBphm19SohM2g OXLE2vgFwJLk+R8uD9N3pZzz0/vm0kcGE87YPRBZ6nO5m7YScB0upnWFm7g0tRw1tyYJ 2RtM/s6NYZ0TJpTpMhbJPAnDU4kow2j9c9IP8L06hjdB4RG12qYysNcbm4SS0ek4Rb6y 0U/Q== X-Gm-Message-State: AOJu0Yw68w7QM9zr7SQbXq/1HpKeafVm/5hd+cw+aQkhhhdIK/AqYp4G vd9GHfU0By037a+CMbDExdU= X-Google-Smtp-Source: AGHT+IE22PcDp7LHr0bveTlzIwiDDweuP3YXTMT1Ylh4ts3pme+8jKLYvs372KUXsQfXq+9sxxC5eQ== X-Received: by 2002:a05:6000:1543:b0:32f:869e:b24b with SMTP id 3-20020a056000154300b0032f869eb24bmr6908763wry.14.1700516792331; Mon, 20 Nov 2023 13:46:32 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:08 +0100 Message-ID: <20231120214624.9378-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- v3: - fix compile error --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 15 +++++---------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..bb048e14b 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,27 +158,24 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) printk(KERN_INFO "i2c-matroxfb: Could not register secondary output i2c bus. Continuing anyway.\n"); /* Register maven bus even on G450/G550 */ - err = i2c_bus_reg(&m2info->maven, minfo, - MAT_DATA, MAT_CLK, "MAVEN:fb%u", 0); + err = i2c_bus_reg(&m2info->maven, minfo, MAT_DATA, MAT_CLK, "MAVEN:fb%u"); if (err) printk(KERN_INFO "i2c-matroxfb: Could not register Maven i2c bus. Continuing anyway.\n"); else { diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Mon Nov 20 21:46:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746996 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wr76iPPJ" Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CFBD2; Mon, 20 Nov 2023 13:46:35 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40853c639abso20505525e9.0; Mon, 20 Nov 2023 13:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516794; x=1701121594; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Upu++zhA/RZdGnIiB8rFAnP6PssgAuOHlFea851Ots=; b=Wr76iPPJvPkqYjXWWz+EdxnnYzrl+7P+deOzHmv84Bm6378KjxTzxfEQA58+Uin/CF wbXR/mz0ypgb228ITgiFW8GNhXEh0JkTbGiah4knv3xoJM2qN4ElnvZ7tiFMobtOHHbT b6CblcTnNIQxgc87cnmIjHPmjGUpmCuWVh385rPC4bI2Ub4zJ1BCBuVVM6eTXJlkpEFr KblsTg54TgbkEupDqivRZdxLVYngs3QNvWk6OtZknh9blXNAQhReEsct38GwPqhgedwK sd/T6T2o4u2p+bM0QShmUedoAbe1SEHlwsNQ9seyR6S5vxB7u8Ad9QKPzKkO4SdNfR5L waBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516794; x=1701121594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Upu++zhA/RZdGnIiB8rFAnP6PssgAuOHlFea851Ots=; b=pMvafx18lrRcb7fK01TVzhW2d3hdhkTaQEkvSu/eOXYHVdwFbSHoFmCmB3tPDSEhO4 KUaP1f39j6HjaT6Uz+KyQVeSIgKWJsl0kOq50QWBqk7IIXITh+stACkivBIIV3+kjLB7 NVZdmYkJgV5/L4XajZaU0T4cWCudH4PTSXLHQLdbgNR++pgEteNu4fLV6XQLbYy/CKN0 YfT8RP/ZuOxi5Uou9/RM5iwewFFFNvhCyGwH5MFGzuC9XrdW7ggt3zlEFbom2qYxHFwG U6DFnqcEMTljA33DBK+LrJu6GKN3v7CYCQcuaDwLBjnN/3d5WMkjdraGkc1yIiqg9nKq BFGg== X-Gm-Message-State: AOJu0Ywz896XReg+7AQiLc0UuCSahqT2QnOMWkEDWrG78Ciqo/njRLUy 1s01locehrqilv2EEtOd7bU= X-Google-Smtp-Source: AGHT+IGShYbCS8GN/5rAfdvOMeC0Rmm3E5GPr3cI5QbDT98zWYVN+PfkHaKPIKb7avI0dpivwWZpug== X-Received: by 2002:a05:600c:4f81:b0:405:39c1:a98b with SMTP id n1-20020a05600c4f8100b0040539c1a98bmr7120058wmq.20.1700516793380; Mon, 20 Nov 2023 13:46:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:32 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:09 +0100 Message-ID: <20231120214624.9378-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Mon Nov 20 21:46:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745496 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UmMYzjFA" Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5AD9D8; Mon, 20 Nov 2023 13:46:35 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-32f7c44f6a7so3253146f8f.1; Mon, 20 Nov 2023 13:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516794; x=1701121594; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=UmMYzjFABp5FR6+c792VIxyCNsh5J22xYhxpewIJT3fqu+HWxYPBNqGLRJWCyoPDZk Wb2cKzj3CGmdDt7btZN3pMjhVoKyhNlc4f0Q2vhEj//ANr0RdBdiFVEjIBvq+sq4rJek FL0DP5ephdponzAoTaxlp/1gHHD71h2lYXV25dLyUUdf1CBNFl0tIjLa1jTj2Onyjxsk N52vaP5Tl6WXSyWwShuWE3HXRbsAQOlbe6gqN+p0ZrPLEDyMupLFYfCop695z6SqQEuS 0K6jU1Qvyia9mvoYQfCQVihdCheFuN/RqErgABDgtKoXjVnKbgG9HC/DYwaEWGSYUMob mM5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516794; x=1701121594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=pWMtGYc7JpTbXJFRs8yyxUyRx6Z6R3rRrMTjBXVlbDTymxmKkemNesq0Qo6egVFlGD de3FHbRwo9aI8GmXoD31g9trlXzkXMDb4TMR/WEiUqWb0k9ZOl3a4C8EePOWHyLEcmP4 IO6w5629FoVgdNsA9q9JOILQUjx5PNAaZzECPb6Sh1SwIkMNxVGEShEMtDBRNe12FwC7 G/EwkT2IPG4Or3e/sA6s3QRakp0oeLG9vcZ3AzUKoLkPu+uIiZw8qhyDnqAxhZxak/2k lfGtSfv9SH5ucvnth+rhoLYGuNpTjCTwkoJMiksG/VDm4aN85Oh8yEfaPQok5MY20Gp5 6tSA== X-Gm-Message-State: AOJu0Ywa7zM/mvaUnsbsKlRfog2k0phcscGfKd3FUW+XaIYnSzhnxMXp wUvPl0soYvC2Dme0Qr+1mNU= X-Google-Smtp-Source: AGHT+IG7oJFy7m7GTxwuKt8k7oUtMWjUdpocB0tG7v5Jyio1SAIq6jBjcVPqQfsuIcvy5PtuzIb31g== X-Received: by 2002:a05:6000:186d:b0:32f:80cf:c3cd with SMTP id d13-20020a056000186d00b0032f80cfc3cdmr7426776wri.4.1700516794213; Mon, 20 Nov 2023 13:46:34 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:33 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:10 +0100 Message-ID: <20231120214624.9378-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 20 21:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746995 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ORibleWo" Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9BBA100; Mon, 20 Nov 2023 13:46:36 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40b26d6f7dbso2836295e9.2; Mon, 20 Nov 2023 13:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516795; x=1701121595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=ORibleWohRfM4Ab4bN6m5HPmyebs0jNqoswNx6MzwUH/rTTU0tqVW7vHLpkzsu1f2q bl1ZQ1DlUAVqTlQN4akWLUlwRtYEX1rfeiTmuURQXgcoP481dJ/7amon2o5AHkqS+84x EAWq9rCIaQuUxqdIWVnpoiS2sp8wfDEWUPwARCHYBMAc2PnfOSSt4Q0q9QkW+IeFD+VZ rclcEFJXdQuUXpNFuTYLzN3j9RNPR82B8vk02iDGyAh4B0ibGw7JSuOLJOByZfCgbK8M nwkryG1Tcng9InI31ycWbhaLb/GpC7wXvLQwp/qgvKJ72/nsKMBjXAEnbBaC6WaqyHDb qXkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516795; x=1701121595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=tTnQluBSPtddhgkTEjKlJT+mny6pAtTZ51yn1fA/djdyofYJkuhaWZc/VMUO5eFlQp reBhcqcFICo3ciUEKIo+zqY2obTysX6InTIn76ZaLmubABY2JU6CrECfcF54ZwX4cxQI t9jeHctfGJi0jituutLHWJloAlmtrlDMSWMyCOIQCiPu+MrfL9WmAeoiUfhwLnJkG1Pj +9YiV9M+rSH78OPutQZxkreUe2xx+ML3YDc/k/tqByfYHNSueTQCyAhFL/er3CH3+0nY nVaRoPfbNCkTvlcsFyGxTMAa41i6jbWokKJCTB1ts3AE4fhiBoXo/JeFQeA7puMi2Pw5 BtuA== X-Gm-Message-State: AOJu0YyGR2icIauXtmUs2Wi+bkdVpJ+Aj4gn7uAhmyPwQWUWntla/U9/ lIHmNnHLJglDyaRdiNhTEY4= X-Google-Smtp-Source: AGHT+IFWapLuFxCSewhtGN5+SzhD5+H3LCSt/zm2fnp0PaW4rmMLvzE2JdtHwPvZpR+N8k/OW58kcw== X-Received: by 2002:adf:b318:0:b0:331:69a2:ceab with SMTP id j24-20020adfb318000000b0033169a2ceabmr6977633wrd.19.1700516795084; Mon, 20 Nov 2023 13:46:35 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:34 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:11 +0100 Message-ID: <20231120214624.9378-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Mon Nov 20 21:46:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745495 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HNkrgF2I" Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3188A4; Mon, 20 Nov 2023 13:46:37 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40839652b97so18363605e9.3; Mon, 20 Nov 2023 13:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516796; x=1701121596; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bq7nwej1uXJ8BJR7pdDi87hSI0E9HenTuebLuXr0HrY=; b=HNkrgF2IFppu1basFaX0egxxy4+lcRL2RLcuxEGSyeHMQq+F5s0Oo5vesx5ItPg0iI G5OjAFtGIgm+2Gauqt5l2AAHIJhxoNUFxRDZZcpLOieN1kQzj2194yJihDs0VZaalGXe iTshEtZTm3N0/cUpGhiNcF4gpg2yW5aOYJHlFHcyF6KFwO3u81aceXn7IVqTEmYsuJPV B+oqlni8bnQL8dabOKFPvXdYcH77l8n2P6KNm1rFK++tWNDxfO+be8XXnHeF3qyamDTo PqRz9+WUoGN4lYi/ZDT1e0o6JSwv6GMkQxd1fvIlKYYBIv+wUzYItSPGiP7Eoe/typlU 6hNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516796; x=1701121596; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bq7nwej1uXJ8BJR7pdDi87hSI0E9HenTuebLuXr0HrY=; b=hcwrUFYyFz+J+MmdkzWqDt8J58U29G3qkMN0w5oTSCJXT47p1dfcNwIBwln7YBdNMe jhLvs5L5ceaDCeJ50Ms8ZmxlHDxpTI6zFovnM02kqs5t7XHOyaF7LX3zscmg44HLgAyn JdKMBbKZfkGk/tfToRcGx8fVxE6N9lKbODtq8aD5N3fCo6L6RaEdIoL6p3bL1/AUvi1T F0AcEbtg42szYM/g62uQGQ9DPjWio6GPzRr/H6PN3geoY7we74p4az1JaWvluUhkB+oE jYjt/YDWcvO8iRag1ZcucqS8pQrrVIh3g+WsM3d7imUsMA7IlTC3XtwSAQa+Waw5eR7Z rANw== X-Gm-Message-State: AOJu0Yy57nd5JnYEPf5lk2HuhrIQ08/HwII7rcFsNeDtHYC37b7unY9I jXmrYsgK3pAxoFieKHX3/Bk= X-Google-Smtp-Source: AGHT+IH1S4/fJsobtHJJPWdqFrJEAF5OXQoLCltzpm8iDTMOYpJCpPVCKnhW9kW09x82/VjIEFaoPg== X-Received: by 2002:a05:6000:381:b0:332:c65a:8f1f with SMTP id u1-20020a056000038100b00332c65a8f1fmr4065388wrf.47.1700516796157; Mon, 20 Nov 2023 13:46:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:35 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:12 +0100 Message-ID: <20231120214624.9378-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Mon Nov 20 21:46:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746994 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ghcuOtel" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B232C10F; Mon, 20 Nov 2023 13:46:38 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40853c639abso20505765e9.0; Mon, 20 Nov 2023 13:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516797; x=1701121597; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=05TjyImSoTBVtC1xNXeArH35uiTcm8HxTuw7Nbu59W0=; b=ghcuOtelCeMbfmhYleMtFvj1LRTpEZxka7hb5P5nXUai9x9VEpvnmM/hNdFJ0PxnVr fU3G71a3xk+xOXsrXwn0++OMSXws370XH6LcbhMJ5JnQB2/qEX7kuHE4mYXu0Uk8MnLq jRHaLnniyqREwaDfbqKMkZF58hFKmUiDQB5Ed8m4EIuIZP4n5N0WBrZ+dNg/pw6tuRBa CG/Z/UN+d+KcRU8IA5SLOkNRIHtyLi9mp5vGq5Kp9IvF25bJIXUxY1MswBa/qPMGnHq7 WyG9mQVloWHyOcjb65v0Yc+w84z2VAcSbiFZuAc2Cf73AhZ+Mjvn9Y4Uj+PGtyNRV+W2 WVnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516797; x=1701121597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=05TjyImSoTBVtC1xNXeArH35uiTcm8HxTuw7Nbu59W0=; b=IdbA/3bVIZ1jTxWKGDlapmdqNgWKnYsOlR3X4teUMJINDm5vhTzLQFQ/FAQkIGeEFg a/VEm+4uTdtW+wMcxyj7GA+hRC9BTO7GtXi7ARcyP+rUJHCjtm4/7fCYxD9ACvfyhDJT NzqEaZoAH/I0DG1jcyRQUotfvNpLygcxqQWKFJENsdVHQvzLU5Lt4E6C8gNldnVR6I6z s+at6CJu4ACpQbSYfHyakSdHIvIT4Wn0ml73v+ekVcs/cUd1VkIAKABNwtUPsz93cW00 Uw+sDv2ViVcIj7kvLToRFFE+D2NOwBQSEyPswMLrjAtpWndSLvxJDBpeLVlXsQfe53+0 mcLw== X-Gm-Message-State: AOJu0Yw03W/lH0AJM4ECAuRp2oVH+9LEH7mvh+rqEM6QCHvFv3ZhLRAW dksoAfMC93OK6RH8wp8Mcac= X-Google-Smtp-Source: AGHT+IHJoVgqVgRHUKYiAlqB4jK5099Vv0cVK0mL31SC+jI+u/8+HbpYjQSSsu7PjIpJalcA1ZWpRA== X-Received: by 2002:a5d:64e8:0:b0:332:ca10:388 with SMTP id g8-20020a5d64e8000000b00332ca100388mr2882898wri.45.1700516796963; Mon, 20 Nov 2023 13:46:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:36 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:13 +0100 Message-ID: <20231120214624.9378-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Mon Nov 20 21:46:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745494 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ltf2UMO7" Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EAB5D9; Mon, 20 Nov 2023 13:46:39 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4079ed65582so18418775e9.1; Mon, 20 Nov 2023 13:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516798; x=1701121598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MYIXvkWgZP3jTqRawAZ0bvfdTUgjzQkomxaiR6ITIUY=; b=Ltf2UMO7YeFPPV2fvCp7ZOtdj7rjkbHoixuqDi4G5d9wFuyd4ebNy5PqJUXGSoWmxP Irk2Je8wTddNZHFroUwnFwiHWJZF4wbLlIzaakh8P1aqqfIDgqPxvc+7NSFXhjgDH9zA y6Zs2kxvJM6QdEy6c8Scn9s5l5csfg7axfZcxbsFEBaGKjraW6AgpkrBlzuCdSiUYJP7 NZ2VaWRx5vIE3EjMCXJayEJXUpk4S5KcjG+jgAXZFrjP6KP6a2ZhOfhfDZndTgM4kwBu MMMhk0e4pSvvSH4hG4JlL3SXaJKU4JGnTiNSrxtZj6L92he0rdeqkHKAOf9lfw77ntyT XPSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516798; x=1701121598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MYIXvkWgZP3jTqRawAZ0bvfdTUgjzQkomxaiR6ITIUY=; b=ZlvDNEcFBxt6gljdovlyoUL3Exkuo4RYb8HG+nbRLkmImxBO3C6u7OongD/qx6Q997 jOo8gDgXKidKMytkT6TuDNE2LgGMr25kkomVCwY4AiZZBXK7ewB7qrm93QawkW1jxr9d pFcLuyXZW67lIPM/RsRUSOtRYs9B+kpTe1tAkak/0nAaSWQZXpzdR7TtM1ucn+w4WWlX S8IX+DKApqiX3E8EP3UCECA0xtc8r/hkzrtxyhwXYPnCHThIy/hSAGb5HKH40mPgR2MY a/yHtbqy/EtCjmHajJNstSV/cAZSMUscxmAQa0a6+g6p5P0r2uC4xPLPyy/fBN0IWbav c7Bw== X-Gm-Message-State: AOJu0Yzq6NuazsxJXfL1037An8dLn1yruP9DOablJgQCbNtnrqGoD1Vy kPeWiDu3ntqEVqMl6U+O9gg= X-Google-Smtp-Source: AGHT+IFKwgcCGvl+3GjRXi3JOaMzRX6/rxJnUMyqVb00sOOqmTwTqVycHrl5HKcsMJsrsDJpaUNpzw== X-Received: by 2002:a5d:574e:0:b0:32f:810e:8a3f with SMTP id q14-20020a5d574e000000b0032f810e8a3fmr5245352wrw.14.1700516797921; Mon, 20 Nov 2023 13:46:37 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:14 +0100 Message-ID: <20231120214624.9378-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Neil Armstrong Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Mon Nov 20 21:46:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746993 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aSwFUpqT" Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C829122; Mon, 20 Nov 2023 13:46:40 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-331733acbacso2126128f8f.1; Mon, 20 Nov 2023 13:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516799; x=1701121599; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IHtXO9XtiC85W+x/HW1S1eU0VwIPJlyCXEkRfSi7Djs=; b=aSwFUpqTdPXF+puqUtVU8EKLT6UmUItBDHRCbaCaemnbVUwrR8NMIrJiY9eD1tGgYw wYIZtfvSs8/1C3oOHMPPwWhOXp4t5mUy6e3rLusFPXtIvC4HiaDnBkbugNTFel7Fcd+L TEUxI+OVMIFInO/Za7uy/OLGhc3nUeXdA53j50Q+eTDOODv9XlzznRQPqu2mrGjlO52O yt/g4P+KZJripmVIybT6TuDr3xKPSlaFapv1kyK9jj11FVAjXu85mJzQilq55yIsiyxs X7cpwYRfU76LjuIN/5YwLsV8Mwjclv41GBl/XXfsbz/OVcd+BgvJEMVoyRl4/eGfqQbt h+Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516799; x=1701121599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IHtXO9XtiC85W+x/HW1S1eU0VwIPJlyCXEkRfSi7Djs=; b=JZXSEpNgzl8usHHHR+Zc9qFYCgHF1Xd4/KvV7sFAxSdXYSXJ4mAjVrNYEcAtGeF0iN Ra87ezd/BIWWhJfS5GT/pf9Omz9w48p8SR/yJ6bGHB+jV9HMMU63w8PS5Y2vg46sCEVT eqVCfMHLtKYkqWxAOr0QuQoX7zIDCwo/73dL48gTJG7mOtZvFMheoXrbPPf7OmZ6TLhF 1LSt4HNCLDv2uO2Y3CRDQxAMEvXHb3FXmxlilza9r1HYg0RDQSsgIOgf8RI39SLuDaAz BBL9A4dLcRTYvBQP4xi2cq+9ulkJJyI16PB+d38/lFmKN7YXOB2qOfqwSxP/ErxhYchs gHcw== X-Gm-Message-State: AOJu0YyOtM98WULzHYB2HGo73HuMF7kRLxm49ZCgwxI8KeUoHamIDx86 IyI+BnwrDT6EKU/Q5x9G4Pk= X-Google-Smtp-Source: AGHT+IEPEt13Bi9UDLuM7ucKuA1EJUrPpC7p/7AqpQmlWfFXaZtyMu7XxxZkwo1OTgJaGb+DXzLqfg== X-Received: by 2002:a5d:4531:0:b0:331:6df2:3603 with SMTP id j17-20020a5d4531000000b003316df23603mr4725750wra.61.1700516798842; Mon, 20 Nov 2023 13:46:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:15 +0100 Message-ID: <20231120214624.9378-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Mon Nov 20 21:46:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745493 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GhOJjKTZ" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B1B2132; Mon, 20 Nov 2023 13:46:41 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4083cd3917eso20397365e9.3; Mon, 20 Nov 2023 13:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516800; x=1701121600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YucjSL5i0nwNQb8TgcsZe7VSoyFWTM6YGwWJl941dgc=; b=GhOJjKTZjWp6kZHcAfHGLnFIgl4Oc2D5GpdoUmGu+1XfRVq7x1QPVGSiq7wj7jFXiD JH9pcWKizQV5X4qAt9FVnKw+vuQVMqUg71VvFw+2zD2d6chKCkYybEyDAfrX/y+qNIy0 BhXqAWgVJj4KxhN+WSTZiprYJFm4wEArX3mn5dY6R//1Z72gPq0sQ5IXd0IRdLyB0qGI JrVWyfDGrd/ZeMDC48vVDOdHbk681duD40EpUEE2Mpmy3zRXDWV/CKb2BcbKJWqWnKg2 rdI+S5UcGjTBrgJ7V+MT5+Vh+A9BrevO9pllULL6LNvNgDGQ6tr1waRniQt0ElK+5RAP zR8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516800; x=1701121600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YucjSL5i0nwNQb8TgcsZe7VSoyFWTM6YGwWJl941dgc=; b=wGsnP1W2S9bBKtDpytQC9CNVQBGvg4fbHJDSRsVI8a1PxFWyuA9k1FplQJAxxURJ1S TutsIfOTaYYWn4vXywIhLZIvaGg1RWTPHTpCT+1hFfWvAA4yhfHfLBzFnIFV2muXMety gi34sYRX+BEne32JQAZh7uz8u+z/Ksqjj21Kqv6F4Umm5WUdXKaO/L3y+NJOdSZq38+0 tNcjz5/6fVVzKQqXtzi1jJ/QzkWNX2kW6P666zITJAEew4M57CYf4f3qdpFtiCysvkMB yJ6gGfkGisQvFDGScMegqp7ZnTWYpwE2PN3zaxSY9wZL0xjjzWN8DEiMxMoLHH/IsVhG DL9A== X-Gm-Message-State: AOJu0Yykxhjy0p7YGlMUk55neIyc34MRNKADG/Rq8Ejv0QZTFQ527euS wWq2wirQ83NNNFXNvp7oAD8= X-Google-Smtp-Source: AGHT+IHI1MXMavn+Gq00D5IWRHVWhxn647ptsSuePBK36r3qhuByg6Z/4wSKnRhzWG0O01cnuBnrlQ== X-Received: by 2002:a05:6000:18cc:b0:331:6b5d:84d2 with SMTP id w12-20020a05600018cc00b003316b5d84d2mr5455372wrq.19.1700516799569; Mon, 20 Nov 2023 13:46:39 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:39 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:16 +0100 Message-ID: <20231120214624.9378-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Mon Nov 20 21:46:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746992 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L1NgYdSJ" Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BF74188; Mon, 20 Nov 2023 13:46:42 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-332cb136335so707202f8f.0; Mon, 20 Nov 2023 13:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516801; x=1701121601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EQ/FEK2mYsIsrLAMj1ftUkEFHG7z/MaBn+ksqWZD4+o=; b=L1NgYdSJ5vHAYv8WXWbb3tRRgaBIt8tv75t1HggQer8whwgI8I8U1XOn3L7+0z+bI9 XnZZsrOWaFWbVv6uNNBAwWnmrlbq+JJAqa6ODU2AZUbveSokB+eqxY7MMfFZ4Hpk1aKp inKviwfftIsb6sYq/mLtaIahtvJ4AexEgKR/9Xn89GmubcxjBO/V0Ur3t0YtBKNYEwWT 8g/7VW5SAgfSNH7Qejm6yjmzInsZl3G/AWdDuBXZpZIGshwhxmNPakNmVqSX0/2gnflt oGuGZ3dx9XrKOwTSwJ1kKjkQZrH83XqlK28oZsHvPq9l0j7JomS8JI9KAk5fRe+SGy8j LUtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516801; x=1701121601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EQ/FEK2mYsIsrLAMj1ftUkEFHG7z/MaBn+ksqWZD4+o=; b=NKcQCmKJIkzsO5X3Y2P9GsO/CLXD5BOeqtrqfX5sgbOCLQg0tVBdWERD1EX4UmYrJA 7smrDsmuc9QvXUDJBD+26Yu45dJt4QWq7MCxiouB6qD4Kv1nXJX1k2EDsM2ppQg4KmbJ RVp0drt0x8DwxupqyVg6MiF1VIe00KygmttRp74RKunkgDVkn4geYpylbN/pIHoprJqP Poea0vrET+ufxy8J+o0eViYrCe6x7EEN/LJ4m3WEUN2XwUkQbcU4iCgv3kUuMNHHHKwF BMa5FgKbSTFeucQu6jx85p6wHm2Z+oB98U5w9BkA+2y5KTUQyZc3bmYfEr1EeVV5PBsy kKTQ== X-Gm-Message-State: AOJu0YwyfA/2EpiQEdAKPAuaX40LXgI9gRvSEvlL7HMp1pWSi+684W4J 5FyX1PYbnDqDoumLkZf9Ts0= X-Google-Smtp-Source: AGHT+IEJmFFE3EHKXQ4RGWFBYumObm40aSlus52AgE+TXXlh+CCacbrX+eglWn0cbPoyet+nNAcCRg== X-Received: by 2002:a05:6000:4010:b0:332:c1da:4cca with SMTP id cp16-20020a056000401000b00332c1da4ccamr4845981wrb.14.1700516800595; Mon, 20 Nov 2023 13:46:40 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:40 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:17 +0100 Message-ID: <20231120214624.9378-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Dmitry Baryshkov Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Mon Nov 20 21:46:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745492 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZBDuolz" Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F4C8CB; Mon, 20 Nov 2023 13:46:43 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-331733acbacso2126166f8f.1; Mon, 20 Nov 2023 13:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516801; x=1701121601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=lZBDuolz/Ve2Kql39nrWMyssJK46MAX8SIa0avgweMI4nQ47+b4g7VVIhaLDjiAfqH WYdAXiLvxCzRwkhG2Cl7ivBwHik+eKYQ5loboZgtUfZpfID2SBayPdXwa58nXuqknzvU ZRoezjLbNew4xxz7xflIntWujLU3xlRfsY2PPMLHX28V1Tg8v3BJMf9B4UQwbooMFiHy JhUvy3dHXvbWbWHgQdBdwS4lm01I3kvYdtQo6vIL6DUMJzfgvxPPyd/UcYD60/3kGnZc hTK9wuFb4PrVTvKQEB1TqFWtsfX6TwSaaE7Owgn1S9caAHORGICBKx0cbaLzrmRguFSe WcMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516801; x=1701121601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=uefdVcBzdX4dnxAapyYE/3mbYyJDVIIkRbZmI8ugo4vtqotdOxSjk1fgZ2GtLRG838 wJ/bae83kqaIb4jFDhBYcEQHQZLbMq5WXAVaaQ2D8lLF1X2x1Rw5PguIhrS7Az5LDYx5 q//4rB6XnDtD9ZuFUwu0nBbmHdFkfD2EjJ1CxHC+6z2pNLKTBbMa+EOflYA2+isFiUM7 0Ajp4eID7KhaLqYDctkcz2bF0HAtgh0aztLW7oKbsD/sNqL3yQBfluAXmUSTfx8kHsM/ mTxac3ayzrWdEixYK1U8LrNaK3zoOcgzD1x3H7NXpfu5Fx9Jxxb2MOeqUsNs11rWUmvT 02Rw== X-Gm-Message-State: AOJu0Yyfo0JYNH1+QSWs+SOlBc4NqB37u9/TFSlRVymWXgoaInLVb0pY FbTYKzV/vvUGqlZYGdvaCrkd/5M4j0nDtQ== X-Google-Smtp-Source: AGHT+IH3/XFzq2U/6agtXbj1oqhLy7Jth3QoBz9Hz0FwIflN3vy7qQTcPG492HCCqk1aqFe8zNZYvA== X-Received: by 2002:a5d:6d87:0:b0:332:c49d:28f6 with SMTP id l7-20020a5d6d87000000b00332c49d28f6mr3843056wrs.13.1700516801468; Mon, 20 Nov 2023 13:46:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:41 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula Subject: [PATCH v4 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:18 +0100 Message-ID: <20231120214624.9378-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Mon Nov 20 21:46:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746991 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R9uTnzRu" Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C5C31A1; Mon, 20 Nov 2023 13:46:44 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40906fc54fdso20452795e9.0; Mon, 20 Nov 2023 13:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516802; x=1701121602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=R9uTnzRuk8C6IVifraIGRrXzWfIJH0LESZKTQpuCvq8EC3qfce2MgsfCtufdubrtbN yppLC4ibhuQN6YCrsDUVkMDjerBi6UK3oFLAF9JXJ5ZDbXIJEW+ViXQHrrn12XdyjAcH KWtryUpRy1Q4Zdd4ad4yRiOaoKN03R+SN1FgL+DrksF/2Pmc5P77d3mUxA7WKFkkwHTj NgEGLDUrUJ7OTPufXZbbvGZPs6teezeE71Ko9tDuQRf7cDXVd+ERRC9nTrDcL2d8tw8r oP3MNns2nX6Dklp5ZleEec0TNfvGtqJ5waPdJ0UvmKQe87cktUXCpxjrqdCzpNUMxMUy N7Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516802; x=1701121602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=RVO+j2EOz0uhGA0ytAS5iy/nSiIEUnle0vTLuz6cfyTWRY6mmCexq11ZIIsSRJrwpk UCxHOfvxT+MzLDCKGK4RdAlDicuPCXyfCQ+RUZ97cm6kzswmFzDDgqV6M9Pc/wEdmqTQ LfITHKmSNYEMphkZBiy2/8eQRz/EPlz+tajpDPJTCSiO045axH6PEL1R5d8zvR8gJTB/ AThQxCETsC2WY6uNhbfcGBLv2O2p/B0XNrVlcgMCuLqhDfaR1zesDg8TTEiW3/DwiqH2 2Hl5kpXxLD2F3QfP2Erhz4ssAyqeRhz6DlkvJJN+LRh2AKPCDA3ckCqImXE3utCu9hoV yLng== X-Gm-Message-State: AOJu0YzzMZAwARSmtmUH2G8PR7axNguk51fvvNpN3CfSY2Vn2fhtYNaq Bh3VLOvArZ8Br4HX4MfISEM= X-Google-Smtp-Source: AGHT+IGCNvJ+s9QKyAFCEyfQzE+WdN1YcyTEOm5eawrcWLv+hW9plFQx2WrzNQnxKdHkttv2+45PsA== X-Received: by 2002:adf:ed45:0:b0:331:41ab:22ad with SMTP id u5-20020adfed45000000b0033141ab22admr5898305wro.20.1700516802375; Mon, 20 Nov 2023 13:46:42 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:19 +0100 Message-ID: <20231120214624.9378-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Mon Nov 20 21:46:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745491 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OsNZpvrQ" Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2575D45; Mon, 20 Nov 2023 13:46:44 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40859c464daso20068915e9.1; Mon, 20 Nov 2023 13:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516803; x=1701121603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bqROwQG7N3qrkO1+o2zNL4maIfyYwDDg69jSMCtjk0o=; b=OsNZpvrQIJ53iBOXn0CblDPCFVQAOz1/kmMpbNhgbh6EDubTv4YE+Cx/4waAsdJxAW a0e7o8GvPKcud+BPNfc6mtOlEkpUX7HveZi5bfrwwcQe1yxAfMgxF4YePSqf7ux1HDup rN4XmD/6/CYLGeiUNu5FcUU8/d71TEwMHmV0kjHo7lKD1y+PzveK3KKUubzPCO9nVSI5 HCFZCH1sITrNzROieI1ELI7J5y+IA6yPXjUnlKZsQp1wsj74ntwR3A+fNAeZfNIZgrxm O2NeL7Gh4Hk9Dka/VOVNKmpBfQ7HLMxf7MToodp+iyqFn6z9Ka+YxYOguzGrjUCO7HRS eQNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516803; x=1701121603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bqROwQG7N3qrkO1+o2zNL4maIfyYwDDg69jSMCtjk0o=; b=RQEasv/+NhHIDdqkvEA2bBjG0ulvjbatoYNKKiT+R0Y8skdK16eKi4PQRnC2YZq91m bdThtScLNssEtFdhGkt2EfHV5VDuXw7kdQsP+FCa6QmOhiW8MFFg4M7CAbv/dVn1qPVs YamWVCY9VNFhxCN3InyyCogrKHvXbv6jFg/Bf4PH838OsIyczv4elMQAd8Q7icx9IvzF 8fcxtiNqRcV4EGvaSwdK1R7o9KFmthFKYmNeoPrgG0dhr41brvo+PCEihpV8+OhCUeQy bZ8/cjvdTi9QAwaTlBXlIe/hvPHt+FALTr8EGcuYPg3WQPmp36xuRRkWJGX+UwU9OGDw eXVQ== X-Gm-Message-State: AOJu0YzDKgo35cfxT1RAnBtMG9oklC4KRzvlqjkN1yX4iehq8i3ELayy SOaW7McZbqSJ/kt80mwO8SY= X-Google-Smtp-Source: AGHT+IHzZWuP7fUYMd2+O3OBOSCHQpJLAk+VbHkWWjSpa7kQzX5njoZWRysEH9t0PNmhOAIArQoRaQ== X-Received: by 2002:adf:a353:0:b0:332:c4e3:9b09 with SMTP id d19-20020adfa353000000b00332c4e39b09mr3466448wrb.30.1700516803239; Mon, 20 Nov 2023 13:46:43 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:20 +0100 Message-ID: <20231120214624.9378-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 20 21:46:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746990 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S6oeHTuq" Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8E3ED54; Mon, 20 Nov 2023 13:46:45 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-32f78dcf036so3595673f8f.0; Mon, 20 Nov 2023 13:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516804; x=1701121604; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=S6oeHTuqo9Cu2jPbQ3WAd/KLLo/MJ1AasiPwxFVLCz7SCg0CbVplwEnBFerioZVKOL hAR7S4ZgTQc7n+S1T+KsgxVpcUlYDy0SS3TeF0EnBfQZ10xFhGJf+3DN6rizpd+cNmZV 626gaOK6dBa4Ly4heXRdUDhtEu2SfftESNm6C413pAYCTMERI2wTpUJ2B/fmjhy9P2H6 eFlfEPTxoYDjDHD/A7LPcGky+/f3sEM0QYBz806qPMx2QPyhWK0yhMpHCNylJ0klSQrh NuBl1FqMLd2D6zr3Pq0LjaFObY5YTqbfkOV1/E1sBLw+gBcjFfaD8c3HxsINPxcC0R7T 3fhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516804; x=1701121604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=DyfedBdIdRwY9VVUErcrv27Ym5xG7OrUbK00fVbcxxL4RmiLb5LOTbp+EzN5rpK2Je JPAMMN9MKZw2Np0NcLNKAbzEzJijdadUU3xznpgcHiPOQFrNdZKvpUl9XoXjeErB8lbB ukLhw4G2vT8p4R1r2OYIyy4+djI+NYNa5+a03cxaKojmJupb587KHtECud6AvMKseIL9 OoXxxg7Hqy7I7ZNjeeKaqvO0DF2bd/qNhRaO4iM81IZFtDnzUzEZUOm5luGOj56niUte +EVJpoAjhptcc0yMRyy3KrCGeQe9X0tP8qEw7jPKGjxzBTp8Y1iHgezSQuXFifLc86Vv U6Tg== X-Gm-Message-State: AOJu0YyDimCwgVaVZKqutGgMNXHDlZov2vk9CFty6til4VCXuy8hJnpz t9dAiiu+Oh5QwjtG9jBqxD8= X-Google-Smtp-Source: AGHT+IFhVjIKyJHoTFDY1S25E30i9YBHBvrq3sray80zY0SoXNdaGxfljpNF4jtOS6XdTV+AbxDGhw== X-Received: by 2002:a5d:6da6:0:b0:32d:a366:7073 with SMTP id u6-20020a5d6da6000000b0032da3667073mr659505wrs.14.1700516804106; Mon, 20 Nov 2023 13:46:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:43 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:21 +0100 Message-ID: <20231120214624.9378-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Mon Nov 20 21:46:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 745490 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LXyrklz9" Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1B1FD63; Mon, 20 Nov 2023 13:46:46 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-332c46d5988so1117817f8f.1; Mon, 20 Nov 2023 13:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516805; x=1701121605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=LXyrklz9NdIABktGaWIu9SmMhyCrDNoXI2o00RsbYG163kgsVMykEO5+e1uc56ERyI jaQ2LpR0+xF/c4xOH1bx//Sk0o8tvS6sfjJNpt2AAad5aXMVH8Rb4dGDxSy3xmQ6yk4b a0ZfVeb51hMhX1Cw3CRkbFcZi9HDVDhr2eEZkUMHWwogqqAjAEBSvAUM1SWwuc+XYHa6 UGmDAoBN2L8ikID6ePl5vzeS8GZhxbqm6/d6qglJbPQceZTaoqPaYia+hDajr3AudyE1 SnCf7oVu5J0Waa5f24HR9q3ZQWkRL83Ppi/n53rY9EhGzSa7ag+ihJo9PCwU/UFcPDcJ x14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516805; x=1701121605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=hryciiSj5mZ7HVwHax84BUbw7c+UykxM7hDbrHWghEHTOxtRNoHS67q4BaYNFdplMS KVC8gdpGbN6lyJgjtL1P4SEj4n9sOVdD34mVf0nTVFJH3eIwi9N14XkTcvutZQ6a3/hU 999FnmO4lTS58mSXPu9aFpQZJd+oDe1PILvwoKCVVHUACEQ8SMena/0LabnfwZogoisD L16qZlmUrkEsRK41k1Yu2GKb/WIv+uhsOgeDnzo69YkoG68xlVldR9tIjpurO8I62vLv L3UKQT3KdODguoWPKIHvR4GCC7X3bIv44B9WUXJNdMTPTQQcYbd2ARaTMpmRkp7ZjGMM Vf0w== X-Gm-Message-State: AOJu0YyFhKQlQ8KEfboiZFYJuUNPT+76Y+venARGxw2C3td9AH3Q0kKQ odx1hqzs4hAX2qeSx+DOXqI= X-Google-Smtp-Source: AGHT+IFO9ZmrSbH6A+/A5LyWdCeKfgaeedlrEYc7qHHXqeUF8v+awr8pU44qCeg4rV4R9MhiuP768w== X-Received: by 2002:a05:6000:18ad:b0:32d:b06c:d30b with SMTP id b13-20020a05600018ad00b0032db06cd30bmr6861142wri.55.1700516804962; Mon, 20 Nov 2023 13:46:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:44 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alex Deucher Subject: [PATCH v4 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:22 +0100 Message-ID: <20231120214624.9378-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev; From patchwork Mon Nov 20 21:46:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 746989 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NJObFDy1" Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E8DD79; Mon, 20 Nov 2023 13:46:47 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-409299277bbso17817435e9.2; Mon, 20 Nov 2023 13:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516806; x=1701121606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=NJObFDy1D0dyDfAj4tNiz+auUALyeVTm1J2hMFjdWftGR3JnXkdNsjrFmHe7b2MC1U B/n7eXLsiERVc4c4lDIQjBU089Qk9TLR0fDN1lMDNnCs78zPEVPcmcomvabflElmHTmF w1DHAqm5VH0iPL9z8I9JFOAozeiuvLvKDLgL4JBBAqMx/vpNwWGdii8dVkBSpniuTKH0 VRiRH0Ahn59+CeCVSHKX+nCND9OnUiwL1TL7WqHYUBvjfNp5HXdB7pr1z7KPLctT+ric 5bh7H3cFFtmp2cbcikehP8101TEBWkJks1X5ZAc5mM932Gvtc5b8Pje/23dhTaBwmOaH 7tzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516806; x=1701121606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=YN8kyODE89DTSodKIXW/zbtOvg0sXhx0MCUxLb6yoX9kfRZDWrJObehWh/AaJpdGFc lxKw1Y9xRA3Ot7w3itFY+9pCYoJbOIYIGAVfjqumIApbJdWPeoZb12SkjtmzH2QfKmu/ vQ6PUFmsS5fhaT/gD3edBZ10xPnZLHtSs+G2E4H2hUFlpYnomv1LRMO1JfLivRnjiWEF LA54oACvQ0r8P4Gf57jKaTJZH+7VlYfDbCWEXhUR7itxAxmQQmYWv0NEYrDjMNbTh/l5 KS/QtMe2hDcF39gi6NaEaEU1zFLohN8LokhhLV09QYBmjf30tGZsBiBcPmWJqcutQSaF 8b/Q== X-Gm-Message-State: AOJu0YyUgzmhrBZKkkU65lEF7rpN806mm+UqkRTNVhzKuwMdlVd+Lnmd DjusGrC9twnPxm7QkV+2MIScY9kpkzg= X-Google-Smtp-Source: AGHT+IEqJE/oVNOUE1Qqm8diYpUVGakA8xpgibcOqaJoKcZswdc3zI/IPqN/vZiu77V30PdsZ7piBQ== X-Received: by 2002:a05:6000:1845:b0:32d:a4e5:d3d1 with SMTP id c5-20020a056000184500b0032da4e5d3d1mr7428728wri.4.1700516805958; Mon, 20 Nov 2023 13:46:45 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:45 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-kernel@vger.kernel.org Subject: [PATCH v4 20/20] include/linux/i2c.h: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:23 +0100 Message-ID: <20231120214624.9378-21-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- include/linux/i2c.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 0dae9db27..d029aade3 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -850,7 +850,6 @@ static inline void i2c_mark_adapter_resumed(struct i2c_adapter *adap) /* i2c adapter classes (bitmask) */ #define I2C_CLASS_HWMON (1<<0) /* lm_sensors, ... */ -#define I2C_CLASS_DDC (1<<3) /* DDC bus on graphics adapters */ #define I2C_CLASS_SPD (1<<7) /* Memory modules */ /* Warn users that the adapter doesn't support classes anymore */ #define I2C_CLASS_DEPRECATED (1<<8)