From patchwork Fri Nov 17 18:14:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 745310 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=calian.com header.i=@calian.com header.b="WoFrOLMT"; dkim=pass (2048-bit key) header.d=calian.com header.i=@calian.com header.b="DeFiHQSs" Received: from mx0c-0054df01.pphosted.com (mx0c-0054df01.pphosted.com [67.231.159.91]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 645A6D6A for ; Fri, 17 Nov 2023 10:19:07 -0800 (PST) Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3AHHo8SE012164; Fri, 17 Nov 2023 13:14:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= selector2; bh=7GoMAZT+cFHI5w2j68ZleiTSqVJtBTZFGotaf7W7sck=; b=Wo FrOLMTY7DBS0BsZsyrTUl0ZMytnk0RDKgKnZW+NTKqSKaR78C+CPZV8jwFNMX8kV xUrSRrW0DLrE6VRNvo/SB7jP/ZGn+ci7Di2lxK7ToXV8sPALMLORu5X8frvSQ94L SBzCyd4cXOFJATGmtanL0/jTXpWiQoCVoIV3Hhh1SYHjt/p8Pg1QiwK4IvtszmkI gKB9wSBwP4hJ8PglUmYaWauO8Wm6RmPLkgO95Rscr3SamDFAM99Xv0L/QLEFaHDZ jW05vCbWA6hEVy3lFGYFGtu7odXI6sKr/Mdevv7rNzlhDFDXo9MN4H1+z+UySE5A xXLWzxg2gJm7acKFFwjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= selector1; bh=7GoMAZT+cFHI5w2j68ZleiTSqVJtBTZFGotaf7W7sck=; b=De FiHQSs6bAtCSa6sGjqobm8xHjbFnuRGiEgHRobY+Kqv/9bIqjqpNigQ39WkUXcyy xw1SyVV+S0xt5LKl2far10zN/R20l/btqY84W4NDHE5+4ImDas+UXbFkqqDfMtZK Sq/V51HRI0y4z4E/9HE/+NQc9N3NzsvgwrnhNbyYQYo6NlKuJW86sfQ1g6vqHPq7 trgzByPqxzy4t13LtnG5xiDfSSaD37SEsuaiL8mfSvSdGNpPmTzLvT8VbmvcXCDn F3iD9co1vK8mtpOSamWFvlvCaRYchvr6u7yauoDFn8BXofWlpk0+5wqpBmXWlNSD d+1hi3qLW1nC7XFVH+qQ== Received: from can01-yqb-obe.outbound.protection.outlook.com (mail-yqbcan01lp2233.outbound.protection.outlook.com [104.47.75.233]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3uduwq0u2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:14:39 -0500 (EST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQhamM57c6MgSQtZzoO63TUqFJjoZxEXMxduafhZuXeONufogcS1UbP65Kklrp36vTgW5sDBuKXa8OwxvG9FSktlxA2ONRLO9LoPu4OhNowe66N/MD8iCUU3vKlKqF/cm74i6NA19pCIj8ggnTJX9y/jTjcJOU89z3ZCuNMQR+LVhmOqYH4kv6bMStjTY1bFDRm3180yCJP3kl+pe6We0Av7Nw6A1rha0Ky0zLnNFAd8hRsqOhwD778pB2PA6t6EBf3iHAWYFHFhD3e310y5A4uWkGJFxkdzP5ntrLA5NxdVu02n5JFQtydcJk0d6U3AQbMFU+3eCH+Hj/OYlytlUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7GoMAZT+cFHI5w2j68ZleiTSqVJtBTZFGotaf7W7sck=; b=H2vWXSwYAzukILobD5sDHOyU7g/69ZtViN2UYyUCsN6nKg4rpxQrAis9zWNamqGr2vJeE4xkmFiAw9BGt9oXed/j2RWAgO+kEjYs7nNpAdmrziInQSuxF5aVSSacth64phPk4jngJf74Q9ZbM3DLWgfSO/GLuBh/BTt0yOq+Gp+dxBe1SlZ7TJ6Xr7ZKJb4j31Mpm3/IN06rkuKkKSeH7M14sUFEH9YZAjHda7G4Ay5WVvP/beZd+PXphALhiPOlfMCBrbYOrIr4NL82QYaDWGpJlJFLcVxXwjBQrqpQCsRS8y5NfiY1wem3GqHAzAMv81xY/0su7PN13Hwj7ditlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none Received: from YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:b9::6) by YQBPR01MB10797.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:73::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 18:14:38 +0000 Received: from YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM ([fe80::8e4a:d951:9c01:a8af]) by YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM ([fe80::8e4a:d951:9c01:a8af%5]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023 18:14:38 +0000 From: Robert Hancock To: "michal.simek@amd.com" , "richard.rojfors@pelagicore.com" , "ben-linux@fluff.org" , "andi.shyti@kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Robert Hancock Subject: [PATCH 1/2] i2c: xiic: Wait for TX empty to avoid missed TX NAKs Thread-Topic: [PATCH 1/2] i2c: xiic: Wait for TX empty to avoid missed TX NAKs Thread-Index: AQHaGYHtEoEebCqWzEavNcJ8AuRGbQ== Date: Fri, 17 Nov 2023 18:14:38 +0000 Message-ID: <20231117181238.3989861-2-robert.hancock@calian.com> References: <20231117181238.3989861-1-robert.hancock@calian.com> In-Reply-To: <20231117181238.3989861-1-robert.hancock@calian.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.42.0 user-agent: Evolution 3.48.4 (3.48.4-1.fc38) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT2PR01MB8838:EE_|YQBPR01MB10797:EE_ x-ms-office365-filtering-correlation-id: 980777b9-afd2-4f58-4d9b-08dbe7990fc7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K5E09Eyk2J170p6yt95SBEdh0EYBberOfw8JO4/11zZdZxfOQ+KS6+OJMkcLdBCrBQZGoogCffeHIVshyUGtr5oz0RD4EaDM7osTdRucIuEqshTFVZmkdCWYYB9s8VWqKRebgIDL40PQQHA2mWb7jSa3w6Q25U96jsekXsueDAE/xwQVmQcdAcBw6uINu+GA7wdXlk5yp0tdfTGpj62h0fDoBbfW/1nCL8+qX0eup7xlHO7rm62gYhGk8jY9Cvz+UGg2e4B5GyeAOtsqcVaWU3Vv5W6YsxYGy460ykHbOliCtIPtnIba81zOzsw77z76CW0ia40HNqctYKrXL8pPYGiLQGJDgMat32eSH6ZOKyWM9ozA2nbuD61nZrRIgeOnK04NHxHJI4Pm0lHeNOjf0Jtf3Ikyg9gc58X42iYK2f73tNCroShe0IBtxI74sI50iKp+xBOhaXTYw9TEN5Ch/swVTybtNrgaLBSkJqld97gJnBdj0m3WAgSmEgvzM2y6vXHoWLxxiteUpZQR99p/4cvNey4LMWmJ0VWFdKOrJkmV/bUeMoiSKluSv+dl4kJK+bS9N6v/722Gq+C/+pt9U/XUiOvFDREI3WrYoNR6uwU47oJEj7TLGZPEgZi0oU7Z x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39860400002)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(54906003)(66446008)(5660300002)(66556008)(66476007)(64756008)(86362001)(110136005)(66946007)(76116006)(91956017)(316002)(38100700002)(1076003)(26005)(83380400001)(8936002)(8676002)(36756003)(38070700009)(4326008)(44832011)(2906002)(41300700001)(6512007)(478600001)(6486002)(122000001)(2616005)(107886003)(71200400001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?6KqorO33tsW0PtfhvHsIOgx?= =?iso-8859-1?q?9kC/aHQoGXHgBqkSHtXnXqV/PF7+/+a0edjN6qaMsmEwh0GNvwEn3AZRkadM?= =?iso-8859-1?q?5lbQtcLAfoCGlgzhA2X8pHwNXYt8JpbQ3mT5Yc0HPuVnPlZ1uQCMSym2XeIB?= =?iso-8859-1?q?tXXmg/jvI6nZFN03HHG6LFRg3KnTn+qgeG0+6nXwjoJRdXHfSiAXhAPoOyDv?= =?iso-8859-1?q?jN9Ru0nTY/2xB3ckO9JPY4ufwJjUFNURelCeQCjR3XQJNh3patJHj3s7mqYs?= =?iso-8859-1?q?KnkjeFoNy1lVtwTj8txgjuKwnUx0vkT6MJ7bIEBI6KP8rN1HoqwKkzsx1mt5?= =?iso-8859-1?q?iHZqgBMYppGYzL/zlYkgam/1LnVnUMakK9tifZa/wtApQjcbwxw2/YJZeXFo?= =?iso-8859-1?q?l/El4AonEFG6AoMA49iuWzQWToU8lsJDH1wuaOOXdZgUJjD9vOHg+JT+j1bh?= =?iso-8859-1?q?PPlmIMIorYkvd98qhyWd9wpj/V39ZHADNsKzDj/tVakN3mm8yxxw+nzSnd8z?= =?iso-8859-1?q?1ww0taNvlcyRo2Y92YMLO6dw1bMLFV5RA/nH7NXJdDWLxr8zhYJ2ZP3HYgSb?= =?iso-8859-1?q?a033CKHSWm7nSJwxEp8AsLOKpd3v9s76OpbPrmF3I+Tyc4Ef4nZH6b1D8/w4?= =?iso-8859-1?q?lDhiyf/OXxrjEcF92x669NHzOilt5ODVtJHLDF1l3DYk2PUzDE7cuZNzkIfI?= =?iso-8859-1?q?7JUsVlTny/LLOayxk5pKEz0a2Bf1Z5Ye4V+9MWFFA63nkGzNDvsLnLVfTL4g?= =?iso-8859-1?q?qzZKd7zQAGIqgZKQTOhKxMNXAuckfqNgWJRrdpV+VVedV8VNMh1nEAN1RYbO?= =?iso-8859-1?q?tXJQ8w+UtnvjsXz+ZOP1//FpBE30T/jxXhPAM4fcQwxfjAyiK/U3ANgTgPZ+?= =?iso-8859-1?q?0JvqLiz1HK/80riJmxoX5d0Q8iABVjNEmPQsdHAK2rBHVWVQ5HJ3NfOY4+sK?= =?iso-8859-1?q?9kvw+d3YwMr6h6xYCJWTiHOskD43RkIpJBoi3GIdT3PRvcjuB0uUDa5HmtWF?= =?iso-8859-1?q?hpJe8G6WdsuowgY7IXRvYtKdfHZnxcAtTTkuEPc8Ji5ozNEkuFGKuohbqit9?= =?iso-8859-1?q?9Leg+fCXzCXhW5miUJt+B623okEbGbT8dTQ6BAzABmN+yzAYS4jf+TZfhYGh?= =?iso-8859-1?q?Q7UDJMqI0xWVt6JPeCxH7sVR0uSaM1dJN9BSVX3ypOOHCYDTwx/IzVIzBYtr?= =?iso-8859-1?q?2TbrbvAA6gH0mO16Jgg1WSJgr/ScFLsuNz1tQjC6J0K7aTUrfVV1f7wHoiw6?= =?iso-8859-1?q?P5zOYcZUqUkIaNOMLl8J3hDFpvm9LQVxzlQld0dzw1ssay2yCIBXSc70RVm+?= =?iso-8859-1?q?AAMqewrYDWXdiLioaXtRiI2K7cyOh/nfT5NzslP/6+UsHb2pEWcd71l3XS4d?= =?iso-8859-1?q?QpSmg/4IrSWsuRjImx0tKCyNVGrCAPsZT4qAbE2GwIl7+LwaYHiGKD+Stzxw?= =?iso-8859-1?q?+aDquApekrWjyWaM4rGCAe0OYJwK3BfZKUkief1U0CvxcI6v4nvbP9AUCuHW?= =?iso-8859-1?q?vZpSmInZ1+xEW1FfZVyE++iY6JQbje7I8gkaoTQ7xqPbRrIHYh/agaQTTAHp?= =?iso-8859-1?q?Vuetc2gQOLZ80Dj5mI90cvzaW4u5h7EbISABsXAcV9A5YY0u0w5LbWw/7fzJ?= =?iso-8859-1?q?fNDFZRsmJE/NRB8akumeItEJhI4mINV7DWPuX1Q=3D=3D?= Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-1?q?CD3LcoW41pV?= =?iso-8859-1?q?VPABVMvxqutaWrlTlIqNRH1kzvaKvINag6yuJaINKpP2A0jviGwXZNkFUUsw?= =?iso-8859-1?q?H8lNV2G2LNo8Mr0IdC9mLTFKPoiTFSFh8mXthQbn7Ai/ya0ekurYZ3RbYjeq?= =?iso-8859-1?q?uv3BPlP+dE/Pnpy800+SMCfq6ZKMZm/q7FmVMrLnxfteabnoTwssbx96AesV?= =?iso-8859-1?q?IH148TEf1D/l0Dr+J9qmhoWzf+kNNyhejLJOwnIRmQc3iFgmrtoMQAkkqKbM?= =?iso-8859-1?q?Mb0Wx2h2r7kJSa0ZIdR/N2OKIeOnd2IzW/hBbtQpvw9SpsC+TsyBj35d+UdR?= =?iso-8859-1?q?QN9jEdJ5LgkFhqQEfxqAoz6899Ek3g2ATgQfKYOAJRjGWECnEN/rG7oix3rL?= =?iso-8859-1?q?QXLXf15//wbyP70U+3Hbyy16A4yKU/YqNNk4+EQaipAqSI27U+e2aJ5jj7Dl?= =?iso-8859-1?q?n4hUqa4KZm4ykh6+6h8G0XtSM//lJGT8Sd5OO+0HC60CV7KV3IW8g0p2wMD3?= =?iso-8859-1?q?KcDl0Rz1VXfQi9Rih9IZdNlW0lVwR+HdBiw5QWBqPpuL0YayCOMXXAR4ptsM?= =?iso-8859-1?q?RQxon8OmVoN87Atbg+KhcCRU6IkNBQZV08spjHtxQYPX+cl3yzuyT+3NbyDQ?= =?iso-8859-1?q?MP7IR36UjnhFw44vOMveBX8ko/hIQK47eGOd2GaD+lGEcTWcMI+h2bLfreTI?= =?iso-8859-1?q?2ld1S4V3goxSF0oXHVmvKrWWqpjAJtM7OMqkbDwKvh1oT5WR9K/RnDbGD5rs?= =?iso-8859-1?q?/j8h/tp2AHD+dZH/es47o1GVWJtlxtKHT/EAjii66MkDpxI9UKgdz9NlKFWC?= =?iso-8859-1?q?yBbjhXnegjWX2kP607vC/VRzO7GMim17JqK85uEO0UymscE5kChyKl8g8OHc?= =?iso-8859-1?q?gbqBuVEpuEQDBNlYxBWZc82WXEZNi+R6R+egz+G2Zg6kCFSlNeSx/s/rSMJP?= =?iso-8859-1?q?QPSxmE0utttEt8/QYNwgwcJMD0DYwKv0OSQB6a2FJO8SC4M8qhPlH3SNQfHw?= =?iso-8859-1?q?nvsTSBKOSlQ=3D=3D?= X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 980777b9-afd2-4f58-4d9b-08dbe7990fc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 18:14:38.3645 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mxYtha7vNHORn+LsI/G6WXwqVMTkgj3o9Aez0wtdqmMN4jAyGN/easa1vp+U4TQPnzU1lpRwGS9jjFukzPKHDr2Pe/2N8g1SKChO1OdclII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR01MB10797 X-Proofpoint-GUID: 3KcSas8zGU5-LnbVW65Wo2NuPKDc1mjK X-Proofpoint-ORIG-GUID: 3KcSas8zGU5-LnbVW65Wo2NuPKDc1mjK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-17_17,2023-11-17_01,2023-05-22_02 X-Proofpoint-Spam-Reason: orgsafe Frequently an I2C write will be followed by a read, such as a register address write followed by a read of the register value. In this driver, when the TX FIFO half empty interrupt was raised and it was determined that there was enough space in the TX FIFO to send the following read command, it would do so without waiting for the TX FIFO to actually empty. Unfortunately it appears that in some cases this can result in a NAK that was raised by the target device on the write, such as due to an unsupported register address, being ignored and the subsequent read being done anyway. This can potentially put the I2C bus into an invalid state and/or result in invalid read data being processed. To avoid this, once a message has been fully written to the TX FIFO, wait for the TX FIFO empty interrupt before moving on to the next message, to ensure NAKs are handled properly. Fixes: e1d5b6598cdc ("i2c: Add support for Xilinx XPS IIC Bus Interface") Signed-off-by: Robert Hancock --- drivers/i2c/busses/i2c-xiic.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 71391b590ada..6e84b4d67fd9 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -774,12 +774,15 @@ static irqreturn_t xiic_process(int irq, void *dev_id) xiic_fill_tx_fifo(i2c); - /* current message sent and there is space in the fifo */ - if (!xiic_tx_space(i2c) && xiic_tx_fifo_space(i2c) >= 2) { + /* current message fully written */ + if (!xiic_tx_space(i2c)) { dev_dbg(i2c->adap.dev.parent, "%s end of message sent, nmsgs: %d\n", __func__, i2c->nmsgs); - if (i2c->nmsgs > 1) { + /* Don't move onto the next message until the TX FIFO empties, + * to ensure that a NAK is not missed. + */ + if (i2c->nmsgs > 1 && (pend & XIIC_INTR_TX_EMPTY_MASK)) { i2c->nmsgs--; i2c->tx_msg++; xfer_more = 1; @@ -790,11 +793,7 @@ static irqreturn_t xiic_process(int irq, void *dev_id) "%s Got TX IRQ but no more to do...\n", __func__); } - } else if (!xiic_tx_space(i2c) && (i2c->nmsgs == 1)) - /* current frame is sent and is last, - * make sure to disable tx half - */ - xiic_irq_dis(i2c, XIIC_INTR_TX_HALF_MASK); + } } if (pend & XIIC_INTR_BNB_MASK) { From patchwork Fri Nov 17 18:14:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 744787 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=calian.com header.i=@calian.com header.b="JGNMHHdV"; dkim=pass (2048-bit key) header.d=calian.com header.i=@calian.com header.b="QrPlAKdR" X-Greylist: delayed 201 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 17 Nov 2023 10:19:02 PST Received: from mx0d-0054df01.pphosted.com (mx0d-0054df01.pphosted.com [67.231.150.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 415C1B8 for ; Fri, 17 Nov 2023 10:19:02 -0800 (PST) Received: from pps.filterd (m0209000.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3AHI3xS7007392; Fri, 17 Nov 2023 13:14:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= selector2; bh=IH0Se88qxNerFDbGSd23aN51txbzvZGW0NYrVV+aMSw=; b=JG NMHHdVI2X1zREJb6dW8YGkf0TbJZIhHATsAPsnbGEcRL8eGx3iM7S+ae2LP9ELJN c4AvRI4Q5hG08FUN6st8PTqvIcNEMC36uWm0BpXC8ikEsm91NUgySGklZih8tlOJ yEj5E2zXYSVoYMhIGxGxZMZcGTD7GmhCZTo95pU9eRlHcwvTF1DgpvZRc/mkjDXF 0P6lhGsOmI3vLN0/yx6UIXHILxFvsIVImeRLKvL19SqWAhSkIATmU0Y50MnuOtxv i8wHDB8u0oa96+vwWHG0Uro88huVwsxlWG+izduLLpq8W/cSWMsl/nl8PeEoIGDH zWJpdAhNmdvAs/hcVFfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= selector1; bh=IH0Se88qxNerFDbGSd23aN51txbzvZGW0NYrVV+aMSw=; b=Qr PlAKdRJ3b0kCj4wV2aQywdhOXGDDmDOIdsN9gZW5w9zoxAQ2h2foUJhFrdCpxWcg VAPReHHALkl81Pr1kvGdaTNsvqUhQwNii7fkniLtoJA+fepf8/t4htuk9uQZoI6Z 5tvjtGSZ2HnbpZWiXYT7kyH5PJ7Yl/2b5+yThSX2MOX6rs+YjoPr6+W7zeNRgJN4 NfmWg6Mpi9MAd24cDwb4LOa9M8Rhu0u+kVsQr7hEx/CgLIQa/AansVaMPzL1aK5A UCfU8Q9NV8LxxbIH0N/sVJVNNNesi+ZgXCtUgO9kOUcHkHCjS++QfkZL+oTRTOcV tMv5/VSKIgl8os5xJp2Q== Received: from can01-yqb-obe.outbound.protection.outlook.com (mail-yqbcan01lp2233.outbound.protection.outlook.com [104.47.75.233]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3udrng0wk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:14:59 -0500 (EST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpKXwuSeky9irsa+HgrryVblNZeE4qfcbMlM4NK1xLoa7jmoM4iKvy47L5snoWdIe+4MvhAEBvexVKGwknXvPJ4qqk2wa0FWLQJcJe+iuCO45mt9CcEn4mRkjAPIdPV9k9KrzClFe87gggBttc85fQfH7SrfXL6fk1D03tekaFBX3kQV2cYouejUsGnR6ljUyY9IPCnFAODX0qF3uORZbcnzX2ZI61W7cCDuht2eqpUur6wsuHKTcd8uyU5daRmOJso9UPPy0FHsDgUOukq3J0snu4nUmOc2vZ9nfpuclFIS6MmR7pM8HO2yC9Jrp75mWy97skQLYqxb+Wy+kRdXUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IH0Se88qxNerFDbGSd23aN51txbzvZGW0NYrVV+aMSw=; b=fg4tvo5p7NwCMjGN80Cr4rjbr+KGV+Bo/9mJw2dSo21ZCNYuru+tOOXpp3rOtLuMwSm4ID3wZYdg/vtbF5xyiziJk/XAFnn9/HJ4+WLPHx7b5LC/aqHMK9OyMQAQQKW8ffFiLIGafo7dHP+w1D2rMTi1hAvziVD33xWnLhlsYMIn3QB9fepU4VLVtLwl869czmMGGDMCGuKgE/arf3bbtUBtijfjyT6h19l4aYssZiNO0qt0xNmB57bjuyKTKUbGfzY3HktJTGSxIrufU9sl0jI9c1hDUw73k8pBZgWzyPiMwoB0DGLWyIVdRw4131hY4djqF7eles5yo2JhYtoTpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none Received: from YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:b9::6) by YQBPR01MB10797.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:73::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 18:14:57 +0000 Received: from YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM ([fe80::8e4a:d951:9c01:a8af]) by YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM ([fe80::8e4a:d951:9c01:a8af%5]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023 18:14:57 +0000 From: Robert Hancock To: "michal.simek@amd.com" , "richard.rojfors@pelagicore.com" , "ben-linux@fluff.org" , "andi.shyti@kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Robert Hancock Subject: [PATCH 2/2] i2c: xiic: Try re-initialization on bus busy timeout Thread-Topic: [PATCH 2/2] i2c: xiic: Try re-initialization on bus busy timeout Thread-Index: AQHaGYH41/AHDHR55ES9zmu8RHrsHQ== Date: Fri, 17 Nov 2023 18:14:57 +0000 Message-ID: <20231117181238.3989861-3-robert.hancock@calian.com> References: <20231117181238.3989861-1-robert.hancock@calian.com> In-Reply-To: <20231117181238.3989861-1-robert.hancock@calian.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.42.0 user-agent: Evolution 3.48.4 (3.48.4-1.fc38) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT2PR01MB8838:EE_|YQBPR01MB10797:EE_ x-ms-office365-filtering-correlation-id: d268c4e6-1dab-4904-5712-08dbe7991b51 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pVR9jYiQSzb0cjT+YUSwkqPCyINBOrjPzfNlAINpCWuvhLHK0lYMtkN4bprjSec7VGJLgTdVu9LZPO90ijTt03sN3Dfae0kYxUoOfTDuuovjBO9qKr6qLyJY6HmyLPiyBZFA/0KTUECnNA898JopDnOzkHC4uuLsD5uLLbea0AtGhHFHqQRGW/uUiTfZsP6n03YIjjPNlac5uYgqqVkXrvg7Hnfyf+3dI9NSU4Fa60ANZp3e4BBTGDylCNdFSDDdqFlqZeNIlAfhLMxC9rnXuop2dCKUGqMh/rBOdKIJVOz7p5ULxZUq5puP5YJYuCwkAjU9rATGu8OGESOIUcTaiibR2JnwIyfs+mKoUiY2LEaFM+q6tDblKBCPUovPy3aOiVUDyJC5ahmPoR4OjQFUH5HdSHoJSv808k/Vhpi9kdxIFZMdJoHwvAJsCNkg6xX3Q5oWEc0G0sVlZVc55GiD5DxD2hy6ZX0lZ43woaQU8VBZVBtsVJm6gnfwtdZiDtb2cgBJu9Yb0ZbYQRApbluIHW8t9GF56f55b2/4g2VJj5GRRc1b3VjS6/MOseTuj+xYdrzy29bVyLRypUDdSsrSSzMNJd4s2oSyJEKt7ifZq47Fk2fYAO4NLbB+FxZtDdMK x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39860400002)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(54906003)(66446008)(5660300002)(66556008)(66476007)(64756008)(86362001)(110136005)(66946007)(76116006)(91956017)(316002)(38100700002)(1076003)(26005)(83380400001)(8936002)(8676002)(36756003)(38070700009)(4326008)(44832011)(2906002)(41300700001)(6512007)(478600001)(6486002)(122000001)(2616005)(107886003)(71200400001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?t7LDB4YYaItqzfFiMBkQWHL?= =?iso-8859-1?q?n6gXwTEtXMwsgiRm6Lqh4ElqKNEe/7TYNvPgngAPR4ZpWlhL0+zIOr+eEHbr?= =?iso-8859-1?q?Sgf0qNboxwOwSXnMJuDe2/S9m4tf3PdcsBaizHnN3Hc8M801fbdSFHBJuQ+v?= =?iso-8859-1?q?lpBINrST5g+ZTQdWoLIE2DItvWadhHIb+Y7bpUw1iScagPSZy5rnPfRH70OQ?= =?iso-8859-1?q?g6geX75n6YVX33NvJSwO+KGwa5LEjKsmMxoXjvjgTl1IruYICOYUlpR4A+7I?= =?iso-8859-1?q?zIamZ4fWTcnbqsVSfx1TtdHzMwnYWtBuRYiJxd6yLdDf2lAkPmmjOLNv/O3y?= =?iso-8859-1?q?Vh+0SJKxVboKGVAcRaQMJ3FTEH9y6QG0e6IlRpt8LeUql+2vOPkzn6woU5sp?= =?iso-8859-1?q?/vZAVSV6N1NdzOOG7kxx9OtCefwhAZYlt24nWXjWgd79dgguFViLGsI1BnzA?= =?iso-8859-1?q?dG17wBGsSMZIwSWGjMrRNaAu7l/BUBABCITtKt3vGCy90gFlstNoa/803j6i?= =?iso-8859-1?q?n1m9XqjbIJV1+Ce76bGRaOoJM+f0DOCjz2Gd9WSWubC0K26e80z/fjnAfbe4?= =?iso-8859-1?q?0oULHAAMEl1cEMppKf34l2Q352oQdc4c5691FlZ5aerybIM0aXWDMad3EFdu?= =?iso-8859-1?q?2vhcJWRiSOeHFz1IBaCa8ShLFniRIc4KL/8C/4gvGOFtCvveQsI0B6XDCCTj?= =?iso-8859-1?q?nIZF4tEvzT2CGMjP5a0KA764/ZKMQC2ZqqDX20EVcb93KQ9qBhwPyXJi70vz?= =?iso-8859-1?q?pLI9DjE6aPM8Ko2ftxEGjfk+gSsGzgZMa5kCaMsFeFN/J1jmgK3XLYp37hKQ?= =?iso-8859-1?q?NB56fn4RDs4sRzFxlioYaNeOteV7oad0TJQsFe/RDxkFTpnj6jSE5BSX0bwu?= =?iso-8859-1?q?C9iuZVZ/XSOkSwrv4YhuO+IxgsybLQgyB1FfyxFASV3u4uXfPjltkl/wPmr+?= =?iso-8859-1?q?Dgftjes4W5rLPsvNLnI9ez3UbmrFtJ1yIgbWI/9yLRbTopbj/IqriMDpMI+/?= =?iso-8859-1?q?tXlZiwfqtyAB4fnAs4BAzTiMAPn1NkSu3jdmJ8uAr/RPRPOZd/VBzKaSBbl0?= =?iso-8859-1?q?R5QhuAtzCF+ubf9/cdr/qI2O1bWnRZK81Zw5Z6TKHIyMg9ELYzsgU71HmmUA?= =?iso-8859-1?q?H27CsXm2K03g1puz3b8Pe5RnT6o+zPZaxIl+A1fdmi4GE4A3EhUeKSuxhI7s?= =?iso-8859-1?q?4PWZ2FXO0mueDW2+Tswv/NlIluHR10Q+qIFu4EDj9pcrOoxGMl8wUtdLgnie?= =?iso-8859-1?q?V0ScJb6VauGEz9ty5hiaFhfTucMgItJpi5GO5DTRNYmY6eSUDLEx78FVLFSm?= =?iso-8859-1?q?uQzgpD99bJ9eLXu2DKduPrsJYDyd8w1nFVNYbWv1eyQcV0c03UGD8tk8TBKd?= =?iso-8859-1?q?cXlxPMSPUGy/nPtLuycSJOYwP5Q9EVv/rOby0Xhg75BxScf2mUKh2JPjz0ib?= =?iso-8859-1?q?+MG4Zzz33ihsVwE4MILUiH/T6k2FWM/tJBSUzIYq9kE+rAPfmMegi7RujK9X?= =?iso-8859-1?q?3RFNRDtI/eOgSGlufGXpJlaNSZ9RHPPBM2hrjQg4+mn3TbYn5xqbdqy//t39?= =?iso-8859-1?q?XG/IYMCOoPy1ZTk3WD+wRhA6oG0sjLfVIAJ5QT53F5Z5jFM00Xjrj2YvppmF?= =?iso-8859-1?q?auOoI35zA3fYlKShqqyquG1O/Or33b1arymRdcg=3D=3D?= Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-1?q?leGFloDXb3S?= =?iso-8859-1?q?Ih0mDpu3DvmtkMzEBofMiMbSWRU0ZjucbyGDETRDpv43FuWFs+hQ4r1SNaPo?= =?iso-8859-1?q?tKwuc017/I8tZwkwsXUQui14d9m4/pAs3hHzBX/R/wYQhv4rqChzHK+03b/j?= =?iso-8859-1?q?+XeYOuNvXtaeeN7GMhBcYUDJ8/izHsacGPFDHEg5kZCnXofHlc/h5IJxVaJK?= =?iso-8859-1?q?hQcDaQZAKMWFy92ssYKLUmtlL02OwGE+J0j1/VPN3TnIndrpF69CHCxO8AzH?= =?iso-8859-1?q?iaOTjS2cyzF4Z4wMAgVYtNDh90D06tv06FQEiSSKMBXRQnWJ8yRV8Jp3Xa7M?= =?iso-8859-1?q?VbGXiAdRfyJRiwIwVgQHIYFCCuHzhAP4r9oPiRAsls4ejQjm4vEMFmG77e03?= =?iso-8859-1?q?1CWpfk6hi8qHfOLAyTtNdrOMxoPxjyT0C76dtjiDjayptk5UGh8psnWS9HGo?= =?iso-8859-1?q?CS0OhBExTcpZpB5ZZhZPirG8sEd0MJbEoyoNaPIFExy2PhW+cHM60RKVAAcd?= =?iso-8859-1?q?IyIh/YTkxDm0+sfSqnP8flK2qLMPNQgaTIa0HsC5x4mOnAg90bZfBpf2c58l?= =?iso-8859-1?q?vnXsACrmvjA4PCH1fUZzIKdWYxV1y+MuwG8KWOpr3R+AooHhy18atS4zdD6q?= =?iso-8859-1?q?SWShVxnp3qkUvuIT+Yb4lAAjCZBr4AGlKkwBuK7gHaFLuzr5TOkFg3eZulid?= =?iso-8859-1?q?Vr4pOTlU2dbrhGbshZDQriH6COReAiWU5dfaTB6c5c9NKBQvWYFMqi/JSqm7?= =?iso-8859-1?q?VUaI7Y1L53VqhPD0NTBT9GE202X5zpxpAgFPsTs8v9negZK/49Vvz3oX0Aja?= =?iso-8859-1?q?+9a6zyowPLZLo948oVxencLm/lZU5F8a8iKuRFXypELeIx7lY9/GfzUroUr1?= =?iso-8859-1?q?LZSVQW+SfcTe7JQeC1Z8j3uyhWFjAzg5ka7K5QriS8d/PmiQCIFvoiunj827?= =?iso-8859-1?q?p5b5H95llDAvH0g9uPGsnFsUq0e4J+t2XmHvBZB1PrMLpNk6nEo5vxGYBfAv?= =?iso-8859-1?q?bdBiZ/Rua1A=3D=3D?= X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB8838.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d268c4e6-1dab-4904-5712-08dbe7991b51 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 18:14:57.6837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j+Thrjkrcwdo6kPoRaD2QmprAAORT8dnj5Il+hLg1IGP5Ynot1smxPMHNjrq2RmVuWDk27gWVh3D9RgWB9J5f/EN1IYrJNc6lor/CG3jKLg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR01MB10797 X-Proofpoint-GUID: A780P-LXJL9G9i2fkStfCPsSvGVxCThi X-Proofpoint-ORIG-GUID: A780P-LXJL9G9i2fkStfCPsSvGVxCThi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-17_17,2023-11-17_01,2023-05-22_02 X-Proofpoint-Spam-Reason: orgsafe In the event that the I2C bus was powered down when the I2C controller driver loads, or some spurious pulses occur on the I2C bus, it's possible that the controller detects a spurious I2C "start" condition. In this situation it may continue to report the bus is busy indefinitely and block the controller from working. The "single-master" DT flag can be specified to disable bus busy checks entirely, but this may not be safe to use in situations where other I2C masters may potentially exist. In the event that the controller reports "bus busy" for too long when starting a transaction, we can try reinitializing the controller to see if the busy condition clears. This allows recovering from this scenario. Fixes: e1d5b6598cdc ("i2c: Add support for Xilinx XPS IIC Bus Interface") Signed-off-by: Robert Hancock --- drivers/i2c/busses/i2c-xiic.c | 42 ++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 6e84b4d67fd9..a396560a7ba9 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -843,23 +843,11 @@ static int xiic_bus_busy(struct xiic_i2c *i2c) return (sr & XIIC_SR_BUS_BUSY_MASK) ? -EBUSY : 0; } -static int xiic_busy(struct xiic_i2c *i2c) +static int xiic_wait_not_busy(struct xiic_i2c *i2c) { int tries = 3; int err; - if (i2c->tx_msg || i2c->rx_msg) - return -EBUSY; - - /* In single master mode bus can only be busy, when in use by this - * driver. If the register indicates bus being busy for some reason we - * should ignore it, since bus will never be released and i2c will be - * stuck forever. - */ - if (i2c->singlemaster) { - return 0; - } - /* for instance if previous transfer was terminated due to TX error * it might be that the bus is on it's way to become available * give it at most 3 ms to wake @@ -1103,9 +1091,33 @@ static int xiic_start_xfer(struct xiic_i2c *i2c, struct i2c_msg *msgs, int num) mutex_lock(&i2c->lock); - ret = xiic_busy(i2c); - if (ret) + if (i2c->tx_msg || i2c->rx_msg) { + ret = -EBUSY; goto out; + } + + /* In single master mode bus can only be busy, when in use by this + * driver. If the register indicates bus being busy for some reason we + * should ignore it, since bus will never be released and i2c will be + * stuck forever. + */ + if (!i2c->singlemaster) { + ret = xiic_wait_not_busy(i2c); + if (ret) { + /* If the bus is stuck in a busy state, such as due to spurious low + * pulses on the bus causing a false start condition to be detected, + * then try to recover by re-initializing the controller and check + * again if the bus is still busy. + */ + dev_warn(i2c->adap.dev.parent, "I2C bus busy timeout, reinitializing\n"); + ret = xiic_reinit(i2c); + if (ret) + goto out; + ret = xiic_wait_not_busy(i2c); + if (ret) + goto out; + } + } i2c->tx_msg = msgs; i2c->rx_msg = NULL;