From patchwork Thu Aug 15 07:58:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 171397 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1866393ily; Thu, 15 Aug 2019 00:58:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzx5TOJI9+c+vYtxZ1rc9DeiG/+juQDyO6c/Hihom/CL3Ie9GOzmBxofjs/I+cH2tPOPRmt X-Received: by 2002:a63:4c46:: with SMTP id m6mr2641133pgl.59.1565855923089; Thu, 15 Aug 2019 00:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565855923; cv=none; d=google.com; s=arc-20160816; b=yT+tKznMwK/NJU+xYDAhbuQRpItVyDqZI96DWaF8XhQ46s5ta5tddpVn8gffIxC7hx D9kV6ibK7PL9EBClcrHmDZFF42h/DURhhYKrjkdag2bp1am30DHEHU6ZJay4Q4aZmM7U +yS5RqfrilTIWoR4JnreT7B+ZNDCO3Xr87SgE+AO6biUpULYTxje+wANnWvuuYKD3aIE 0w+sjNWTtJPL+UUSmkQcTWgx7RDxjeX9XwN9n3Z0sBDnXxokWmxqomkwRONoBycE7AEX ui6ofWz0vOIh7DwokjNkPUmAVWQz/r7SFeiG8/vU+Lgdq69Pmj+IOtr9UbBbXeV4Ew44 Zmcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ZxYIVJXDl0DAiqdp8/QVOF+ggKcEMBtGLnHvtUKRSiU=; b=VeMwL6aO7tmMWwupWYTvONMm+f+BQOOodqvym/OBIyWtTAuMIujUuqPrMHGG2GPMa0 teA0ZaFixQYA5vfH3SRoPoU7apNU4ZGPuKxEUe4wjYAjx4AIKAeeKAmM55kV25a7wyIg 1gvUwDsab4hbvbJpi3nQF5LbSHM6Etk6k6v1RrEIo3C737jAcKZrCV4/U2AKK0FSjBxI UAhwYcsxz7W/lr6RUfbh5lSNgh96gdnByFaRyXcvko0H79u3/fuTkgNWfGZ0bAJkvutp LuNMqagAe0HiCerPvVHssnZTu9r/QjAZNFTNim5enJ1OKqCoIMzGHStTCgB+K8vcBM60 OwUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T0OEX7pf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a190si501380pfb.127.2019.08.15.00.58.42; Thu, 15 Aug 2019 00:58:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T0OEX7pf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730766AbfHOH6l (ORCPT + 28 others); Thu, 15 Aug 2019 03:58:41 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43816 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730614AbfHOH6l (ORCPT ); Thu, 15 Aug 2019 03:58:41 -0400 Received: by mail-lf1-f68.google.com with SMTP id c19so1072229lfm.10 for ; Thu, 15 Aug 2019 00:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZxYIVJXDl0DAiqdp8/QVOF+ggKcEMBtGLnHvtUKRSiU=; b=T0OEX7pfHxaxo4aOq3gWAKq/k0OH2V2V+0DlhgiT8Hrugb/ErCNRJlwXiF/Nr/oE/w 4QYtPLkq3vH5b/AhdCSlkirEHFA5XypmeH9DrVATrPxXf/2iJ1FEHF4KhayWLtKLqt1Z okxEUthyOLkUCCJxiDwPdOgsa+jYUm0rwvb15ZWFrcAIW5BY08SehpOBA8iGpKfiYhLj qw5PevsY02PaqtX/tnUtCusfkEE2SkxjevazeUKUYxO1kcXuRl3MrRKHfdbMzWdCfycZ Nr0oJerFm+zm4wRsJ9JU+889w1msI+zFq7lHEvsyyfHNfdsJJEHWYzqYdY+CFIzD6VUl dbjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZxYIVJXDl0DAiqdp8/QVOF+ggKcEMBtGLnHvtUKRSiU=; b=SCThBbvXZkPJR7QEM8Z9GGdeweB0yvm4p0NTC2iqtrE9plcGhHaQlTUY00mhERorYv aOgkqt1VUCXQ1MgO24tfIbtrfvYtN2lttSBO6InYkpAneeXNu4q3dhHxIWAmfd8tyXnR EAa+kT6WB01WEMK6tPFJymv4PPQtyvW2obLCCcXN+P40cu8VMYN+x15vek0w2TY837xK X0JEjA7ZHjioHfYQNhrecQ0h1G5fa+fyPOhRTEvPwwRSNv7S+9ADXYZB3LVOfwHqp5lB dDdlc6ZPzCSw6f3HFmkWwuk66AzHLXGRH2ofSZl0cpGh0hYut4ZOZxelwzf4ikyVpL+o 0ApA== X-Gm-Message-State: APjAAAUo7KMmDv1adPybBl0psliyFICzILuzStUdEABYdc+2JZlDlDWx Cjm0rXT/7GWLqHfUUF4n463X706M4DVPhQ== X-Received: by 2002:a19:9111:: with SMTP id t17mr1694958lfd.113.1565855918902; Thu, 15 Aug 2019 00:58:38 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id w8sm319257lfq.53.2019.08.15.00.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2019 00:58:38 -0700 (PDT) From: Anders Roxell To: davem@davemloft.net, shuah@kernel.org Cc: netdev@vger.kernel.org, tim.bird@sony.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH v2] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue Date: Thu, 15 Aug 2019 09:58:26 +0200 Message-Id: <20190815075826.13210-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When running tcp_fastopen_backup_key.sh the following issue was seen in a busybox environment. ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected Shellcheck showed the following issue. $ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh In tools/testing/selftests/net/tcp_fastopen_backup_key.sh line 33: if [ $val -ne 0 ]; then ^-- SC2086: Double quote to prevent globbing and word splitting. Rework to do a string comparison instead. Signed-off-by: Anders Roxell --- tools/testing/selftests/net/tcp_fastopen_backup_key.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/tools/testing/selftests/net/tcp_fastopen_backup_key.sh b/tools/testing/selftests/net/tcp_fastopen_backup_key.sh index 41476399e184..f6e65674b83c 100755 --- a/tools/testing/selftests/net/tcp_fastopen_backup_key.sh +++ b/tools/testing/selftests/net/tcp_fastopen_backup_key.sh @@ -30,7 +30,7 @@ do_test() { ip netns exec "${NETNS}" ./tcp_fastopen_backup_key "$1" val=$(ip netns exec "${NETNS}" nstat -az | \ grep TcpExtTCPFastOpenPassiveFail | awk '{print $2}') - if [ $val -ne 0 ]; then + if [ "$val" != 0 ]; then echo "FAIL: TcpExtTCPFastOpenPassiveFail non-zero" return 1 fi