From patchwork Mon Nov 6 22:43:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 741585 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39EDB38E for ; Mon, 6 Nov 2023 22:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y4BT/LEA" Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B499FD73 for ; Mon, 6 Nov 2023 14:44:14 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6b1e46ca282so5357559b3a.2 for ; Mon, 06 Nov 2023 14:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310654; x=1699915454; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VKiQCr7hjncufylg+/VbtbjZsCgjIQoLVjcb2bqVtKQ=; b=Y4BT/LEAzTvqSAeUYWjtMhSP4ZU6g4T475MUtYWDWD5l+uQwG/+7245coPYvRDNlKQ dTs1fgq0lddZ/OIbY5MNRAIDIe3+CxLzkdLpmkv3pK5qSZHnuyqsRsdis3T1nRipp6pp eEajpjvVW5FvdC/aThPCXgScok59YPkniQYFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310654; x=1699915454; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VKiQCr7hjncufylg+/VbtbjZsCgjIQoLVjcb2bqVtKQ=; b=FCKtfiiEM7MjW0hVvuJL4bQsLkcCsXXu2McUwkWGd7XaCrIHfRl7vTsH4KSDDR/mQ9 B+R5iUuNelVDoXZ/Oh3n3dVTHmT/NWDpko6mSrlYeRdZWL6LX2OyOLOIRrzQoqn5TFI6 N9rBRROWgfIA0m4T9wLXgtIM8mDFV/HbdOD3JiUiruXD9CCjwTS+M8NUH17OsqHCnW0o JPEdvuFANBS4Yw5EYX0OakVVJrOAP2ynXgTKuuHDbcVBF3q9m7zZqNPWIOba4SKSIEyd CRVUVCusiALtCHfm1CzozJzH0t63nNQHm/MzU36UJYJ8VNlJH/kDhhpAfjD0jLl3znwu i1+w== X-Gm-Message-State: AOJu0Yx9nUTTADDW5DhMktKFM45WGKBIryZBBohj7QlZH//oUGs8Lii1 t97UPhAzZfOuRWn2Rnwly16zcA== X-Google-Smtp-Source: AGHT+IFkpOfcuPLLDmzAviuXIlthZPNPWwOdFQj4TJlFi0vUiPy3DStnuU/aFfkhjXQBMFMASxqjNQ== X-Received: by 2002:a05:6a20:e123:b0:15e:e0fd:98e7 with SMTP id kr35-20020a056a20e12300b0015ee0fd98e7mr42299408pzb.20.1699310654167; Mon, 06 Nov 2023 14:44:14 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:13 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , "Guilherme G. Piccoli" , Kees Cook , Sai Prakash Ranjan , Tony Luck , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:28 -0800 Message-ID: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On sc7180 when the watchdog timer fires your logs get filled with: watchdog0: pretimeout event watchdog0: pretimeout event watchdog0: pretimeout event ... watchdog0: pretimeout event If you're using console-ramoops to debug crashes the above gets quite annoying since it blows away any other log messages that might have been there. The issue is that the "bark" interrupt (AKA the "pretimeout" interrupt) remains high until the watchdog is pet. Since we've got things configured as "level" triggered we'll keep getting interrupted over and over. Let's switch to edge triggered. Now we'll get one interrupt when the "bark" interrupt goes off and won't get another one until the "bark" interrupt is cleared and asserts again. This matches how many older Qualcomm SoCs have things configured. Fixes: 28cc13e4060c ("arm64: dts: qcom: sc7180: Add watchdog bark interrupt") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson Reviewed-by: Bartosz Golaszewski --- Changes in v2: - Fixed typo in commit message. arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 11f353d416b4..c0365832c315 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3576,7 +3576,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sc7180", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Mon Nov 6 22:43:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 742034 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A961CF92 for ; Mon, 6 Nov 2023 22:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="C1dZ9i1P" Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D51A9D57 for ; Mon, 6 Nov 2023 14:44:16 -0800 (PST) Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1eb39505ba4so3100218fac.0 for ; Mon, 06 Nov 2023 14:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310656; x=1699915456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LEa1YhaI6E/DSKEdiY/yJdz0Wh7Ldi/F7Q44NLO+PJQ=; b=C1dZ9i1P+3RfPTZUX+eTvGxc7Tpd+jjxUfclljveuPnvWnh8sG9Od3eypO7w4gHGL8 45Gw+n6Gdk+EXZ4Im1G/n6hHw7oE0GzlH/GzRDVSzwD/+ReQO6j/zLiVROfXtmSTJfC/ RYiaCABXHaYOn6JJI8stLZ9P1/y+sUbWpUL10= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310656; x=1699915456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LEa1YhaI6E/DSKEdiY/yJdz0Wh7Ldi/F7Q44NLO+PJQ=; b=B2DTjdRr3VVJ9ctOHS2/9dZ5IkOrYGSCpxis9ReHM8Uvl0SCQnVxb2U8+uA3pp7Je2 0iaGRHDSOz9IqBMGsY6AoTWUNAgdjXQB0kQs0fUfP62/t5eH5JkkrS+PVuCn7xRoslLG sYig/PwrBaYsP0hOUMIxT/pNrDsMQc+2iRfF1Ze9NUaYG4LAICCOIfiMe+0vS09a+xB4 hO7akCEQ5R8ME1RMbMq+gT0fQhzzn/X9H6K3W4YuL2DZLh7RcSfltYO4PaJV2SWb4x1D ZUso0by7qHSqD5Lzl2tLlN6nRJk4QsddbJuf1xjGqkWLQ8ophM+1RVDAYR/RS4vPWDOv 7myw== X-Gm-Message-State: AOJu0YxaEaNOyvB0qbIepBXGLwWQCpUT/bBSosY2/ImVC7slJhRQMP5g AA/qhfjv1AOG8n7QP/sZkwhvZJY03Bsh77jYusWZnlJK X-Google-Smtp-Source: AGHT+IFh7/H41PW/ppGqA6uqFtTneJWaryTFy923BZ7uQQOrznF8C+prk0YJps9r/dnHPHRhuKcniw== X-Received: by 2002:a05:6870:10d6:b0:1d0:d9e2:985f with SMTP id 22-20020a05687010d600b001d0d9e2985fmr973799oar.57.1699310656018; Mon, 06 Nov 2023 14:44:16 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:15 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , Rajendra Nayak , Sai Prakash Ranjan , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/9] arm64: dts: qcom: sc7280: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:29 -0800 Message-ID: <20231106144335.v2.2.I11f77956d2492c88aca0ef5462123f225caf4fb4@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 0e51f883daa9 ("arm64: dts: qcom: sc7280: Add APSS watchdog node") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 04bf85b0399a..1964ef66492f 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -5389,7 +5389,7 @@ watchdog: watchdog@17c10000 { compatible = "qcom,apss-wdt-sc7280", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; status = "reserved"; /* Owned by Gunyah hyp */ }; From patchwork Mon Nov 6 22:43:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 741584 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60ED51DDD7 for ; Mon, 6 Nov 2023 22:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="j2ZhQFJu" Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF12D76 for ; Mon, 6 Nov 2023 14:44:18 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6b709048f32so4688634b3a.0 for ; Mon, 06 Nov 2023 14:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310658; x=1699915458; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HeV56VEkVxBLKgE3tH5Ot8a67/WG+4GGqoNJQCZhnGc=; b=j2ZhQFJuRuGyG30PPkN2LDH00bCrzelyQL1tCMYjP7m7phs5m5XrBLL8k8USMuTcFh CS4rQTKEMZlze9RibEfJWmC/fDqURHFAxLIr0w5ys8SVPsunkZ7KyoLvgRSC1bobD9fd JJGCGd4Xm6ISGdBFVS33sz0zmyYukmHGr6Lbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310658; x=1699915458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HeV56VEkVxBLKgE3tH5Ot8a67/WG+4GGqoNJQCZhnGc=; b=aKMVg3yqQuIjHBzJ0iHhKF2xpjPCjgBjf4f0wqAgps+CQ+mvY/GrjuEsDeuxyZ+ydq s/6MscPpoyszv5YsZa8RRsD+dBl6EcGbx7irKke1gO92tmfvLZVJFjKQOh0Vreg25Wcw 69edEynRHijXRtCPhjkczl5HBc8HZTE3wRaY0UHQ5rPS9WLLZIBajhvmm+y79AAX3XAz YIwSyhZQUqsBqCgRwD1AetRHcK/c62FTXLEWoYmyf1cmdj6Xy43zh9tvFh/M/VezPYRG IDFbX0KQkFCfn10kSn8YEd1i6l0PfUeuNEXxdNC5tF9OXAZCPgJLXxe3amxyub27gWX6 KMNg== X-Gm-Message-State: AOJu0Yy6y6XLijwcGX/giIAGRb6zVSuzSPYa7gKqUrL+0IvkZTxtxWFF DaTmD9p6iEZBN272z8hvhQIHNg== X-Google-Smtp-Source: AGHT+IEIXQgziQ3zL7lElwnEoydeiE6VJUQiW2+JzEfF+aRZV0sKWTC30e0/G5mAwH/Lhd2P5d9yJQ== X-Received: by 2002:a05:6a00:190b:b0:6c3:69b9:44db with SMTP id y11-20020a056a00190b00b006c369b944dbmr10357674pfi.22.1699310657851; Mon, 06 Nov 2023 14:44:17 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:17 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/9] arm64: dts: qcom: sdm845: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:30 -0800 Message-ID: <20231106144335.v2.3.I16675ebe5517c68453a1bd7f4334ff885f806c03@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 36c436b03c58 ("arm64: dts: qcom: sdm845: Add watchdog bark interrupt") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index bf5e6eb9d313..9648505644ff 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -5088,7 +5088,7 @@ watchdog@17980000 { compatible = "qcom,apss-wdt-sdm845", "qcom,kpss-wdt"; reg = <0 0x17980000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; apss_shared: mailbox@17990000 { From patchwork Mon Nov 6 22:43:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 742033 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE98C38E for ; Mon, 6 Nov 2023 22:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Z9HuSfM4" Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C44D7B for ; Mon, 6 Nov 2023 14:44:20 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3b2b1af09c5so2373688b6e.0 for ; Mon, 06 Nov 2023 14:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310660; x=1699915460; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MQfwiBgyb0NDLVCz1up5WP4xaDEfvCkGE4sF98eZ7HU=; b=Z9HuSfM4FPnV9mJ/CsS4B3+t92xyYhdaQo8Z8cmhKiY+JnnGVC8HwpIgqcuIdkDt1X Wae4JtthLkDNRFFcXWo8l1dX8lzoyl4FF6phaFTtyElxSB5ZcgVqox4eMGEUA4u3RlaG i0/52SlJlA0kWimJq0bLGOkH+CjjLjnR2S39c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310660; x=1699915460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MQfwiBgyb0NDLVCz1up5WP4xaDEfvCkGE4sF98eZ7HU=; b=rsahC7clbsGkpQKERecat3mQJAr7g0AyHD3g0mEYq6vvNOMwWULRd8b20uYG3JIUod si6yBj6SVrVo3DGuDfzy7pSov6XBCBlJEp4+WaihVuJrWrbkExaMmqhZCnUTb3j+SB74 e0oKSvQAdrGafOGz3V0TukNw6Ft3Y0873uWQWTYHkJiqkkNry79EuAgTBYgcQG1Qk19S MSSU/xEN7edZD2s1kZT1rg3Tq/pqwSH1XKu9tLp3oV7kcANbaM1NvEYCDgFK7BUYBRH6 LjselOJX34miDrl++nEgFMxaowkv01wr1CKGLVPYQFi+hR12RZ5L7dHQDdoUUcCLs6wE dIhA== X-Gm-Message-State: AOJu0Yynubj70TLQZVyIklAi2O5eJd5LT6hRdJ9f8Kj32Xg5AEyFwVhj VVf6RjnscRru/E76Cnel6U3zxw== X-Google-Smtp-Source: AGHT+IFdMSyh5AqVjDStLHve/AJFaFnM1P4vCt/67yxeGNDa/ie7acpEAVZqAzrV0qH2B1+wMAJiHw== X-Received: by 2002:aca:1b0d:0:b0:3a7:52b9:cbfe with SMTP id b13-20020aca1b0d000000b003a752b9cbfemr25606422oib.32.1699310660283; Mon, 06 Nov 2023 14:44:20 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:19 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/9] arm64: dts: qcom: sm8150: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:31 -0800 Message-ID: <20231106144335.v2.4.I23d0aa6c8f1fec5c26ad9b3c610df6f4c5392850@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: b094c8f8dd2a ("arm64: dts: qcom: sm8150: Add watchdog bark interrupt") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 97623af13464..ad4fab61222b 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -4170,7 +4170,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Mon Nov 6 22:43:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 741583 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D45A61D528 for ; Mon, 6 Nov 2023 22:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TDEXNwSD" Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FE1BD7C for ; Mon, 6 Nov 2023 14:44:22 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6c33ab26dddso3569357b3a.0 for ; Mon, 06 Nov 2023 14:44:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310662; x=1699915462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nWMk5KKMdtBkcN085aCokVTLRPwC2LwFd3Blu74oh64=; b=TDEXNwSDDuuZLSeR2MUk+GjtIaoqGaOFNCCqEfS7y0ql3Od45oPwhwxxCEyeP/gbAY MhW/ZaKbujnIZrrOLohyqUqsqZp+ODZnksDpyK/d9OIxl78qEF7qH6xARFPSg2nIITbF IBZnEM77rwwcPzll9MeHZyKD3/bpYNrQFWA4s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310662; x=1699915462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nWMk5KKMdtBkcN085aCokVTLRPwC2LwFd3Blu74oh64=; b=T3mRuWVb1C7AtTCT+RE8EceQ1hkzxI2Ja/HRWtEm5p6uJ1+biW0u/p9cPNE2Ekojk/ YV/cl2QDpTT1rsYJcLGOqSP9ppQDQV/bSMqLKV1U2Zir5vUBywNMU+ggghDtZf+1ETps 3V8JRVn9n9/RgV0cALrKWYDUEB73GOdUn8QFtV4yHN1cl8nFBYHmZyKfN+1rWBLvE8gg z53crtZeXooLauXDTZpPirTc/Ou0Toa6dfM1ovHrz3tfW6f5Jk5VIYs1Jfb4+X09iU3o Z37P8N5lbYQ+4aOjSYRNN+kZVsmoHSCbl0p3IfK2EDD8nEZWzOyBY6N6rj1Y/W1MFu5H WBJg== X-Gm-Message-State: AOJu0YxrAqada4p0x1yLWvBcg1TMOjFhedJhLr7IZ3oCFpU4EMshe2sZ XOojAej2eDQlNDTe2AtxVJ95KA== X-Google-Smtp-Source: AGHT+IE/XRAlVANXomG5FTcOxakhrp6AR2ELR0IIoHu0XMoLIYgpwNN7jHp7jr+xX4zf/HXT5nB2BQ== X-Received: by 2002:a05:6a00:134b:b0:690:bdda:7c35 with SMTP id k11-20020a056a00134b00b00690bdda7c35mr29364786pfu.1.1699310662052; Mon, 06 Nov 2023 14:44:22 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:21 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/9] arm64: dts: qcom: sm8250: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:32 -0800 Message-ID: <20231106144335.v2.5.I2910e7c10493d896841e9785c1817df9b9a58701@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 46a4359f9156 ("arm64: dts: qcom: sm8250: Add watchdog bark interrupt") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index be970472f6c4..72db75ca7731 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -6018,7 +6018,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sm8250", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Mon Nov 6 22:43:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 742032 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC301D528 for ; Mon, 6 Nov 2023 22:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UB5FYUDm" Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1DC110D2 for ; Mon, 6 Nov 2023 14:44:24 -0800 (PST) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5ab94fc098cso2897174a12.1 for ; Mon, 06 Nov 2023 14:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310664; x=1699915464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IoQQSdSDYBKEseBDgznR6qWCbGS/9uqfHl1O8JZlopA=; b=UB5FYUDmVoHNn5AX6qWx6Z7TGqqPuziq3IAuL5pIsIl/KaWGRmuqA1W6wVOt44XFbG gPOypVsSS91+T/fY9BOunlb1l1s250oY8ks1sXQ796XM2L+6bWqYAnpBxE4uVi3jCxv+ jWaGeInivD210DibD0hPo+suU6BJa2Fz4/jt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310664; x=1699915464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IoQQSdSDYBKEseBDgznR6qWCbGS/9uqfHl1O8JZlopA=; b=WI+VTpk9HZ06ZkaREsc546/8/mEF76btbMhaHAIXwL/bcx310/1AQ+qT3TS5ULHJir qDsVYt6tAe/R/aMm3TUQmAAH2RIRPXd+6kH/IdExMcJ6N0L45wxcGptDb2D8GMYUxz/w OgPFNYhjhkdWgzBsYaK6A9AxSFdUMx/ArqePKg1LBfRvA9VGPP09Y1Xlwn6TikAhjn59 6qsEupD0ubmbHahxR33mq4f9Ga0NhSaMxtJ3XqGGS/cs1luHSHlZglwUaXesSN08/F3B Hv2CwNhtykorkXMRw/W2bSYt9hAvInnupkQIHtbEpnclsJSqehGP24aeq2QfzM7cFE/F 0a7w== X-Gm-Message-State: AOJu0Yxnz5EMo2PIVFbEgQoUeEpVWkfQmwAPfLJqbpG17DLFZbjysg91 TnVfdCFKZCc7wOGjRKGBlbH6Rw== X-Google-Smtp-Source: AGHT+IFP1JyPcxPHC4k7NBuLtx69VLdWd6t2zKXiNXtGgUUDRL9+93hlXMrEA2gTPJQMP9kBuHCYMg== X-Received: by 2002:a05:6a20:430d:b0:171:a2df:4e68 with SMTP id h13-20020a056a20430d00b00171a2df4e68mr29744632pzk.36.1699310664461; Mon, 06 Nov 2023 14:44:24 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:23 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , Bartosz Golaszewski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/9] arm64: dts: qcom: sa8775p: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:33 -0800 Message-ID: <20231106144335.v2.6.I909b7c4453d7b7fb0db4b6e49aa21666279d827d@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 09b701b89a76 ("arm64: dts: qcom: sa8775p: add the watchdog node") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 13dd44dd9ed1..6b92f9083104 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -2235,7 +2235,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sa8775p", "qcom,kpss-wdt"; reg = <0x0 0x17c10000 0x0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; memtimer: timer@17c20000 { From patchwork Mon Nov 6 22:43:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 741582 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06EA51D528 for ; Mon, 6 Nov 2023 22:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CSqLR8Be" Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD6A810E2 for ; Mon, 6 Nov 2023 14:44:26 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-565334377d0so3801469a12.2 for ; Mon, 06 Nov 2023 14:44:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310666; x=1699915466; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CL6rNqUZZ/R7S5vMBh8Bonhs6IZKDfrdmFtaTOQlgvk=; b=CSqLR8BeVRWdemljm7igAtREKR8rhIPSka/BQLGCezQwEbyf8B+CGWDHBDXRt9URe8 cko2aRE7+WBXaVx4ehKNIYTMUcKbRQ9NIb1UMT7dsLkkTqcdISaVFaVbvnWCJZ7CQBck Hg5vp8Ru9+p7G05kB84i2BJDsPjTDeD1XUNaI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310666; x=1699915466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CL6rNqUZZ/R7S5vMBh8Bonhs6IZKDfrdmFtaTOQlgvk=; b=Cap1nbCnwCqFbXtnKhbu5d08JNnPRXGbjs5y4L7tkfb+Bt2gKCv7E1gnh5Bdc2D039 O7K/u4NYtIXHetn91IwC0ZhuJMSRJDCFv/Tc9PF6gMPInv7AlDu6+rvaLWZJPXlEvK53 QVLYOwl7SjE9ZpT4ctuUD39Z7jyzj+JjG9zxaWvO+s7py/dlXrqxU3gUcl7sRTqsJ1kA HrQcJAjArGdqPpnUSWeJx+IYt7bjcH4MQlcbufVZ1jl03OzoKjkLlfPl3olSRqxhKD13 saTmmMcpvOhVZ/GFElpxq8uoRgdAdbmwGtHXSyqew1yqQo7LxSmre3j/uwf8D/QBbCA/ YD4w== X-Gm-Message-State: AOJu0Ywb94I2RTC/GUmffq7F/6ti8HAzvUZyxeL6TzFNByBPANWA0DVO 4MEJlbiplO973H3VjE2wFtt9FQ== X-Google-Smtp-Source: AGHT+IGeaYGnK2mOvcF4px0EdMUPyG/1hdE+Ly1oivTOAyc2DaqvSBOFigg78Ncdu9XjKlpJUhYFqg== X-Received: by 2002:a05:6a20:4412:b0:154:3f13:1bb7 with SMTP id ce18-20020a056a20441200b001543f131bb7mr41711778pzb.49.1699310666346; Mon, 06 Nov 2023 14:44:26 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:25 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , Johan Hovold , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/9] arm64: dts: qcom: sc8280xp: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:34 -0800 Message-ID: <20231106144335.v2.7.I1c8ab71570f6906fd020decb80675f05fbe1fe74@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index cad59af7ccef..b8081513176a 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -4225,7 +4225,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sc8280xp", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Mon Nov 6 22:43:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 742031 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C2D1D528 for ; Mon, 6 Nov 2023 22:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OiK77QSL" Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 245A210F3 for ; Mon, 6 Nov 2023 14:44:29 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6b77ab73c6fso3972040b3a.1 for ; Mon, 06 Nov 2023 14:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310668; x=1699915468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JSFzZ8MKWLiAfWY/igP5BmMC+MvDzsV/nsEt0CPNxwc=; b=OiK77QSLdvOzKTwuVexKwfy8shaOf5X0LCpsPwzWfTv9RTrUZ4+/SQTNhHPo5a+ToI JkyyTnwZSM06xvOFLnumXFJANKBrsPWLHWrt5vCWj7uVSNiYJT7Yq7E3tnWfhCG1ed77 thLTFuxnHqR12NdfagsN6fEAtWCTLMA9J35QU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310668; x=1699915468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JSFzZ8MKWLiAfWY/igP5BmMC+MvDzsV/nsEt0CPNxwc=; b=jdKqJ7uDoZ5uU4XCS+WoloiBC6W/1eSDAj5gW6EcppSxHg3yAdizv4D7gOR97erG3q njjSRi/2XQz4Dkxgv6UdqxV5Y95yWjgRNadaf9G8XiV1BXzhFYc0NWbcK0WcfuEe29fD smwHJGXCe4O1z3Bp7jtW+SzLhkXc+edILZLntd+3wgrL1yh7tRIbFavJ+y/lPYryIAcp Y9YuN19rhVaWCuFObqFhjwqYfBN5xjxa3ko9bKJSggJthnO7I2BxvSLayO9Btf7Xi0ta /6wWA9uXTxigiWDJI2s7n//qb6wrySbR+S7iD5ar7dycdPusRVwcP48Tm+qjh28ge2cc j5Bg== X-Gm-Message-State: AOJu0Yzvjfb/iXAe//IDqR4zMB1AYCwNprTooayF3G1c+NvzlNO5RDPn z3F6kxuhEEeT8F+3TAtGUcrImQ== X-Google-Smtp-Source: AGHT+IG6gzEJ52rY+ItvXab//ZSnUcmhXxypnlC7l6Ma3b1yinNqemp4TAQZMqkiymLSkLqhVuFGnQ== X-Received: by 2002:a05:6a00:2e9e:b0:68f:b5a3:5ec6 with SMTP id fd30-20020a056a002e9e00b0068fb5a35ec6mr1433778pfb.0.1699310668041; Mon, 06 Nov 2023 14:44:28 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:27 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 8/9] arm64: dts: qcom: sm6350: Make watchdog bark interrupt edge triggered Date: Mon, 6 Nov 2023 14:43:35 -0800 Message-ID: <20231106144335.v2.8.Ic1d4402e99c70354d501ccd98105e908a902f671@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 5f82b9cda61e ("arm64: dts: qcom: Add SM6350 device tree") Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 8fd6f4d03490..6464e144c228 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -2524,7 +2524,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sm6350", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Mon Nov 6 22:43:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 741581 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 834821D528 for ; Mon, 6 Nov 2023 22:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="I+3E4D4u" Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FF0710C6 for ; Mon, 6 Nov 2023 14:44:31 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6c32a20d5dbso3971471b3a.1 for ; Mon, 06 Nov 2023 14:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310670; x=1699915470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DtIla5EbbYn7ksxcCnIGYzIT7sP4waGo4Xe+LkSJul0=; b=I+3E4D4uAw4sDrCR+Hzng0lg2b9iQelHjIZlh4r1bIG5QfDfsN8/uy9EZd2WsELD6b ZccTJJWRYG02daFWpEFNspzjY6dCN3PGEledRTmfcRdn2nDXYh4GIZpIGdFsxXaztoC+ azTehmJUtMD3Xt79IUghcdxBqt056Evv31Pv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310670; x=1699915470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DtIla5EbbYn7ksxcCnIGYzIT7sP4waGo4Xe+LkSJul0=; b=Mm7jaM6NWARhcPdzoB03FomLmNRYPYsjEleYsnDR8UsGI6Xa7WjspbzVFnjczDjys4 sY7oMf6YBqTmwWz9fTexQdohNQ3Zd2gu/35fF/X5k8g/8EjogQf8Z0acDtPLlrYhAkrR iKBclGDgXN82fL13tMsxWsvkXCJgcgNw12B0JNSC0mbdFb4fhpKoKYSfWoKo0/KAjAun r81UPrs8UJnm4JloCKI5zKRlizgc6tLo7Acvb+gwJvVNMinrwDH93vL8HF7s4QWL8BhK AbZGEMOUyD/ekCFC6NlyUmZwUurq2CGwFUvpJjwUIo6It304OEdHFKpx8eWsIo2F7PYw aRgQ== X-Gm-Message-State: AOJu0Yy2TvKdZD+0AxF/MlJ0Bcq7a8L7XmYVoBFS7nQD9loBm51na/MW Ne6g9IFMv6sjAlmAsqMy7UOakQ== X-Google-Smtp-Source: AGHT+IHhY66QtjpSz12CT+cwtmbPE2TaCgraRxWmFmABFrRaJm+7w2MEktS6cSaLQrf8qgGLBV3IPQ== X-Received: by 2002:a05:6a00:2e29:b0:6bd:71e3:b647 with SMTP id fc41-20020a056a002e2900b006bd71e3b647mr28475394pfb.19.1699310669886; Mon, 06 Nov 2023 14:44:29 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:29 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Douglas Anderson , Krzysztof Kozlowski , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example edge triggered Date: Mon, 6 Nov 2023 14:43:36 -0800 Message-ID: <20231106144335.v2.9.Ie30c1d3f780666f6906fd2fd7c437632c229d987@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Update the example in the bindings. Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") Reviewed-by: Guenter Roeck Acked-by: Krzysztof Kozlowski Reviewed-by: Stephen Boyd Signed-off-by: Douglas Anderson --- (no changes since v1) Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 5046dfa55f13..681d1efbaf2f 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -121,7 +121,7 @@ examples: compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0x17c10000 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; timeout-sec = <10>; };