From patchwork Tue Oct 31 13:53:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 741521 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66AD1DA43; Tue, 31 Oct 2023 13:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Gk1bUJqk" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49C9AE6; Tue, 31 Oct 2023 06:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698760399; x=1730296399; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=X/i4S/9orkQqiJyi2sqfUdDq01hHe9T+DtVbyK1ctSI=; b=Gk1bUJqki80UueoH9LZpzb24SbFMOh+AHxGBLPoxeggYM+oDa6Nxq2tB b/erkXQu+NnSDtSMlnjLxhjJtdNhu8bNIe/NNTz/2n0Rm9HRQXjR5V7CB IUfH50VLY50P36loDleY8rBe9wX/2Fn+G6hoatVsg2W5Qw43S192K1xS2 IVWO6NDe+Jphw02xSiqO1+Cx6Jp7hdtbUKiJLygyJPklNKURIiQxwHXD5 mliT4rgWjx4/iUMNvRipeX5GQZ6+pLgCvMgto086TP6puSIWHrwiy4fXd N5k6z9DiPiSeT4XVgVsNz9r2S/6A1ZAXiwVPjagjI2KxZ4wJJkJAqhKOR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="391159543" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="391159543" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 06:53:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="754144904" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="754144904" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 06:53:12 -0700 Received: from svinhufvud.ger.corp.intel.com (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 2D9CF12033A; Tue, 31 Oct 2023 15:53:06 +0200 (EET) From: Sakari Ailus To: Laurent Pinchart , linux-acpi@vger.kernel.org Cc: Andy Shevchenko , linux-media@vger.kernel.org, Paul Elder , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Julien Stephan , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 1/1] device property: Add fwnode_name_eq() Date: Tue, 31 Oct 2023 15:53:06 +0200 Message-Id: <20231031135306.1106640-1-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add fwnode_name_eq() to implement the functionality of of_node_name_eq() on fwnode property API. The same convention of ending the comparison at '@' (besides '\0') is applied on also both ACPI and swnode. The function is intended for comparing unit address-less node names on DT and firmware or swnodes compliant with DT bindings. Signed-off-by: Sakari Ailus --- Hi Laurent, Would you be able to use this to replace of_node_name_eq()? It's fully untested. I didn't add an op for it as it rather looks like all the implentations would be the same (but with different container struct). drivers/base/property.c | 28 ++++++++++++++++++++++++++++ include/linux/property.h | 1 + 2 files changed, 29 insertions(+) diff --git a/drivers/base/property.c b/drivers/base/property.c index 8c40abed7852..766ac3fc8cc5 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -594,6 +594,34 @@ const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode) return fwnode_call_ptr_op(fwnode, get_name_prefix); } +/** + * fwnode_name_eq - Return true if node name is equal + * @fwnode The firmware node + * @name: The name to which to compare the node name + * + * Compare the name provided as an argument to the name of the node, stopping + * the comparison to either '\0' or '@' character, whichever comes first. This + * function is generally used for comparing node names while ignoring the + * possible unit address of the node. + * + * Return: true if the node name matches with the name provided in the @name + * argument, false otherwise. + */ +bool fwnode_name_eq(const struct fwnode_handle *fwnode, const char *name) +{ + const char *node_name; + unsigned int len; + + node_name = fwnode_get_name(fwnode); + if (!node_name) + return false; + + len = strchrnul(node_name, '@') - node_name; + + return strlen(name) == len && !strncmp(node_name, name, len); +} +EXPORT_SYMBOL_GPL(fwnode_name_eq); + /** * fwnode_get_parent - Return parent firwmare node * @fwnode: Firmware whose parent is retrieved diff --git a/include/linux/property.h b/include/linux/property.h index 083a1f41364b..096ade186601 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -108,6 +108,7 @@ struct fwnode_handle *fwnode_find_reference(const struct fwnode_handle *fwnode, const char *fwnode_get_name(const struct fwnode_handle *fwnode); const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode); +bool fwnode_name_eq(const struct fwnode_handle *fwnode, const char *name); struct fwnode_handle *fwnode_get_parent(const struct fwnode_handle *fwnode); struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode);