From patchwork Fri Oct 27 14:42:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Travkin X-Patchwork-Id: 738785 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4986518049 for ; Fri, 27 Oct 2023 14:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trvn.ru header.i=@trvn.ru header.b="0TKezU14" Received: from box.trvn.ru (box.trvn.ru [194.87.146.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE5A9C4; Fri, 27 Oct 2023 07:43:35 -0700 (PDT) Received: from authenticated-user (box.trvn.ru [194.87.146.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.trvn.ru (Postfix) with ESMTPSA id 8279B40553; Fri, 27 Oct 2023 19:42:48 +0500 (+05) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=trvn.ru; s=mail; t=1698417769; bh=/wvspNZ6UnwHBJSoNffLyGijS/yc+9Bx1gjik/P77pE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=0TKezU14dvQYvmZVCGhrOkT0XMcQVoePyWFa1I3rRm6mX4nIMDQkDiluXU7Jy+xjo 5b/L/FgM0buo9gOBYyYQcJ9diV0i55P2iwvM2ByaMHUZj5uudoONCyJUSKUbC7KuCN PAyHpkQ+WUrDvkVYgCreFW4JCU8XFe0KCrycBlJZaw4toIVjZi7IFsoKCwfaao5DIr sbvcDPg1Tm/+LDEEMTmIsv7Yf0yOWj9uygWUSsmWPQd+IpxHQuZFL+sf1IE6dsEfoq RS/KkKO1QhFH1HHNm4hnCPfOV31Nh7GIWcKuP62bg+OpO+HGwb60otqk7xY2YcmUOh HWS2tuk+XdVIA== From: Nikita Travkin Date: Fri, 27 Oct 2023 19:42:21 +0500 Subject: [PATCH 1/3] arm64: dts: qcom: acer-aspire1: Enable RTC Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231027-aspire1-sound-v1-1-5ff3cf8b5701@trvn.ru> References: <20231027-aspire1-sound-v1-0-5ff3cf8b5701@trvn.ru> In-Reply-To: <20231027-aspire1-sound-v1-0-5ff3cf8b5701@trvn.ru> To: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nikita Travkin X-Developer-Signature: v=1; a=openpgp-sha256; l=693; i=nikita@trvn.ru; h=from:subject:message-id; bh=/wvspNZ6UnwHBJSoNffLyGijS/yc+9Bx1gjik/P77pE=; b=owEBbQKS/ZANAwAIAUMc7O4oGb91AcsmYgBlO8xbT/dr4P0OR1A/Mcg7Izk15NCEbz2Ss101B ClTp7VwQNaJAjMEAAEIAB0WIQTAhK9UUj+qg34uxUdDHOzuKBm/dQUCZTvMWwAKCRBDHOzuKBm/ de0FD/sGSQp699iOGnsKkb4UdbmDIxMt8Iwx4iwbvxX3zqcano/O6E8lu9tmB+ZXUMRR874ni3Q ZaysymuK1cCXW02SL2Kq14OzUj/o+hw9kYpHstfGS5dZjxErMPMcHwhn3xl+63C9yEdi61cElBY 9hZ69fmLwbGzUYxcu/2Ed3janX1ee42nYa49iTA2TklbczxFY/RFCrEOzBBL5yckqFcYD/z4Ry/ l0/lRlcmiypWpNX+rVDO3l0VwbmuOvXGm6cmk8qzWOtDH86/lIPtFb17IAo1pgdgPmdLxCbMAyN Zomz6AbKBmVDtFiLbBnqNAVRp72VF1jbjQaNX/J7fE1bjg2qq60Intb9LshPCXYklW0wm/illaa cCXREzzvHgTO+7oZ9tzgPT4K+FRqnGFxeMlfhb9CfWpIW2t+R0+AZXo4amdPJrpowe0RPddm0W2 ScZbpYQGxYMiUR3/t81JH2fV9ynRL8VtqqiGvbGafMyN3lOauIy5ws4d3BLheCjZcGnuP8czll1 nSQENoP1olh46Hiut5DZbji7iGN+l/gF7W3G23u2LI6sqXuyqleO2qdtDpTNsxz1o2mofXsSUZ+ x26pEBIus5bkFChiV8q4YpDUwUSX/vAdFs6dJmwTJs3R7NP/Zp0LT4I4BPOMQcAPskO06JNGalH Y5jXKc9ZqA3o72Q== X-Developer-Key: i=nikita@trvn.ru; a=openpgp; fpr=C084AF54523FAA837E2EC547431CECEE2819BF75 pm6150 has a read-only RTC that can be used to keep the time with some extra userspace tools. Enable it. Signed-off-by: Nikita Travkin Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts index dbb48934d499..cfde8cd47107 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts @@ -351,6 +351,10 @@ &pm6150_pon { status = "disabled"; }; +&pm6150_rtc { + status = "okay"; +}; + &qupv3_id_0 { status = "okay"; }; From patchwork Fri Oct 27 14:42:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Travkin X-Patchwork-Id: 738784 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 498C7182CE for ; Fri, 27 Oct 2023 14:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trvn.ru header.i=@trvn.ru header.b="l9Byw6iu" Received: from box.trvn.ru (box.trvn.ru [194.87.146.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEE62DE; Fri, 27 Oct 2023 07:43:35 -0700 (PDT) Received: from authenticated-user (box.trvn.ru [194.87.146.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.trvn.ru (Postfix) with ESMTPSA id 8156640554; Fri, 27 Oct 2023 19:42:49 +0500 (+05) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=trvn.ru; s=mail; t=1698417769; bh=eqmIkkJoEX4wLBmCVriM0QlbehXiI4/GaHNwKQsh75Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=l9Byw6iupejRMmwhEuuQ+u91/S+6UohNmC0/Mmt5FjV/RqZaioBBWCMJYR0sGLjVe lV8NgyAtXfXTknoJPUOOoP7fAukroF/8gwBmuB+CPk3NTmbE5Il/bVVWRZ6lmvdCgJ pl9jYSW9SdRbKCU47GbGqHGcAKJw0MQL7bR9AVBHwpqZ4CpevBua+13lXUzEPGADjN YPua+mecjMhTNhx+fgVrX350lU0+4Om/zfNBc6kB7v6cDcYu8jCVw1bKwfalQnz9Ih uGyHKlye0LSv8HRpj5BJKaFIdA62DgTCNyLUawSI54UQbTrK10zrhV5029mV72EUGb GuE2lvhKGXchA== From: Nikita Travkin Date: Fri, 27 Oct 2023 19:42:22 +0500 Subject: [PATCH 2/3] arm64: dts: qcom: acer-aspire1: Correct audio codec definition Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231027-aspire1-sound-v1-2-5ff3cf8b5701@trvn.ru> References: <20231027-aspire1-sound-v1-0-5ff3cf8b5701@trvn.ru> In-Reply-To: <20231027-aspire1-sound-v1-0-5ff3cf8b5701@trvn.ru> To: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nikita Travkin X-Developer-Signature: v=1; a=openpgp-sha256; l=1892; i=nikita@trvn.ru; h=from:subject:message-id; bh=eqmIkkJoEX4wLBmCVriM0QlbehXiI4/GaHNwKQsh75Q=; b=owEBbQKS/ZANAwAIAUMc7O4oGb91AcsmYgBlO8xbnO705dHZXG80e25iSYMqO/brPSmEW7Yce CG/57QRmiSJAjMEAAEIAB0WIQTAhK9UUj+qg34uxUdDHOzuKBm/dQUCZTvMWwAKCRBDHOzuKBm/ dWGiEACoEd3tGoQuYmuisQ+9VXeRW4qCM3ITZGPmnxCX51TBFacSFh40cjqsMtFDSE3Unbcr4Tt /p88GxcD0xm2NBNNKgd5Xc7NHf+uQ+fjmkXXE/ZF2lKmknwG/Ifk3BxnoomAA6p7SaltffqYzxI cBz1DTGiqPmTWtqsFrUFoPZ5B1gU0IhLKpc0ukfm/iFPruyGIkMGsIoKaLrsC09+S7FzhdW8tcQ 7FsklhElnboV7fvH29NW2D1oQU/SzIB4N+EbFJE7Zn+Bu8OU+Hl+2tPKh3hsjZ4K8sKKK7GOSAO 4ghnMcCM14nQap02k2HP5JDG6TonB1RadIPVbop3+lDb5DWbk06bW4uUuUPQt5mC7Ng/gxasm7g ZYg5ScczRUXhSeXTo3x4D85j4ffL7LPbk9ZLebrvwo2/NhEfaGWhdTM747SqylZklRYC4aRiyJ0 9m+4oKbt0Y+RxcLV5MRn11ajDZ2c+FwOD4FRSx3kK4pe52gdXLTQd0gHtY5Q/JQCnRNYiEoA6q8 1qJNAjxhGbKXkTK0jqcvSNnEx8+oDZHu0JjGH+MUu53wAol3WI8Vbt4k2IfNdg7oux7+p/wLhrD ghB4GsjirzMxbRfz3so2SGvchK4ZN4AGMoTX/hbCIGSICbGfkJKyglo/HVIxc0q3xj7liKpII+/ Bk1BRxCXRIJXMjw== X-Developer-Key: i=nikita@trvn.ru; a=openpgp; fpr=C084AF54523FAA837E2EC547431CECEE2819BF75 When initially added, a mistake was made in the definition of the codec. Despite the fact that the DMIC line is connected on the side of the codec chip, and relevant passive components, including 0-ohm resistors connecting the dmics, are present, the dmic line is still cut in another place on the board, which was overlooked. Correct this by replacing the dmic configuration with a comment describing this hardware detail. While at it, also add missing regulators definitions. This is not a functional change as all the relevant regulators were already added via the other rail supplies. Fixes: 4a9f8f8f2ada ("arm64: dts: qcom: Add Acer Aspire 1") Signed-off-by: Nikita Travkin --- arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts index cfde8cd47107..00b442696618 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts @@ -209,9 +209,22 @@ alc5682: codec@1a { AVDD-supply = <&vreg_l15a_1p8>; MICVDD-supply = <®_codec_3p3>; VBAT-supply = <®_codec_3p3>; + DBVDD-supply = <&vreg_l15a_1p8>; + LDO1-IN-supply = <&vreg_l15a_1p8>; + + /* + * NOTE: The board has a path from this codec to the + * DMIC microphones in the lid, however some of the option + * resistors are absent and the microphones are connected + * to the SoC instead. + * + * If the resistors were to be changed by the user to + * connect the codec, the following could be used: + * + * realtek,dmic1-data-pin = <1>; + * realtek,dmic1-clk-pin = <1>; + */ - realtek,dmic1-data-pin = <1>; - realtek,dmic1-clk-pin = <1>; realtek,jd-src = <1>; }; };