From patchwork Fri Oct 20 18:42:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 736287 Delivered-To: patch@linaro.org Received: by 2002:adf:dd81:0:b0:32d:baff:b0ca with SMTP id x1csp455136wrl; Fri, 20 Oct 2023 11:43:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGG/kBXWveJIsd9gsHmNQM3BG3mCK5FvafKuf40nv3oSESHW3hxcthQ0MNm8Pz8jVxd2C7 X-Received: by 2002:a05:600c:1d22:b0:406:45c1:4dd with SMTP id l34-20020a05600c1d2200b0040645c104ddmr5740197wms.14.1697827385146; Fri, 20 Oct 2023 11:43:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697827385; cv=none; d=google.com; s=arc-20160816; b=FtUSshskVXonpXLTCgzx/BYuJvHV5zIddx+AAutFlbnlGo4L6SzuP+XiFsARnWwfBI wIfuiJ0eUnrnqounR7CaUIFZRMakE8Y5HP+z9bf5mOR+5mjkiOnVNDS2zdrwqv5VXfCS d5w/3zFR/yDT3Op8hi7XAkn99o5wh8pvA2ajd/jRdpbmklF/cUwdzWmkIU70aUCL2Aua W7dOmbD9EwrBwQ0cCp9BPLYgeVDnakuFjnmiAJFnv698531jwDgXZwXsjKNnC4V8IJrD O/rSKgNGI+Zla3FG6UOhwq4t8ZbjIxwl2BjiD4cEb5V/0wUtCYKbDmqZLByvwDuB5ARS S+ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=not3VwtTGNgVrUR+v7u8KRKbikWl5f0cWiC/jB+WwGc=; fh=wZ3Ndt8eAnQrQkkKqp0eFYDiHOF/POsFgfLoX53jb8o=; b=I0+AvFXEu/ilwmAj5iAKZqu4rEaFoEY0M558sEIMcTcjfSrwLRVPo3swSxuaiqcV/L c9KYgtkZmBGay7md5jp/nKYom4Fnk0qDQMxnOBL7U6n1dWkQeAj0Efi0Zg0jitFcSlY7 1MjWg3OyZOVx4y30507kWfNc1xJouYUuUtnindTDhvtXED0O+xfJzskjLJ8e1X3e1H6k Bfum9xE8IGo+J7AUKS5a73grYcutu/eFF0nFpuGXUojwsFg2psNYSW26+97N08urgmKO h2bTMxuSTSOCMuvl0wtmAPuu6A2hJbobx6GCuuY/SS4HEpxjX4mXBDvlMElQ/I4r6+cy A7wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W1VxGsW2; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id he15-20020a05600c540f00b0040749d9f09bsi1688626wmb.85.2023.10.20.11.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 11:43:05 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W1VxGsW2; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A955874FB; Fri, 20 Oct 2023 20:43:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="W1VxGsW2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B08BD874FC; Fri, 20 Oct 2023 20:43:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 71AE4874F8 for ; Fri, 20 Oct 2023 20:42:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=semen.protsenko@linaro.org Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1ea48ef2cbfso893350fac.2 for ; Fri, 20 Oct 2023 11:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697827375; x=1698432175; darn=lists.denx.de; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=not3VwtTGNgVrUR+v7u8KRKbikWl5f0cWiC/jB+WwGc=; b=W1VxGsW2+EnZnOimOU9f9QVUM2ZpNAVHvi7XE4eTDYXSOHqXUgOuDw5bZay/P4j1QW RG95p0N+dtW73DczUcKzzbXjeXhRe2iu1Q/tQIkJ3uQn8uYmQ3lPlmjvVart+meUFAvX jnmxE511JTOWIXTG19f2I+LNMbGumZisnKuvCEEZ9MuSeY05d6t2D0f4IiyVIHhUXtYn 91SSnb3TE1MGjkUb/pSHknYra8L22nYEL6yJJKdCeppq4nJS2XCh0Zxj7EOyiVtE7x/d M/dQ+oRuBxSKa8n+NsE64tvdYaQm4TR273V20C/JAe0oFpYHoAm1O8G+IW78EOKt9k6c no5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697827375; x=1698432175; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=not3VwtTGNgVrUR+v7u8KRKbikWl5f0cWiC/jB+WwGc=; b=IIM8DVClhEesEbtgOTpGo/M03SiC9aBCfR6ybpNJjAz9a1KeznY1JRxtD7wevT8lgt dFp/+V6cqjBmvYfEZTS/XoCUJ90jOW+1y/vOidm/RvvN5CYINMYvwOUDwE7UVdpnQ/p2 XtjnUISjiOhT6qq4mrcBMELXP4GI7+rXOfQDuBZU3a6s7WnArK+DUZ08+Kx5PGD/VxKy Dw7IzMSKKe+EhI7bmzjZU1ArHTc0ruPfkYuNEAWQ0dalbJ0O4mqpGzmQ9dRDuE9A9Qk1 vliNoM72BE710BUJGGRhKH5gdIsAoSk8/kBBZylYnCZX7fp6ZewbK7MBKhwNoIrBhzbF unjw== X-Gm-Message-State: AOJu0YyPnO7I8roaBSTtEKNRYG6ny1HITa/mPl/HsoxkSTr878LVEr5n 3ZDoCL7tVno40RKovTwW38c6Wg== X-Received: by 2002:a05:6871:821:b0:1d6:4b84:c7ed with SMTP id q33-20020a056871082100b001d64b84c7edmr3180553oap.23.1697827374964; Fri, 20 Oct 2023 11:42:54 -0700 (PDT) Received: from localhost ([136.62.192.75]) by smtp.gmail.com with ESMTPSA id m7-20020a056870194700b001cc9bc7b569sm460048oak.27.2023.10.20.11.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 11:42:54 -0700 (PDT) From: Sam Protsenko To: Tom Rini , Dzmitry Sankouski Cc: u-boot@lists.denx.de Subject: [PATCH] board: samsung: Remove incorrect SYS_CONFIG_NAME in axy17lte Kconfig Date: Fri, 20 Oct 2023 13:42:53 -0500 Message-Id: <20231020184253.21915-1-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The global SYS_CONFIG_NAME in axy17lte Kconfig overrides SYS_CONFIG_NAME for all boards specified after this line in arch/arm/mach-exynos/Kconfig: source "board/samsung/axy17lte/Kconfig" Right now it's the last 'source' line there, so the issue is not reproducible. But once some board is moved or added after this line the next build error will happen: GEN include/autoconf.mk.dep In file included from ./include/common.h:16: include/config.h:3:10: fatal error: configs/exynos78x0-common.h.h: No such file or directory 3 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. That's happening because axy17lte Kconfig defines SYS_CONFIG_NAME option in global namespace (not guarded with any "if TARGET_..."), so it basically rewrites the correct SYS_CONFIG_NAME defined in the hypothetical boards which might appear after axy17lte in mach-exynos Kconfig. Another side of the issue is that SYS_CONFIG_NAME is defined incorrectly in axy17lte Kconfig: config SYS_CONFIG_NAME default "exynos78x0-common.h" The .h extension should not have been specified there. It's leading to the build error, as the generated include file has double '.h' extension. Fix the issue by simply removing the SYS_CONFIG_NAME definition in axy17lte Kconfig, as all related defconfigs already declare internal values for SYS_CONFIG_NAME: - a5y17lte_defconfig - a7y17lte_defconfig - a3y17lte_defconfig Signed-off-by: Sam Protsenko Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") --- board/samsung/axy17lte/Kconfig | 8 -------- 1 file changed, 8 deletions(-) diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig index a018547ff5d4..209394a8a5a8 100644 --- a/board/samsung/axy17lte/Kconfig +++ b/board/samsung/axy17lte/Kconfig @@ -1,11 +1,3 @@ -config SYS_CONFIG_NAME - string "Board configuration name" - default "exynos78x0-common.h" - help - This option contains information about board configuration name. - Based on this option include/configs/.h header - will be used for board configuration. - if TARGET_A5Y17LTE config SYS_BOARD default "axy17lte"