From patchwork Sat Oct 14 21:59:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 733969 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F72CDB465 for ; Sat, 14 Oct 2023 22:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233360AbjJNWA2 (ORCPT ); Sat, 14 Oct 2023 18:00:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233033AbjJNWA1 (ORCPT ); Sat, 14 Oct 2023 18:00:27 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C75A1D6 for ; Sat, 14 Oct 2023 15:00:25 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrmfV-0001zq-2D; Sat, 14 Oct 2023 23:59:33 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrmfI-001hum-RA; Sat, 14 Oct 2023 23:59:20 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qrmfI-00GSU5-Fm; Sat, 14 Oct 2023 23:59:20 +0200 Date: Sat, 14 Oct 2023 23:59:18 +0200 From: Uwe =?utf-8?q?Kleine-K=C3=B6nig?= To: soc@kernel.org Cc: Nishanth Menon , Herve Codina , Bjorn Andersson , Heiko =?utf-8?q?St=C3=BCbner?= , Mateusz Holenko , Muhammad Usama Anjum , Matthias Brugger , "Conor.Dooley" , Thierry Reding , Alim Akhtar , linux-riscv@lists.infradead.org, Karol Gugala , Qiang Zhao , Hitomi Hasegawa , Rob Herring , linux-samsung-soc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Ruan Jinjie , Yinbo Zhu , Jon Hunter , linux-rockchip@lists.infradead.org, Gabriel Somlo , Andy Gross , Huisong Li , Joel Stanley , Yang Yingliang , Sumit Gupta , "zhang.songyi" , Zev Weiss , Arnd Bergmann , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Lubomir Rintel , Krzysztof Halasa , loongarch@lists.linux.dev, Santosh Shilimkar , linux-tegra@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Daire McNamara , linux-kernel@vger.kernel.org, Shang XiaoJing , Leo Li , Konrad Dybcio , Andrew Jeffery , Krzysztof Kozlowski , Pengutronix Kernel Team , linux-mediatek@lists.infradead.org, Nick Alcock , linuxppc-dev@lists.ozlabs.org Subject: [GIT PULL] Convert drivers/soc to struct platform_driver::remove_new() Message-ID: <20231014215918.prqhkk7kp2vobe3a@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <1b2fddf8-c0a6-4afa-8ad0-f280dea1607f@app.fastmail.com> <20230928061449.xxqhyyrg6e357dn2@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230928061449.xxqhyyrg6e357dn2@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hello Arnd, the following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) are available in the Git repository at: https://git.pengutronix.de/git/ukl/linux tags/platform-remove-void-soc-for-6.7-rc for you to fetch changes up to e77e6e3e909d33361c58af848a96e1f7f71ba7e4: soc/pxa: ssp: Convert to platform remove callback returning void (2023-10-14 23:27:34 +0200) ---------------------------------------------------------------- Convert drivers/soc to struct platform_driver::remove_new() This PR contains the patches I sent in the series available at https://lore.kernel.org/all/20230925095532.1984344-1-u.kleine-koenig@pengutronix.de that were not yet picked up in next as of next-20231013. It converts all drivers below drivers/soc to let their remove callback return void. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for the rationale. ---------------------------------------------------------------- On Thu, Sep 28, 2023 at 08:14:49AM +0200, Uwe Kleine-König wrote: > On Wed, Sep 27, 2023 at 04:01:58PM -0700, Bjorn Andersson wrote: > > On Wed, Sep 27, 2023 at 10:43:16AM +0200, Arnd Bergmann wrote: > > > On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote: > > > > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König wrote: > > > >> > > > >> this series converts all platform drivers below drivers/soc to use > > > >> .remove_new(). The motivation is to get rid of an integer return code > > > >> that is (mostly) ignored by the platform driver core and error prone on > > > >> the driver side. > > > >> > > > >> See commit 5c5a7680e67b ("platform: Provide a remove callback that > > > >> returns no value") for an extended explanation and the eventual goal. > > > >> > > > >> As there is no single maintainer team for drivers/soc, I suggest the > > > >> individual maintainers to pick up "their" patches. > > > > > > > > I'd be happy if Arnd merged the lot at once. Arnd, what do you think? > > > > > > > > If that will be too messy then I understand. I have queued the aspeed > > > > ones locally and will push that out if we decide that's the best way > > > > to go. > > > > > > The main downside of merging it all at once through the soc tree > > > is that there may be patches that conflict with other work going on > > > in individual drivers. > > > > > > What I'd suggest doing here is: > > > > > > - have platform maintainers pick up patches for their drivers > > > if that is their preference for any reason > > > > I'd prefer this for the qcom drivers at least, please let me know if you > > would like me to proceed. > > I can send a pull request as Arnd suggested. So iff you want the qcom > drivers not be a part of that PR, just make sure they appear in next > during the next week. :-) > > > > - get a pull request from Uwe for the soc tree for anything that has > > > not been picked up in one or two weeks from now Here comes the promised PR. The qcom patches are among the set of patches dropped here as they are already in next. To state the obvious: This is merge window material and the idea is that it's pulled into armsoc and then included in the armsoc v6.7-rc1 PR to Linus Torvalds. I hope it's not too late for that already. Best regards and thanks Uwe Uwe Kleine-König (12): soc/fsl: dpaa2-console: Convert to platform remove callback returning void soc/fsl: cpm: qmc: Convert to platform remove callback returning void soc/fsl: cpm: tsa: Convert to platform remove callback returning void soc/fujitsu: a64fx-diag: Convert to platform remove callback returning void soc/hisilicon: kunpeng_hccs: Convert to platform remove callback returning void soc/ixp4xx: ixp4xx-npe: Convert to platform remove callback returning void soc/ixp4xx: ixp4xx-qmgr: Convert to platform remove callback returning void soc/litex: litex_soc_ctrl: Convert to platform remove callback returning void soc/loongson: loongson2_guts: Convert to platform remove callback returning void soc/mediatek: mtk-devapc: Convert to platform remove callback returning void soc/mediatek: mtk-mmsys: Convert to platform remove callback returning void soc/pxa: ssp: Convert to platform remove callback returning void drivers/soc/fsl/dpaa2-console.c | 6 ++---- drivers/soc/fsl/qe/qmc.c | 6 ++---- drivers/soc/fsl/qe/tsa.c | 5 ++--- drivers/soc/fujitsu/a64fx-diag.c | 6 ++---- drivers/soc/hisilicon/kunpeng_hccs.c | 6 ++---- drivers/soc/ixp4xx/ixp4xx-npe.c | 6 ++---- drivers/soc/ixp4xx/ixp4xx-qmgr.c | 5 ++--- drivers/soc/litex/litex_soc_ctrl.c | 5 ++--- drivers/soc/loongson/loongson2_guts.c | 6 ++---- drivers/soc/mediatek/mtk-devapc.c | 6 ++---- drivers/soc/mediatek/mtk-mmsys.c | 6 ++---- drivers/soc/pxa/ssp.c | 6 ++---- 12 files changed, 24 insertions(+), 45 deletions(-)