From patchwork Fri Sep 29 10:16:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 727974 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAB9E732E3 for ; Fri, 29 Sep 2023 10:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbjI2KR4 (ORCPT ); Fri, 29 Sep 2023 06:17:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233087AbjI2KRt (ORCPT ); Fri, 29 Sep 2023 06:17:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F30ECCFB; Fri, 29 Sep 2023 03:17:40 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A0C1C433C7; Fri, 29 Sep 2023 10:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695982660; bh=Fi+IDHGlBgmNRYu1rK859S59T3doLUrBZChLlDSK6B4=; h=From:To:Cc:Subject:Date:From; b=HTpXzlSV1r3+kMFhGBJEbYO0Kx/5XXFGf7QJcGdXmb8luEww4sON51bn8Bv8kSDiP 3pRXSVPdnopll4AxB9MLiD2lVogHCm0JoezvpTGiy0A645WHLH6o2O9TsYKfF4WmTj VfAsI01gYSB/yYy6TFtVvfN6+AW0If6RoZhBgZkxnateA5hrGPpB0i99ukvmJq1Kks CXSHfjmO1q1Z3errqrDbYxnaYuFon14ZCICGYX+dzbQABtdnYf9iPLJq6VrtfeuEuT v8yFYvBzri+yMDc9i8+dW9cwL+R/Nn0rODKVdLuCGjnZdvUIin0DKaVeeq4pJLJwBO 4k5zhc1vd2qYg== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qmAZ1-0005GE-1y; Fri, 29 Sep 2023 12:17:39 +0200 From: Johan Hovold To: Sebastian Reichel Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH] power: supply: qcom_battmgr: fix enable request endianness Date: Fri, 29 Sep 2023 12:16:49 +0200 Message-ID: <20230929101649.20206-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add the missing endianness conversion when sending the enable request so that the driver will work also on a hypothetical big-endian machine. This issue was reported by sparse. Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") Cc: stable@vger.kernel.org # 6.3 Cc: Bjorn Andersson Signed-off-by: Johan Hovold Reviewed-by: Andrew Halaney --- drivers/power/supply/qcom_battmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index de77df97b3a4..6ec71276bb70 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -1282,9 +1282,9 @@ static void qcom_battmgr_enable_worker(struct work_struct *work) { struct qcom_battmgr *battmgr = container_of(work, struct qcom_battmgr, enable_work); struct qcom_battmgr_enable_request req = { - .hdr.owner = PMIC_GLINK_OWNER_BATTMGR, - .hdr.type = PMIC_GLINK_NOTIFY, - .hdr.opcode = BATTMGR_REQUEST_NOTIFICATION, + .hdr.owner = cpu_to_le32(PMIC_GLINK_OWNER_BATTMGR), + .hdr.type = cpu_to_le32(PMIC_GLINK_NOTIFY), + .hdr.opcode = cpu_to_le32(BATTMGR_REQUEST_NOTIFICATION), }; int ret;