From patchwork Thu Sep 28 20:38:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 728226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11422E743C2 for ; Thu, 28 Sep 2023 20:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbjI1UjC (ORCPT ); Thu, 28 Sep 2023 16:39:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbjI1UjC (ORCPT ); Thu, 28 Sep 2023 16:39:02 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17AFA19C for ; Thu, 28 Sep 2023 13:39:00 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3ae5ce5beffso2586389b6e.0 for ; Thu, 28 Sep 2023 13:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695933539; x=1696538339; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=G7n1MMetRWMiDVlP8bztrbYv7/3piwCnbkbnF7yATs0=; b=MwZnPUpcrHXruP9u7JjnDeZsh0iTXpPJqyXUwWQ/v5la3P7iAyYDcl0TcmDX8WOkcW pUZykF9vunWliWX9Bhy7954bdZc5Q1kO+bZy1rHzGHG0KmZsC6uo8NJAa4c7LW05nV2S dYBxu2zKtgC+bkJn1jk6g93KajR0epoH8zHv0fkVhXHNN4RMiTgtdmVZoa/hAF0LZz10 MWiuTvE1NFNljaYwKMA6kJS4CcGROq46w0cruWtZKzzb9is+2eJDK1NSmWJP5tRD4J0A GEt66/+yrS1sHfkeq7l3f3chvOEbilyDl/6GL2BoMgtFDAxrBI9FesXLYz3klBffEaUp 3aqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695933539; x=1696538339; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G7n1MMetRWMiDVlP8bztrbYv7/3piwCnbkbnF7yATs0=; b=M3cfw7/UjLZLM1ed5ABSnAb+ZekTfeRvFeWRBBq3cO/FOHAovUqkig7yj7xt8mxIsW tipHjJHMIrCfpQaHmv4I8dDhnYpjQUeTteG0qfD92gLUeLlvkQ3efXF4K79DXlIArUV6 FT7PSiXrGp1Sv1ja2R1zmJ70HRaAGnEqL/CgTZUXZVIXR3qmRCrLzaLYTxuQ4xKmCEBK XEeUjQ6h1a7e+9/Rva5MsHOLzhW9FyoPMwN7tmA/JI2SYAYSsTnA4Ipt2nDDGjK0bPTj jlTIS5cg6+l0aVsjYphXtetk0f0Ujn7/OgwnxWcQJZGPsk2ns84TTd4iCT2+16Qlxdj6 Mqhw== X-Gm-Message-State: AOJu0YwQw9TcJU6wl/YWWPOVgKBQa4wxKurvml4qD2kA5JAKUvHts+vQ vRn9CAgJwrdFOehyD6Msg6UufoB6GM08Akkf X-Google-Smtp-Source: AGHT+IEDVOT0t0pYmMUizSqdt+Q6TUjORZcuHmrm6RX+BwnGChxhX5QVdNiFOtacUQgoHra7xAd27g== X-Received: by 2002:a05:6808:1b06:b0:3a8:5fd6:f4d0 with SMTP id bx6-20020a0568081b0600b003a85fd6f4d0mr2671849oib.49.1695933538632; Thu, 28 Sep 2023 13:38:58 -0700 (PDT) Received: from lvondent-mobl4.. (c-98-232-221-87.hsd1.or.comcast.net. [98.232.221.87]) by smtp.gmail.com with ESMTPSA id b25-20020aa78719000000b00690cd981652sm13750269pfo.61.2023.09.28.13.38.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 13:38:57 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2 1/2] csip: Fix not registering CSIS service Date: Thu, 28 Sep 2023 13:38:55 -0700 Message-ID: <20230928203856.2100456-1-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz adapter_probe callback shall register service the plugin wants to expose which was not the case for csip since it depended on a device to register the bt_csip instance which is then responsible to register its attributes, so this change it so there is a dedicated driver for CSIS which takes care of creating the necessary attributes and associate it with the adapter so it can be cleanup properly. --- profiles/audio/csip.c | 150 +++++++++++++++++++++++++++++++++--------- 1 file changed, 119 insertions(+), 31 deletions(-) diff --git a/profiles/audio/csip.c b/profiles/audio/csip.c index ec042afd54eb..05bf588d8d6f 100644 --- a/profiles/audio/csip.c +++ b/profiles/audio/csip.c @@ -54,7 +54,13 @@ #define CSIS_UUID_STR "00001846-0000-1000-8000-00805f9b34fb" +struct csis_data { + struct btd_adapter *adapter; + struct bt_csip *csip; +}; + struct csip_data { + struct btd_adapter *adapter; struct btd_device *device; struct btd_service *service; struct bt_csip *csip; @@ -62,6 +68,7 @@ struct csip_data { }; static struct queue *sessions; +static struct queue *servers; static void csip_debug(const char *str, void *user_data) { @@ -78,12 +85,6 @@ static struct csip_data *csip_data_new(struct btd_device *device) return data; } -static bool csip_ltk_read(struct bt_csip *csip, uint8_t k[16], void *user_data) -{ - /* TODO: Retrieve LTK using device object */ - return false; -} - static void csip_data_add(struct csip_data *data) { DBG("data %p", data); @@ -95,10 +96,6 @@ static void csip_data_add(struct csip_data *data) bt_csip_set_debug(data->csip, csip_debug, NULL, NULL); - bt_csip_set_sirk(data->csip, btd_opts.csis.encrypt, btd_opts.csis.sirk, - btd_opts.csis.size, btd_opts.csis.rank, - csip_ltk_read, data); - if (!sessions) sessions = queue_new(); @@ -201,25 +198,6 @@ static void csip_attached(struct bt_csip *csip, void *user_data) data->csip = csip; csip_data_add(data); - -} - -static int csip_server_probe(struct btd_profile *p, - struct btd_adapter *adapter) -{ - struct btd_gatt_database *database = btd_adapter_get_database(adapter); - - DBG("CSIP path %s", adapter_get_path(adapter)); - - bt_csip_add_db(btd_gatt_database_get_db(database)); - - return 0; -} - -static void csip_server_remove(struct btd_profile *p, - struct btd_adapter *adapter) -{ - DBG("CSIP remove Adapter"); } static int csip_accept(struct btd_service *service) @@ -332,9 +310,114 @@ static struct btd_profile csip_profile = { .accept = csip_accept, .disconnect = csip_disconnect, - .adapter_probe = csip_server_probe, - .adapter_remove = csip_server_remove, + .experimental = true, +}; +static bool csis_ltk_read(struct bt_csip *csip, uint8_t k[16], void *user_data) +{ + /* TODO: Retrieve LTK using device object */ + return false; +} + +static void csis_data_add(struct csis_data *data) +{ + DBG("data %p", data); + + if (queue_find(servers, NULL, data)) { + error("data %p already added", data); + return; + } + + bt_csip_set_debug(data->csip, csip_debug, NULL, NULL); + + bt_csip_set_sirk(data->csip, btd_opts.csis.encrypt, btd_opts.csis.sirk, + btd_opts.csis.size, btd_opts.csis.rank, + csis_ltk_read, data); + + if (!servers) + servers = queue_new(); + + queue_push_tail(servers, data); +} + +static struct csis_data *csis_data_new(struct btd_adapter *adapter) +{ + struct csis_data *data; + + data = new0(struct csis_data, 1); + data->adapter = adapter; + + return data; +} + +static int csis_server_probe(struct btd_profile *p, struct btd_adapter *adapter) +{ + struct btd_gatt_database *database = btd_adapter_get_database(adapter); + struct csis_data *data; + + DBG("path %s", adapter_get_path(adapter)); + + data = csis_data_new(adapter); + + data->csip = bt_csip_new(btd_gatt_database_get_db(database), NULL); + if (!data->csip) { + error("Unable to create CSIP instance"); + free(data); + return -EINVAL; + } + + csis_data_add(data); + + return 0; +} + +static bool match_csis(const void *data, const void *match_data) +{ + const struct csis_data *csis = data; + const struct btd_adapter *adapter = match_data; + + return csis->adapter == adapter; +} + +static void csis_data_free(struct csis_data *data) +{ + bt_csip_unref(data->csip); + free(data); +} + +static void csis_data_remove(struct csis_data *data) +{ + DBG("data %p", data); + + csis_data_free(data); + + if (queue_isempty(servers)) { + queue_destroy(servers, NULL); + servers = NULL; + } +} + +static void csis_server_remove(struct btd_profile *p, + struct btd_adapter *adapter) +{ + struct csis_data *data; + + DBG("path %s", adapter_get_path(adapter)); + + data = queue_remove_if(servers, match_csis, adapter); + if (!data) + return; + + csis_data_remove(data); +} + +static struct btd_profile csis_profile = { + .name = "csis", + .priority = BTD_PROFILE_PRIORITY_MEDIUM, + .local_uuid = CSIS_UUID_STR, + + .adapter_probe = csis_server_probe, + .adapter_remove = csis_server_remove, .experimental = true, }; @@ -344,6 +427,10 @@ static int csip_init(void) { int err; + err = btd_profile_register(&csis_profile); + if (err) + return err; + err = btd_profile_register(&csip_profile); if (err) return err; @@ -355,6 +442,7 @@ static int csip_init(void) static void csip_exit(void) { + btd_profile_unregister(&csis_profile); btd_profile_unregister(&csip_profile); bt_csip_unregister(csip_id); } From patchwork Thu Sep 28 20:38:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 727348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B584E743C0 for ; Thu, 28 Sep 2023 20:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232039AbjI1UjE (ORCPT ); Thu, 28 Sep 2023 16:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbjI1UjD (ORCPT ); Thu, 28 Sep 2023 16:39:03 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 036CF19C for ; Thu, 28 Sep 2023 13:39:02 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-690fa0eea3cso12057550b3a.0 for ; Thu, 28 Sep 2023 13:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695933540; x=1696538340; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4AY5BVXbm4ubX1JZNRvTpReH2b5fYZxAwIwQHK1qihc=; b=Raa8Nhllhq+52FbFpOXBHmTc2gcyx/ZUyCuwSyasA4FKZz2sdJdO7EemGCSSrkLluc qm2ZtkxIVS/4ywB9GB+dSJFvd20ygh4M1h6HpykCqXvUQGL5fmSyei3qJ0ZuFhvCPV0U prkqZJkgx7Pf/46qspJaU3FnDo2kospBFs9fkR10CAAn89FmJHAAJUzqk3uU87Ukm/ft GQXBo8KR+pBHKizIzxJ980PTiU+IaVQ8BPpW8JmUt2qJVPNWDX33y5R4VX439ujDJHae 4jyfNwJGlRuW5KlwT7O9mQkvHlVLosT8BSjJfx+i9uG+mpBx6zTI6LrTGjrkKZ846ujB zrUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695933540; x=1696538340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4AY5BVXbm4ubX1JZNRvTpReH2b5fYZxAwIwQHK1qihc=; b=hx49NcrLvtAfoiUja8/rCM+9UcTiO+bFmhItKemTZPhwbzMdT6J+R3O1fSWtg7aZQ7 XJolosT/1rTkzxMV8kBdTGwPJUqhGOccZTNV7jecN55RGH1im5D7mJXgMpvoadSZRp2m 98FU/CzsnXi6Sr3fM1icbE5Tnc2kNQMWyOQwGVOceUpJ1Umq1WFgtUiS6iVapzVzbFpW 5hlTGdJm2Y5XRISadzLZsNPpbxheiI83LjZL+Sy2dHzTMY0hyJdJ5hP0VBHh2Q7KdnLd mJSUe5Rv4m88MZwCFYBK6INPwMLeOGpV419F7kI6eKQcRbWQ/WX8+Nc7ttn1/97WchhC RwMQ== X-Gm-Message-State: AOJu0YwavZzNC///cwjXutqTWXvpyARCXbjVpWXW6Sb8qU7slnIJe+5q //mFIb27Z8/Rzk9gbRnCvtcCftCj8XxPSVwB X-Google-Smtp-Source: AGHT+IEFRBD3OflIsRxl+CxJs/xtiF0v2om5tUVdIff4DQ2R2oJCObUcLzEIaKZet7uW5hsd+8r5zg== X-Received: by 2002:a05:6a00:10d3:b0:692:a727:1fde with SMTP id d19-20020a056a0010d300b00692a7271fdemr2401206pfu.14.1695933540487; Thu, 28 Sep 2023 13:39:00 -0700 (PDT) Received: from lvondent-mobl4.. (c-98-232-221-87.hsd1.or.comcast.net. [98.232.221.87]) by smtp.gmail.com with ESMTPSA id b25-20020aa78719000000b00690cd981652sm13750269pfo.61.2023.09.28.13.38.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 13:38:59 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2 2/2] shared/csip: Remove bt_csip_add_db Date: Thu, 28 Sep 2023 13:38:56 -0700 Message-ID: <20230928203856.2100456-2-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230928203856.2100456-1-luiz.dentz@gmail.com> References: <20230928203856.2100456-1-luiz.dentz@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz bt_csip_add_db is unused since csip plugin does use bt_csip_new to properly create the attributes for CSIS. --- src/shared/csip.c | 5 ----- src/shared/csip.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/src/shared/csip.c b/src/shared/csip.c index 7e90a3c97614..04a8d542b390 100644 --- a/src/shared/csip.c +++ b/src/shared/csip.c @@ -389,11 +389,6 @@ static struct bt_csip_db *csip_get_db(struct gatt_db *db) return csip_db_new(db); } -void bt_csip_add_db(struct gatt_db *db) -{ - csip_db_new(db); -} - bool bt_csip_set_debug(struct bt_csip *csip, bt_csip_debug_func_t func, void *user_data, bt_csip_destroy_func_t destroy) { diff --git a/src/shared/csip.h b/src/shared/csip.h index 0f8acb1cae82..bc5519cfbc49 100644 --- a/src/shared/csip.h +++ b/src/shared/csip.h @@ -36,8 +36,6 @@ typedef bool (*bt_csip_sirk_func_t)(struct bt_csip *csip, uint8_t type, struct bt_csip *bt_csip_ref(struct bt_csip *csip); void bt_csip_unref(struct bt_csip *csip); -void bt_csip_add_db(struct gatt_db *db); - bool bt_csip_attach(struct bt_csip *csip, struct bt_gatt_client *client); void bt_csip_detach(struct bt_csip *csip);