From patchwork Wed Jun 7 22:57:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Willy Tarreau X-Patchwork-Id: 103325 Delivered-To: patch@linaro.org Received: by 10.182.29.35 with SMTP id g3csp1991142obh; Wed, 7 Jun 2017 16:34:01 -0700 (PDT) X-Received: by 10.84.238.131 with SMTP id v3mr30753496plk.168.1496878441921; Wed, 07 Jun 2017 16:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496878441; cv=none; d=google.com; s=arc-20160816; b=DOu7rn02S18vP3fdpRcHXBHSqbCjZBRSptxJkhZzsMvxERPpEP90MrEXlcKX6hktJm G9Q5T+AQxHT2YAsLGbP9n1yvOsAz4VgbBslrnMpNJfb+UmKlSjdx0Mw0CEsGr8AYOxsr X7pdU5C1QypTKincNwC0ibZaD2jYx+oYNIKLNW2PSPjZhmwII4znCDRjrSbzQL6Alj/z v4ZyWpozmtDC7OJjBNmKJNYFuIt65HmByt/Z4be8dEZYyb3mpzswIt6scBB1PSRAfGp7 jxYXl1cV1JN3jP4/A/wrKVS4k3e4cP9GgZ7cSrk8eVor/sEM6EIoYf3Atnh1qcv4cCnZ sPvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=CgNERQ4ulSfRcRPrAYowIFGsI4DxMVv9tyLv1lxQtM4=; b=T/6jY7sqEsEpft0ezmr+xX+MOcCRaxl46P+DCpu9x7tbZgcJ13DfnNASHrBodfJaOq 7Sk7RGKeEdkJd0E+Ow+tvE+zpCPvH/DQ6DktZ+/GpbqFn7Mpy818JPd9W2FY+Y0x7xT8 nzfkKbXMRAgjlJ0uV/O4T0psvjYrPlFZsYQDReBuvwXbZXtenIaMvpReS78SHZHOnEC2 B6nlzvoTX9LFghI3wC69xliRra9xh9WAXDoUqu2w9nDHgATiRA5X6jrX0BNfkKOgSzmb qyZp74KqvXG5uzgHh3SUiV2YO8zAwhP62coUnyd+YQu1VZcK5qSWC8I6dfN0aqbj0xms pmrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10si2869521plh.401.2017.06.07.16.34.01; Wed, 07 Jun 2017 16:34:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbdFGXd7 (ORCPT + 25 others); Wed, 7 Jun 2017 19:33:59 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:50732 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbdFGXFO (ORCPT ); Wed, 7 Jun 2017 19:05:14 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id v57N14jZ032766; Thu, 8 Jun 2017 01:01:04 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Arnd Bergmann , "Martin K . Petersen" , Willy Tarreau Subject: [PATCH 3.10 068/250] scsi: mvsas: fix command_active typo Date: Thu, 8 Jun 2017 00:57:34 +0200 Message-Id: <1496876436-32402-69-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1496876436-32402-1-git-send-email-w@1wt.eu> References: <1496876436-32402-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit af15769ffab13d777e55fdef09d0762bf0c249c4 upstream. gcc-7 notices that the condition in mvs_94xx_command_active looks suspicious: drivers/scsi/mvsas/mv_94xx.c: In function 'mvs_94xx_command_active': drivers/scsi/mvsas/mv_94xx.c:671:15: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] This was introduced when the mv_printk() statement got added, and leads to the condition being ignored. This is probably harmless. Changing '&&' to '&' makes the code look reasonable, as we check the command bit before setting and printing it. Fixes: a4632aae8b66 ("[SCSI] mvsas: Add new macros and functions") Signed-off-by: Arnd Bergmann Reviewed-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen Signed-off-by: Willy Tarreau --- drivers/scsi/mvsas/mv_94xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.8.0.rc2.1.gbe9624a diff --git a/drivers/scsi/mvsas/mv_94xx.c b/drivers/scsi/mvsas/mv_94xx.c index 1e4479f..55716c5 100644 --- a/drivers/scsi/mvsas/mv_94xx.c +++ b/drivers/scsi/mvsas/mv_94xx.c @@ -621,7 +621,7 @@ static void mvs_94xx_command_active(struct mvs_info *mvi, u32 slot_idx) { u32 tmp; tmp = mvs_cr32(mvi, MVS_COMMAND_ACTIVE+(slot_idx >> 3)); - if (tmp && 1 << (slot_idx % 32)) { + if (tmp & 1 << (slot_idx % 32)) { mv_printk("command active %08X, slot [%x].\n", tmp, slot_idx); mvs_cw32(mvi, MVS_COMMAND_ACTIVE + (slot_idx >> 3), 1 << (slot_idx % 32)); From patchwork Wed Jun 7 22:58:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Willy Tarreau X-Patchwork-Id: 103324 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp2179900qgd; Wed, 7 Jun 2017 16:22:29 -0700 (PDT) X-Received: by 10.84.201.74 with SMTP id t10mr4605634plh.191.1496877749476; Wed, 07 Jun 2017 16:22:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496877749; cv=none; d=google.com; s=arc-20160816; b=h/hdjHsLkn01zsm4LUeQlhDZz4WQt0+atqLWXFM++AreKv+hFHjRJP7YYVVF2IZHY7 W+36AOZ18EeV5E6VlQerC/RNRJxSDvn8p5aXBpReZD5G+vgn/kIbWCmkoEI9BBusUEmW sov2HZSWE9d1js6qNhEXvBi/wZ2Gkbh1Cu4tiA7rB/G+tRFlK8BKV9v76ia8NWu7yKeZ qqvvIxJ8YVY25d5/zPZmYBb8bHr7vh3R4Tq8MQhqjuMIR+vdFnC7q0KSZ3mTLvgL7qM2 jkJGpLexAT3cgaFp/2HpNpzgvF8vMVvd0zm5CVeL9NERsb3z/B+/SE7uJc/BXugla5Sp H0mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=N25dycyS/zEeJo4AovW47aqCNBgKty/se3q3WVnm97A=; b=e3TMyvr0Sbrh93AsaoJXIs2tGF0K2h3RAQ7wHooyNizIgYSFuy3mLgG1/kNbmbF+E5 V4ZqTJIQAAbvNPqbTc9B3SR858o6lAW+ZmE64xdajj2pxf4bA4lQHIrJ5SFs1r7NOYU6 cBePZEuIlamUcofI7glt2ZJz0j2kJBITMkI2Got1zxKyCpfNMynz7yASAp90N5FqaPn1 YapfKVWFD0MVjEUxpOksfgZCPEcjoqNhxyIbIxlGg03+bQRUSnHSr/s0A06I05yRMddd JlQtPU7SkQFklR/NYC64Kt8nrksPLjIhYGoY/s4QfDO+iTHYBoY17wwEzWkXK7U2tBha ddbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l27si2857824pfa.92.2017.06.07.16.22.29; Wed, 07 Jun 2017 16:22:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbdFGXWF (ORCPT + 25 others); Wed, 7 Jun 2017 19:22:05 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:50797 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753426AbdFGXFn (ORCPT ); Wed, 7 Jun 2017 19:05:43 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id v57N1Bli000335; Thu, 8 Jun 2017 01:01:11 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Arnd Bergmann , Linus Walleij , Willy Tarreau Subject: [PATCH 3.10 103/250] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation Date: Thu, 8 Jun 2017 00:58:09 +0200 Message-Id: <1496876436-32402-104-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1496876436-32402-1-git-send-email-w@1wt.eu> References: <1496876436-32402-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit f0e8faa7a5e894b0fc99d24be1b18685a92ea466 upstream. This function clearly never worked and always returns true, as pointed out by gcc-7: arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi': arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context] With the added braces, the condition actually makes sense. Fixes: 34fe6f107eab ("mfd : Check if the other db8500 core is in WFI") Signed-off-by: Arnd Bergmann Acked-by: Daniel Lezcano Signed-off-by: Linus Walleij Signed-off-by: Willy Tarreau --- arch/arm/mach-ux500/pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.8.0.rc2.1.gbe9624a diff --git a/arch/arm/mach-ux500/pm.c b/arch/arm/mach-ux500/pm.c index 1a468f0..9d53256 100644 --- a/arch/arm/mach-ux500/pm.c +++ b/arch/arm/mach-ux500/pm.c @@ -128,8 +128,8 @@ bool prcmu_pending_irq(void) */ bool prcmu_is_cpu_in_wfi(int cpu) { - return readl(PRCM_ARM_WFI_STANDBY) & cpu ? PRCM_ARM_WFI_STANDBY_WFI1 : - PRCM_ARM_WFI_STANDBY_WFI0; + return readl(PRCM_ARM_WFI_STANDBY) & + (cpu ? PRCM_ARM_WFI_STANDBY_WFI1 : PRCM_ARM_WFI_STANDBY_WFI0); } /* From patchwork Wed Jun 7 22:58:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Willy Tarreau X-Patchwork-Id: 103327 Delivered-To: patch@linaro.org Received: by 10.182.29.35 with SMTP id g3csp1996830obh; Wed, 7 Jun 2017 16:54:56 -0700 (PDT) X-Received: by 10.101.90.12 with SMTP id y12mr35888058pgs.226.1496879696456; Wed, 07 Jun 2017 16:54:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496879696; cv=none; d=google.com; s=arc-20160816; b=Jr+lQSngRrSTvdzlVCNnXZ88Wj4sbhp+d8aKZpVIRoiT8SYeaBYF9dgnhBxhzxleX6 yGeFJ2f7AMokfr73FOJ39EcB84uajLbHGIJhCPr5aYAXC9RAkI1Wo/SxQYdQl+796ZQn Lvx/OdcxnrmtPB+aVOadLECsI558pM9z2hJDoZyD7h5bAm0kXWn012Nlm8NaRtVJeLu4 qXBi2fPas8L+v8g9k+AU8xkHjEvDsjLbOL0N5CTGcBahjRsL8ZjTwXveGfSZkELCmP0Y YnGN5zLV4Su/UU3O8vdPgairt1QPOr73OhNjjeXvOnDKT1ETkIVw5JPy28jbB7gL+oHH tM4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=zF6SfvVGLXUjocpAJhYsY2FFNb419wQAlho3eiKicQY=; b=xS5yLAVsQGuBdh0OAlPN5sUx0d5WS8I0lMoQrYVdoRvmQXRXBZnhen90CTiXEuAnhS S37aLd+Qv7H90LPeQrWmXsx9e1+TGzN4Nao7CkxzUArOcpNmkIps9pK7UUev3PHsCffb OXmZw8Y1si+NHPqQn3aG1utlnc6bRDxB37cRmTRBP6t7pzzdb+lz7QrzMh4mCr4c5o8F 2ATzqG5AhZlg9M+Cq1eaNeaSagS00vW5FmE9WQ5d6BagB4gXnzJFJJmlTlqf1fvnLyGA su90Ngi6cg4Mbc5f/QOyjbNbbB54VxRCYPXxicfHkqy/GjoeynrS13/pybRhq5NetdBa ijLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v140si2831413pgb.168.2017.06.07.16.54.56; Wed, 07 Jun 2017 16:54:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752967AbdFGXyo (ORCPT + 25 others); Wed, 7 Jun 2017 19:54:44 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:50430 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbdFGXDi (ORCPT ); Wed, 7 Jun 2017 19:03:38 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id v57N1DN1000340; Thu, 8 Jun 2017 01:01:13 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Arnd Bergmann , Mauro Carvalho Chehab , Willy Tarreau Subject: [PATCH 3.10 108/250] s5k4ecgx: select CRC32 helper Date: Thu, 8 Jun 2017 00:58:14 +0200 Message-Id: <1496876436-32402-109-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1496876436-32402-1-git-send-email-w@1wt.eu> References: <1496876436-32402-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit c739c0a7c3c2472d7562b8f802cdce44d2597c8b upstream. A rare randconfig build failure shows up in this driver when the CRC32 helper is not there: drivers/media/built-in.o: In function `s5k4ecgx_s_power': s5k4ecgx.c:(.text+0x9eb4): undefined reference to `crc32_le' This adds the 'select' that all other users of this function have. Fixes: 8b99312b7214 ("[media] Add v4l2 subdev driver for S5K4ECGX sensor") Signed-off-by: Arnd Bergmann Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Willy Tarreau --- drivers/media/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.8.0.rc2.1.gbe9624a diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index f981d50..936ef2f 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -549,6 +549,7 @@ config VIDEO_S5K6AA config VIDEO_S5K4ECGX tristate "Samsung S5K4ECGX sensor support" depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API + select CRC32 ---help--- This is a V4L2 sensor-level driver for Samsung S5K4ECGX 5M camera sensor with an embedded SoC image signal processor.