From patchwork Mon Aug 28 09:07:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 718378 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44050C83F11 for ; Mon, 28 Aug 2023 09:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjH1JIE (ORCPT ); Mon, 28 Aug 2023 05:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbjH1JHz (ORCPT ); Mon, 28 Aug 2023 05:07:55 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14597EC for ; Mon, 28 Aug 2023 02:07:48 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qaYDl-008S2d-8i; Mon, 28 Aug 2023 17:07:42 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Mon, 28 Aug 2023 17:07:42 +0800 Date: Mon, 28 Aug 2023 17:07:42 +0800 From: Herbert Xu To: kernel test robot , Linux Crypto Mailing List , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: Danny Tsen , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX Message-ID: References: <202308251906.SYawej6g-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202308251906.SYawej6g-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 25, 2023 at 07:44:32PM +0800, kernel test robot wrote: > > All errors (new ones prefixed by >>): > > In file included from arch/powerpc/crypto/poly1305-p10-glue.c:19: ... > ae3a197e3d0bfe3 David Howells 2012-03-28 75 > ae3a197e3d0bfe3 David Howells 2012-03-28 76 #ifdef CONFIG_VSX > d1e1cf2e38def30 Anton Blanchard 2015-10-29 77 extern void enable_kernel_vsx(void); > ae3a197e3d0bfe3 David Howells 2012-03-28 78 extern void flush_vsx_to_thread(struct task_struct *); > 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 79 static inline void disable_kernel_vsx(void) > 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 80 { > 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 81 msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX); > 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 82 } > bd73758803c2eed Christophe Leroy 2021-03-09 83 #else > bd73758803c2eed Christophe Leroy 2021-03-09 84 static inline void enable_kernel_vsx(void) > bd73758803c2eed Christophe Leroy 2021-03-09 85 { > bd73758803c2eed Christophe Leroy 2021-03-09 @86 BUILD_BUG(); > bd73758803c2eed Christophe Leroy 2021-03-09 87 } > bd73758803c2eed Christophe Leroy 2021-03-09 88 ---8<--- Add dependency on VSX as otherwise the build will fail without it. Fixes: 161fca7e3e90 ("crypto: powerpc - Add chacha20/poly1305-p10 to Kconfig and Makefile") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202308251906.SYawej6g-lkp@intel.com/ Signed-off-by: Herbert Xu diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig index f25024afdda5..7a66d7c0e6a2 100644 --- a/arch/powerpc/crypto/Kconfig +++ b/arch/powerpc/crypto/Kconfig @@ -113,7 +113,7 @@ config CRYPTO_AES_GCM_P10 config CRYPTO_CHACHA20_P10 tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)" - depends on PPC64 && CPU_LITTLE_ENDIAN + depends on PPC64 && CPU_LITTLE_ENDIAN && VSX select CRYPTO_SKCIPHER select CRYPTO_LIB_CHACHA_GENERIC select CRYPTO_ARCH_HAVE_LIB_CHACHA @@ -127,7 +127,7 @@ config CRYPTO_CHACHA20_P10 config CRYPTO_POLY1305_P10 tristate "Hash functions: Poly1305 (P10 or later)" - depends on PPC64 && CPU_LITTLE_ENDIAN + depends on PPC64 && CPU_LITTLE_ENDIAN && VSX select CRYPTO_HASH select CRYPTO_LIB_POLY1305_GENERIC help