From patchwork Sun Aug 27 12:28:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 718017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5060EC83F12 for ; Sun, 27 Aug 2023 12:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbjH0M3H (ORCPT ); Sun, 27 Aug 2023 08:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjH0M2s (ORCPT ); Sun, 27 Aug 2023 08:28:48 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D771E186 for ; Sun, 27 Aug 2023 05:28:45 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99bf1f632b8so310178966b.1 for ; Sun, 27 Aug 2023 05:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693139324; x=1693744124; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BIQMZSplS2rE5HA4WckOVzu7Ot+7UVATUf/Pm8921WU=; b=yZF6sOQpHQDVi+FDWxMHhoUHRNfXzeOwnMTvx+WroZJFJQCITvayI9bwsLfXFiOtLR PqzPwRlBKPnjUN9cT8z+gCLxbfKHX0tQaYscTXY/DtwjMHBWDyoTfkqGDy9yx3q1hfki ddY9XwSmdsuGbv8i5KfbDxACrhUdL/cSp4BJ3B3aSHd4tIpDSTYDscAaZmNHyA3ZNoco tp2GcbXZcg3dvkMpHUqbR2ing1V9feI07Sg3PQaCwNcIz+gY2HwCL0qL7uhQ7MJFRto1 z3peGpQoq1p65LGvVf1h7RMxE9jvBHd6EHV/JG2suRjbGN88EhsWEIBi/Nlue9kd771I bDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693139324; x=1693744124; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BIQMZSplS2rE5HA4WckOVzu7Ot+7UVATUf/Pm8921WU=; b=kZcwQrZly2KLHQR8n/ybXk2r8Mtt3AVFq5w8Ib9GJPtO+N3jRFE5IB12hLZnogWcfs qPaKiUyu9kXcH/ENQcvWbkJUWQ1Plo3JwCGWxyrkiCxiUpJTLwYvueuVLeK3sVZRKS+a GExrVQn7IGECGhh2C9PcfwyluRfiO1pAKLfObEZQWkn/UAlCF1CYIgOVfU9G0Qs3Z3pb eWWFUj92zQ5cLd//ql64IJi0VHlShPVhPkYCkoi7sFfDDVVqUAaa7pp3hdHIjG3k2KNf +ZgZRIhzXRBeQ7cxD0JQ5Kxg17H7b5+ajcj+jB3mVPnTCT6Ku5oLeruVQOIp8AYdBi7g 85vg== X-Gm-Message-State: AOJu0Yxmj9maIkz1550lDrO3oBt1F5S5185TBI4lFas6HkMh2p9jnjl1 8SqiS/TRLChygDwVBwEi+37E/w== X-Google-Smtp-Source: AGHT+IF+so4Fk2URicgubG6xO1HCg+IhCafYbleB6GezafBokdUts2/y7TkO16ff8XY0B5bTecgBhg== X-Received: by 2002:a17:906:3156:b0:9a1:f81f:d0df with SMTP id e22-20020a170906315600b009a1f81fd0dfmr8070915eje.69.1693139324343; Sun, 27 Aug 2023 05:28:44 -0700 (PDT) Received: from krzk-bin.. ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id rp25-20020a170906d97900b00993150e5325sm3384826ejb.60.2023.08.27.05.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 05:28:43 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/3] ARM: dts: qcom: drop incorrect cell-index from SPMI Date: Sun, 27 Aug 2023 14:28:40 +0200 Message-Id: <20230827122842.63741-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The SPMI controller (PMIC Arbiter) does not use nor allow 'cell-index' property: qcom-sdx55-mtp.dtb: spmi@c440000: Unevaluated properties are not allowed ('cell-index' was unexpected) Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 1 - arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi index 9c02d88e8eae..03da1ac9e43d 100644 --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi @@ -641,7 +641,6 @@ spmi_bus: spmi@c440000 { #size-cells = <0>; interrupt-controller; #interrupt-cells = <4>; - cell-index = <0>; }; tlmm: pinctrl@f100000 { diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi index ff596215ae3c..49c16ee2e169 100644 --- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi @@ -551,7 +551,6 @@ spmi_bus: spmi@c440000 { #interrupt-cells = <4>; #address-cells = <2>; #size-cells = <0>; - cell-index = <0>; qcom,channel = <0>; qcom,ee = <0>; }; From patchwork Sun Aug 27 12:28:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 718016 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD5EC83F19 for ; Sun, 27 Aug 2023 12:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbjH0M3H (ORCPT ); Sun, 27 Aug 2023 08:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjH0M2t (ORCPT ); Sun, 27 Aug 2023 08:28:49 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7BC9188 for ; Sun, 27 Aug 2023 05:28:46 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-99c1d03e124so302149066b.2 for ; Sun, 27 Aug 2023 05:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693139325; x=1693744125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yre2f9fVZ6ai/a0mptpH3eErz97R0W3oywtkJtSV3Ew=; b=vDXwvttJAxGSSsxm2+GimppFbbxFeFHkHUBJQzxr8m0str/7Wdw3X5u2rjS8YLey+L l/+Z26krmjRopyG66RzRgbCpiTW7AbXlLCxd38sUwNjgfhkZZrOqenKknRYX5R5Rjr91 xlh27gmoFW8GCDQKeadYM6bn3NOVtkz0SDm3JUUOcLp/QWkCpvO7ih3zsjLYfXwAJN0Y uBPilUPC2aQbnO3OiRG6lLCXdtzYPIvKFmUZIBj6n6aJFhUboRlwR7FTh69XAp/UeWFp pLYXGBcxz60Zjhr1v9a/KRDZN4AEk5uHwfWuNyuvPnUeOl7wo8HQgfn7eA2Ao46CnW1Z mRiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693139325; x=1693744125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yre2f9fVZ6ai/a0mptpH3eErz97R0W3oywtkJtSV3Ew=; b=JENhMK4cLa+Q7v6BONRiJ3b14GpXZMxjRd6CTzIQ5hXadUqrKrnU2maO6mKDq6ubwv A/4CKN6YT5QyKsOtlWawYbJ0ORSJedCs+SJ6yxbWWKYdTlkUZwg3PtnkKs6OAx7K/d7c LCxJQNpukHMt98sSxaAam2kS/NuNmlHEaujXMseGGgfBtKGN5mFzsPB/UX029C5985Ja NdLF0T0ro+yvrG8MwihvXVb8TPffxjjmdenUK75qDGECp0QBTJhgHcXEYGQtxMpptlci tDEIvWI9GEiySu/rWnIOVUNFwASNcqYj/StUvPgBu2GHDq1GTlpvw8wYJAS8xPU+dpCo IFVg== X-Gm-Message-State: AOJu0YwzIz4LTelFRKjGDJkOri8d4vSZ0chY0hcBDcCZ4389YeY8Isbo rhgRb2HUwqju6Ol/VFdXKTrdbg== X-Google-Smtp-Source: AGHT+IGToWailvSldU2w9yx3hQWQuxLTeWHjSmM/bQdA8LGmefQm889AJtrx0CVxLHwvnejxWTCGNw== X-Received: by 2002:a17:906:ca:b0:9a1:688f:cf21 with SMTP id 10-20020a17090600ca00b009a1688fcf21mr16624744eji.43.1693139325497; Sun, 27 Aug 2023 05:28:45 -0700 (PDT) Received: from krzk-bin.. ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id rp25-20020a170906d97900b00993150e5325sm3384826ejb.60.2023.08.27.05.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 05:28:45 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/3] arm64: dts: qcom: sc8180x: drop incorrect cell-index from SPMI Date: Sun, 27 Aug 2023 14:28:41 +0200 Message-Id: <20230827122842.63741-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230827122842.63741-1-krzysztof.kozlowski@linaro.org> References: <20230827122842.63741-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The SPMI controller (PMIC Arbiter) does not use nor allow 'cell-index' property: sc8180x-primus.dtb: spmi@c440000: Unevaluated properties are not allowed ('cell-index' was unexpected) Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 8fa296142eab..344ba444fcba 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -3299,7 +3299,6 @@ spmi_bus: spmi@c440000 { #size-cells = <0>; interrupt-controller; #interrupt-cells = <4>; - cell-index = <0>; }; apps_smmu: iommu@15000000 { From patchwork Sun Aug 27 12:28:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 717528 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754E1C83F16 for ; Sun, 27 Aug 2023 12:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbjH0M3H (ORCPT ); Sun, 27 Aug 2023 08:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbjH0M2v (ORCPT ); Sun, 27 Aug 2023 08:28:51 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D939188 for ; Sun, 27 Aug 2023 05:28:48 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-99c3c8adb27so283127066b.1 for ; Sun, 27 Aug 2023 05:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693139327; x=1693744127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IcVnzZ8MSOPSpFPMNqTfyeOLJhI+g+xFMbAA/QR3NNQ=; b=bQ+/of5oF4QEdpOByeDf+hUPyIAkVs/qAY5Dll4xIBx1/X5zD/K7itkdW4SXt9Mf5+ UVsO0tV9n8BpMvZXBVYzpWjS1b98/BXM1Y8mhxXc+oHyVEBS6yNWLGlB8ftmhKjtXfrO sziU9lT/rNKxgNSlfp5Yothn2G1HaWRPM2kRhuxBpSQJqWa50OheIU3mUCavnIHgQuBp pK3OUPXYAUmXuqscR2dF82FrqvTBf2HSAHb9/RLdiSxqFuinTP4jUIkd3hMeuOJ4VzBq kKjKWVC06ogVdmqAUfX6aGlGG6P0JpVGu4jKDJmGQbXdCRMjjLi7o6mKgrv1u/PgsVq3 NEdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693139327; x=1693744127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IcVnzZ8MSOPSpFPMNqTfyeOLJhI+g+xFMbAA/QR3NNQ=; b=a8NDfv1zVZTu8T7fmXnPDADuBInyjkDM3gQ5L3zTYhNNUXo/JT76D4iehKvkGwPOiO M2kdFInuIMo9pQKLmRk//cWIb+Fh8NPnCs3Gx5reZa1gTn/0KpKDiMLs5W0Eb0i+5EAQ KJtCf0hWnLOT0JbS49HyWfPVzwYcZgmw6xMKVTYcQ441b3gyadIi7ZH/VjzrmBE+3j5i 2MetoPoNdDEolkkSRtvme4jpI8SmvZ5H1GFeQkD/5GJVaCOkGCrolOZmpV3UEf8YYa7C lE8GfjAUsz+SIdMf2EIiTO5+NGaCDyyzgeEC/nDOQfeBUgvuVEbAWuBSQAGVITZm7Vmw fa3w== X-Gm-Message-State: AOJu0YyWM+hYn4a4wLRWl63FiKfwihCDJzllnMM3gMK+LFvKvG7T3jXf uVa9Sexv3SN74PKDQNHpz60TNg== X-Google-Smtp-Source: AGHT+IEaBWj4HoPwemXMp4e33SXcx4jTCKmnqkv2bgAxXf5aahwtKV9mCr+u6fWN5pWjvuQHS3nmXw== X-Received: by 2002:a17:907:7888:b0:9a2:25a6:a42f with SMTP id ku8-20020a170907788800b009a225a6a42fmr7433519ejc.19.1693139326658; Sun, 27 Aug 2023 05:28:46 -0700 (PDT) Received: from krzk-bin.. ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id rp25-20020a170906d97900b00993150e5325sm3384826ejb.60.2023.08.27.05.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 05:28:46 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Luca Weiss Subject: [PATCH 3/3] arm64: dts: qcom: sm7225-fp4: Revert "arm64: dts: qcom: sm7225-fairphone-fp4: Add AW8695 haptics" Date: Sun, 27 Aug 2023 14:28:42 +0200 Message-Id: <20230827122842.63741-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230827122842.63741-1-krzysztof.kozlowski@linaro.org> References: <20230827122842.63741-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This reverts commit 413821b7777d062b57f8dc66ab088ed390cbc3ec because it was never reviewed, was buggy (report from kernel test robot: https://lore.kernel.org/all/202204090333.QZXMI2tu-lkp@intel.com/) and used undocumented, broken bindings. Half of the properties in this device are questioned, thus adding DTS node causes only errors and does not make the device usable without the bindings and driver part: sm7225-fairphone-fp4.dtb: haptics@5a: failed to match any schema with compatible: ['awinic,aw8695'] sm7225-fairphone-fp4.dtb: haptics@5a: awinic,tset: b'\x12' is not of type 'object', 'array', 'boolean', 'null' sm7225-fairphone-fp4.dtb: haptics@5a: awinic,r-spare: b'h' is not of type 'object', 'array', 'boolean', 'null' Since bindings were abandoned (4 months since review), revert the commit to avoid false sense of supporting something which is not supported. Cc: Luca Weiss Signed-off-by: Krzysztof Kozlowski Acked-by: Konrad Dybcio --- .../boot/dts/qcom/sm7225-fairphone-fp4.dts | 28 +------------------ 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts index 18171c5d8a38..568165f4f9e4 100644 --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts @@ -386,36 +386,10 @@ &i2c8 { }; &i2c10 { - clock-frequency = <400000>; - status = "okay"; - /* PM8008 PMIC @ 8 and 9 */ /* PX8618 @ 26 */ /* SMB1395 PMIC @ 34 */ - - haptics@5a { - compatible = "awinic,aw8695"; - reg = <0x5a>; - interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>; - reset-gpios = <&tlmm 90 GPIO_ACTIVE_HIGH>; - - awinic,f0-preset = <2350>; - awinic,f0-coefficient = <260>; - awinic,f0-calibration-percent = <7>; - awinic,drive-level = <125>; - - awinic,f0-detection-play-time = <5>; - awinic,f0-detection-wait-time = <3>; - awinic,f0-detection-repeat = <2>; - awinic,f0-detection-trace = <15>; - - awinic,boost-debug = /bits/ 8 <0x30 0xeb 0xd4>; - awinic,tset = /bits/ 8 <0x12>; - awinic,r-spare = /bits/ 8 <0x68>; - - awinic,bemf-upper-threshold = <4104>; - awinic,bemf-lower-threshold = <1016>; - }; + /* awinic,aw8695 @ 5a */ }; &ipa {