From patchwork Wed Aug 23 08:54:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant B Adams X-Patchwork-Id: 716763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39716EE4993 for ; Wed, 23 Aug 2023 09:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbjHWI7x (ORCPT ); Wed, 23 Aug 2023 04:59:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbjHWI6D (ORCPT ); Wed, 23 Aug 2023 04:58:03 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5AF9199A; Wed, 23 Aug 2023 01:54:46 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fbd33a57b6so50166345e9.2; Wed, 23 Aug 2023 01:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692780885; x=1693385685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7u0D1vKsgp+LzrkxafeIdw43ha9lu5raeDJAVDWxoo8=; b=Z2yj4F8BQq9pyniw85upgEcGXlayZJKLK+004DFTVY2Vz9d0/0limFZk1jnqgu4JCN Ga0oWg3ZVgAbJX7csPr/f3pfjZ8rfDoS9NwVaB7lSCcRDi4iFmyXUxxJXdvGkSERL/MN kIz4BGrosZvFJcGpzZIaX0KpMEi6NPhq5/n7R6C/dY9knzV/24wWHe9EymDIuYkVe88J DkSYRpFA9gAYutf9t9UryrFmx3h4PlsvhBpS6eOxfrpbzZ5GCEEFJgIUBlyOD90jJaSh Fx4+I4GIF1mbs1ZkQNaw6UFTa2+KIXzWiwFZLpZFJTxakgEfUAUwiPHZZYdxDgPvWVfJ r9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692780885; x=1693385685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7u0D1vKsgp+LzrkxafeIdw43ha9lu5raeDJAVDWxoo8=; b=CF/I8Bg2eNh0YadJslUtelnC9H3lh8VYoASY7qTMrRzAb8NXvgv2GdhfxmhGmC+pmy KT62ZfXb6UDn6hWDfL3w6McedngFimhBKrBloJV9rWVnTU5IjQyPHlyJRWz5DE8ldGhG +fr3l/fF3CjfwrsRYItezaTOISKD9oXqByIDL4HOhkVO/URFesKTW316u6Rg/kASUUHt Tic156xlpxx9vPCteKZkflho0U8sNxxHSxQ2eM5p7Bq3ryvtkBNrJWma0sVA5Xz1wxbj fpK9/l4ffQmABvo690yzI59rV3vdjEJw6p5hzorMRAL95x/+wziCVnALt7vg5z6LSh3S FSig== X-Gm-Message-State: AOJu0YyO+OOfCUSKUr7VZFXczpDJaYs0fTOCNRTZcGaoXq+NRkIvdT7E nGjYCtVqnzOEHpG3AhE158uqj2G++ogNWw== X-Google-Smtp-Source: AGHT+IFckMV0KrXEfSTJ1ulVw/BczcqOeoFhAmPSo5PmBS3fcUbgwtBwB1XAAK/hCvbIilAlZVkZkQ== X-Received: by 2002:a7b:c459:0:b0:3fe:16d3:7d60 with SMTP id l25-20020a7bc459000000b003fe16d37d60mr9280946wmi.9.1692780884696; Wed, 23 Aug 2023 01:54:44 -0700 (PDT) Received: from gba-Precision-5530.kat.ac.za ([196.24.39.242]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fed78b03b4sm16265420wmc.20.2023.08.23.01.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 01:54:44 -0700 (PDT) From: Grant B Adams Cc: linux-omap@vger.kernel.org, tony@atomide.com, Grant B Adams , Sebastian Reichel , Bin Liu , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 1/2] power: supply: Fix tps65217-charger vs vbus irq conflict Date: Wed, 23 Aug 2023 10:54:29 +0200 Message-Id: <20230823085430.6610-2-nemith592@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823085430.6610-1-nemith592@gmail.com> References: <20230823085430.6610-1-nemith592@gmail.com> MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Enabling the tps65217-charger driver/module causes an interrupt conflict with the vbus driver resulting in a probe failure. The conflict is resolved by changing both driver's threaded interrupt request function from IRQF_ONESHOT to IRQF_SHARED. Signed-off-by: Grant B Adams --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index a4bc9f2a10bc..6f68becdbfd0 100644 --- a/drivers/power/supply/tps65217_charger.c +++ b/drivers/power/supply/tps65217_charger.c @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev) for (i = 0; i < NUM_CHARGER_IRQS; i++) { ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL, tps65217_charger_irq, - IRQF_ONESHOT, "tps65217-charger", + IRQF_SHARED, "tps65217-charger", charger); if (ret) { dev_err(charger->dev, From patchwork Wed Aug 23 08:54:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant B Adams X-Patchwork-Id: 716762 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C08CEE49AE for ; Wed, 23 Aug 2023 09:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230458AbjHWJAC (ORCPT ); Wed, 23 Aug 2023 05:00:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235202AbjHWI6D (ORCPT ); Wed, 23 Aug 2023 04:58:03 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47C5419A6; Wed, 23 Aug 2023 01:54:51 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2bcbfb3705dso43281741fa.1; Wed, 23 Aug 2023 01:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692780889; x=1693385689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wGWZmoxclOfYzjyLvlkmT9ZvCsngcDBgs2bkB2Nywss=; b=Sy/NCDXkCZin/+NycWRiYEWKtdkDBzopVQ7kv139T3K7UCae5dMGr/U7va70x4eTcj P9Xsm7TSMqdCWUZGc7HwsSW0awPLIFowu0ycYjeipsl1edYONGtcUrhYI+XEjuma9VPt qYmFymGUKPrk0aDq8mMHH+QqY36SsQ0njUASXSogMg4ml0uLsWUoooS0x2hNPAftAuMk QkuzVgJ1erhBAy6GKwoO5W4wNxTlCG1R9sXiO722rj50x+2OReu/SurONQSqkt/E5Tiu QXK49viO/7VQLHGLMQFRTC+xe7jUI/NiA6lbiuKCH6IR+4Na+9WhTwfYh3OSMmpOgGCE VUfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692780889; x=1693385689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wGWZmoxclOfYzjyLvlkmT9ZvCsngcDBgs2bkB2Nywss=; b=dSQ6SKfkeiLD9TkxvkcDhwLHD+M7uUKTTL4SWG7PzQkoiQXIlY7B2rdAzyQVteWPqw IcCIHPjrvpFAq2+dOlGy9axXy0yqPSP+mHLZGigjqKJPm7VDzCOxw/A1YjaaOvjGZh9d WPBinhwIPGqNVJQ36GvmcVLQJzyKJE60MQeIx4r+K3IJdXxgJ0QqGTAhxRLvhuBhacW+ ITWwXdm4+2QKc/ptsfrAIU7rAlbhE4t9TW6mMzpLKytm8dFQaHQmvo5JfpJFCNVKyXL9 m7f8BhuiDQOKS5fkr4ndjvKiLFFRo2JRkPlUd/U2vXh80zulmcRASYpyT90P12DbQK1p POHw== X-Gm-Message-State: AOJu0YyW+iSOv5KCh92LhbgIbu+hxyE/zesGzsK0e09Oh2pvT7sPEQnp 4A/xsorbtePcJV6qD3vIvxDsjCwBZsebgw== X-Google-Smtp-Source: AGHT+IHgk3D9e1v+N1TnoJ2cmm9pMqdjPPYyCQTyICyrvuzndJXyHdOsLy1+JBqbqy+9qU6WJyiT/Q== X-Received: by 2002:a2e:3c0e:0:b0:2b6:3651:f12f with SMTP id j14-20020a2e3c0e000000b002b63651f12fmr9533149lja.3.1692780889123; Wed, 23 Aug 2023 01:54:49 -0700 (PDT) Received: from gba-Precision-5530.kat.ac.za ([196.24.39.242]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fed78b03b4sm16265420wmc.20.2023.08.23.01.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 01:54:48 -0700 (PDT) From: Grant B Adams Cc: linux-omap@vger.kernel.org, tony@atomide.com, Grant B Adams , Sebastian Reichel , Bin Liu , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict Date: Wed, 23 Aug 2023 10:54:30 +0200 Message-Id: <20230823085430.6610-3-nemith592@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823085430.6610-1-nemith592@gmail.com> References: <20230823085430.6610-1-nemith592@gmail.com> MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Enabling the tps65217-charger driver/module causes an interrupt conflict with the vbus driver resulting in a probe failure. The conflict is resolved by changing both driver's threaded interrupt request function from IRQF_ONESHOT to IRQF_SHARED. Signed-off-by: Grant B Adams --- drivers/usb/musb/musb_dsps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 9119b1d51370..cbb45de5a76f 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev, error = devm_request_threaded_irq(glue->dev, glue->vbus_irq, NULL, dsps_vbus_threaded_irq, - IRQF_ONESHOT, + IRQF_SHARED, "vbus", glue); if (error) { glue->vbus_irq = 0;