From patchwork Thu Aug 17 07:10:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Rudolph X-Patchwork-Id: 714482 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E1BC41513 for ; Thu, 17 Aug 2023 07:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348364AbjHQHLY (ORCPT ); Thu, 17 Aug 2023 03:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348369AbjHQHLH (ORCPT ); Thu, 17 Aug 2023 03:11:07 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ECFF2D59 for ; Thu, 17 Aug 2023 00:11:03 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-99c1c66876aso975789766b.2 for ; Thu, 17 Aug 2023 00:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1692256262; x=1692861062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b90IMLBWM6zQGsk777iCjnjr53BKkJdrEo5WNQ1ldaY=; b=H2c7NBiQQhO7/E+JhYmltH5Qey+YF7rioiXGPAct8f1Q++JttPziqyPgN9AzV7QaeC wbvn0skUZbWJx3/XZ8hT5/KK2lY+EoBYEsTKBGFocAUZyM2BqhyFrNd/fMB1Jt4bxcfP vt5Sp3TwVEGX2NMLnd3+P4pVzHO3g98ugqPOPMomOVeuLRGo7ljqecvx/0HL90dJY5MY BTyNeomIxik49AbiSKIH5sYTeHhEkCbXYPS9OO6LqQwlx6nRijQaQZU8J26pIAfRMm42 F62n2sZeF8VDqtjLbFTM7Gd0ii2k7oQXvuNl+Q/85HIColE/a4BXG26jmUckMCnjEPZb 4y/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692256262; x=1692861062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b90IMLBWM6zQGsk777iCjnjr53BKkJdrEo5WNQ1ldaY=; b=IRRYK+PycmM4P8O/re3NrQPc8oUULZi0JM/lMpQIcKp+Oug/hvy3Oqae/d9SMFnrJE QZDd7Dgl3z7bvXgBfm6qIwFycx7rgA61TEQ8C+qRUf9wqjj53cSrC2KCHNZ6xisSBIUs /wrWF6E1z5J3lqTK3umJkKMj1wgi/S9Y9pVptWekYeSJIqIbJEr4V0LZSdFye3+bfRMK RQzuLP6aG8iV9DJfZFF9NPzHLzm30ljpz/jLe9L36/hdTaH/zEm7qWgNYQ9nqZk28DnP ltVT+JYNHiwJ2MT5nW494sAZ56SZt8PZcXpcFldyq79s1E4YzhsFZfM3U4+z9Opuwm8e A2dw== X-Gm-Message-State: AOJu0YyjhfhbChPOnOpbAVNiv0CDd8OHupujCAIA4h+D9S0RJA+rzyQZ /k1MGTYcK7jjdc8MQgUJ4F6vCg== X-Google-Smtp-Source: AGHT+IEgdlNDyUuQTO740sHhf8djCEa8VT8SCiFbw6TV/IOas227T3QbIjZIW2aIg8rgvvW1eRh80Q== X-Received: by 2002:a17:906:311b:b0:99b:507d:dc05 with SMTP id 27-20020a170906311b00b0099b507ddc05mr3493724ejx.16.1692256261878; Thu, 17 Aug 2023 00:11:01 -0700 (PDT) Received: from fedora.sec.9e.network (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id qn17-20020a170907211100b00992b510089asm9674361ejb.84.2023.08.17.00.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 00:11:01 -0700 (PDT) From: Patrick Rudolph To: Peter Rosin , Laurent Pinchart Cc: naresh.solanki@9elements.com, Patrick Rudolph , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v15 2/4] dt-bindings: i2c: Add Maxim MAX735x/MAX736x variants Date: Thu, 17 Aug 2023 09:10:51 +0200 Message-ID: <20230817071056.2125679-3-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230817071056.2125679-1-patrick.rudolph@9elements.com> References: <20230817071056.2125679-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Update the pca954x bindings to add support for the Maxim MAX735x/MAX736x chips. The functionality will be provided by the existing pca954x driver. For chips that are powered off by default add a regulator called vdd-supply. Signed-off-by: Patrick Rudolph Reviewed-by: Krzysztof Kozlowski --- .../bindings/i2c/i2c-mux-pca954x.yaml | 23 +++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml index e5c1070903ef..2d7bb998b0e9 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml @@ -4,18 +4,29 @@ $id: http://devicetree.org/schemas/i2c/i2c-mux-pca954x.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: NXP PCA954x I2C bus switch +title: NXP PCA954x I2C and compatible bus switches maintainers: - Laurent Pinchart description: - The binding supports NXP PCA954x and PCA984x I2C mux/switch devices. + The NXP PCA954x and compatible devices are I2C bus + multiplexer/switches that share the same functionality + and register layout. + The devices usually have 4 or 8 child buses, which are + attached to the parent bus by using the SMBus "Send Byte" + command. properties: compatible: oneOf: - enum: + - maxim,max7356 + - maxim,max7357 + - maxim,max7358 + - maxim,max7367 + - maxim,max7368 + - maxim,max7369 - nxp,pca9540 - nxp,pca9542 - nxp,pca9543 @@ -56,6 +67,10 @@ properties: description: if present, overrides i2c-mux-idle-disconnect $ref: /schemas/mux/mux-controller.yaml#/properties/idle-state + vdd-supply: + description: A voltage regulator supplying power to the chip. On PCA9846 + the regulator supplies power to VDD2 (core logic) and optionally to VDD1. + required: - compatible - reg @@ -68,6 +83,8 @@ allOf: compatible: contains: enum: + - maxim,max7367 + - maxim,max7369 - nxp,pca9542 - nxp,pca9543 - nxp,pca9544 @@ -94,6 +111,8 @@ examples: #size-cells = <0>; reg = <0x74>; + vdd-supply = <&p3v3>; + interrupt-parent = <&ipic>; interrupts = <17 IRQ_TYPE_LEVEL_LOW>; interrupt-controller; From patchwork Thu Aug 17 07:10:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Rudolph X-Patchwork-Id: 714481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B94CC2FC1F for ; Thu, 17 Aug 2023 07:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348367AbjHQHLZ (ORCPT ); Thu, 17 Aug 2023 03:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348371AbjHQHLH (ORCPT ); Thu, 17 Aug 2023 03:11:07 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7FD0272B for ; Thu, 17 Aug 2023 00:11:05 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-99bf91956cdso912609966b.3 for ; Thu, 17 Aug 2023 00:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1692256264; x=1692861064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=89F7HPVQyXXTql6NKond4APoTNtrcoR3WWVsZWeYnGU=; b=TgbZ/CJaNT5E0pj5GYvONqmkY9clXaDgZ3GzFBalCaFrSv0lcMDrWxA3FIoESnHuSp lnk0quVRulaA0xNXQla3opRrVW/yUkYgRBw1YuZGCTjUZUuLlG0h2Gy76KtnaFzf6rdN fuaLqDkWKWKRW1nl0+bTR79RrqVDD9PTC2I616oUPhzdZ4ezByFHnsgMykFe6LJvrgki OltaoZoZNQ4du8HJ6noqzMhYIH5l4atz6wH0itLVjrErfLSVdYoykRusEiZczIahSAfH YyqTPGvgS/vk+xoJMefOpL46tdlGdQZ20gKiKYAv2U6cCrlgLpKeQwnjVinrvshnIYdq mWgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692256264; x=1692861064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=89F7HPVQyXXTql6NKond4APoTNtrcoR3WWVsZWeYnGU=; b=Zups61LaNT+R2WAIsddgmo6l7SJNJsTf4nAMPCuVSZ9GBIU8JM1SjIEK/R2X7WFPXM Uv5cWtRn4+sl6Ns3HG7B54Kyj7e7P6BAKzYdH8A+L1dVRA5mGv2vZOSv61gi4qYwb6Z2 tIxKPXckchjUid5JFIMF7Yd2mGrrHhbfVxKQl+bafhThDOjk2od4EaZ3P60s+oG667ad l+IaCo9TmNNYTkbEKg6Yvyx3iN3jyXTQkLye2Sn7uVlgXeiAUvPKpBcJjjO2TZcJjP+G nDOCJSWdtAi+fZVTZLDd+3X+RIei3dd4UwOz8Htkxa8sKZVAjohCgWJwXe/cb3SPvRq6 pJ+g== X-Gm-Message-State: AOJu0Yx2eD4bI8GhuitnUgB4zt8XtGaYtHcLTwn/seBo2Y3t/WbSnP8/ jE/b8x+4RjXfpKOpp+/eePSaCA== X-Google-Smtp-Source: AGHT+IFtJOLkzjgVmHbLgbpjFzK/zm5xo4iX82t+PikH5g9nEQtQqq+sKdZl/RoN5YPHQQgLU97h+A== X-Received: by 2002:a17:907:a078:b0:993:d617:bdc8 with SMTP id ia24-20020a170907a07800b00993d617bdc8mr3293049ejc.7.1692256264435; Thu, 17 Aug 2023 00:11:04 -0700 (PDT) Received: from fedora.sec.9e.network (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id qn17-20020a170907211100b00992b510089asm9674361ejb.84.2023.08.17.00.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 00:11:04 -0700 (PDT) From: Patrick Rudolph To: Peter Rosin Cc: naresh.solanki@9elements.com, Patrick Rudolph , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v15 4/4] i2c: muxes: pca954x: Add regulator support Date: Thu, 17 Aug 2023 09:10:53 +0200 Message-ID: <20230817071056.2125679-5-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230817071056.2125679-1-patrick.rudolph@9elements.com> References: <20230817071056.2125679-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Add a vdd regulator and enable it for boards that have the mux powered off by default. Signed-off-by: Patrick Rudolph Reviewed-by: Andi Shyti --- drivers/i2c/muxes/i2c-mux-pca954x.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c index 968111442625..b863f7b18190 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c @@ -49,6 +49,7 @@ #include #include #include +#include #include #include #include @@ -101,6 +102,7 @@ struct pca954x { struct irq_domain *irq; unsigned int irq_mask; raw_spinlock_t lock; + struct regulator *supply; }; /* Provide specs for the MAX735x, PCA954x and PCA984x types we know about */ @@ -444,6 +446,8 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc) struct pca954x *data = i2c_mux_priv(muxc); int c, irq; + regulator_disable(data->supply); + if (data->irq) { for (c = 0; c < data->chip->nchans; c++) { irq = irq_find_mapping(data->irq, c); @@ -496,10 +500,22 @@ static int pca954x_probe(struct i2c_client *client) i2c_set_clientdata(client, muxc); data->client = client; + data->supply = devm_regulator_get(dev, "vdd"); + if (IS_ERR(data->supply)) + return dev_err_probe(dev, PTR_ERR(data->supply), + "Failed to request regulator\n"); + + ret = regulator_enable(data->supply); + if (ret) + return dev_err_probe(dev, ret, + "Failed to enable vdd supply\n"); + /* Reset the mux if a reset GPIO is specified. */ gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(gpio)) - return PTR_ERR(gpio); + if (IS_ERR(gpio)) { + ret = PTR_ERR(gpio); + goto fail_cleanup; + } if (gpio) { udelay(1); gpiod_set_value_cansleep(gpio, 0); @@ -516,7 +532,7 @@ static int pca954x_probe(struct i2c_client *client) ret = i2c_get_device_id(client, &id); if (ret && ret != -EOPNOTSUPP) - return ret; + goto fail_cleanup; if (!ret && (id.manufacturer_id != data->chip->id.manufacturer_id || @@ -524,7 +540,8 @@ static int pca954x_probe(struct i2c_client *client) dev_warn(dev, "unexpected device id %03x-%03x-%x\n", id.manufacturer_id, id.part_id, id.die_revision); - return -ENODEV; + ret = -ENODEV; + goto fail_cleanup; } } @@ -543,7 +560,8 @@ static int pca954x_probe(struct i2c_client *client) ret = pca954x_init(client, data); if (ret < 0) { dev_warn(dev, "probe failed\n"); - return -ENODEV; + ret = -ENODEV; + goto fail_cleanup; } ret = pca954x_irq_setup(muxc);