From patchwork Fri Aug 11 20:50:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 713401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112DBC04A6A for ; Fri, 11 Aug 2023 20:51:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236775AbjHKUvH (ORCPT ); Fri, 11 Aug 2023 16:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236082AbjHKUvC (ORCPT ); Fri, 11 Aug 2023 16:51:02 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C741C2D61 for ; Fri, 11 Aug 2023 13:51:01 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe45da0a89so4066855e87.1 for ; Fri, 11 Aug 2023 13:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691787060; x=1692391860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZJZqdrCnpunqS3BylltOM5jIKNmh9VxM9LXMzEyqRjI=; b=Pj5G0Mdco1jcZUC+NwBukisw4Q598vhEA+/UyBzPOpn8TakZSsu4nSbKKC+3lyxTQe +llpMtKdyJ92Vc91Ilhcr5+oDOSb3sZFgo8qRHvhRolI9RVLXjTOzaxYKU20eGmjNiOO rjuFaDpBdwcUEXB/C4Z7BMp34wxlyVPylNIG73FpXnz5ai/cIXWhJKsklHyS2/ga8bov 1+5WraQXAA2fSdxPXkOi2HVq6AH2MwVx0m+JWoH576yl2mRiIMasaiG2+zDA2m67UkTZ YHlfq35v4gaudloThrOSjK3MXzKa6sfsvXkxMMe5SP6IUGvcz3YWWJRu8kBlvW0ZYISY CbgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691787060; x=1692391860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZJZqdrCnpunqS3BylltOM5jIKNmh9VxM9LXMzEyqRjI=; b=by5aIyntmlckgIRj43cnjmbbJGdE1nS++8YE4cC0Twr8u564hAN++QNYNlDaNRd0/2 rcObUFOWbZtGgC9pGcETSdJuFioOxHuIeJv2OyFNBvLXK2uAQk+gcyXZUz0Q+9qHOCq+ dhdiZ0iJuUF61H7RMi6zgJqwNhDQgc6IlREOxAT6asXvfZB2e9zSEbzjWfdDS351EB4E ugyntva4KCV/oXhttl8HY3sPWpXnCg9p5DVpNboauDU2bkVJ8t+BG71P4jyJWIQ0bZv5 0sIusBkh+Dhriti5/XgbHaHvBc7zLU9WCz5L7JJiWGNN/Q4r6nvfZp2NwFQF5EBRot3s eD8Q== X-Gm-Message-State: AOJu0Yx2hK0KE5pYNVr+SAfP+xllrxpqPiWX4kGpipv7ZNVPbBbROQJo NOVCc4vPUza2P0Oi9yNfItNdhw== X-Google-Smtp-Source: AGHT+IFHnoXR1GdX3zOmLUKVQxxNDp3rP1R6j1PP6qRnKgvWqSYFFPULcN+nZ9mTsFSyKhAywIE/Kg== X-Received: by 2002:a05:6512:1053:b0:4fe:6ff:dfba with SMTP id c19-20020a056512105300b004fe06ffdfbamr2631302lfb.1.1691787059953; Fri, 11 Aug 2023 13:50:59 -0700 (PDT) Received: from [192.168.1.101] (abyj188.neoplus.adsl.tpnet.pl. [83.9.29.188]) by smtp.gmail.com with ESMTPSA id w26-20020a19c51a000000b004fb964d48e6sm858285lfe.95.2023.08.11.13.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 13:50:59 -0700 (PDT) From: Konrad Dybcio Date: Fri, 11 Aug 2023 22:50:56 +0200 Subject: [PATCH 1/3] dt-bindings: crypto: qcom,prng: Add SM8450 MIME-Version: 1.0 Message-Id: <20230811-topic-8450_prng-v1-1-01becceeb1ee@linaro.org> References: <20230811-topic-8450_prng-v1-0-01becceeb1ee@linaro.org> In-Reply-To: <20230811-topic-8450_prng-v1-0-01becceeb1ee@linaro.org> To: Andy Gross , Bjorn Andersson , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691787056; l=1394; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Xs7DWl7UXFCwBwUfTPZ/9JWG71aQ0gSpWJmN6cxyqxU=; b=ZOQu/nQy3JDlJGB64q61SmEmQSYfQGkHtafbccPhQyv/4IVZF95QKS76V1Mr0IVRRkdka1/Q1 G1BAIQLcy2OABTj77ArDFy0LM4PxzaAtQiSQPjSTjgv6uY5SUKZhhsR X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org SM8450's PRNG does not require a core clock reference. Add a new compatible with a qcom,prng-ee fallback and handle that. Signed-off-by: Konrad Dybcio Acked-by: Conor Dooley --- .../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml index bb42f4588b40..36b0ebd9a44b 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml @@ -11,9 +11,13 @@ maintainers: properties: compatible: - enum: - - qcom,prng # 8916 etc. - - qcom,prng-ee # 8996 and later using EE + oneOf: + - enum: + - qcom,prng # 8916 etc. + - qcom,prng-ee # 8996 and later using EE + - items: + - const: qcom,sm8450-prng-ee + - const: qcom,prng-ee reg: maxItems: 1 @@ -28,8 +32,18 @@ properties: required: - compatible - reg - - clocks - - clock-names + +allOf: + - if: + not: + properties: + compatible: + contains: + const: qcom,sm8450-prng-ee + then: + required: + - clocks + - clock-names additionalProperties: false From patchwork Fri Aug 11 20:50:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 712738 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B92C04E69 for ; Fri, 11 Aug 2023 20:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235459AbjHKUvJ (ORCPT ); Fri, 11 Aug 2023 16:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236587AbjHKUvG (ORCPT ); Fri, 11 Aug 2023 16:51:06 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9E6E30EB for ; Fri, 11 Aug 2023 13:51:03 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fe2de785e7so3853772e87.1 for ; Fri, 11 Aug 2023 13:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691787062; x=1692391862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QB5xPzqWzKOoML0l3PVSjUAWLn+OWEjXc30hnsMTP30=; b=fBmCkYdDOdODeooFLeiVItqNPuPMPFnsB2sguQDoHmPAbHa7mBkfKmxoJpZXpbayW9 yqkHuR5uj9WVDaS6qIQ3GM4Z6P6U6Z2xmkNyZTmx5a0poyfVZFHHkjB9p0GSUbSITy5T Vqqe/Cus5frPq6pT5Pg2jlZYCc7Mr+ZnnK8KlV7rXK0JDRVRPXCSBq5zZCiYiVSURHIc ggWR37h9BBUMhYCAFIot+/xPLOj35MkHl2GE3d0Taz2NnFc4D6TsByIsmDyw2wXMLNjj HChGL1aKNx/tKbxfCV7C+l20cp3iWPbK6NZpRE1wQACf9qpY5+wITo0V1VRLQTgRK4EB DVUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691787062; x=1692391862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QB5xPzqWzKOoML0l3PVSjUAWLn+OWEjXc30hnsMTP30=; b=Rpc802xetfqKEJqQEH3mCnyhEkntSYw2m5jeLJm56pKja43KmR/K93m8snBs02+cLU 4pLX9YF/v4rX0+QFvSNyBwgx3QVBsmVps48r1lrMNg/1UqLQCW9U4Zmn+Aj9fQqsvYrp XpViJiQN8CBN3ugYZQrwd54jpqejy7O1RWY5F+M7FgKz3wpGNVScsariU4ZWy7upU8Gi D5DSt4Cg1kDYHDpNW5YSuYlpXTIS5as9B1AwG3KMLUHEo3YyqLzhszbj3UwDjde8+e6A zC+S2GtjMKea8/NcB/2CtP7Cim137Pj1DC/jm7xU2zNMWlDhbUuKrVZmF98/mUiEBIXc 3RYQ== X-Gm-Message-State: AOJu0Yx2Dxs5wOK0jnM/2MFTrU33/fF167fjIZ0qY9fSX7FvCK3Enum0 qrcBKh7sSh3ZR+zvxP6MvuXWKg== X-Google-Smtp-Source: AGHT+IFz+rCkKcqd0YzQc8eu1kZyDXmDzxIVaGMt3ZEHL79F0JeFtqROLu1tLVU1YdhHiMY9MUonuw== X-Received: by 2002:a05:6512:1194:b0:4f5:a181:97b8 with SMTP id g20-20020a056512119400b004f5a18197b8mr2670689lfr.25.1691787062202; Fri, 11 Aug 2023 13:51:02 -0700 (PDT) Received: from [192.168.1.101] (abyj188.neoplus.adsl.tpnet.pl. [83.9.29.188]) by smtp.gmail.com with ESMTPSA id w26-20020a19c51a000000b004fb964d48e6sm858285lfe.95.2023.08.11.13.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 13:51:01 -0700 (PDT) From: Konrad Dybcio Date: Fri, 11 Aug 2023 22:50:57 +0200 Subject: [PATCH 2/3] crypto: qcom-rng: Make the core clock optional regardless of ACPI presence MIME-Version: 1.0 Message-Id: <20230811-topic-8450_prng-v1-2-01becceeb1ee@linaro.org> References: <20230811-topic-8450_prng-v1-0-01becceeb1ee@linaro.org> In-Reply-To: <20230811-topic-8450_prng-v1-0-01becceeb1ee@linaro.org> To: Andy Gross , Bjorn Andersson , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691787056; l=1084; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=RzvdGw3IEkgoyMi6gKDkVuP1H4j8B0h8WD5wZuY2HnM=; b=+9SEp37pEI+KIv4leu0konNKFkQlJyzX4N8S00ogXVAhEo4UoRef+dyDlDBl7nifWIr6voJO7 /JIK/XDll/eBBzVyMALXSlpwdsVVy6H4VVHp417WyQtwBxZpzBR0Gx3 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Some newer SoCs (like SM8450) do not require a clock vote for the PRNG to function. Make it entirely optional and rely on the bindings checker to ensure platforms that need it, consume one. Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson --- drivers/crypto/qcom-rng.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c index 72dd1a4ebac4..825a729f205e 100644 --- a/drivers/crypto/qcom-rng.c +++ b/drivers/crypto/qcom-rng.c @@ -173,13 +173,9 @@ static int qcom_rng_probe(struct platform_device *pdev) if (IS_ERR(rng->base)) return PTR_ERR(rng->base); - /* ACPI systems have clk already on, so skip clk_get */ - if (!has_acpi_companion(&pdev->dev)) { - rng->clk = devm_clk_get(&pdev->dev, "core"); - if (IS_ERR(rng->clk)) - return PTR_ERR(rng->clk); - } - + rng->clk = devm_clk_get_optional(&pdev->dev, "core"); + if (IS_ERR(rng->clk)) + return PTR_ERR(rng->clk); rng->skip_init = (unsigned long)device_get_match_data(&pdev->dev); From patchwork Fri Aug 11 20:50:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 713400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A918AC04A6A for ; Fri, 11 Aug 2023 20:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbjHKUvU (ORCPT ); Fri, 11 Aug 2023 16:51:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234385AbjHKUvI (ORCPT ); Fri, 11 Aug 2023 16:51:08 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49F772D5B for ; Fri, 11 Aug 2023 13:51:07 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fe655796faso3831978e87.2 for ; Fri, 11 Aug 2023 13:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691787065; x=1692391865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z7dwX7d2dU/+Fcf4YUfoOQ8dtmFpWA9dQl9ljKJ8KV8=; b=kOivY6A78wD3tWHGor9Cb6KP6jgrIb7TqJ+AjqJaGYfU2vA+LInbZR9s1mfmRUwA/h iyuRxlM1WFZseiNI3SW1FMdj5MdtBxsC1Dl1UzjMb0X4AyjOnT9OQsjOWUfLhgiOMw6m H9qEcL2q6KDjH6Xxj6wBx3MqqDQD3ST+0IBVkXIGif0GsgpTK3q5g3IBBXdLY2M+39Mb ZaX5tM+gDyqK+52Zcfv4aw40+wek0TXQHrGVfaSExFktQAq+GTDsIWLvL5hNOmuXQu04 D1ijZdcgllbE4tAaz95z5tbea3/nJJfhtptxbfcg/a7TXDU6FiZikzWv+KpFa7kd72Co Q4ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691787065; x=1692391865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z7dwX7d2dU/+Fcf4YUfoOQ8dtmFpWA9dQl9ljKJ8KV8=; b=YM7zsXnFkanpMUBHWQws4+YxBYp8phXW48OvDN7Q5c4ZteP3eqMi/BOlAqYP+VEtG4 wtbFQb2a6TExK0K8D59HkBn3m4mAXD3XgVqx7wwuTLrjXo+LiIWrwXIYLEg56vh4SuXi UrPzx0wtgpJs70wuQXKTvwpONAladPPnWj5ndR8PIxDUXwQwGDp+/cqOCrSz7a2oTUoh yERifyFSdKZCAFeNHWoFGwO07TpnhGvvbHhib0BLxb4byOUqmPKWAWNgabHO17PA8sh0 zph7FZcjONdNsFCrBFUTdF5Eov9v6FDSsKoEs2fW4ey+Wigr5fwb26YCne+HBwCseI4a w0Ag== X-Gm-Message-State: AOJu0YyXHza5R7Ep33o2Cyf/IK4B+g+6GHPyFVzJKDcAua3uQ4lhYiHs /GWr3bAAqna5loUUZmtgriHVrw== X-Google-Smtp-Source: AGHT+IH0f7VkHrdSE5JI85lrLR+IIkp0OZpQwcdyDA34Xp1fap/jwI98RHyGsQns5XeKhGWo59Uv4A== X-Received: by 2002:ac2:465a:0:b0:4f9:5404:af5 with SMTP id s26-20020ac2465a000000b004f954040af5mr2325253lfo.46.1691787065714; Fri, 11 Aug 2023 13:51:05 -0700 (PDT) Received: from [192.168.1.101] (abyj188.neoplus.adsl.tpnet.pl. [83.9.29.188]) by smtp.gmail.com with ESMTPSA id w26-20020a19c51a000000b004fb964d48e6sm858285lfe.95.2023.08.11.13.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 13:51:05 -0700 (PDT) From: Konrad Dybcio Date: Fri, 11 Aug 2023 22:50:58 +0200 Subject: [PATCH 3/3] arm64: dts: qcom: sm8450: Add PRNG MIME-Version: 1.0 Message-Id: <20230811-topic-8450_prng-v1-3-01becceeb1ee@linaro.org> References: <20230811-topic-8450_prng-v1-0-01becceeb1ee@linaro.org> In-Reply-To: <20230811-topic-8450_prng-v1-0-01becceeb1ee@linaro.org> To: Andy Gross , Bjorn Andersson , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691787056; l=726; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=DAjiq74UUefJdsfOInU2jHQz0HV2BK7biar8Njrb1Tw=; b=+8cN3Nbx0tNivhACQMoC05m52yue+77h5opat4b8o/IbMvK06IRdMl0t0wPmP1UQpkMU/RcXg tnG4E4qQsXICNSa1PVVsHI4XzKoktqX9Paoa3cRrpgDRNQxE3JytCS3 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the Qualcomm Pseudo-Random Number Generator. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 4bc1c46a5f44..48618e88a273 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -1738,6 +1738,11 @@ spi14: spi@a98000 { }; }; + rng: rng@10c3000 { + compatible = "qcom,sm8450-prng-ee", "qcom,prng-ee"; + reg = <0 0x010c3000 0 0x1000>; + }; + pcie0: pci@1c00000 { compatible = "qcom,pcie-sm8450-pcie0"; reg = <0 0x01c00000 0 0x3000>,