From patchwork Tue Jul 9 18:55:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168768 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp8917773ilk; Tue, 9 Jul 2019 11:56:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzr70Vjbcu5CaC+AqGUGuEXLY5sYMxyl3zncGfoh/kFLr/InnnhJPwRPrvbe7oSWE+bMF5H X-Received: by 2002:a17:902:be03:: with SMTP id r3mr18592203pls.156.1562698602862; Tue, 09 Jul 2019 11:56:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562698602; cv=none; d=google.com; s=arc-20160816; b=l/f+qVBvDDIMj6eaUVrryKJ7AGVCFFd9tTQYRLsfl9xyQgwOU2vw9+PmkLFv9rxRa0 dtGuC9M2eDkyT7w8NHSA3oA723B6PoZjdEjpv+nF7f6nV4bXuaO/f7BVchwaeMorTpo/ TX/n+vNXFV6gOw3+BP0qUlgAjZMXHxuV6lrQgD0RGwWIIVdaADfeniHdHbd+Q8XFs6/Q 4KyOLbA/blLut3vFtK+VNK1k4UvYgabiYvtnmppNtLv+zgJplko2q4zZz20PQl1GK0Zl XTOdIqmVzDmKsDefSBUffaEVZdAtc9sQRjMUs6ULZ8yb8infITZcSQnDIfAjzpiEFgyj hF5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=T7oX0B2cqsS8O0BdQSK1AgBX09irXpCkVJWLOpiZgaM=; b=zCUcahSP9Rt80gQ/+2Fj6UZCOM5GlxF5LQBj0EELPE9hk4MdiLKcfBNPmH9ySg4VWj PiqXqDnXCWTJRw3jf7VbyTptVAZpWNM040bGVTYjIABGAXnQX8iuMvH6T95JMmRyhwDx ++bQ0TS4e+h7fVPhAsyQ08Ve9eUVVy7xETQz3VeBveIhNZV2XV8gx0yx5FskwMw7fCsi Y3GgsIdv21+atjh1Tf6RYGKR8T0iM+PpDYWe3xx9TkUU3ArgRI23DM/ShPrPNljBM9Fh 6mYPsbV7BRgrX8ul1RU22xLdgV+R7d6KL/SKDyDalpqAu/tKtlkgmOq9p/N/FaE3YWdp Zi0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bg10si22382617plb.160.2019.07.09.11.56.42; Tue, 09 Jul 2019 11:56:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbfGIS4l (ORCPT + 30 others); Tue, 9 Jul 2019 14:56:41 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:49835 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbfGIS4k (ORCPT ); Tue, 9 Jul 2019 14:56:40 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MyNoa-1ih2kD1m0a-00yj1f; Tue, 09 Jul 2019 20:56:29 +0200 From: Arnd Bergmann To: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" Cc: Arnd Bergmann , Pawel Dembicki , Linus Walleij , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [net-next] net: dsa: vsc73xx: fix NET_DSA and OF dependencies Date: Tue, 9 Jul 2019 20:55:55 +0200 Message-Id: <20190709185626.3275510-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:B23ZNL92t9F/IUnyQGFh8/+hX2SO/gVgPJMR323zJSPmPOxQdzA 6Xuj/fq/GzYC5z5ff2E7aTX/JaXm2JVV2AADZBFm38pUrBOQ3VWAi8pRj9kUOd/OcArxXYc U4K2IqcyxYF1ENBiFTwWvyUwTAPFaOwpeg5JmmQREucjGE8ARGnQ7xM8d94H1w3RMKg1enE /Bqrm1Wrp++RAMpq4RRdQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:cPjMJwBK140=:MJaLkyHabLEIhuoC4AdLJx S3wPkPOnP1UYfmGk7SXx37JiJCTq5LYimH6GIsXICDndTqnhjjbnUEINmsT/X6k5LVYq1uCGK FQQ2jhrem59XqYKc8UZh3KxAJbbBtb4lpW39rTUob1NXWPsJZnspWCpYK6fnhFtGFHohc31XA iLbQpQ587nU7iUGV9nbZhFRzf4J5S+tx9sM9oRsaEJN2BLl3YtZkKDCkj7pkLdFPj8Qzl7dAE pnoi5XURl2+gqzuNjlBMlDDt2FKYcbkhKSHemXtsAn7z0ich5f85Loyynnq2+nlhWZwkzVS4W PalilIND2pWh5ywXrSh/xlSCOot5bSCwIwwdnjDFTVr3c8w4Uzm4zIzOwxuTu+S9fng1DZG9D 4gePICIKJLtREdfLH4XGqTZN7sVUGjhdEG3sOkHwPIE6yPJcA3kC3iPNmUx9fFpW51iMfsjYJ AquRV0ajCteO9PQHhGRD9w9ROz8GM/5kKWaKKew8Ryqa0OTBHH3NuxL+4zhpndeX//zPHibYb YKsTVdSFMIm5BrydYyIvmnisSRVnC+O8D9pARssnAE//gopknmwSaUraq3jrWyU0onW0dfOyo PUkHRK7OLHCkeBK8uoSvkgfoVdShTCEELr3qwI5Il3s5b+6OdtAtLSj5xw23mcAsyN/rBnixr L5w8J5rFpZqYWRzusHXH51r1shK8iJzZHa/1/IyoUGdQXq/BpCugCmxFwzZvzcGxW6jcrPKcR u5iIRQRJPlSWxgIL3re2WSVGEja32HOv5sUNcw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The restructuring of the driver got the dependencies wrong: without CONFIG_NET_DSA we get this build failure: WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=y] && NET_DSA [=n] Selected by [m]: - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y] ERROR: "dsa_unregister_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! ERROR: "dsa_switch_alloc" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! ERROR: "dsa_register_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! Add the appropriate dependencies. Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver") Signed-off-by: Arnd Bergmann --- drivers/net/dsa/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) -- 2.20.0 diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index cf9dbd15dd2d..f6232ce8481f 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -111,6 +111,8 @@ config NET_DSA_VITESSE_VSC73XX config NET_DSA_VITESSE_VSC73XX_SPI tristate "Vitesse VSC7385/7388/7395/7398 SPI mode support" + depends on OF + depends on NET_DSA depends on SPI select NET_DSA_VITESSE_VSC73XX ---help--- @@ -119,6 +121,8 @@ config NET_DSA_VITESSE_VSC73XX_SPI config NET_DSA_VITESSE_VSC73XX_PLATFORM tristate "Vitesse VSC7385/7388/7395/7398 Platform mode support" + depends on OF + depends on NET_DSA depends on HAS_IOMEM select NET_DSA_VITESSE_VSC73XX ---help---