From patchwork Mon Jul 8 12:50:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168631 Delivered-To: patch@linaro.org Received: by 2002:ac9:6410:0:0:0:0:0 with SMTP id r16csp6510097ock; Mon, 8 Jul 2019 05:51:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqw6vRHI1w9ck17XXy6d0P8T8l9tW1R1sdX1xSBVcm1TlQRemRNBIZIvWvKbxMiV84p/J8zf X-Received: by 2002:a17:90a:19c2:: with SMTP id 2mr16664607pjj.13.1562590266919; Mon, 08 Jul 2019 05:51:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562590266; cv=none; d=google.com; s=arc-20160816; b=t9AAcxIkq5/16aZfxUYPQvo8UrqcvPCfzhGP1jkQe5/tziOru8C07diRh98xbd00zp q2tptcCGx6QLWqre1c6uSPws7RZHJP1poD9egzTOH5qmMOjpi2Gizl7QbjUjJ0lBv7Pl ldA/LU4xSPZyHqmcZJ2Nh/N5dj9Z3ldKKlKZ/nAmH2AJPzM7JIpPNnKZevIx4qk9V8J1 uxzLpBQC940+Nja9Z//u2gQcZuINyMPsnX+A9DQQzJZ/UeVOkLn9iDSN+JGc1Fo5IdZ7 QJwVYtX5cOa1cp9WZtmyLU4SSu1PmoGlgU6te5SC9LIZCi0Uk+UhVSzQhhB4kAl4khzO QTiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3R6WKN9XC5P6z5I7XTHThKim3QdXbkGFo33KnusXQY8=; b=jORnrkY4kYHGXoNl5X7vaNS7D/n+C3Wg+gq8YqayIwVoylyeR2RC1+guQPjpGhlWMY sEsDX46xbUuNsNCGzW3yE90KI36G7nOLSUonbH2QASqXLDgzB4DI2yZFtPu1aMEU+xod Y4vDgwy0pZcOw4wheSylYVwUcmTbMz2y0yzAZRUR9icZEHupDwll64wwrK1OS+q9Q1xK UQo7MNJ7/orqJQsQE/xMuELt8CMduGpLW+6xgJ2mGMkjisAQga4w9hZMQG6saSf7Mamj /JVo4u+j7+g2jV3kFWU3Dtvii4qefb6Xm1k1OCBCFTrUywoHHDeNWqdnCqZ54KJQhnYy bbBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3si20132283pgm.122.2019.07.08.05.51.06; Mon, 08 Jul 2019 05:51:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731039AbfGHMvF (ORCPT + 30 others); Mon, 8 Jul 2019 08:51:05 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:41495 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729022AbfGHMvF (ORCPT ); Mon, 8 Jul 2019 08:51:05 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPA (Nemesis) id 1M3UIe-1hjv8o3PBC-000YS6; Mon, 08 Jul 2019 14:50:52 +0200 From: Arnd Bergmann To: Kalle Valo Cc: Arnd Bergmann , Miaoqing Pan , "David S. Miller" , Rakesh Pillai , Brian Norris , Balaji Pothunoori , Wen Gong , Pradeep kumar Chitrapu , Sriram R , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH] ath10k: work around uninitialized vht_pfr variable Date: Mon, 8 Jul 2019 14:50:06 +0200 Message-Id: <20190708125050.3689133-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:0ZEH7BLXky2hsEkFHE941e4QDy+Q0DeLq46hitjd9gIhiQjjcX3 +rAvYpf6ObAijkvutVOtvfqk9eYOtLienzGiIpbTDGnsqZCSITBIvrTu4jxz+YdUu9QRHv3 QxLpMOZsqLWoMbZNFdcxIW5SWLT43shXwIKV5kDoF+g5+atQdjJ2NFU8SP3cT2qvXakgjww UX0MmUnxTukQk/l0l/CAQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:3Ejh7jG9+JE=:u6LjctvG2zwbsJ6T/k0FHq dgqfAC28oMIrAdI3ri95sJPS96jeTdpTsFSyNNrt79K6b7RXwdm+hovOFSNbRPvheL0RpUFUr j33VnbNkyz58HRB+debVGYYWUqw/JneG8hlo5nRkC6g0ckC5rYr/7ktSnqJobABl9N4vywlX7 WPFNf6J2MZxb2LYhIe0/MJU4gacUZwBgHQ6kW9d7KTlOARuEAPgoGkGTdXQemvGlmEs0VvDXL luJHOTs2LjvmZ/gkHlLLTLEY5Az7G+BGPlYV7rcQMSxo+0Uy+Gv61HjOnH3CqmLcLdZPu8g/t 13EK9BIyqmBZzHDXg/eLkt5mGLnF79mG0PnsM12rdaFZGwv1jv28lPeshJnX7myAhWbnXCXed 6beGwDbuM1XZijsv6AkwOvMFGDoYm+5s2j52yBEkuQAeaX3gpTF55v84GlktgJba9jnAdovC1 cEssA0JM4U0bIW9oFZfiKkTollfb1O4ZME96c8eUJ6p6F0fMu95ciNyExKgWuDiGSDlS406+K FiLLyENPaGPB1+EB0f4ma33zXTdn9guc0/w8GBiFS2OOmSwxUEKvfxiLVFd73Dk/b3PnQg38V N5dBlWtqXW+VT3xvWgmL1Lr5ZxuEqzZ0yIF/vjUq0j61xk0qqlHJhld0w5bcrJAXH2+w0XLeC PRGctYgwnh6YOqY2YZse3yQvX4Zx0i8eeAyEJBtbhKrhJgUkWpnsRbt4XSXH5ZB+IJKITvJnC ftlKEzqC3l2XxINHW4aGdJRHqZSfRuy37pFKrg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As clang points out, the vht_pfr is assigned to a struct member without being initialized in one case: drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here arvif->vht_pfr = vht_pfr; ^~~~~~~ drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning u8 vht_pfr; Add an explicit but probably incorrect initialization here. I suspect we want a better fix here, but chose this approach to illustrate the issue. Fixes: 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath10k/mac.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.0 diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index e43a566eef77..0606416dc971 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -7541,6 +7541,8 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, &vht_nss, true); update_bitrate_mask = false; + } else { + vht_pfr = 0; } mutex_lock(&ar->conf_mutex);