From patchwork Wed Jul 26 23:31:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 706852 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE77C00528 for ; Wed, 26 Jul 2023 23:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbjGZXbq (ORCPT ); Wed, 26 Jul 2023 19:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbjGZXbp (ORCPT ); Wed, 26 Jul 2023 19:31:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EEE12704; Wed, 26 Jul 2023 16:31:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 228B561CDB; Wed, 26 Jul 2023 23:31:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD987C433C7; Wed, 26 Jul 2023 23:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690414303; bh=r7QYHW3VKvt2WtGg9gadUOAfwlfHNf+lUew4M0VWzWI=; h=From:To:Cc:Subject:Date:From; b=FigZcKcQPrGdBwQ9/L3i6PvgDhZ3jNe5Mw1YIWYsG0dTKG8E6LYsAy771371B2OfD DdId4YZkV7bvFGCfq0m7+VBBDGditUnRGUnwfe5jBd09q7vb7vpxc8hXP1MBkRl7Ke ta1gWNaSi3dsRutqCYI4bwQZn99HVRXmQUGeuP3oMa+pAtZxHdO4Viobu1cF1Bhvbk ELIRKd9CPw52H7ZNeM4bGi32fpmfe2dj4c5fmRep88RMmAcwSkMv28YPU5/b1JAFWG QLnYnjAXbm5Yz1t2WezhagAogiEJyGYRLUHAuV3hY17Aka1DZ4E0vs6KYRpR9hETET a8Is0LCZwn/9Q== Received: (nullmailer pid 3811250 invoked by uid 1000); Wed, 26 Jul 2023 23:31:41 -0000 From: Rob Herring To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , Broadcom internal kernel review list Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] soc: bcm: Explicitly include correct DT includes Date: Wed, 26 Jul 2023 17:31:29 -0600 Message-Id: <20230726233130.3811017-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Rob Herring --- v2: - Fix typo in commit msg - Add raspberrypi-power.c --- drivers/soc/bcm/bcm63xx/bcm-pmb.c | 1 - drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 1 - drivers/soc/bcm/raspberrypi-power.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/bcm/bcm63xx/bcm-pmb.c b/drivers/soc/bcm/bcm63xx/bcm-pmb.c index 9407cac47fdb..a72ba26ecf9d 100644 --- a/drivers/soc/bcm/bcm63xx/bcm-pmb.c +++ b/drivers/soc/bcm/bcm63xx/bcm-pmb.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/soc/bcm/bcm63xx/bcm63xx-power.c b/drivers/soc/bcm/bcm63xx/bcm63xx-power.c index aa72e13d5d0e..98b0c2430dbc 100644 --- a/drivers/soc/bcm/bcm63xx/bcm63xx-power.c +++ b/drivers/soc/bcm/bcm63xx/bcm63xx-power.c @@ -14,7 +14,6 @@ #include #include #include -#include struct bcm63xx_power_dev { struct generic_pm_domain genpd; diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index 58175af982a0..06196ebfe03b 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -7,7 +7,7 @@ */ #include -#include +#include #include #include #include