From patchwork Mon Jul 24 05:13:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 706795 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2183C001B0 for ; Mon, 24 Jul 2023 05:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229593AbjGXFN5 (ORCPT ); Mon, 24 Jul 2023 01:13:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjGXFN4 (ORCPT ); Mon, 24 Jul 2023 01:13:56 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78D4DE40; Sun, 23 Jul 2023 22:13:50 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3a3373211a1so2373547b6e.0; Sun, 23 Jul 2023 22:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690175629; x=1690780429; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=caoeUxdk/bY/30hShXkM8xzsEfv9tOC0PQvdZObEqiY=; b=KYD9a4ljlBeWIzDK9kSM+wtkeKt3bOrazkF5Xp838g3RE1NG9jTSHD/pFsqgGvB8pH SKWeeBfl2HV2aMTyoGX3ingxOXm0C3fabo5d1/NoM8vpoxGQr/4ZPHz9e/BmSd4mRqPm u2EMUUmFr3TfhsDfhyRQTnJm2V6Lx2LsKP9XaX+yuzg463Im6sZRUnULiXsV7cdG7JYc v9Twr8zm/d9pxtQeIwPnqSO1O1c73aJZCaWwVZmb115l8Wg1lzsWQMkmvOxqnR1IxXw8 HhzI0MYiHSmvisooFrdUvjvs6Md5ffI0KQiupCqjboAphXLLFOP7F8X294iRF0eFLzsr Jt8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690175629; x=1690780429; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=caoeUxdk/bY/30hShXkM8xzsEfv9tOC0PQvdZObEqiY=; b=OWcxKub/2T78QX4qcQty/6vxk9yvx38alH7g0uQAIdfITfhUlcdK30sN5Oxwi2Cw+I AAaRj0Hvq9b9dPQso6SP41rkK1yc2G0WjfWV67ahyIsMVNTQ/tpd9gm9yScP9pilU195 kluVqHLgxC98MVKDdj71PozXC807n9kQ7tDscdcORS2P9OpuoPvBFbrVx6w4SBdLX35U 7C6sKeWcrvTh6o7tfxUvrDxSCu7u/YsnyGWH6MoSgvHnbzN38a2TSBTWviALKrRoCk1A SAmoofEPzzpL/36ni3VehooizIqq7liYo6V3Idi8GYoHIxREW7XPPCgq44TaezxRMOc3 3SEQ== X-Gm-Message-State: ABy/qLa8akFiO0BQsXvMpj1EnNKfdxpCpAQOXirVJLK0/i5Hu7slchvQ ABb3p25etODX+vTP6Bk25lltsH/+jow= X-Google-Smtp-Source: APBJJlEDCNOx+kTZCCY18koIORa1WIU3zN1YrwleKmbxpXbt6hOx2rpIGov6fTFkU+iz2ubrKMu+dA== X-Received: by 2002:a05:6808:a97:b0:3a4:947:c97b with SMTP id q23-20020a0568080a9700b003a40947c97bmr9726446oij.0.1690175629481; Sun, 23 Jul 2023 22:13:49 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:b8db:3c3:1ff4:2ae3]) by smtp.gmail.com with ESMTPSA id gv17-20020a17090b11d100b00265dc26d8dfsm7501106pjb.27.2023.07.23.22.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 22:13:49 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Yangtao Li , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] Input: qt2160 - tweak check for i2c adapter functionality Date: Sun, 23 Jul 2023 22:13:39 -0700 Message-ID: <20230724051345.335219-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org i2c_check_functionality() returns essentially a boolean and not an error code, so treat it as such. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/qt2160.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt2160.c index 599ea85cfd30..b0b9d7a2691e 100644 --- a/drivers/input/keyboard/qt2160.c +++ b/drivers/input/keyboard/qt2160.c @@ -345,12 +345,9 @@ static int qt2160_probe(struct i2c_client *client) int i; int error; - /* Check functionality */ - error = i2c_check_functionality(client->adapter, - I2C_FUNC_SMBUS_BYTE); - if (!error) { + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE)) { dev_err(&client->dev, "%s adapter not supported\n", - dev_driver_string(&client->adapter->dev)); + dev_driver_string(&client->adapter->dev)); return -ENODEV; } From patchwork Mon Jul 24 05:13:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 706794 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD2AC001DE for ; Mon, 24 Jul 2023 05:14:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbjGXFN7 (ORCPT ); Mon, 24 Jul 2023 01:13:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbjGXFN6 (ORCPT ); Mon, 24 Jul 2023 01:13:58 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193BDE54; Sun, 23 Jul 2023 22:13:52 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2632336f75fso2496906a91.3; Sun, 23 Jul 2023 22:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690175631; x=1690780431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TqW8DfZ6fP+85CmTsJVzjeFdh5CJjlffb6mkzwyRRAA=; b=Tlc1MlavR+Wldxpwq4X5o+8CWM7f7kxeQC4dmahGNQQetc8PON7FoURC6vPsEYZvJB 7+OOHFLM6NASIqpsBr8SBXN/6zacIwRGDzy2k5A4/D6oJYBUPgheH39SaP0fFEeY2xrG gDQWXHzjhlC0pK7dQOUh1ghuZzHL1k5JkBKx9J+5vrRjZNrA9rnIz8qXBazD6NyerZLK UpcK9GXTEqLCXQHQ9SQCUqbNfopRqoKYcuU5lDIOmW/mldOqYuLb4zr7v6wfXO6tJAbC AvAJRdYPPz0ehJFhxnskvKKIdLyAR718xeKz/TSCz78vN67ZFV421Hh/ZjK6as5gXdSc cV5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690175631; x=1690780431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TqW8DfZ6fP+85CmTsJVzjeFdh5CJjlffb6mkzwyRRAA=; b=AGRVCNcW9hNeOVXCqq6PPe2azXZ8BbFxB4d8mwy2u6xseFEnZzK3wbdSCzBtbv4QEA BgX1ObXEC8ie5w4PnRPDEJOtZfk4F1xFf/SV35Lx6bM65ke44FEDmC8rZ8YyvZGaumDj TzxLtsIElJAv1QVnPaUJAndANONvx7L3Asn+hFiEOrq0i37qR4Hw88+VHza/hC89PxBc DlCDt5YXx+yPk/LbxL8eo7WbRB/kBZDLdCZBTs14W9GtXdOl31iW2KNnf2DkGNgwTJw6 GyCfL5fE8ylURIRtfSPu/A+sfqI8SITFCfjkOC1l0kyF3Aex3XtUO8qk2HJt3QZ1gIPk hGaw== X-Gm-Message-State: ABy/qLbGBg4OwUpRL0kTy1oWGYTi98k1HNXeCkiBwKztsDVtIE0+B9Su btceiAZBF+n9sPLxcCDipIFGc7Dw7FA= X-Google-Smtp-Source: APBJJlH0Im8QdnVDV93025+Hbwmqv/NIDLqn4PdqoTzvlK5Q+axm2BFQ63P3SnqiCMS6ZM9l0jtNPw== X-Received: by 2002:a17:90b:3711:b0:268:13c4:b800 with SMTP id mg17-20020a17090b371100b0026813c4b800mr2499791pjb.21.1690175631102; Sun, 23 Jul 2023 22:13:51 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:b8db:3c3:1ff4:2ae3]) by smtp.gmail.com with ESMTPSA id gv17-20020a17090b11d100b00265dc26d8dfsm7501106pjb.27.2023.07.23.22.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 22:13:50 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Yangtao Li , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] Input: qt2160 - do not hard code interrupt trigger Date: Sun, 23 Jul 2023 22:13:41 -0700 Message-ID: <20230724051345.335219-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230724051345.335219-1-dmitry.torokhov@gmail.com> References: <20230724051345.335219-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Rely on the platform and ACPI/DT to set up the interrupt trigger. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/qt2160.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt2160.c index b8c0f0ebf604..6cfaabd10482 100644 --- a/drivers/input/keyboard/qt2160.c +++ b/drivers/input/keyboard/qt2160.c @@ -371,8 +371,7 @@ static int qt2160_probe(struct i2c_client *client) if (client->irq) { error = request_threaded_irq(client->irq, NULL, qt2160_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - "qt2160", input); + IRQF_ONESHOT, "qt2160", input); if (error) { dev_err(&client->dev, "failed to allocate irq %d\n", client->irq);