From patchwork Tue Jul 25 09:57:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenglin Wu X-Patchwork-Id: 708182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E54C001DE for ; Tue, 25 Jul 2023 09:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233495AbjGYJ5u (ORCPT ); Tue, 25 Jul 2023 05:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233491AbjGYJ5o (ORCPT ); Tue, 25 Jul 2023 05:57:44 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4D5410D8; Tue, 25 Jul 2023 02:57:43 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36P88VrY015729; Tue, 25 Jul 2023 09:57:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : date : subject : mime-version : content-type : content-transfer-encoding : message-id : references : in-reply-to : to : cc; s=qcppdkim1; bh=fWUkQlxsXRS7iV+aexyELVn7s+veqyHJs+3ritNx2GY=; b=mKq3ZUbVtm2X36bQAi8WtmemL7sXY4ncMRxkqqXyFiY9Nj0yh0SzOPRF7344JNrFk0aP CfhIQt2Xnt45PuQtzQBxf3ov1yMDAuDBAFX/T0mPfvL4r1BCKLC53oIqFLWHq4Rb4jTl BpxsTjkO0JdRLYmvkZSmMQuvZMr/iv817Thn0jLeUwTpiMOI//pwvQK+MFTfSCKUCC7y XEb2YRylVVJ2D5e+xPTs356+qh5fZUZ9xyOtMLbakIis69FyXA5Jwg8n2d+CCwIy+z8z 0birO5DajiwV0/11FJYxOW7jm2rYs2xheQK0PuecYwV+ARGb8LOkmFP/uz/gZpQiuxTU JQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s29j5gbuf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:57:39 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36P9vcs0014384 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:57:38 GMT Received: from fenglinw2-gv.ap.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 25 Jul 2023 02:57:36 -0700 From: Fenglin Wu Date: Tue, 25 Jul 2023 17:57:19 +0800 Subject: [PATCH v2 1/3] leds: flash: leds-qcom-flash: declare the driver as a module MIME-Version: 1.0 Message-ID: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-1-0f5cbce5fed0@quicinc.com> References: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> In-Reply-To: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> To: Fenglin Wu , , Pavel Machek , Lee Jones CC: , X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1690279054; l=753; i=quic_fenglinw@quicinc.com; s=20230725; h=from:subject:message-id; bh=AzMDDoRZO0HzUZhV0OYLAbxShCC7XGts2sqsVW9hIHg=; b=AyIMOQCkg4b0M1085n2J4GBf+lXi4UxWtVrdM9nhchqnBhqM4hrHWwz+e2FQd1iVaCU5gE+Mv ktu+PhsTYKNCfjKEg0XXXNP3sI3BqQV+8HbU/r5P1wp0COtm9UQsroI X-Developer-Key: i=quic_fenglinw@quicinc.com; a=ed25519; pk=hleIDz3Unk1zeiwwOnZUjoQVMMelRancDFXg927lNjI= X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: FwnjDFXtjOsS2Ysk_TRItwi95LCCjr0u X-Proofpoint-GUID: FwnjDFXtjOsS2Ysk_TRItwi95LCCjr0u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_05,2023-07-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=544 phishscore=0 clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250086 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Explain in Kconfig that the driver can be compiled as a module. Signed-off-by: Fenglin Wu --- drivers/leds/flash/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig index 4ed2efc65434..4e08dbc05709 100644 --- a/drivers/leds/flash/Kconfig +++ b/drivers/leds/flash/Kconfig @@ -89,6 +89,8 @@ config LEDS_QCOM_FLASH the total LED current will be split symmetrically on each channel and they will be enabled/disabled at the same time. + This driver can be built as a module, it will be called "leds-qcom-flash". + config LEDS_RT4505 tristate "LED support for RT4505 flashlight controller" depends on I2C && OF From patchwork Tue Jul 25 09:57:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenglin Wu X-Patchwork-Id: 706478 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29DABC04A6A for ; Tue, 25 Jul 2023 09:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231126AbjGYJ5v (ORCPT ); Tue, 25 Jul 2023 05:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233509AbjGYJ5r (ORCPT ); Tue, 25 Jul 2023 05:57:47 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A92F11999; Tue, 25 Jul 2023 02:57:45 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36P9lCi4003593; Tue, 25 Jul 2023 09:57:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : date : subject : mime-version : content-type : content-transfer-encoding : message-id : references : in-reply-to : to : cc; s=qcppdkim1; bh=4bYZn8KsNVyvtvAHPDcH9lOPhrvBpowcdWikiFWiqms=; b=leABWcaEBnoyDtYSzOy4I5P/LClKtB63xyGZ0SLhff6Fm7TyTOBDCLuK3CNupe4UZjjk WsuVQeSlZFAEvzYOFJqWZfHSUT5Ut6hI/73rUP7Hr9VH4GJcb+geGPkIXk5ngqK4x1Vi 89koT/QvIZIOx3OF0yS+eTk1myuWQkGmtMvseYFZAjcs6DOwTcPZi0LUbpQ0BPNTqzC/ Q+njeH5gb76lvU6V4Uf03+ohATM0LHkPe3i8i1qrHtIBnmsPXt/WTqQCfd0FJHRY8ZHW I2gmctnbgPARtpTq6dotFATck5/Yezm+fuKpxUQ2t0/V4M5Absj9Swugw/qZHiBd/RW7 CQ== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s1qa3tjhr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:57:41 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36P9vebl021614 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:57:40 GMT Received: from fenglinw2-gv.ap.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 25 Jul 2023 02:57:38 -0700 From: Fenglin Wu Date: Tue, 25 Jul 2023 17:57:20 +0800 Subject: [PATCH v2 2/3] leds: flash: leds-qcom-flash: turn off LED before setting flash current MIME-Version: 1.0 Message-ID: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-2-0f5cbce5fed0@quicinc.com> References: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> In-Reply-To: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> To: Fenglin Wu , , Pavel Machek , Lee Jones CC: , X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1690279054; l=875; i=quic_fenglinw@quicinc.com; s=20230725; h=from:subject:message-id; bh=W/dfqC+/sx2xdVFtlxcBI6JBsWRBJdEzU7xvhTBhVQk=; b=mhyIsm06MIsDejy0g0TzWf+U5u/3kNjoenYLow6u3aRJqU29uOCcNmzPH8fh8IwsCVrsOiCGk snYrWxGXkwoCubvEpupxkY6z6h1swrqWwdsKZ8OWJ4QDxwa/vdHDbnv X-Developer-Key: i=quic_fenglinw@quicinc.com; a=ed25519; pk=hleIDz3Unk1zeiwwOnZUjoQVMMelRancDFXg927lNjI= X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: XNC7vZ8WRUeCst9iGFroJwehMG0B9RRz X-Proofpoint-GUID: XNC7vZ8WRUeCst9iGFroJwehMG0B9RRz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_05,2023-07-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 mlxlogscore=545 priorityscore=1501 mlxscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250086 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Strobe off the LED before setting flash current to avoid it's being enabled with an incorrect current if it has been working in torch mode. Signed-off-by: Fenglin Wu --- drivers/leds/flash/leds-qcom-flash.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c index b089ca1a1901..29cf09479422 100644 --- a/drivers/leds/flash/leds-qcom-flash.c +++ b/drivers/leds/flash/leds-qcom-flash.c @@ -309,6 +309,10 @@ static int qcom_flash_strobe_set(struct led_classdev_flash *fled_cdev, bool stat struct qcom_flash_led *led = flcdev_to_qcom_fled(fled_cdev); int rc; + rc = set_flash_strobe(led, SW_STROBE, false); + if (rc) + return rc; + rc = set_flash_current(led, led->flash_current_ma, FLASH_MODE); if (rc) return rc; From patchwork Tue Jul 25 09:57:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenglin Wu X-Patchwork-Id: 708181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B91AC001DF for ; Tue, 25 Jul 2023 09:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232032AbjGYJ5x (ORCPT ); Tue, 25 Jul 2023 05:57:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233505AbjGYJ5t (ORCPT ); Tue, 25 Jul 2023 05:57:49 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8531E19B0; Tue, 25 Jul 2023 02:57:47 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36P8K6bc000957; Tue, 25 Jul 2023 09:57:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : date : subject : mime-version : content-type : content-transfer-encoding : message-id : references : in-reply-to : to : cc; s=qcppdkim1; bh=ScsO8gFEUdeQmbh7UjCwmM/ydj1dSKOBKKvQp49SZyY=; b=pXNqJG7GJccCjA5gL2i7TqdEujtfB/u3VVg5X4UM89IoqkidjgR+wl2OutEGoHMnLj/P CYVM30MyKgfEZtFakjPsHM2fvc9ppGr/FS1h2utOiazIL5TFNI07gaWagb2ghZvyATJV kiCMGIE4y6BMEYMCpfjI7+utdLyxCaX9D4cHYGJSQL0eR0YHTPSp9bqMte9IOqCtcsvi V1CPnJc4qcRhVCa3EXD84+UZ7B/9tp5E0uxr2zh39m/RfcK93bNIDp+niQXo9MydrdAb 7yRyxXRXj1vJ8F9O7Pdc1OnslDeCWREU1uCkcaJ6Fe4JwwvZiL8XluJGJ+qPC2t65bIW bw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s1v6u9xt4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:57:42 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36P9vfeI014998 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:57:41 GMT Received: from fenglinw2-gv.ap.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 25 Jul 2023 02:57:40 -0700 From: Fenglin Wu Date: Tue, 25 Jul 2023 17:57:21 +0800 Subject: [PATCH v2 3/3] leds: flash: leds-qcom-flash: put child node if registration failed MIME-Version: 1.0 Message-ID: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-3-0f5cbce5fed0@quicinc.com> References: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> In-Reply-To: <20230725-leds-qcom-flash-driver-tiny-fixes-v2-0-0f5cbce5fed0@quicinc.com> To: Fenglin Wu , , Pavel Machek , Lee Jones CC: , X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1690279054; l=744; i=quic_fenglinw@quicinc.com; s=20230725; h=from:subject:message-id; bh=vYKLErViyJpx6PQYnTAwpfzAwvI97fsyFd3BM/iAYkw=; b=Y88jIIdAoUUJ0ZlWpBM+lZjvUCEeJMwkPGcYzedHMJDyyDpqocRrp5MIk85ouM0+nhCBrtTxy pgJhKCuZzFHBxUgSBspI0AWJkn14DS2ZJ7n9gIOmiKO1EBHMBiTG8/v X-Developer-Key: i=quic_fenglinw@quicinc.com; a=ed25519; pk=hleIDz3Unk1zeiwwOnZUjoQVMMelRancDFXg927lNjI= X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: p9PX_iIs_jAeh6ofeuITWzg3dVKc4kpZ X-Proofpoint-GUID: p9PX_iIs_jAeh6ofeuITWzg3dVKc4kpZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_05,2023-07-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 priorityscore=1501 mlxlogscore=698 lowpriorityscore=0 impostorscore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250086 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Put the child node if register flash LED device failed. Signed-off-by: Fenglin Wu --- drivers/leds/flash/leds-qcom-flash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c index 29cf09479422..a73d3ea5c97a 100644 --- a/drivers/leds/flash/leds-qcom-flash.c +++ b/drivers/leds/flash/leds-qcom-flash.c @@ -749,6 +749,7 @@ static int qcom_flash_led_probe(struct platform_device *pdev) return 0; release: + fwnode_handle_put(child); while (flash_data->v4l2_flash[flash_data->leds_count] && flash_data->leds_count) v4l2_flash_release(flash_data->v4l2_flash[flash_data->leds_count--]); return rc;